From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D56C28B28 for ; Wed, 12 Mar 2025 12:21:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18265280002; Wed, 12 Mar 2025 08:21:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 132BD280001; Wed, 12 Mar 2025 08:21:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3CE7280002; Wed, 12 Mar 2025 08:20:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D6A19280001 for ; Wed, 12 Mar 2025 08:20:59 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E4495A99C3 for ; Wed, 12 Mar 2025 12:21:00 +0000 (UTC) X-FDA: 83212808280.27.5D46A37 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 86938140010 for ; Wed, 12 Mar 2025 12:20:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Y+p+Plm7; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741782059; a=rsa-sha256; cv=none; b=bdylR0sHrWUACO2VRJIaobapkEx8yPbjfCnwL7bigC2t6RPXO73o8ga3Ir9JQW4p/jtnGO 1WG9PydoM+iQCruFtoeWp2KcVLseD+JnuPw3qXq0sfCJ2eHXyRys6/sZyBTYUZuzqClhev /7KH6FGgnqnF1ePWsjAb0tjlQAkHEmw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Y+p+Plm7; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741782059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h+unGnlI6eXA2qo6dr4HD/w8OSOg2geZ8GiQ3pINjjs=; b=Sw65SjHBqGClMk6D4gtn0CPkvTEc25Ee6cIt6wij80sN+yvmmwr9Pw9Ur/3kjp2Vzwa9lu beCgXwjWwnsimMmHa8Ajf2atdvEcUA7Ir2TmQxb7hBK9yOWOghbeU7B69WUhJYD4API2V3 2FGu9wiaOLYpUprAKX1wsCmnTNzPS7Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=h+unGnlI6eXA2qo6dr4HD/w8OSOg2geZ8GiQ3pINjjs=; b=Y+p+Plm7ovbuRdP2zdu15NqCyH VbRRoxAAS8UVc+mbzKisYqAjrcycqRlnmCIH+CDSoH7OdEqZA+40IQ6XlXYD7Ly7lP92fDWsk8CZ6 T6NvKnFLSy4ophBOKW14vTVKTQhZ5Sx/Nnc2WB4B49ez51YDCWdVNO9GnmMXNoT1jrjiTpUI2HyBF X5LhZqebuv8hXHM0yCbKmBddM97ajjLAEE4VscvDj8eus0ijjZLx1QS8381Q489UbYZaccUL2LLbW vNvdoNZsuCBp2vGjPqomGJfQS58FOvrqzWGSGhtBkIeaqAZcX99PLG/0j/tT25ErwHWLM8M+FAanz FhTu1tWQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tsL4w-0000000Cofs-04QB; Wed, 12 Mar 2025 12:20:54 +0000 Date: Wed, 12 Mar 2025 12:20:53 +0000 From: Matthew Wilcox To: Liu Ye Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/debug: Fix minor issues in mm Message-ID: References: <20250312032344.297946-1-liuye@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312032344.297946-1-liuye@kylinos.cn> X-Rspam-User: X-Rspamd-Queue-Id: 86938140010 X-Rspamd-Server: rspam05 X-Stat-Signature: m4ysrtq4d5jthqhnntzrq3iboy7wf8x4 X-HE-Tag: 1741782058-510818 X-HE-Meta: U2FsdGVkX19B+w+535NHgp5juf0aILgwvi0ptybTOI89hUlh57h6Qr8q7P4agiMKiJnllA4GKR0ewJ9NFEC1jInKsv/RUcXZEMICGnFFLf2+WOXXtOpkeyfMuLY1Hq5R2zIHdDEP3B4qK1mBlgLURp0knx3kNcL4b9oQlDbbyKgzQsBeepMoWxBdleym6ynZ6M3GiZk6Z+3rt1Kgn+HWrehSWGZDvBfttPlBNWNnlxDKpcWDX1jscbL7unu0wmoq1iKXDY9RJtOEC8EJ76iiYfQOewEoMZ1YPg6gbIxTzVtqSEcR+O60ooe6M7YEHcpB7oq2Ei0nLFWSzU7URAgLCSN8muK6dRJLsHbFMRX9pvejE+FYP0puf/8V/8dBOPm438pWHws3918VjF+uf2wDJStiAvX55RljTJ9oCkx8+HJYMzSaCL32wzguqSOZgcC9SA9hf1OM91aOr5V5of5FL3XyPYt6p5XEY5v6xZG9jXCJlmOLXNKWnhUA0Ug9ILLRQ1Ywybyi8QeovXkaqJMkJrsySwJ9zQ9tIZnLqifAB0SH+UZovtPcdlFXRrde7iQrw8FNGO9v6wcyYMZFNE3vNxFKX+n1Ty5Q8E641DCJmv8byLxMwHwlu4GxVvLbK2pUZXMv7DxPQbfODJnoJl0fsEnwZbbnhzgjEh30dm0idGUAcdA+MA3O2GyFBGvms6BTOMIlOT6xndg9V5F0BS6ntC6kA1Be/vFf6Y4QVEqcpusKjmrZZA33+bNr4q0OdJkQsI5A4Lmx2Vleu10KuApXqyn7j2uqlawYTkE07Sm2Civ9IbNUAYdkNZA+L/X4sguQJX/0VhfoxSiWf+xA3s7wf/0Cjy03axlNrUWPmXdxon/jzlzaZeyEEH6p48DXnHqqMU/l/mSbyR0anfCC8BpJ4Hv9nIqqJ38LguTuoIvj6VyfmP7bhOl6JidOduYmp9e86zgqhfw7xzaT6ctNdTr qHhAqI8v UBGRHeS9VmJjvYEg8RJ9MOZ89EW2LplfCeDQDgWJpaU9Fb/I0kE3NOrseYNAL7s2CrO0b251kf55NNeQwGYI1m7HLe1qROaB+k/fTSBEJTRQcWIriBaXtGTceUUKzrwi07rbelkMu/LZKmSK74A3b6jSzmbU5se5A9Y5aVcDXZbOrrYX4PMrUGnMQHqr5h77Gm/TnqmFnfYUX7d6oIW6fy//lpkbFaxObiTDj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 12, 2025 at 11:23:44AM +0800, Liu Ye wrote: > - Simplify compound page judgment conditions. > @@ -132,15 +132,15 @@ static void __dump_page(const struct page *page) > again: > memcpy(&precise, page, sizeof(*page)); > head = precise.compound_head; > - if ((head & 1) == 0) { > + if (head & 1) { > + foliop = (struct folio *)(head - 1); > + idx = folio_page_idx(foliop, page); > + } else { > foliop = (struct folio *)&precise; > idx = 0; > if (!folio_test_large(foliop)) > goto dump; > foliop = (struct folio *)page; > - } else { > - foliop = (struct folio *)(head - 1); > - idx = folio_page_idx(foliop, page); > } > > if (idx < MAX_FOLIO_NR_PAGES) { How is this "simpler"? It seems like churn for the sake of churn. NACK.