From: Matthew Wilcox <willy@infradead.org>
To: Liu Ye <liuye@kylinos.cn>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/debug: Fix minor issues in mm
Date: Wed, 12 Mar 2025 12:20:53 +0000 [thread overview]
Message-ID: <Z9F8JYitsY9viNg4@casper.infradead.org> (raw)
In-Reply-To: <20250312032344.297946-1-liuye@kylinos.cn>
On Wed, Mar 12, 2025 at 11:23:44AM +0800, Liu Ye wrote:
> - Simplify compound page judgment conditions.
> @@ -132,15 +132,15 @@ static void __dump_page(const struct page *page)
> again:
> memcpy(&precise, page, sizeof(*page));
> head = precise.compound_head;
> - if ((head & 1) == 0) {
> + if (head & 1) {
> + foliop = (struct folio *)(head - 1);
> + idx = folio_page_idx(foliop, page);
> + } else {
> foliop = (struct folio *)&precise;
> idx = 0;
> if (!folio_test_large(foliop))
> goto dump;
> foliop = (struct folio *)page;
> - } else {
> - foliop = (struct folio *)(head - 1);
> - idx = folio_page_idx(foliop, page);
> }
>
> if (idx < MAX_FOLIO_NR_PAGES) {
How is this "simpler"? It seems like churn for the sake of churn.
NACK.
next prev parent reply other threads:[~2025-03-12 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 3:23 Liu Ye
2025-03-12 8:37 ` Oscar Salvador
2025-03-12 12:20 ` Matthew Wilcox [this message]
2025-03-13 1:04 ` liuye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9F8JYitsY9viNg4@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox