From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD3CFC282EC for ; Tue, 11 Mar 2025 16:26:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99BA0280004; Tue, 11 Mar 2025 12:26:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94BF1280001; Tue, 11 Mar 2025 12:26:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813EC280004; Tue, 11 Mar 2025 12:26:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 63912280001 for ; Tue, 11 Mar 2025 12:26:43 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BF4F8C0337 for ; Tue, 11 Mar 2025 16:26:43 +0000 (UTC) X-FDA: 83209798686.25.CE4B15E Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) by imf16.hostedemail.com (Postfix) with ESMTP id 92C2518000C for ; Tue, 11 Mar 2025 16:26:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Hzs6x+Rz; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741710402; a=rsa-sha256; cv=none; b=RP1OPo6jncchn66kYckTbVrFZZJ4WfG/jLX2QhFvtoDoJNaRcY18FwZUR9CMNe/Kfq0EDy OcoE9SlSCH2M7Jkvht0qkidBMRGYJftWrsRVm78MQtQ1XHK/kBghGI5mIr2Wv2pClWT1cP Se0nuJp8n5r4G7xzTxu/P+d/tw6mzY4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Hzs6x+Rz; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.187 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741710402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V2mnFFnUijG9A/gZIz5QOKtJPBK4Pn57c7YnZizYs6g=; b=VrxhXoZmmiPCcYhzSZMx14Tpm/U6le4XcdgNUQULwWPFMkZXoDX4elvicbi2crz/M3mC3e WH7swLssGGgVELczDb8jnej13offij5dzkHmDGlM6LZNuHPovlHSqz4CXxi2gM+an6gk98 vYU6uV5j7SMdrN3B6OSYm5033PaJH7c= Date: Tue, 11 Mar 2025 16:26:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741710399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2mnFFnUijG9A/gZIz5QOKtJPBK4Pn57c7YnZizYs6g=; b=Hzs6x+Rzgb48DJUaYA8dcBu9P4KaphhCvBK6PDI/xDYc20+Ix1DnzuXl3MLVpFHc+/5WNz o7sF8qDuDp6OvmiiOtY5vEtxYtmTHnvOXi1bMCoUzOw0PS8BMWxBNkdMb5WPcADd3UrWwe FbNy/uDzx8xH2be/izyHuAW905pj/5M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team , stable@vger.kernel.org Subject: Re: [PATCH] memcg: drain obj stock on cpu hotplug teardown Message-ID: References: <20250310230934.2913113-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250310230934.2913113-1-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 92C2518000C X-Stat-Signature: wqo3eopbtuy6iqs14kxf5sbjyjdunjpj X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1741710401-219548 X-HE-Meta: U2FsdGVkX1+qOflq1blGrsbJ4c4d5gAKL5nAG2J5jDkpT2XYpweTdNLLcwrA1rBLBOUz47V2Za7snKqgyzj3KLS5yMtlf39Lee32nsex6xK63D1nteKHRvWQZVJqtWjzBmQPSz8gAaN1Wn9Xn79Hk9aEk9VDmCSmC3tTCinuJRSaNf3I0/DfDD4wY9IhwW3Fk5aX7zMtDt2i9UOhnYDLoXIDQog6eY7Ya1RPBBUg5bRT0A+f9wifTzKlro9jiLgHUmP6qKK8ix4nxUFzWGelAAwkKQxu9+oQzh97KHocuvcqEVMPVH4B4wiyuLSZZUR8jncPEy62W4YAQpLP2JkM+RezN2YowGjzH6UcRnWgCz0GN/DhotO8VL4xtGiMLErqA82c0SLYAOANlnbfeeKYmxLy8dpmCzS0eZu2R8FYHkriiXQto1ynyqSplYfuaGUU2sUI7Obcvo3LuDMC+jlkcKXByenQgeRcdTrXLmjrpbKeoej7DEY4CBnnEUMlpGTkarKQ9rVdtYJlKRxWtBM6Q6oD4a6y5rzYXBOK78KlsoB7NSlLvbn3FJL9YkQNgYzziWezVQ22b3X2VMwv/7mej1Ht8rNaqAeRJ9aTY8mvS7csW1L5T+CRUDMLcQoLAsUXYqw92RO8dvOM5+K1Zdlvy+vd87kr5jeawx+bhrXYgj4gwAJ3ROkdka64EyZ3njIh6Qd4oOVc6nc3TAFFHFjTomLGeiHHDMrKJ8TIeV6yn0qEh+w2QpcdOUykApM4UKjSrCq6tdQ84TfQu6WmEOSHhOn1akeRBTkcA/xDvGRQe89yMVaje0J84zxXh2f6Gqrr0H0pR249kjZT9Mv5erGbrNgNGnl3zrLTrv7jjXENRKVBs3AeVdu5wlpObZnrWvE3wukFuFU4c/gdAQG6lj4ecPx9S0HQXzeDsYcKh4DH0oH0WqQsr6llAzBVvH1j5epNTJ7VYHYmsaeRqK9IbT6 e5TLsM/B ZdAqZQYriD3zBi4gv8rfyyOPhtFH6y1JRXMEq36gBZtJgg9uM7h0DzRsxeYm8bjfju3fQ+dygGYXHnRSZy6jyC3Lzgo4AEuc7jv99TjocUxUOksdaJERNDrgAVldxKSFokMARq0glf4t1k4Rrz5+n1sSPQEvzRrePfmyBbJXRg6yI++8m9kFgzce2H4xexHvJKoduOIzHEAdAJz+LkUdqq0Qsasb+I8xtJWJLn9KcjfoBZuU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 10, 2025 at 04:09:34PM -0700, Shakeel Butt wrote: > Currently on cpu hotplug teardown, only memcg stock is drained but we > need to drain the obj stock as well otherwise we will miss the stats > accumulated on the target cpu as well as the nr_bytes cached. The stats > include MEMCG_KMEM, NR_SLAB_RECLAIMABLE_B & NR_SLAB_UNRECLAIMABLE_B. In > addition we are leaking reference to struct obj_cgroup object. > > Fixes: bf4f059954dc ("mm: memcg/slab: obj_cgroup API") > Signed-off-by: Shakeel Butt > Cc: Reviewed-by: Roman Gushchin Thanks!