From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC38C28B2F for ; Tue, 11 Mar 2025 15:25:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22CDF280003; Tue, 11 Mar 2025 11:25:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DCB5280001; Tue, 11 Mar 2025 11:25:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07E5E280003; Tue, 11 Mar 2025 11:25:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DDFB7280001 for ; Tue, 11 Mar 2025 11:25:07 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AA11D14023C for ; Tue, 11 Mar 2025 15:25:08 +0000 (UTC) X-FDA: 83209643496.05.7DF535E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf02.hostedemail.com (Postfix) with ESMTP id 6516F80011 for ; Tue, 11 Mar 2025 15:25:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="V61EZph/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8vov8tjM; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="V61EZph/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8vov8tjM; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf02.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741706706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=POc6T+mAoJ4qDMhcmbOtW7KExFZF7URkjUCqOS4qsXo=; b=GqD/pO0XdzWtWd0YrXbQk61JDlQZSJnJ+am1Wtvy6UfvpigEHztIlwzBQWoVAb7pcbDNV1 2n62kR8vBWQ8G++ETvOE5myksHxRW43Hg+I//OSsToQR75UcQ+3QURd6PbWrRohCNAHXH4 KB/rf+Lo8hJ79boxhTwS4Ddd5wCkjgc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741706706; a=rsa-sha256; cv=none; b=NB6tRyim5FChdYWOtAXXDrpszJSbW2onJr0av+5hGt7htS2btbAKND1pp/q01w6XGERNb8 mCTxS73Z8FY9o16KX5i2zJgSHCxADV7GRwggBn4kgNYMdfzkDTS4Y6gxTCGGJsmmJLXtjN 8vCxz0jjwZkXPKl65sw0uvnc+ZwpQLY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="V61EZph/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8vov8tjM; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="V61EZph/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8vov8tjM; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf02.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C7AF41F388; Tue, 11 Mar 2025 15:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1741706704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=POc6T+mAoJ4qDMhcmbOtW7KExFZF7URkjUCqOS4qsXo=; b=V61EZph/Y76ROrq5uN8vo4cHNsoCtJuiJMzhOID5nvyW/tTDUkADof1iCJW9pRB4YvOCr3 T5QbnW15Sekt/sj38/DwTIv9uWhPAsA6pjypFnvfxmkH1sGqzKzc6gEbt5QKOupHGAWdKy FR/mhYOQWor/y9zjNi6JK+r03taZphI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1741706704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=POc6T+mAoJ4qDMhcmbOtW7KExFZF7URkjUCqOS4qsXo=; b=8vov8tjMk8sg0VFc6CkonkGqVOm1sOfopgaPvkSYJ6+ZwoQBN8Q4dlh5gI6aD6PGUu1EM2 mUTRztpupOxAqqDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1741706704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=POc6T+mAoJ4qDMhcmbOtW7KExFZF7URkjUCqOS4qsXo=; b=V61EZph/Y76ROrq5uN8vo4cHNsoCtJuiJMzhOID5nvyW/tTDUkADof1iCJW9pRB4YvOCr3 T5QbnW15Sekt/sj38/DwTIv9uWhPAsA6pjypFnvfxmkH1sGqzKzc6gEbt5QKOupHGAWdKy FR/mhYOQWor/y9zjNi6JK+r03taZphI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1741706704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=POc6T+mAoJ4qDMhcmbOtW7KExFZF7URkjUCqOS4qsXo=; b=8vov8tjMk8sg0VFc6CkonkGqVOm1sOfopgaPvkSYJ6+ZwoQBN8Q4dlh5gI6aD6PGUu1EM2 mUTRztpupOxAqqDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 33674134A0; Tue, 11 Mar 2025 15:25:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id beSPCNBV0GfiawAAD6G6ig (envelope-from ); Tue, 11 Mar 2025 15:25:04 +0000 Date: Tue, 11 Mar 2025 16:24:54 +0100 From: Oscar Salvador To: Gavin Shan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, akpm@linux-foundation.org, shan.gavin@gmail.com Subject: Re: [PATCH v2 2/3] drivers/base/memory: Improve add_boot_memory_block() Message-ID: References: <20250311004657.82985-1-gshan@redhat.com> <20250311004657.82985-3-gshan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250311004657.82985-3-gshan@redhat.com> X-Rspamd-Action: no action X-Stat-Signature: tdwz1o1jcxqsn1qkeny67148uggj53ij X-Rspamd-Server: rspam05 X-Rspam-User: X-Rspamd-Queue-Id: 6516F80011 X-HE-Tag: 1741706706-82036 X-HE-Meta: U2FsdGVkX1+OH3x3j5d1kmTO2DU2FiIE6MBQ7HxVL0RWJrtZJbVC+6UfoBzKFvTUuzmTwD05xjUzk7pyZtQD9MAipQ5w7z9UVciMC0arozWJU9PvJBYegVfwboEutbXN5IFHg8Jmgfr7E0etyKfcskGMDQahwpfZ7a/g4p0Sq006KNkzet3j4HIl0B39OhYRxMWAhB+WzbxIgwGGWSjrqKpatFL/H+hdO+aYLOw3HPRE8+ShVoidnUrEhGOW3A8CD6NtdpqnInTpe2RVHLFQU6T3sK0TjwHYp+nLAg5CPuhDaCIXkgQ75RKfCWy9MR6hiT6bUL0USVzw1lBLZahyubIgF8jP7pIZjcIArnKG5yxRl0eMuHwmpKLGd8DPTSF2TWlZuzwAz5iKHKl9+/ds1QC/AnVPECop0MmWG6l6KKUnA2MMJpX+9Oje2vOrEvJAyfphbEeDDRD5wyOL9SIfLytgQJM/LgGDE6id1Va1gfA38l7sMsApJQVgIL8gGW+USBx+ESTj5NI0EGU9hDDPEFRGdp2lUs21cumfiVa9uuSiYF9v9ZghUglpsWMKA876GJhrNxDrtinwCKXY+vcGDFCPixB2kOPNSjhS6tQKtZtk053ikV011ORz4iilNIuZ2UszD6aVjlBm2E+ckTYJlWDgnDNme+4mxdreotP8d4rA58Ia0Ns711dUyIqSsr7N+RdG7tXRz5XWVzOy0zpnscRyHpYBjbuoRDgmrqX8zCNvyHlmpPa0lP+wXWyWrvNyWhQaa3iytk7tllYOR4mfyS87ww8owS9UbXEvSCp9surkewzmrwJ8XtJDF5zyk0kg1925CHg3PV7uvWbBEN+NxhetKhhRnzgdPUbgoDhxT5jjQnN2t4x0bO55SxmL3ziboBdl8TZ6O3SCat38snXz36Bo01bF+71zGu10w9yxl694mIdF5DA+CPB3zjOPl2dbNS5GnDt5Q90/YdQSBrW BFk5nkLf Qf6sp2anu0hLcLuLaUJ4q9xFA/X14FNOLUQ+XtdNMmbFsAtzjZkSOpvYWXloiSFSTPx69dNMURmhAGEIzoWYCNj7kbgqMidD9ChDymnmWcvtR6Iq96cFwM1McLHzg+MdJplvbaE4Ufg6UoJjYsMihy98vRGAM/6B+qKM94JOy+Tip8UVzFoO4QdZURzJsChTWfWO1KWwi21gh+fULP/H0VPH+P0/GfEFCGDtCKJE+9xnnyeX9d7FOZUqI1YdOo1P14wWZfmUXFB1q1vqvci83zQENZKjwhknq0vLbRj398Glc+9LaI+TFxE1+ZceS7H5K0+F3Rwq6Z1m5Sh/ZrHLIauErf8WDlHOYdHLlsy4fdXPSfihrJ2OxMAJd8Rmk/WvSZYmYEhQyK9FqGQobOKGZQDsCyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.022429, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 10:46:56AM +1000, Gavin Shan wrote: > It's unnecessary to count the present sections for the specified > block since the block will be added if any section in the block > is present. Besides, for_each_present_section_nr() can be reused > as Andrew Morton suggested. > > Improve by using for_each_present_section_nr() and dropping the > unnecessary @section_count. > > No functional changes intended. > > Signed-off-by: Gavin Shan Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs