From: Oscar Salvador <osalvador@suse.de>
To: Gavin Shan <gshan@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
david@redhat.com, gregkh@linuxfoundation.org, rafael@kernel.org,
dakr@kernel.org, akpm@linux-foundation.org, shan.gavin@gmail.com
Subject: Re: [PATCH v2 2/3] drivers/base/memory: Improve add_boot_memory_block()
Date: Tue, 11 Mar 2025 16:24:54 +0100 [thread overview]
Message-ID: <Z9BVxpyi_FUCnig3@localhost.localdomain> (raw)
In-Reply-To: <20250311004657.82985-3-gshan@redhat.com>
On Tue, Mar 11, 2025 at 10:46:56AM +1000, Gavin Shan wrote:
> It's unnecessary to count the present sections for the specified
> block since the block will be added if any section in the block
> is present. Besides, for_each_present_section_nr() can be reused
> as Andrew Morton suggested.
>
> Improve by using for_each_present_section_nr() and dropping the
> unnecessary @section_count.
>
> No functional changes intended.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
Acked-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2025-03-11 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 0:46 [PATCH v2 0/3] drivers/base/memory: Two cleanups Gavin Shan
2025-03-11 0:46 ` [PATCH v2 1/3] mm/sparse: Expose for_each_present_section_nr() Gavin Shan
2025-03-11 9:31 ` David Hildenbrand
2025-03-11 11:52 ` Gavin Shan
2025-03-11 15:26 ` Oscar Salvador
2025-03-11 23:37 ` Gavin Shan
2025-03-11 0:46 ` [PATCH v2 2/3] drivers/base/memory: Improve add_boot_memory_block() Gavin Shan
2025-03-11 9:34 ` David Hildenbrand
2025-03-11 15:24 ` Oscar Salvador [this message]
2025-03-11 0:46 ` [PATCH v2 3/3] drivers/base/memory: Correct the field name in the header Gavin Shan
2025-03-11 15:17 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9BVxpyi_FUCnig3@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dakr@kernel.org \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=gshan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rafael@kernel.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox