From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E03C28B30 for ; Tue, 11 Mar 2025 10:38:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38301280002; Tue, 11 Mar 2025 06:38:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33196280001; Tue, 11 Mar 2025 06:38:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FA95280002; Tue, 11 Mar 2025 06:38:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 02FC7280001 for ; Tue, 11 Mar 2025 06:38:31 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 404C5AB251 for ; Tue, 11 Mar 2025 10:38:33 +0000 (UTC) X-FDA: 83208921306.25.3C271DB Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf27.hostedemail.com (Postfix) with ESMTP id 4FECF40007 for ; Tue, 11 Mar 2025 10:38:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b="SUn/faol"; spf=pass (imf27.hostedemail.com: domain of cyan.yang@sifive.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=cyan.yang@sifive.com; dmarc=pass (policy=reject) header.from=sifive.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741689511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f1K76VH9GZtVs+LPd+wKDkO5SY/QeivVsM/htD74ZLE=; b=BOE0fTKUsGsFIgHmlBIH+/BwQ2OJ85ajIARhE0ecP4yootgXdYY+EJwoMsR0wlrtgAdyX5 0+yq4HfXomPCVXHHTDgNEzsE/BRxRq7krTxGXY+zdSRadhKzmbRfj0ukW0hdq7erXkXT6c b4vcgvwylQmDwlh/++jLCm96Os6djLc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b="SUn/faol"; spf=pass (imf27.hostedemail.com: domain of cyan.yang@sifive.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=cyan.yang@sifive.com; dmarc=pass (policy=reject) header.from=sifive.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741689511; a=rsa-sha256; cv=none; b=bXT61taBXFCDV+5xsmUVoj+B9aMVWzuDjj5Cj2Ik5g6qEhg/BdiSzszc9OQca8GEP2PCHa 70pdCNXDaSTvt1CkuGoP/zUgwTlcIlJC2hWWZWkm2ahu4VSgz1qt0T1jIJ0WD6PyycXnEO Ovmg5DTVrYy0WtcVVRUkjZkSTPPVXT8= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-22334203781so111392135ad.0 for ; Tue, 11 Mar 2025 03:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1741689510; x=1742294310; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f1K76VH9GZtVs+LPd+wKDkO5SY/QeivVsM/htD74ZLE=; b=SUn/faolucviXmLNNEiHA0bfErnveXBThVTubTJ9HaJhQf7O7dcsRvgQ2HS5VbJDI5 gk8zzzdydyO9RgRS95uO6i4vyEJ2dRhs5QX/6jsCTak2YMpqoNl4NpzKeyvZEh73+oFZ /sMDw1UDp0tOg+sB6m0U9J0Tge3wlfaznxO4wDgStUbZtsmk8/WIz/CSAi63fKNJmrSC z8aehPamDqmJVkqgeF8ymasqAKKuJbnSxjyCZppZJ16UD6S2PYJcgh6RoW5NLgcP4a+9 qyuYP0JQU2oH4Yl0G3XlvyWg0kyZPEdcGSHUGK/bOM54xYOkieonr/M08E8MR7wPUUvM u2YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741689510; x=1742294310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f1K76VH9GZtVs+LPd+wKDkO5SY/QeivVsM/htD74ZLE=; b=avlCdLs8iwjW7qCFxPkGdUkBvG4H9e9K4EEDsTM9PpBFpHvJesA11HPjL+cVpNOm1V FzQtGJLjKzT4mfcQoTJpcQ7EIJbG+B+PidpzASfOnjvqSin4pPUWfG+h7JyVuFfr/VvV 7Ycy8ObNnlaunwGQpeVPeL2KfX1XYKodJHHELQAldvHkh3wB48j6ZZM1bKe2Svff93yr 1YzRGTwIpUYU3Q6kBGn9JKMDkH2SnoN4f4PZLxyk8P8X/uLR8PGqKYyJGb7rGMfU2JfP nMe8e+8Ae4qS9Wgky2NHl8y3ZPtHEGK4y3TC84gxvK4DZW3uRGOOzYSNBfKp+y61Nnu6 tuBA== X-Forwarded-Encrypted: i=1; AJvYcCXpygMPcrLKZ13/lWtydXwZONpIFdNOui2EmE13nSkxtKgUB4RB2Y+rJMfSrrbrjDZ2uSutApzuYw==@kvack.org X-Gm-Message-State: AOJu0YwR/QztFQroDzewkMEqH1gzczLOtIsypLwhgZPfcZDt/ixEmm9o KIUE2ep1Yt2V+ojLu2CgBtE9wSs4HQmF2racN3vCRvJIc7EfkQQuha9mMKp+Zyk= X-Gm-Gg: ASbGncvqX9do/mYiBZypfFO87jSIQ82QtC7ZHG7Kd3Q86odrlRVVXtyW+kOKeNldPjY DvRgtwQ+XmqXrHcwSqY4S+BdNuhxoj1E3FQigrGVHAmUDQoZKFxntjPBCO1IFzgFXAHRdQSIQag 30FHJ38eab1oApcbfDfBolShZu7DJZCG/noRWrzv88MxHgKQD+9H/B+6TkW2L1SCW/hC3G77qH4 /gVai62ngBY1PWdqyi/hFFgEgHbPj1DzWS3B/27W0DV9047bjwPZe7H0ovOQ9sXqid6//s4NYnq qXhhkICPBRbRTvvoryJqzHH/Xu5W3qBuE7G8q5eFhBsvwW6o0N9dEQ== X-Google-Smtp-Source: AGHT+IGwF00pn0ttTAwXGotu4n032tAfHEPg1cyOkGTgN8LMC/JgxCYBqIV6RS/HysJzHJ7Xm/MRrw== X-Received: by 2002:a05:6a21:329f:b0:1f5:8cf7:de4b with SMTP id adf61e73a8af0-1f58d6ff812mr3970836637.16.1741689510077; Tue, 11 Mar 2025 03:38:30 -0700 (PDT) Received: from cyan-mbp ([136.226.240.168]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af287c2d533sm8673120a12.23.2025.03.11.03.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 03:38:29 -0700 (PDT) Date: Tue, 11 Mar 2025 18:38:25 +0800 From: Cyan Yang To: David Hildenbrand Cc: akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm/cow: Fix the incorrect error handling Message-ID: References: <20250311023730.56658-1-cyan.yang@sifive.com> <4a068856-328f-48ae-9b1c-0ec7d65dde6b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a068856-328f-48ae-9b1c-0ec7d65dde6b@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4FECF40007 X-Stat-Signature: hx8ueijgh4ywjjxz5tkspty8i1umabpo X-Rspam-User: X-HE-Tag: 1741689511-430149 X-HE-Meta: U2FsdGVkX1+PA/8b6pFyhpkyyJIfPWqsoSid6srdNJHZceMmqABLCKKeWHX20eYNfiTZvtzIZw5KluhCnHkZA8PMoZatbSPcwuUzmYUGn8EnaiYjwguKpYDwiOy08IKKcrZbgr4PrbMMGjv91ip+b2U0SXFjDN4x6uY/JQYuUTQIc5ovIXDSTK23ksl0iaKsPf5B7uLg776PTiSj8H6THGMoeesYiAgmCVfcv8hArn/qyAgavp+77c4opjoNZknDWvg5UW7udkKijE5x8P5GOH9qBYDtN6tWiiKu587Mzyuoj6JJpLCVUW8jtlzT3gHYrWlOrSlCb2E/4ktBhkH9PEnMPUuDLQN9QbsbC1ifIGrKo35lIEKW3u0PGV+8VVptRFkqvp3sAfFAqxMf09BYDNCIpWQRTAuOPlIPjPZIGsuBNVXgxf/de6y3T8hSo/mViQRabcAa1uZbJWm3OFbCXoriWIqDk7b1nS3K/RCTracoe9AcTHvOmzBnnYzZp7E1JemofuZQsoXXJDSxlbs95FTForYyZsqeM8XPiRMyKpKFr3JHyboLS0fd9dl9vQEnwVnPUJTCPfn1/uKYtxOnElHxOaO0IuxMrj4acBqB03Tcty2jNQLNOD1zzUk/uem0MMRANQXHCWB7B251ckP2+9Se/ZNDCAIdFQXN2q6VVHLGOh8mg6HA0GewpCY3HZY8n4k9Pdv3PVglxZNBKSpKeqIaPYl4DnTLcZETNaIS6mwyfmxZW5jAqX8SUrRrMwlE9H5VtI3I1BRBxTjvbOI02vj85UTyiFeVTbcjrCIGMjk1kdYn4i0vfq4qOge7Rn0Js5l1imGZtZ+QK7JFsS5kkY0KCrgXkbkbvsTS8+l+xqbY+vAy482ExTPvl/Teb7f6eOmMKB/Z5JNz3/3sN09YYVTjDiEeVcxtNjV2Lbb94V1EP2JnYN6rIZoFOs1Pc3fzA2CfvaIo5IdMkymLcOg 5/pV+DB4 ftR020O4X6u1kgsN9q5rzmvTKklt+iXVn669LC03kudNGmaNYiar2Vo+D0ov9fZC2Df6SVYsjFPTItY4+8MwlXaf0p2LKqhl1WLqL2Axy+d+eK8BSSF5xlfx0wtxi9PxoKBSBoG8jFostBGkjZhGeVL58dL+StiqsUc/zUL8LC5+EE0y6aLH6spHNuZ+6AyJI1hyPgbJbXeb6PuJQbnmCHF4Qe1wrkvxDBllWay5DoESoT34XXU1kqlVXi0nNXx6UUCsovk8qEDrDR613CpM+aYQWsm9iSq/MXz3yJpl/oyQkZcidvdNJ5xx43hXCNqbn0hU3OD+PEOU5IHgLnNy9BhTxvzxd7p/KIl2fnz1ENXljuVg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 10:19:32AM +0100, David Hildenbrand wrote: > On 11.03.25 03:37, Cyan Yang wrote: > > There are two error handlings did not check the correct return value. > > This patch will fix them. > > > > Fixes: f4b5fd6946e244cdedc3bbb9a1f24c8133b2077a ("selftests/vm: anon_cow: THP tests") > > Signed-off-by: Cyan Yang > > --- > > tools/testing/selftests/mm/cow.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c > > index 9446673645eb..16fcadc090a4 100644 > > --- a/tools/testing/selftests/mm/cow.c > > +++ b/tools/testing/selftests/mm/cow.c > > @@ -876,13 +876,13 @@ static void do_run_with_thp(test_fn fn, enum thp_run thp_run, size_t thpsize) > > mremap_size = thpsize / 2; > > mremap_mem = mmap(NULL, mremap_size, PROT_NONE, > > MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > > - if (mem == MAP_FAILED) { > > + if (mremap_mem == MAP_FAILED) { > > ksft_test_result_fail("mmap() failed\n"); > > goto munmap; > > } > > Yes, that check is wrong. > > > tmp = mremap(mem + mremap_size, mremap_size, mremap_size, > > MREMAP_MAYMOVE | MREMAP_FIXED, mremap_mem); > > - if (tmp != mremap_mem) { > > + if (tmp == MAP_FAILED) { > > ksft_test_result_fail("mremap() failed\n"); > > goto munmap; > > } > > As Dev says, this one is just fine. Leave it as it is. > Thank you for the review. I agree with you and Dev this is just fine. The reason I prefer to modify it is - usually caller checks the return value directly and "tmp == mremap_mem" should be determined by "mremap". If you still prefer to leave it as it is, I will send out the v2 to remove it. > -- > Cheers, > > David / dhildenb >