From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D66DAC28B2E for ; Tue, 11 Mar 2025 10:25:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62E02280002; Tue, 11 Mar 2025 06:25:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DD01280001; Tue, 11 Mar 2025 06:25:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47FB5280002; Tue, 11 Mar 2025 06:25:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2CC24280001 for ; Tue, 11 Mar 2025 06:25:05 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9F123161CDF for ; Tue, 11 Mar 2025 10:25:06 +0000 (UTC) X-FDA: 83208887412.01.64B35CE Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf28.hostedemail.com (Postfix) with ESMTP id 94941C0006 for ; Tue, 11 Mar 2025 10:25:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cfCy3z5+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741688704; a=rsa-sha256; cv=none; b=qheWeREjS7AbbwERIco/jlXbRpHGTsHBoj+9sNoMZWsKv54UI5jE1Og5zNUBFZnjGEbiB0 iKnpV7+nZYhm9zpG8OlWO6ucH4bfBfFeEtoZGKD2mMOzx2N9+WAy4bbAtaVuCYTEyNPSFQ reF1USWgbB+EtIkVAKm5xEA294qHkPU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cfCy3z5+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741688704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yQ9QHu9OwuR/HOCYxmuFMkfIcaT2lB/BHKzVqZDxMW4=; b=tnUuE5Ebjl/f5SeGPa3CJuTrNy+rRnIdxHtAXYPHK81J7dXkGpJfuQd+WTbbqy7SQJTn5v OwtPShMpk2tVX+XtE0T2V0MqE5NoNRImFBCkzATbndguuQdbK+c6mrNfQBV/oiC/If3Ii6 ul6xG+livE6F+sqqcEdeteMd+lXdL7Y= Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-30613802a59so58839921fa.0 for ; Tue, 11 Mar 2025 03:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741688703; x=1742293503; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=yQ9QHu9OwuR/HOCYxmuFMkfIcaT2lB/BHKzVqZDxMW4=; b=cfCy3z5+pA4kWpJl9lLZ/lKOL0gVpvDjjd5/ymrJpRrvnZO/s844MVxpmqxe+4VL1J 4HGnerweuzk09xqkerCesTZ+ct5tJzLgLUA8R1Lby0cBZnibz63exx5NP2u08p/49uF+ sXEPgAVyMWPltbqTAEXvGHB8Fx7egaEiwN36N1mn7sKRt1LKsTJ8E3aKcd+Bbrlv6GA3 ex1UFyeE8HUCJHenDmfA1fUUM5tz+0UIgj2wQv/xb790lSX7ZlLRsRrt0QC9shtM5bg5 Rrr85bhIV0vDa8AIfec/qXWOURFb5tYCMc3TG214rh2KktiSUxlytinO6xEBHi342Ui4 i2Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741688703; x=1742293503; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yQ9QHu9OwuR/HOCYxmuFMkfIcaT2lB/BHKzVqZDxMW4=; b=GXYqZd/LD8oa2PoT0kfRd1M1d5DWKN4HNVrstByCK88uWHVawqzUym2cbN/fbFMHgj 6KMzpo9GV2gZ+jz79ztG9byZ+zt1RFNY+b40kJMbEc276Wqg9DVRmO7TP0+2RMhI/T8s jY3HdpTJS+WLOsJsWwbSjvwJH1BT2Rc54FxIMPk8udhiTuVzr/1RNZ06zoWxmtboYFHb 7G3dH7H8+/1bs5J4XORR8s492ckmVbEb3EDXEi9Rx3b6pZyhmsFUpy/NeYgFi3RghSKU EbGsGi0+lP/8ECVdXF7hLm2bHQOVF+xZXxngenDzFWAgB4I52GZw2STCLTxmZ++suv2V Waug== X-Forwarded-Encrypted: i=1; AJvYcCXjl43jnoHmS1BI9VfuAl7oXeQIormr75OFwfkn+u5Lg7+cbfSe2vE2mNRGQQf3YbPq/1hMkVUjaw==@kvack.org X-Gm-Message-State: AOJu0Ywg3TDssq2GbooPAHHZBFugBlqeG9vvIt03KOMMICDdlCgBGT5e eFS/Bs8J4M6ZU4KXf6WCZpG++LWmMfO+Uf2lBcbBn7UBYe49JwD5 X-Gm-Gg: ASbGncssK4UXcCpDx8HQrtN4ABqulhfy5eJdm/ajEkMqHC2UzqyEsUU7eUnJfvLU1S+ dcc1UBpG8hDBy02D/v70mVdr9EZylkVclydEJJAxGXE+1/x+/FkzsIcPDr5mPwxAMUTi0HkLm6J eMpz2wVmiIjrsfekl1N4fhX3Zm/E86djOlCeesBY2ix3K6SeToT5khhvudkcdzJUzCxQQbfHlW8 PquyqBdjCboe5XYNdHV5Lvw1zXSFOpA+6nXTOLL/WNjgqBqmJZW1g11E1tUn+E/daWO/4A4Z306 iV2gTlRmEKa7HGmcnvViH/mYmMM2TEopQHA2zA8Ed5VGUnbiVre5AaXDRLT6Bssm6l8= X-Google-Smtp-Source: AGHT+IHZ491cWXLpS+dqT3PInxZGFT9Hawkj2mUnUkO88aGsnJ/1oIGYlFx6eiFALRnYsmrDGwS0fw== X-Received: by 2002:a2e:bea2:0:b0:30b:bfca:bbf2 with SMTP id 38308e7fff4ca-30bf44e60d1mr57376651fa.7.1741688702288; Tue, 11 Mar 2025 03:25:02 -0700 (PDT) Received: from pc636 (host-95-203-6-24.mobileonline.telia.com. [95.203.6.24]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30bffe3a2b5sm14425671fa.32.2025.03.11.03.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 03:25:01 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 11 Mar 2025 11:24:58 +0100 To: liuye , Andrew Morton Cc: Uladzislau Rezki , Andrew Morton , oe-lkp@lists.linux.dev, lkp@intel.com, Christop Hellwig , linux-mm@kvack.org Subject: Re: [linux-next:master] [mm/vmalloc] ff6f2b81ea: WARNING:at_kernel/fork.c:#vm_area_init_from Message-ID: References: <202503101629.7289b1-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 94941C0006 X-Rspamd-Server: rspam11 X-Stat-Signature: 9xfjkx4i3ypx5p9hepfw16xa1c37knre X-Rspam-User: X-HE-Tag: 1741688704-682059 X-HE-Meta: U2FsdGVkX1+wEn5/FRGevJhSXg37f88cya/WQVAn7fYxWvcs6ljQBB59w1p1lMwY+8sYdO4dR7zc5Q76HoA6HIIxAvXH63M6qaY84N2WFnfoOeRbCUh/3heEyk3GYYXfFdEuYpSisEsqvrQOHEnP0fNiFdtY8mCwuok0JdOLsW+pPRRnACwHlC4+cXoQ1vZ8BgZeKgFiSvSx0sVtKfgkM/Vw28J4HTg5kBl8qS6Sb4W3x/iot2d8WaaLY9KKSLkd4odqgekkH2YOHJvsw3VBa0b4Bafs7ijzej0qThHxJO9nSsnhaZRxs9Y6euKLOdJvYKafRXhcEOZ3gsZBBDhccQQtpiP7ZcN9c7ZRMZw9bkCCKbYABDpGMtLpcnA4lfZ7FL5evaxluFG9eUvrE8RfCdg17sMgw8wVXntPoSi/YozgNVDVTLIV2oMEPiew0PCTeVpni5nJRu+vNfy3w8koBhETjiGKefh0xi9AFQXFvwj8JV1jS8atPMvg7MDrS3+dZQ12wdYs3GmQy5nbcuMD4dyJVSW+aKaCqwRIRN0ig/C/tLHqsgNlMc5bHUEpaPQvlXUnw8iqkPcz04ZZ1js/iWrYaoumk7HGd49/dW8/MyCxYTEdyIQtYtoN75SdM4UGqNQ6F7EXtcsxan6utauzG3jr2zchhRhH7P2QFrQgvv/xoSjY7RUCLL1wQ31wuU8UU3JFw628Qq3cmJ9SpOKLIB1q40ZIQnIyd2ozOXv3JQ3Qw3+pL0Y3bK8FRFJhDVYRnn0MOnlQ3tg+vm8KMwKMXx2QejKOWOFbRTc+iHibbdHr81wz94wsedPG9JFwOtv6Dx3cfR19n95o/MyiQahmx4VPa3wIb8ZZUhoOhM0SKX/BFHlvOr2iEm529AdjM5qEhF3j5eE3JSDoWW2tCUlMo++bi6hBvM3t/QEt4E/Pw3+xmO4f65RNLkD23XxyfPfxJlR8RId4PXI7oczdd1d da+3F+f6 qKh/9L5WGLFD6KmfsPwe4Ff7w2bAtd2ABnRT90U3MD1sdzTWwkLgH4pJ2SWZZtQN0LMJVTwgEczNrnrpgKoFwmz8NKQ0/kGHFYBNG7AVDB5Y+4tKHkfVYdnl+Y2IaLyZfFMfOZwe3UeVSWBgLgCvokKgE7rg5RCeOiW/VCCjUiH/lK7D3VxmN/zqCbUw6vVmlqAh9cxpUXyHZHD+/AMcdSHtPciUYFaVZ0EbvvLHg/IK062/7+QAB44P28nI1UIHGqeY4D/BmSkFQFzxc14n5f2iXhw3Yk2BhNgTz+JeKixuO+DaNpj8iMAfx15zCbvAU+QvQ9gf00uS6i917U5eyzUQJnZbwTfmrHY5FXszLJ3y9rtx6R8lQheHDAPeBXSMuBnOtXraModYlZpX92Ln0grHDp0ITVAEm9lbXOgLbzIU7Cgu3ipMCJxxnt3MN3TFYbgYx3U0D68XPaXzd+IklBADkURQQtmj0uk1IKRPmtXSmUwQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 03:26:59PM +0800, liuye wrote: > > > 在 2025/3/11 00:52, Uladzislau Rezki 写道: > > Hello, Andrew, Liu Ye. > > > >> > >> Hello, > >> > >> kernel test robot noticed "WARNING:at_kernel/fork.c:#vm_area_init_from" on: > >> > >> commit: ff6f2b81eaa8a9fe5d158c6e7b1e58d3929c32c1 ("mm/vmalloc: move free_vm_area(area) from the __vmalloc_area_node function to the __vmalloc_node_range_noprof function") > >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > >> > >> [test failed on linux-next/master 0a2f889128969dab41861b6e40111aa03dc57014] > >> > >> in testcase: trinity > >> version: > >> with following parameters: > >> > >> runtime: 300s > >> group: group-02 > >> nr_groups: 5 > >> > >> > >> > >> config: x86_64-randconfig-101-20250306 > >> compiler: gcc-12 > >> test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > >> > >> (please refer to attached dmesg/kmsg for entire log/backtrace) > >> > >> > >> +-------------------------------------------------------------+------------+------------+ > >> | | fb8faf4337 | ff6f2b81ea | > >> +-------------------------------------------------------------+------------+------------+ > >> | boot_successes | 9 | 0 | > >> | boot_failures | 0 | 6 | > >> | WARNING:at_kernel/fork.c:#vm_area_init_from | 0 | 6 | > >> | RIP:vm_area_init_from | 0 | 6 | > >> | BUG:KASAN:slab-use-after-free_in__vmalloc_node_range_noprof | 0 | 5 | > >> | WARNING:at_mm/vmalloc.c:#remove_vm_area | 0 | 5 | > >> | RIP:remove_vm_area | 0 | 5 | > >> | kernel_BUG_at_mm/vmalloc.c | 0 | 5 | > >> | Oops:invalid_opcode:#[##]PREEMPT_KASAN | 0 | 5 | > >> | RIP:__vmalloc_node_range_noprof | 0 | 5 | > >> | Kernel_panic-not_syncing:Fatal_exception | 0 | 5 | > >> +-------------------------------------------------------------+------------+------------+ > >> > > The patch that is in question, indeed, looks buggy. At least i can see > > how a use-after-free can occur: > > > > > > static void *__vmalloc_area_node(...) > > ... > > fail: > > vfree(area->addr); > > return NULL; > > } > > > > > > > > ... > > ret = __vmalloc_area_node(area, gfp_mask, prot, shift, node); > > if (!ret) { > > free_vm_area(area); > > goto fail; > > } > > ... > > > > > > vfree() - __also__ frees "vm_struct" where "area" points to. A NULL is > > returned and free_vm_area() is invoked one more time on already freed > > "area". > > > > Probably it is better to drop the below patch: > > > > ff6f2b81eaa8a9fe5d158c6e7b1e58d3929c32c1 ("mm/vmalloc: move free_vm_area(area) from the __vmalloc_area_node function to the __vmalloc_node_range_noprof function") > > > > If drop this commit, then the two “goto fail; ”in the __vmalloc_area_node function will cause area memory leaks in the __vmalloc_area_node function when returning. > It does not leak. On a fail case we release everything including "area": fail: vfree(area->addr); return NULL; this is how vfree() works. > Perhaps the following changes should be added. > > If the following changes should fix all issues I will send a new patch. > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 61981ee1c9d2..1826f3d70885 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3697,7 +3697,7 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > warn_alloc(gfp_mask, NULL, > "vmalloc error: size %lu, failed to allocate pages", > area->nr_pages * PAGE_SIZE); > - goto fail; > + return NULL; > } > > /* > @@ -3725,14 +3725,10 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > warn_alloc(gfp_mask, NULL, > "vmalloc error: size %lu, failed to map pages", > area->nr_pages * PAGE_SIZE); > - goto fail; > + return NULL; > } > > return area->addr; > - > -fail: > - vfree(area->addr); > - return NULL; > } > It is better to drop the patch. It does not fix anything, instead it has introduced a degrade. -- Uladzislau Rezki