From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72324C35FFC for ; Sat, 22 Mar 2025 21:13:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35977280002; Sat, 22 Mar 2025 17:13:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3086F280001; Sat, 22 Mar 2025 17:13:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AA68280002; Sat, 22 Mar 2025 17:13:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F0D16280001 for ; Sat, 22 Mar 2025 17:13:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B3438C0D06 for ; Sat, 22 Mar 2025 21:13:51 +0000 (UTC) X-FDA: 83250439062.16.9630F89 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 1741D40004 for ; Sat, 22 Mar 2025 21:13:49 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m0scgQiN; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742678030; a=rsa-sha256; cv=none; b=x1AUMBl26dGij46xGzfXPZPD+NkknN71bTNZO8+0lNFFnQHnUg9iNEXix21ThOuGdZzRvq uWt0sYm9Vl3RKeXG4vlmM6Tfl0Mr3E+2ZnxH6b4Ty/J/H/JBSCiQPhL8qEYIkZeQsG88HH rblFe/tAjiNL6aZnV/B1AIp3clXlhus= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=m0scgQiN; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742678030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jw4nRoBv7YvGHs2GxEuwE6E/Q8bCcDDx4GQysHcomdY=; b=zGfsfgX5nMYjoi9+SzB4fmU2ub9zP9gAacyVeFyXg9yIgea2uYeX58B5jC188kUr1vfwyk Z6v+trqxaISAMpJfOb33rpNtqPWLFmPKjcYwVhlWj8jgqBR4av12LAEkTGHVlzLVSqO786 QXOiRm98y65dJHs9OYus9hMKALdBHPA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jw4nRoBv7YvGHs2GxEuwE6E/Q8bCcDDx4GQysHcomdY=; b=m0scgQiNuoD5yPnuFu0bD4acmd 7Zlo/jvG7RNVmecORw+43mRCw8GjWi0NUBFsEnqzroN4seI1rscu3MRdkxqZnZwMPuUhN6NuL0I9H cIESWsscc/n7z0SWwuI3gfTQaBCblcGGy2rKACT90wKqjg+4EvpIKv2r4R5QCUc1/C6OmGlqH6Q8g 81oSZ0WzNXLHcfqRNVKhkeQCIc0LvBqKthNaE66NFqKOYXvxXn2+1KBMYmC/bV07ve/WrrD145jyu OymivnxU8lm2PCxI0dy4KEXPjEEVun3Yw0tTBZk8F4GSpAgdEa8B15pz3vXedxnXKupDrLyant1tF u0fAiToA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tw6A6-00000005qST-1h6Y; Sat, 22 Mar 2025 21:13:46 +0000 Date: Sat, 22 Mar 2025 21:13:46 +0000 From: Matthew Wilcox To: Tamir Duberstein Cc: Andrew Morton , Stephen Rothwell , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] XArray: revert (unintentional?) behavior change Message-ID: References: <20250321-xarray-fix-destroy-v1-1-7154bed93e84@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250321-xarray-fix-destroy-v1-1-7154bed93e84@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1741D40004 X-Stat-Signature: 9ummgmqwy5dtb96yrocpy1j3q9wqfrpo X-HE-Tag: 1742678029-805236 X-HE-Meta: U2FsdGVkX186gfA3xESVIsTG+KXX3Y/INW02HJ7MB1A/20FsnN2txWmTGFPQ5OpC9vT2RQwWmzwCZYq1d4UvC+ZIcwTlImbqJA/t/c+bXHfE17kxE4ywmgYDaedeEDZw8KRDwCgPaA75CGTEX7W7Km2X4MaQ5Cn5z4AIAPcvTnlTzYsOx4h05EFldGbircYx9LckG+T9OJ6nR/Vd0wdkTwp288UXnGlOv1TKU2jBPJyXdAuYC5FxzfwsrR6xo9BFmGO/DfZYtC/yh5rZDeG5AEE/kaOB7/nVNOfQQrKYV2f8z4CgKGqc6f2KdsMuPRKoVHTNCaNF0WcqIsVyH2fboUeSIVquxYXhN7MW3vFF3LKTtEyHws1rCmJTltvQ/jDb3TPAbTRSRnGRDWa2tZmlnIo4ibjUo7k372bjMwYzNteywhAuvu52g2DbpAFUAogcLLjSQH5pdORwNKxI0+LyRO73d5vRZ5aiSGH4s6NM426XYESgVtGp02zj8FhGPZbaHPvJ2+bfK5Fx9CUy3N4G7SjqIO9HQCqF1HEep5Xy90k9TBXk/8x78Mn8sGwhTpCVX/41lKiyXequHfjsYN9R7vzT/WVOlzzOKqSPlqu1HPunXf57/ClhMXmL9Ba/jzJT/VbWidqdPVALvFcfcAyVZDctRRH0NoLKkjbPSm6a/oHcBhr+QKFtFCvLSroMxhoOt+546SCFOc0WHpdSy6/fuxXcgbLEvNi+vTndcSfDjsZyUqgSDVTLnOsUVdyOH/M4sT2qKbidyktfO2mJWRhRnnpBMINYt11VZK//r4IwARrgHYbk44V1zNj9uDCQqtVZyoRcmHDU6K8+eipe7GaKJKNBEPV/aX/b/H94P7nWOJrLfSknuy3oIWd7a9/ISHmPmmll5BOKh0LpCm7hceDJ7EYKRxFNhX2ym8VPIuvHZjgjzIYhV2D7XD7X77W3l/5MBgxGr5U6D8wCYI8mPVA TZuu9/nX CDHG+btB2wdqe6NKKOBP/pVK9eLzMMdVCw8UnpfW26L2FsIJ1uKcl/uPYlQYGIBrMGUcxpMotsZ/vjbcnBYENBep6lsG2KOYhFAjFuao7db3ylSOxweLFw5c/id+MiDaLzbCMWpq1akU8rVOA++M/h4yj0l6luqIDUuDMXmZs5ZzJlVfVJyecNduA6oLTZa6c7p4CoeLhpVHojv1WLW7wAG4BUHS5WMx7dfv8yQP4hT1Gqbtke2BYwdW9jPRLnL38KopL4l+5hutwBgk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 21, 2025 at 10:17:08PM -0400, Tamir Duberstein wrote: > Partially revert commit 6684aba0780d ("XArray: Add extra debugging check > to xas_lock and friends"), fixing test failures in check_xa_alloc. > > Fixes: 6684aba0780d ("XArray: Add extra debugging check to xas_lock and friends") This doesn't fix anything. The first failure is: #6 0x0000555555649979 in XAS_INVALID (xas=xas@entry=0x7ffff4a003a0) at ../shared/linux/../../../../include/linux/xarray.h:1434 #7 0x000055555564f545 in check_xas_retry (xa=xa@entry=0x55555591ba00 ) --Type for more, q to quit, c to continue without paging-- at ../../../lib/test_xarray.c:131 #8 0x0000555555663869 in xarray_checks () at ../../../lib/test_xarray.c:2221 #9 0x00005555556639ab in xarray_tests () at xarray.c:15 That has nothing to do with xa_destroy(). What on earth are you doing? Anyway, I'm at LSFMM and it'a Saturday. I shan't be looking at this until the 27th. There's clearly no urgency since you're the first one to notice in six months.