From: Matthew Wilcox <willy@infradead.org>
To: Tamir Duberstein <tamird@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] XArray: revert (unintentional?) behavior change
Date: Sat, 22 Mar 2025 21:13:46 +0000 [thread overview]
Message-ID: <Z98oChgU7Z9wyTw1@casper.infradead.org> (raw)
In-Reply-To: <20250321-xarray-fix-destroy-v1-1-7154bed93e84@gmail.com>
On Fri, Mar 21, 2025 at 10:17:08PM -0400, Tamir Duberstein wrote:
> Partially revert commit 6684aba0780d ("XArray: Add extra debugging check
> to xas_lock and friends"), fixing test failures in check_xa_alloc.
>
> Fixes: 6684aba0780d ("XArray: Add extra debugging check to xas_lock and friends")
This doesn't fix anything. The first failure is:
#6 0x0000555555649979 in XAS_INVALID (xas=xas@entry=0x7ffff4a003a0)
at ../shared/linux/../../../../include/linux/xarray.h:1434
#7 0x000055555564f545 in check_xas_retry (xa=xa@entry=0x55555591ba00 <array>)
--Type <RET> for more, q to quit, c to continue without paging--
at ../../../lib/test_xarray.c:131
#8 0x0000555555663869 in xarray_checks () at ../../../lib/test_xarray.c:2221
#9 0x00005555556639ab in xarray_tests () at xarray.c:15
That has nothing to do with xa_destroy(). What on earth are you doing?
Anyway, I'm at LSFMM and it'a Saturday. I shan't be looking at this
until the 27th. There's clearly no urgency since you're the first one
to notice in six months.
next prev parent reply other threads:[~2025-03-22 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 2:17 Tamir Duberstein
2025-03-22 4:37 ` Andrew Morton
2025-03-22 10:34 ` Stephen Rothwell
2025-03-22 10:37 ` Christophe Leroy
2025-03-22 16:21 ` Pedro Falcato
2025-03-22 21:13 ` Matthew Wilcox [this message]
2025-03-24 14:45 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z98oChgU7Z9wyTw1@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sfr@canb.auug.org.au \
--cc=tamird@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox