From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E15C36001 for ; Sat, 22 Mar 2025 00:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D24BC280002; Fri, 21 Mar 2025 20:30:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD4E2280001; Fri, 21 Mar 2025 20:30:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7577280002; Fri, 21 Mar 2025 20:30:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 96E74280001 for ; Fri, 21 Mar 2025 20:30:30 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 755911608B4 for ; Sat, 22 Mar 2025 00:30:31 +0000 (UTC) X-FDA: 83247305862.13.B557344 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 1E0A9C000B for ; Sat, 22 Mar 2025 00:30:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jLrVt2n9; spf=pass (imf10.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742603429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CWlkvk1KBetht7Ag+Rj3C+3gwynOXUnhWtcvGTCPH9g=; b=lqsOpTL0RijEP93P9B8scrd+3GZKobsiHUdjNTfB1Bee0ynC8O2p8oMU4tiBWkuqos2QEW QjAmV3EgJMZxvfY5exKUSSZTlPCY9cnyB4UjfDthHEuNWlUBmK4kQbQJ8OtI6oQsiECHZR QrHs8WkUNbkqIR+oPWZWp1DyvQSCnzI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jLrVt2n9; spf=pass (imf10.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742603429; a=rsa-sha256; cv=none; b=yX6Pv0mzg87u5ZmResjilHG2VHfecdJffijZrjbJXoHcPuUtCVOYFhIq/QYHic/UqVcenI CKNYgXEyRPuLGvvTCOD61netpnnBpmJ4WgLMjnl4NuZ9npHXvICLSoUx6LT90lm7HWwyvN czop/P6mns/YJSsBUfUFlMtPvTpdt8Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742603428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CWlkvk1KBetht7Ag+Rj3C+3gwynOXUnhWtcvGTCPH9g=; b=jLrVt2n9uHzHId3mmOFi2Elvb+D6B3tMXdqlAbjPBbLQqwyP5Wrg5krf6WELlxHtLapnZf JCkcikUleFRIiY8QWXmIdsM6rIJsMzNX247nxBo4yS6ZiwL8g8V/kwIDd6IyzGsBYY63Xs 6cQ4SanMyi8aHbkY/DH6+0NV1wICXAk= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-BVmrPZvrOJaNNm2KiZjNFA-1; Fri, 21 Mar 2025 20:30:26 -0400 X-MC-Unique: BVmrPZvrOJaNNm2KiZjNFA-1 X-Mimecast-MFC-AGG-ID: BVmrPZvrOJaNNm2KiZjNFA_1742603426 Received: by mail-il1-f200.google.com with SMTP id e9e14a558f8ab-3d43541a706so22231605ab.1 for ; Fri, 21 Mar 2025 17:30:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742603426; x=1743208226; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CWlkvk1KBetht7Ag+Rj3C+3gwynOXUnhWtcvGTCPH9g=; b=ZsXTeR8+a08YwImHy/4yQLTiWx6NZr/LuS8UhsQHihBvpjR3DiqLCr4Y8/QNmsKWpI csFxIF8y7aC/i9IPJIZ2VZ2LGvfDSG6pqQ6darYS0DynAR27l4ZPdsYh0eDx4DpA3rpT kHn/wT0W7fxwh8wolQ3210Xt+hdegpFmT+O0LqNh5Z7OpV9YcZi8D5QgJyzWiNr5eI2P 7WjqzbiSZ4SqAiqkC6p9C32xQGUPQNYqgCI6+Op48qh+WBUlK1gfi9L0nZAkOSI0Oas0 6bF+k+IRaKsUIKAQQgi+R6bifbSwA46qZzZWzcTBX8dn5m/s8biSk2risqLdMAuVVSS+ xiWw== X-Forwarded-Encrypted: i=1; AJvYcCVIurMPpPCq5YYla7MJ4LSlhmChiH3NMDkuzsCYejv/FKRd/vIQ/QEpbFyHl28COd6Yp2Y+buLnUg==@kvack.org X-Gm-Message-State: AOJu0YzBuCS2bu9kEcwjoug5S+BPOQ8E/Ck297xGLL3GHbGnmZ25lKb6 gZjHEdaZmEnDUKanMsXNPNNOTXJcDx4bCNdwIWmhb8mrioA55KBRI6qPP0VDunufATvE6Hi/msI 15bQYH4dIIcGXZqAzt2RPcA1OWL3h4CmNGHlnoMbPxL41sXKu X-Gm-Gg: ASbGnct5GVkBbunbPSDSMuEAsezDXhaPgZ0T1y6LV/JjCs2wG9ugPqZUUflwNfNRhzj 3cEVp42glVoR3rd9vr1xHFwzzYHVq4QPxxJrthf+E5PFgmI8u0v2ns8kPtF9uifbh0TtGXt/xiM xA+JqqNm4Q5awf84SAGxU66rWuildYxX3Wk7vtn/nxxi7v4geRGhPvEbbqif2+urvXlHPjX3F2A y5NIUoAlwKO53Z/YG4kHogeVZSHTKSdFw6t+YYNU+XqvaJnxNo3aNB+nNoyxMpOf8PQuOS16Ris onpDYjw= X-Received: by 2002:a05:6e02:1fed:b0:3d1:97dc:2f93 with SMTP id e9e14a558f8ab-3d596186300mr62395115ab.20.1742603426005; Fri, 21 Mar 2025 17:30:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHz+fdg6EnsNjYRzuN4tmC+mxNsl6fpbM1aMJ0TwbL+kR0iHWiiNNJUAdfLRTjLeppDFKFSzA== X-Received: by 2002:a05:6e02:1fed:b0:3d1:97dc:2f93 with SMTP id e9e14a558f8ab-3d596186300mr62394955ab.20.1742603425546; Fri, 21 Mar 2025 17:30:25 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f2cbdb3aa9sm690364173.17.2025.03.21.17.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 17:30:24 -0700 (PDT) Date: Fri, 21 Mar 2025 20:30:22 -0400 From: Peter Xu To: Lorenzo Stoakes Cc: "Liam R. Howlett" , Pedro Falcato , Andrew Morton , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6.15] mm/vma: add give_up_on_oom option on modify/merge, use in uffd release Message-ID: References: <20250321100937.46634-1-lorenzo.stoakes@oracle.com> <233o4lohzhriye27szk6mucduneuvosmnp6pmnjepz3enxjgtt@id6kwhjgysbj> <494b3b71-4331-4365-838c-84974bbed32f@lucifer.local> MIME-Version: 1.0 In-Reply-To: <494b3b71-4331-4365-838c-84974bbed32f@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HYm8GgHlLEYZRv-AC-0yBggZCjSaLhEgmWNb6iUIcN8_1742603426 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 1E0A9C000B X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: 6937m65xjs8r7rt1cbxyn1az6qqpdtte X-HE-Tag: 1742603428-479372 X-HE-Meta: U2FsdGVkX1/ucGA44RhZzqLFZVvBbqY5CQ+cr/veAfKkjCrPWnISDXF/qLdjIi3MdkZ9M4S6w/ONrmapgwHPIJOeeqhcD2hwLS3T4D63GK677g2n5Bjcwa3yYGbaMsE5mjE+iU+jceoKWN8cHIuxjJvsiqQ5JGWrN4mmohqTQKJHGL5iWYU6fSl36Rk+DZkfluvX5aDBE203XTNl0hOgGKyCunX2+c37/asIsatte4zq9sAFu3jT6wGiqfUwAWsG8yYEUc3385Hht/VbiqGCw2GaSgWYCZvYikbjrwJjkTux6DN+dL1kDh0BW/pRIY3QqVexEPiJH6mmyqpRaVuiFI4itB0fPcoxzqP/5woZ8X/BiK3sQEff6YGgp/9qWmhezyeZnuy5f1VOX5L+rvKzssgteWdusCl6l4s0EBH4GAZd0iISsHnvCHqSBdhWp7VIjY4rZ0b49pc2cS0wrpIyqB8oRAkNvG4fOY1Il0VWWSZfnwfJA5z0K+4juIAMVMGhzcS14kBw19NfMY4OF7FlYOioWj36sp3Us3YYTI2v1XxcOkWy15x+5z4TBS7Nh2f5KrPgVOWkD7U+ZpXrGVAzTo29El/R5XZrNW5L5tMWpJm6S74A/q0BhQfMrAnChghlEOtVWTbkFCzWI/uIgtS/LSerguNZZUtwCuoZ9R/N2/WEKmidd5ypffyHanpHY6gvlRG6rdmR4rjpYMrG7RjuKe79tJTGYeU+9eKbqJfR6SPlw5GlU1PyhpQHwaYct1dXz+PHyvk+Gid0vQt9Jv0+Q/sJS3YXj7VkP1W5eW3pXxbqB72s5WAY9Vvp5ox+YzB8Ytda2cFm0s9JjYu1s1wg4ykW8V2TUV4bg1f5TZZ0Bucgr6/Yhh6hn6GO00f4wNv4h1QwqSAaQ7SRDMmqWDC0x3WDRR3Kd2iFt58p5PS7LpnNocwPc1+vHf3VAMLpURFuP9974VawihUB45b0P+U MyeIUVlU LClm/JD6/wYAABBuqgDFbcTgP4nHBXImgA4lyXsfARFVSTNNBx1AaIL/KBas5FG5Xs7Mje6PMsRMgLAl9a4UsqN0R2EspZ7Wesz4o0LjPuX7LQGUW1fkS5toEWVXEITXsJIAngcUwQE3Sg1TAB8sXPinAKpCq69cROnhCkSrkMaRc3++7x7h4edxvZwkIAdNg1gV/e6F/god3lOZFq+0pwzM+DBqmmX4E2Tls/VRw3iq/ydfVy6CQfBZ5z4sUuO1bUtFzPO8LUwEECdPd4sO7aZT0Kqo7WX9/fBHyiVl1WkTS29YzJzgwy05afaEnLb9OKVPEkGxKp9aF6N4VWwQfb8IFbkjIBoUsEOxeehwJKhD0i4xamu+gq9dLSW1F+MAzWcDbzjtEockq9TY/roT80BYXxaYFOH3zKNA8+qXWe3CFPporsZAty6fKiXJoW2pTnS9i6Wf5jmdehDqZqixGV3rmn+1RVIlKP6cW4VzJd83VavKGArdEhZtTAigO0EXE9P3b3OA0eZNfKAf48OrCqm6+3ll+cK5bS744wXjd8NXW8NIK46EtyDE6jg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.026476, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 21, 2025 at 05:16:44PM +0000, Lorenzo Stoakes wrote: > On Fri, Mar 21, 2025 at 11:27:34AM -0400, Liam R. Howlett wrote: > > +cc Peter due to uffd interests > > Gentle nudge for Peter to make himself uffd maintainer :) I am not a fan of > this 'happen to know person X often touches Y' stuff, this is what > MAINTAINERS is for. If you're not there, good chance I won't cc you... > > I also strongly feel we need somebody to take overall responsibility for > uffd at this point. > > Pints will be bought for this person in Montreal ;) Thanks for the offer, though I will be absent from lsfmm this year. I sent a maintainer file change here, though: https://lore.kernel.org/linux-mm/20250322002124.131736-1-peterx@redhat.com/ Maybe someone would like to be the 2nd reviewer, and if he/she would be at the conference maybe the pints will still count? :) [...] > > I hate both of them, and I (mostly) blame uffd. Some blame is on syzbot > > for exposing me to this unreachable failure. ;-) > > So do I. I agree with Jann; AFAIU, userfaultfd is innocent, if it used to work. I don't think I have followed much on the recent vma mgmt changes. So I am almost of no use here.. I'll leave that to you experts. Beers indeed might help. Said that, it'll definitely be very appreciated if the old behavior can be fully recovered, so release() will never fail at such -ENOMEM. Thanks, -- Peter Xu