From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDBFBC36000 for ; Fri, 21 Mar 2025 18:57:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E569280004; Fri, 21 Mar 2025 14:57:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16CE3280001; Fri, 21 Mar 2025 14:57:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00C6E280004; Fri, 21 Mar 2025 14:57:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D034C280001 for ; Fri, 21 Mar 2025 14:57:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9FAE8B7CA3 for ; Fri, 21 Mar 2025 18:57:43 +0000 (UTC) X-FDA: 83246467206.25.ED96963 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf05.hostedemail.com (Postfix) with ESMTP id A8079100012 for ; Fri, 21 Mar 2025 18:57:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FUQXX9Fg; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742583461; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MC0meKmPQiWag+asDsnzWKC6Vb+K69sXucOHKhpzZsk=; b=Cau2WX1zs4MakfwpD65KlD6XROng5JTfaoDLPgReRGVEqckil1GL8Uh0Dj58aaA9Y80fr8 GGaNNi8yN12ONwWMKBPftKsYLVwMQqvQeoiTXoJp0Pyfg9Xe3BAicVlNt9Ns55T7hWFGQU 2Pc06Pns345pW6NgTollwExjRJ1pBrQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FUQXX9Fg; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742583461; a=rsa-sha256; cv=none; b=MQ+IcED+Ev4feB89ErgRDQtK/gE6ozwLW6x8OYG2wmp3pAZ5aQyI8iKzuPPtCwEzX5n1C3 DS5yL6atKSJ+8wegOM5Hl0LvzDBVyevIpgRTWljR5H7axq0dxdPLieufgzNQWZ0mNlo9Dc jNUSl8aqZK6pPYBmf2IlGAzet0qkrLg= Date: Fri, 21 Mar 2025 18:57:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742583459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MC0meKmPQiWag+asDsnzWKC6Vb+K69sXucOHKhpzZsk=; b=FUQXX9FgYIhglFozc0YNqMHNHD+NfIZveBN0sY4ZA4CpBxVw+KluzWXHLAxDdW5rTaKmwX iaiej63T954gdrSt0Lgd1QCNp0txNTh2avDhe/+I/AwXDJMsrCDLz0pmf3QfoKLNGkMbsj 5c0UyaqrEXDpONhl2BNXbo2uKfqiIoo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Nhat Pham Cc: Chris Murphy , Linux List , Andrew Morton Subject: Re: 6.14.0-rc6 lockdep warning kswapd Message-ID: References: <3f156789-759e-4195-8881-c5c74ced85d4@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam01 X-Stat-Signature: r6iq9ydiz8pri36zie4yn14ppx1chysx X-Rspam-User: X-Rspamd-Queue-Id: A8079100012 X-HE-Tag: 1742583461-131067 X-HE-Meta: U2FsdGVkX1/c0eRm5eWa+xxWikrSaWNj2ci/R2vGWHDYJg1GP8Hed5KNB+QbqzUK2nDxC3Z11oC4hcB2I9wESOp6qq1GJus+NtjnJNQH7BnxkRpHd1WC/DE2PQSlUU4ykTVuWTRbD1frVQLnPtVKjxeEFZQx09SNq+JWAURZuz2D6Kh4VbjeQG/Wqut92U7IG+TGKyL4yNAm6n2/dFgg6z02gGm44txUnw50mUhTCkLr0SWYXxWLjN8pu7/7cuWz1KEnlsElolfBZAz89W+RXrLeXEq1iEnp59JOv275oYFjLFXk0tZuCqfxjPmiQZGrzLAHlig6032QLSXlA4weWCIYG5K0F8VNi85Il6p2FJfNyTYGNa0QAWWIgyxAczQqo7vuZZEvRqFImrVKaEPIIoLfduNUFae9nAI37iWQCgT9VIoYXot5wYWLaBvY8mIKaPwrm3qeFGMli/Q5NWs0jDE0UIr8p9l4a/gsBbzqqZWdjwYvVkdxFKGp4ZgJU9nixB/fCz//CXqxWCnf0kOT6q+5m0Orl4AHs67wkwvrEqwBZe7BjgcBfrti0blX7jsR5M3Y4G57Sc0HwhJp7elP3h9wvHgkrrXuB/R7MF8990+QGBmNUhXl8ao3tr6yOtfjxJ+km4zkNWgLc5R8sPqsb47BkWCV4OdktMKEmnA2skL9peKVbfAWVZPMpseoJdNX7lOx/p8M/8808RAXVM6jHl7GkBXgWTo4nIStohYc6/4i+zW6oxHoijmiT6AxXzRD8Hn6p9rdC60IRhPNLJO1WwsWai5Y5YNNbWEevo3iLLyHPcnhX+6htj2eGn+ISf4jC+CXQfZDvWXK+coQwIaQtM/io8P06ojYuLw6OHJ3fuve3ab1ZL3lv4mT5+HEEiiQloSVpLDoc2sK1PdO1o9HyZc6kQq7KVd277DzTAu/Va4lWMFVa8jYex39HvM/eEeOApfI4v/9jnAholX/Q2E eBwibRCL HW/WlAakYnAT3+SWpBD7ZoaFyGuQL5soUsj+akReq5NrOQNtLQSy62jvH2XxDkc1T03Cf/Ptjz3jdg/4YJq6FToJVUys4lc001STlPOS4hD8e1wqHo8RkTFT++EmMMzPp7cj0oJs7y3AxWzEj3N87ywA5YMeP4I0xVJfv1+RbcblxUmKxqCmu0k6WpimoUUZUyVpnPJ7YsgPtipfcXwn1n/IanheS3uZN3GfLDAmjHhYskArtwPSMZgcY5KIu45PyEf73YkBu3Yea8EOEZWSaU3WHsOg+Qc5XeRbUsWmcUI04oGMxRVzi1IF2EXynX6hrQvolTsw+5M5sTYIrJh8lhVeDWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 20, 2025 at 09:28:12PM -0700, Nhat Pham wrote: > On Wed, Mar 19, 2025 at 9:31 PM Chris Murphy wrote: > > > > > > > > On Wed, Mar 12, 2025, at 9:52 PM, Chris Murphy wrote: > > > 6.14.0-0.rc6.49.fc42.x86_64+debug > > > swap is enabled using a swapfile on btrfs (which is also used for /) > > > zswap is enabled using zsmalloc/zstd > > > > > > Downstream bug report includes full dmesg.log attachment > > > https://bugzilla.redhat.com/show_bug.cgi?id=2351794 > > > > Also occurs with 6.14.0-0.rc7.56.fc42.x86_64 > > > > It's not reproducible in any way I'm aware of, but isn't uncommon. Updated bug report with rc7 dmesg. > > > > > > -- > > Chris Murphy > > > > Eyeballing the trace, this looks awfully similar to the problem that > Yosry was fixing here: > > https://lore.kernel.org/all/20250226185625.2672936-1-yosry.ahmed@linux.dev/ > > That should break the following link in the chain: > > &per_cpu_ptr(pool->acomp_ctx, cpu)->mutex --> scomp_lock > > since we release the first lock, before acquiring the second lock. > > I don't think this is in rc6 yet. Can you apply the patch and test again? Yeah I don't see it in any MM branches. I suspect it's because there were discussions about fixing this on the zswap side vs the crypto side. Although I mentioned that I prefer that we take the zswap fix anyway. Andrew, is it too late to squeeze that patch in? If it is, maybe we can just land it in v6.15 and backport it to v6.14 via stable.