From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A6BCC36002 for ; Fri, 21 Mar 2025 14:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D232280006; Fri, 21 Mar 2025 10:09:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25BD8280004; Fri, 21 Mar 2025 10:09:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D732280006; Fri, 21 Mar 2025 10:09:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DFDE0280004 for ; Fri, 21 Mar 2025 10:09:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 41BABBB755 for ; Fri, 21 Mar 2025 14:09:18 +0000 (UTC) X-FDA: 83245740396.25.6B00EDD Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf05.hostedemail.com (Postfix) with ESMTP id 5234910001B for ; Fri, 21 Mar 2025 14:09:16 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=X7Ad5Ctt; spf=pass (imf05.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.177 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742566156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O+nhgTbLeJKhDFnNTQysneSWHNY3+PqAlhMu5LglW/M=; b=H+kJcAMdSS6d9pbfdfX/tV8D8t0y0IMdpSLALg0SuQFL270bMtoqn602iRkIJRZh0CG8wq xiFnk1Go4ssD5wxWKWph9eUg37PwtZWjrOBYPSU3PVxIppU3KVAUNu8oMXS+hCbl7lmi6w HWgE72kVvapHBjh0W6N2TrS1bPubY08= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742566156; a=rsa-sha256; cv=none; b=2C1xKH5UnCTad404Qwz7vTgDiX/Vrv0Ze61LHXiUtnit1ZJs8nm7blYF/EqU9/Qe/VE/d2 r2toi6fFfFrk816OnbWnCxQSoVEUy/m1RO7SOFdHeLkmtzb0SXF2Lde9rRpeWpg8nzdjdC dOI5MFEbuHxRoOKNIOftrQdnlHw3tik= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=X7Ad5Ctt; spf=pass (imf05.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.177 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7c5ba363f1aso131526785a.0 for ; Fri, 21 Mar 2025 07:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1742566155; x=1743170955; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O+nhgTbLeJKhDFnNTQysneSWHNY3+PqAlhMu5LglW/M=; b=X7Ad5CttcIEUh9VUHK0Pq6FA3xzbyiGUQKekHYR2OizcTiepjtNsepFLxTY2Sgcs3i BOnAGnqv/RtYtOEjBbc7oaKlZ7VmmD3Qh3yj5zDxcOX5Ytf2bnwmE3KuJ3iwjH1JdB2n VJ5WL1W8FvksE3wz95jukbOMQKV6v7TLt3ljWQhxVTFpgOTkE/nUu9H4+b4na2wBw3t7 T1iqwPjMReMMgnFiCoN+CTdGcUMsVuimZDzsWhA/h1NuBwfl/lU47OzKJmjS6aYq5swU wG8lr+xBQ5CF8IEwPmSOC532XmDKw54JXFhXLxF3WhQemI6XlExl/mZhNMkahdDFFX/K BzdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742566155; x=1743170955; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O+nhgTbLeJKhDFnNTQysneSWHNY3+PqAlhMu5LglW/M=; b=lIuYJ7xq4MkmVXvxJwsFZuay3yqBf3MwMRwSkF4Uv6GS8xWxLNEuTvJLskHdG6ctGr YZ63P/k9JFRooY7Qnqs6+gcSIXPSt52f83c+OKWz+e6pPXe/XBDJYjUGwDfsJBU1xtaM yGX94hEZM0qoveXxXO2/UsNjdY+fqlbMh218Gnwb29gkmukP19RpxMepP+PtMi+SP3Rd V76s3jKFBzodrV/2H6ITiOfVugxLT5vVGzbzrZSg+dTVJHIBGul5g8ya5LrmZkm6q4yk cuk1611+jCCTZaHl5G4DGNVbHaKI2yJcyl5BpqBH+L0fozOlQq3z/IE9xi/dWrPGtNoG 83BQ== X-Forwarded-Encrypted: i=1; AJvYcCUKtekkwawjp3QRTV9hx8YgkBFeoZ0Wc3jG4GChQahyd8CkRuMf/5+3MKJsinLiUCISm/+eAtx0AQ==@kvack.org X-Gm-Message-State: AOJu0YxInu91ovmRN0egrrxa3sGfO8QPI5gikFobyHCSnTjqiBHFkS7o 2mzqJEamWYKojtyu5TCWvvwuNOrPuqPt68eq66u6QYwQw2nO4qJ9Qb+xgo0pK/4= X-Gm-Gg: ASbGncvPEPUfCM8lOQEMSEQ15BRxOjItS9XJixgC1UmEcAynxfjYEyq5k+tTmgHQzOD yF8CFoyH2mo0C6OWZj95DUv+9FZASJNsKaSYe8D3rjPsJ4zWvu7X0bC+2ki3nV2o9APD5OUAgIZ kDtLX0v+XoV+OVc48oOWuNjQNZ1Y7xs9tbbxWyrU7caxJfh2Dp6CCWiO1ZGYT1WCSIsrLrw8tvh iSqsee9pqGLHv23YIh2WQF3ihVFHJJ+A38AXTsOBU4w/DVAXfEWwOoyfF5x74G72TCL2enF9J94 Jx2fL1vJBH1GPX6zjKvH/FR9KNYHH4BzByhZCkUNPXvyKPomZ6FAQEug0VigBsVNpEwx77privI L25M3eoJWWxb2ZR+UqkMF+LJFIt4= X-Google-Smtp-Source: AGHT+IHYL5PtE1l5A53doJXJiyZ0pMLxq3g63BRJBYsQxz2bFKxwUqG2PxozWwwqOpZAZvNY+68OCw== X-Received: by 2002:a05:620a:2727:b0:7c5:3c0a:ab77 with SMTP id af79cd13be357-7c5ba1337f0mr490684885a.4.1742566155122; Fri, 21 Mar 2025 07:09:15 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5b93484d7sm134529085a.81.2025.03.21.07.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 07:09:14 -0700 (PDT) Date: Fri, 21 Mar 2025 10:09:12 -0400 From: Gregory Price To: Rakie Kim Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v3 2/3] mm/mempolicy: Support dynamic sysfs updates for weighted interleave Message-ID: References: <20250320041749.881-1-rakie.kim@sk.com> <20250320041749.881-3-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250320041749.881-3-rakie.kim@sk.com> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5234910001B X-Stat-Signature: hhptaw15c3adxhc74cycdxoaes8sc8hn X-HE-Tag: 1742566156-612163 X-HE-Meta: U2FsdGVkX1+tIlO+D8jVe6Oj2mxu+XBmUXIW4UAi1In7pYzbbR1fufo3HhuseP9KhQ2aOM9FGzKr6mqCiIcrS+9zzgrVHhO36ClVfv/ftiP+FQdQTtvl0Lx/PGTUTSVaZNG5S+rviYDOmk5ORhf92bqpNcjdSb94U5o8e29kQhrXD4i/pta6HF/w+PKWoAU1JMqs6OIpainQXlHsa/RKl+SYGFWDh2pU8LDB9/v/De98XztlJW47Pvi6fupwiEzwcqpR35w1zVInP2tdXHH5xCWhbLgcBn7FrwHULXUxrQRrgHAZ4sRgE4RmD3dgJyqJdNaJDYcguzrseOBx4mv89jtLwmOA4UlJHASyahI819oVqZDal6sriMSscE65ZNebZx+15o0reUoK/+qh5G/3EerD6f+dswzJh1HYHFA7/TcPDvgbAf+N2kR02T2A+PF0CC9x9N/EpdDYHGKRGVLdGh3Z9JAFhKveFllHOX6eKAFATDpKM2rF3kTLFpDLhl3b6iLdaDR5H6/AZaagIdGukhh0DM1OoMmPDsQCnRWOs0hDIp8M5ppppsXAnzVKO6zLz26/TWENHhSqWkDXmeNlUnvhoHArEH+wGg8ITTiZKmbt6QGATb/Tl7Ii+/be1Y03DX+BrQ2rO/ZdOhLbzMP8AZn8zOytSgrpSJdI7NIDWTmoHmUGilnO8E3ZzSXNLCPCEjRbB8SwPColXueHQIdwMkJpn4AdNIBzJ4BM6pJDHTJpKreHB4doj79at3rr0rw4R0QSh8ThP4oj6xWKfTKxfzGfuxgKQtnlF4FjChhgZ/dzWAfZFEn+xRGKbk4tnrn39AcwIyPJ+3x7+iZx0b1ykOrlv97pYJLkmxizcJEJ14YG1kFnrF2B2sqcFU1Lgj9CBxxgagvTxNfgNBvBIHUlh+chneSKqZ2+dh/xtH0NV0v10OYGw+4WRjSsVoXLvsKLBl+1QTKGWVUydeZN61D JY4dzdMa Mtn5ptfeoNwKjf5NQo4Ym6AgLQXaT5j2/5KXLJ8hgMFE1EtQPQpRh+JccJWg/xBPWsv1xrOjRruLSnErQhbsO9IFExIMP0K3CFOP0Uv2rXYHXIesezCDtgXdzPjrCaXnbAAX2L5XW29mkRqkUg/sh9JBDE1QUPpnmuMGbpUJERefe/yovTH1kr2aErCFeZ+BKBmC03jXsOsF+hfIWKpEpkmqmZDQH3nc3RHG3+3yHgepDJI8k3eybLii4QbDsYc72LFNlR/059EO6MYK3I69JC2HeHtkM4Kf3qfkc+YPVhgony5nPE3svemz6T9MPdoZdGl26zYUC2JZRbNURuYWGj9BkkUXNI/kRXFaTtBYouC95Z+yVRZkTmHpo0k+ETZEYXZQRav7AEMjsAUuIuZpYgA53AXeddvEpAw+96N22ojdxQM3lJrsDuQ7NRaPKFBqGsl1ifHs2IlnLqxiM/KjJMGt6dKPGjSQoMYJdF3HMS8E0Sbr3ODW6gkK9BNtOCHMZFFmi7aV34eIy7uA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 20, 2025 at 01:17:47PM +0900, Rakie Kim wrote: > Previously, the weighted interleave sysfs structure was statically > managed, preventing dynamic updates when nodes were added or removed. > > This patch restructures the weighted interleave sysfs to support > dynamic insertion and deletion. The sysfs that was part of > the 'weighted_interleave_group' is now globally accessible, > allowing external access to that sysfs. > > With this change, sysfs management for weighted interleave is > more flexible, supporting hotplug events and runtime updates > more effectively. > > Signed-off-by: Rakie Kim Reviewed-by: Gregory Price 1 nit > --- > mm/mempolicy.c | 70 ++++++++++++++++++++++---------------------------- > 1 file changed, 30 insertions(+), 40 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 5950d5d5b85e..6c8843114afd 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3388,6 +3388,13 @@ struct iw_node_attr { > int nid; > }; > > +struct sysfs_wi_group { > + struct kobject wi_kobj; > + struct iw_node_attr *nattrs[]; > +}; > + > +static struct sysfs_wi_group *sgrp; > + sgrp -> wi_group? Or something similar, sgrp is not very descriptive for a global. ~Gregory