From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72880C36002 for ; Fri, 21 Mar 2025 14:03:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3137280005; Fri, 21 Mar 2025 10:03:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDD00280001; Fri, 21 Mar 2025 10:03:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA620280005; Fri, 21 Mar 2025 10:03:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BA6D5280001 for ; Fri, 21 Mar 2025 10:03:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 53135142366 for ; Fri, 21 Mar 2025 14:03:34 +0000 (UTC) X-FDA: 83245725948.03.027C0F0 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf04.hostedemail.com (Postfix) with ESMTP id 740C54001C for ; Fri, 21 Mar 2025 14:03:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=R2Dx6yhT; dmarc=none; spf=pass (imf04.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.44 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742565812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uh0IrT1w8SpjDCYcv9mtaMhDrGwZvUvL6QFs1cEwHMU=; b=UKkYlb2bcERVgDYaxagHJyLiK8KU8auQYt49pGek7yL4xFAXCdoG9onlMsAK60SsDWOCSB j1LZT8tZqYuPRvKiltfcY/83f0A9fU7Kfk2Dmh7L1QKMdOWIrSxpAKDKT3N0ck0ITgFn8a dFqEVkSWi7whfCJ0h2CkJpAWDQ4d1ac= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742565812; a=rsa-sha256; cv=none; b=LslCoP3qeONpViyK4dMu+2uOZBJvW4NOA0KJ5Qnm3zQgXyHag6MLbKZkXKWLrCCn6fBAlq Ia8fogwzpchv+Qw7EWxebxaELfzrNd6D9aeefQuncO6yn9sXfXVvDbIvoQVRnhRFJZ9JRY R1KHlhF6lA7ezTk46dmVcmq7uhtoLV8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=R2Dx6yhT; dmarc=none; spf=pass (imf04.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.44 as permitted sender) smtp.mailfrom=gourry@gourry.net Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6e8efefec89so17260296d6.3 for ; Fri, 21 Mar 2025 07:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1742565811; x=1743170611; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Uh0IrT1w8SpjDCYcv9mtaMhDrGwZvUvL6QFs1cEwHMU=; b=R2Dx6yhTqqZkFl7CjTaknxIMVYD77z+SOjGpnLeDcEBm21f/lJcViJ+R68fBwwS9Yi 9k+oDSw+D87v/sbt81hvU8sqOiJOVB7T8sdGW9si0p343BU4hX7hzwG+Tb28nZI1p8a1 7IvAnADuQYlLzp9Ygtt3ZIbzwoFP5FJdG+R/OU97k5z9MiWuIVIA2hGpuhE62oVbNvim fW00tMmUuuit+lNpWWK9q4aGvSqKgZJZPZ+pepNuMBoNAaoxL8IQrMKFP77wwWAy/o/2 mPgbxdVtgmk9byMd1tNA3ISnrD/BV54fo1znqw4YdnCzfuXs8ergQ1T5ffzzrNnoGP4z K/TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742565811; x=1743170611; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Uh0IrT1w8SpjDCYcv9mtaMhDrGwZvUvL6QFs1cEwHMU=; b=SQvrX2exFVPShPUSiRW38UqJpsOW8rzFOUTGuBJ3Cf7FD/nARKAI6P2BumOB3XgO7t v7PPe/vT10H9Qbv6aKZ1Kc2VO4WGI4pwx4q1xnmjFCoOOe9pHfJJy2fMtvul3/yUpu8p oykG7Dgnnug3isIpylP80Gob8KAYkcGjTXv384dviV2Y61m85UotNYjh1XsYXcpe67XQ 3aLovyDeoIz/kCKjw6BQ1fT3UR70cyS8WstOGtwAdPIXJX1iMDm9bICqgSUdbTSv3gwv NYOBZtNLC7g4JoUXBW7AvGWpo6VTdSi5o+u5MVNlIKfD6jpBrL/vzNn6ScjCvBKA9M3b 19kg== X-Forwarded-Encrypted: i=1; AJvYcCUESRZGIQ5q2rfRXjqnIduMj51VnTEmK5E/etYGSkH1IsSS6Ze2M0p5+2fHFWNk6n/53D9gGPfemA==@kvack.org X-Gm-Message-State: AOJu0YzU47v/aDc0ExoXspr4oTbtjMT9kW19iPWviPo/mIebfhO9zmb1 PgM6Y1Tk7Bw55YGsRU1XaJORDRckZh0jCyLWM3QWVszsqYB6ffhJrXArc2dSipw= X-Gm-Gg: ASbGnctrtDR+13qSVzGyJkhjZrSXYj6TypVvtcWGNYQynT8leIAOOv5CidQTn6WJaPY h8VJ/hrJG+Q28fvoZg++wbMiJsiRIvK2oY4XRJ9STg4v2nyLjw8HKsy+AZF8l1vkPbNXJqr9Kw0 aO2lYoUzJe5jzhrex4P5x6hBkuqfscklIFsSd9SY/n/AhHTiH29l+2c/XWQCPiwvvBsBF2X80Mf sVJOTfvBWH+AYH1hHQDgK/8/IFua6rrHRV1fCGIcZmeyupDMVeLgg7nbDy77fz3kU08pBBW+juS ckH4WUaTbuVh9aie139fgPOombQm2TnG/6yhRI7THsfmzd8BYXxzdTh4cUJC4qX3Qn8ITahwXXE P+sTcu9N1vaDi4cEweMdW8f5a88k= X-Google-Smtp-Source: AGHT+IEsR9SqinX2KEraGDeefNZOjnaeKRUcenWDJRbEfEjhwa6N5Cjx0RY1yuslTrclVtYFfhgnzA== X-Received: by 2002:a05:6214:b6d:b0:6e4:4164:8baa with SMTP id 6a1803df08f44-6eb3f27f5f3mr39953556d6.6.1742565811373; Fri, 21 Mar 2025 07:03:31 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eb3ef1f51esm11628666d6.26.2025.03.21.07.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 07:03:30 -0700 (PDT) Date: Fri, 21 Mar 2025 10:03:29 -0400 From: Gregory Price To: Rakie Kim Cc: Joshua Hahn , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v3 1/3] mm/mempolicy: Fix memory leaks in weighted interleave sysfs Message-ID: References: <20250320164532.1313581-1-joshua.hahnjy@gmail.com> <20250321043729.939-1-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250321043729.939-1-rakie.kim@sk.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 740C54001C X-Stat-Signature: ymfigiqg35bp1wrdz8bj4errsnjzb5pu X-Rspam-User: X-HE-Tag: 1742565812-931740 X-HE-Meta: U2FsdGVkX19jymjz4EsNnJfU3sq8ljb32eCYq24nLwYPhST6v9VUCktTsatK4jIZsTJI5R+uKp67ggD7Wy0/EBDFblq3p0zkh9/S73J3MqTOTZ06y0ynenQ9tQm1hxnwk06fGyXXsNIqCmEFsgHpwHfMrPGp/yQ63XRnCQgeRTsut64xUro0T+alad6qt3BQAR6Cr/JBegS2z/3Ou0EApRywzsPGFaze52lTn/8k+HGrbu0b7Nq+/VJ9br079C1c2dWLJKT5FFilRuPHSMizUwEIPNVkUtaUXPXT2XthbwE0GEqwXIt5s+nrhXOHwJ4xAT2hBu+Qe65DYol+GevYMmLQLEnWUrIo23v32iLmrL9ews6BuY//4Y9fCL3H1yDimtIMB83n/VP4STmln4yxwnhEC4t/0XjLuFNsd5+fw23Sq1xG7ui6+j+gOQZytGMnS/5RSWxpMIZCINW5bMaQL/1nf0DLQp8LvTVMnumkK+JaUiNKQK3dsb+OeFZMNubhU9FdctI2jt+lfZZUhTqQC7AEHAEIoXKVNawolpLnWkAzlnqrEjB+Mfm3lH4v8p0x7ZkU6qepHW5s+R5Yz6xCdIx0bZJ3BBcxxI04eRlEODwYQyj3vsXmztVUtqxQxg0//qBna42W1X7SlbqsuUlF+RgdBQ9MskVSg07aqUq0NC7Pga9fjuJddRId4WhHu7eJjCJSs3VCkMKZaOluBjrgmSQOIZOrgseLfAXz1hI17/UFreAPgBTIckLnqJQtrzFqafs1jWA+dbkzQYN9S/TS2xpxzjCzMtPCf+rUBURB4tEsC4RlZZXmkB1txfx0+td+sgXtvTk+I/KDkGei5NIl1P3zVkWX83MU0X0sFLe7VMrZKvdMHbxFRdMhhp+XqfM+yOexbKMsJXHoG+OLY4Jm2LO328Fc54zx6cgXmZZmACn9n+uskqSzL/Kfq/n9iaBFVuXbP6zxcNtkkSLvzOH 31rvfScK fpQ+aQB8Xwm8KJqobV1FoqXTt/iE1FJSxQlC0284+FqbKd7sIJTR07Qdv/m/qs0KmITIEuo7lmLTXEI0so05GKBCVWQUsLS9+gsSjh6ib3kG20h3Z/9cy5QVMKLE77rDLd0T+4EKOs+sJ43Sx+FS7x00Tf0Pt87eUsgNRESbeInSgjWZZZPz2b0ckER3ojtTS0zUP+Fp6YfLiA49B5y/JXFXsoN/KuZ201I+YXOG7ALIlKI2S6WhO3liOPtBXry11YswkiyOdXoCevvcR6tQ6uOMd2aPWWZi02PZtrxeIzBmSsYYWY01mw2IYAlWhpsgRHojDuGGIwDdwT0JT+gbwamDFfPxTsfqtrl0hjtxAp71TcQ38jbeGV2dALHa+tSMKmPLTqzAl85NUUt60MCGH7sVYAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 21, 2025 at 01:37:22PM +0900, Rakie Kim wrote: > As you mentioned, I agree that Patch 1 may be a bit unclear. > In fact, Patch 1 and Patch 2 share similar goals, and in my view, > they only provide complete functionality when applied together. > > Initially, I thought that Patch 1 was the fix for the original issue and > considered it the candidate for a backport. > However, upon further reflection, I believe that all changes in Patch 1 > through Patch 3 are necessary to fully address the underlying problem. > Patch 1 does address the immediate issue of calling kfree instead of the appropriate put() routine, so it is fine to keep this separate. > Therefore, I now think it makes more sense to merge Patch 1 and Patch 2 > into a single patch, then renumber the current Patch 3 as Patch 2, > and treat the entire set as a proper -stable backport candidate. > The set adds functionality and changes the original behavior of the interface - I'm not clear on the rules on backports in this way. Would need input from another maintainer on that. Either way, I would keep it separate for now in case just the first patch is desired for backport. Maintainers can always pick up the set if that's desired. (It also makes these changes easier to review) ~Gregory