From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552F3C36000 for ; Fri, 21 Mar 2025 13:59:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70254280004; Fri, 21 Mar 2025 09:59:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B1FC280001; Fri, 21 Mar 2025 09:59:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55368280004; Fri, 21 Mar 2025 09:59:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 37A52280001 for ; Fri, 21 Mar 2025 09:59:49 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 626371A240C for ; Fri, 21 Mar 2025 13:59:50 +0000 (UTC) X-FDA: 83245716540.07.E9AE361 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf30.hostedemail.com (Postfix) with ESMTP id 7F03380004 for ; Fri, 21 Mar 2025 13:59:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="h8/mho8B"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.176 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742565588; a=rsa-sha256; cv=none; b=b8RuYqBBTlUQeQmTxZgP/jFf/GYh0/DQBeleNTnShowoFMDcR+FxZjpPhwZrXixa9u/HmK auHawLOmQfBerDII9szcg5OJ6Vmww4OCp3+IJbelQxtXv9PM/cTs0gyNvD07pR25lpkSQv eLO0BH3yjyP0Qf/RUHDbUkiz/6yNV28= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="h8/mho8B"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.176 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742565588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+9dAeMLXO1UL2jebDZiJp6MgSYhpvl7GGhlGkzkHYBE=; b=FD58Va1Y2cWWXjKcSU6C7Dk6klKRFeYUqfy1nf+zYZTevPYyXv9gLxrAFPXhiuAq+LRz82 IC68eQZiKb7yxJlGKrR+aaamJjIMByRC+HGcVJZ7oQB9qEcBo2kxFcLocPoANk7A5FSMa7 /se1kglcSTQthOxYdijATRaI5zhIpvo= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-47692b9d059so27207231cf.3 for ; Fri, 21 Mar 2025 06:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1742565587; x=1743170387; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+9dAeMLXO1UL2jebDZiJp6MgSYhpvl7GGhlGkzkHYBE=; b=h8/mho8BmINZ2eVXPJaHvoLekGlAWv7PD+FKAdxcnYAwd1oTlSf40CZKHoU/Bh8DzQ 8ECrAmKho1C+zqnoX65CRMrOnl7nakCzTu5CtS1fmtoTZw5jn3keT2OPARGZhiy/7gy3 fB0YgfZ1VP3jJAauI727q3l4UFd3kxHb84d16IQnMBowsCzdhG8f9eJsZkFWMFMAbjdU nAfZNk6HKixKg5CAcVsMWsO6j8tcCA9+CSsIqYkeSG7icPtsZno9FhH66UKu7m2Mal3O 4LhbPaGh4CmWBa9AXn6wBzKvbzkvbv7CXKkyDcyaq+KdojQFGBNhqZXxLOhMmZi9Xt7z 1tAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742565587; x=1743170387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+9dAeMLXO1UL2jebDZiJp6MgSYhpvl7GGhlGkzkHYBE=; b=kurR1Ac4cxond4nXFwK/H8VKT6wixmscPNghwZysT0i5CjQ2qWJlSNjhKu2MD/WMTH yveYhvnte/yMhRabjrpTDRiobHQo4bsNndY/KgEOJNceibbVUR5gM72OXL1PtzdwLjRl zbeftEy/on9LREkp0kU59PIku8SqX72mQFP+PJTiWV2NFPUilm2HP4SYPC7uiWCE5d9q HF+I4JFrfEiNvJmJF/D/5v5JgWsNQ3CODM17/v6qu2BxRKp6CJP0zAHkFRfY1yGIGYp0 8UqUaxGh5iQIupAJM/EaT+TzLNFkcf1yn5QMz6wZ9q6wAHjhvSrupbpUQfe1RqR44c8Q 7Oqg== X-Forwarded-Encrypted: i=1; AJvYcCUM6pXx3he590+D0pX2+3es6HjK1mTBjCapOlLqSM7lrtGf1Vb//1/Ayi4xJ869gMPMkRjl03Wa8A==@kvack.org X-Gm-Message-State: AOJu0YxbuiJLMDeCX6yCARSfTGS5+xDWNzTf4MfnbSR5V6eBjLbrVO5l RokHm/nU6I2bjt41GCTsSGobPSbZXBaN/IkB4Pv0ktdy6fpCYLDngspBfuOVy20= X-Gm-Gg: ASbGncvk5YiOZevg+oUbHUQcVFBFyOVQmLw96z1ou9WzFMXgfEVGG8RO8XLtPhnEmQK lj8lwXgZOFNGGVZ2ajknja/1hdCVoQNcoXKfTbOXXZFdbLFe5oBx+85upes6HplEutlXkf742OR jWNMSXDFifg/xmFvnlmClz6QxnCu80/lAhKqrGFXoTQx95z3sm8rCnRFua/gfTJitz/KHlm3ouS 41uF7m/yHZPhKbiACInyLTADP2fj3lYI6yFqTEewcE1kQjDKWlqOMZXB8AIJc2KoqHoLONcaXJd C7Tt+Q7wZxIMefUhg2nYn/g4hEosviEp6O3UjVUyPU6G43pY7JLmpWKFcAL6WqgriwUWEHylSd1 QxfdK+KGTw+qP8K+yiKSJjAtSE1s= X-Google-Smtp-Source: AGHT+IE40rw76FodwmzMUd5ZJ5Utk+psc3XwsJk0EM0cBH/ak9gdBIcEuV42/YBp1/X9s3GgwHKeSQ== X-Received: by 2002:a05:622a:1148:b0:476:b783:aae8 with SMTP id d75a77b69052e-4771ddc9124mr46926961cf.26.1742565587375; Fri, 21 Mar 2025 06:59:47 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4771d18f7d4sm12292181cf.37.2025.03.21.06.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 06:59:46 -0700 (PDT) Date: Fri, 21 Mar 2025 09:59:44 -0400 From: Gregory Price To: Rakie Kim Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v3 1/3] mm/mempolicy: Fix memory leaks in weighted interleave sysfs Message-ID: References: <20250320041749.881-1-rakie.kim@sk.com> <20250320041749.881-2-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250320041749.881-2-rakie.kim@sk.com> X-Rspamd-Queue-Id: 7F03380004 X-Stat-Signature: c7454c9pichggnzhz6stjtasephu7ogk X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1742565588-130285 X-HE-Meta: U2FsdGVkX1/Z62vn51O9FuNMLEGKii1orcmDYF+fU5ONwp1VRMpagOw0S1w3gY6Qo72KJnieoZqDAJDAO4NBInRzvY2dz+SgFHSFwudcDAX6NvNe6G032mOw0LZs1ZybwDaTDvdXsH6o1/4aGUno+H10C8OZlWn4JaZ6W5xfkzQO0gPUw6CWfdsITnHK3bSsDbDbtkUn1ywxwWqhT1GOPxWCQgGz1Q1JL/HMdJ9+joGPhKvA9DxLHuZvMNUK+P3RziGg/JBLDNBmQ+M8hb8MhGDhGpxDJfcLWEt11fU3ZjTCNb8wAmdju+tQ3KrqIe4W3I6h0eRhNCd/MucoGV2Jwf/XU7QjLzZy/rWPmoqP8fdqf/0VU4DEeedjeFfR3enJftJatKzKN+VfpMjvABZRLOg/+xUY6HLsem5+WMWkhY9HWvgEvzM4WdpHk2U16GyernfvcdzKD/QPsI4nVPR+FmvEIzawm+Iii3Zb1pWGm5ip7t6PdVOhOLbYPZDJpiL/M7tokiCHzd/95I/XOmQzazpwE4Oo7GmnN5cAttY88o+uA7kD/X2zsLP2D18X2PdNEahRzBbYD5TSzXuMXpJj16nhuaXLQrfZpFnYjsodfcQUT+IswVFPZF1rDOt06PkCaRUVnEECxd3THJYFEaLVglwSoig6miCclIWLv2BDSU9X+CungM00YtqlqHk/6QQStWGXNqM7QgDmCL6uDStyQWE+lwB+CcRbEnlhNYyoV6P1IK9UgTeGqu7EF/Ndnx5DRQJJY21THNzYqpEtB9tQTT/Ucv8K3wxLMuUyZ3fEH3CxqseBp3/EFUvivnQeLG2kRNG+Nm9A0qrG6eXMOQ4IIPxzX6xLWvzLZDU+KjF5b0GGcH5ubJuf401alds+LIa7Jbbx05b7OdB3kNxaqJGA3svBjgt6RKxEw815YYPNxSjWnbABuDDWIG0JcbPxx9Vbb7Nngf+FjhlJF6NJto1 cl8LLH2j 0FkJE3SpJxPdzTi+oc8pifDO6JqoYzAR/7SZidpoLGPAbQtc6M3cKFaviLiy1IPI0lS1U27ICoce8v2oywxwjGQ2Rg0HyIjVjGp3VyHF2SAYbt8gmgvEDq5KSKyqKF7iiWcVnVjywkVtZ6dq6UCR7oMeciwz3x5pXlVtT4jU+e50EN1PwV9+5Me1fUtxk/2ezPzWxci43HDkN6mnQjvNJiDJHFOYGe39/peRNTF/IbosbgIjXjivlewMrsc3Zj3P6onj7ZGQUii2Jdyo2UsZfm/GFkQ8SOYLo7pimZcuGXp8GA8t0mWM27ycNdiuGVwo998DFD6Ub6O5saaRRD9Vpa6JsYNNVgYbMvf+vE1IiwsmMQ/IfzCbbgONwO6XFzJ0v5itT33n4W6kiklJRzqZJC5Utyz7+L2k55VAyhuvXdhghca7I7ZSOr6qJkTCM+WpBbRunznz2PQSBQ0rDwyjkUFEw/QtaGvF1WXsqXDO1Hbhwo93f0cogcCpDrtrirt1sF90Cm+FjX3gJ7fo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 20, 2025 at 01:17:46PM +0900, Rakie Kim wrote: > Memory leaks occurred when removing sysfs attributes for weighted > interleave. Improper kobject deallocation led to unreleased memory > when initialization failed or when nodes were removed. > > This patch resolves the issue by replacing unnecessary `kfree()` > calls with `kobject_put()`, ensuring proper cleanup and preventing > memory leaks. > > By correctly using `kobject_put()`, the release function now > properly deallocates memory without causing resource leaks, > thereby improving system stability. > > Fixes: dce41f5ae253 ("mm/mempolicy: implement the sysfs-based weighted_interleave interface") > Signed-off-by: Rakie Kim Reviewed-by: Gregory Price