From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D8E3C282EC for ; Sat, 8 Mar 2025 06:44:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E73B76B0082; Sat, 8 Mar 2025 01:44:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E22C46B0083; Sat, 8 Mar 2025 01:44:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC3CA6B0085; Sat, 8 Mar 2025 01:44:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AF1886B0082 for ; Sat, 8 Mar 2025 01:44:00 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D3CB6C15D9 for ; Sat, 8 Mar 2025 06:44:00 +0000 (UTC) X-FDA: 83197443840.25.67BE5C0 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf01.hostedemail.com (Postfix) with ESMTP id D545840004 for ; Sat, 8 Mar 2025 06:43:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=NxoL7LQp; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf01.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741416239; a=rsa-sha256; cv=none; b=04H/fGMiIXQifK+BSXRk6Fj8WzjApdLvaVrcCg9CtSreYDq18FBYrDlScTHPIbXCJGZhSA G0Kge3z81kP2PoVsHwbbdStXt2LWP1tTOnbYT/52WA9p8XOO829l/1wooeQJ2t5HPyxJ7z Bl4BoGDUhak92RfDLUJm6JkgaITvi2k= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=NxoL7LQp; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf01.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741416239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L7XYd6bILvV5S9oc7kfROdvIGE+piMUFy2TT1wDFAAs=; b=qt32aPWXtta/DmDp7zzIMPX+bFiufTbnrEcfdt/2phfwRiu8mFyrsgx0CZL7SD1dsGrvMV D99bZu6dWcq1vM6MTVwWjykcQEv3XGzRT2TAhxzUtQKqdr7Z7I/1ZbNEdXCHA9AyYBwVLX mxiVCrbF+sfEs++sCRu9ZsChZoM5UqI= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2243803b776so23879415ad.0 for ; Fri, 07 Mar 2025 22:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1741416237; x=1742021037; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=L7XYd6bILvV5S9oc7kfROdvIGE+piMUFy2TT1wDFAAs=; b=NxoL7LQpyjDqavnDgiY9KawrpZWlfEi9wellkQK3HhujQjpbJ4xPI41a11vOIXL/u5 SrzGzUl+H0Ich+BDpM04KadlUuSpZGB1sUnGaYWQAjjWByhuiZj+3Gxq0j2qb6EIh6SZ /chmWt30D/VxcQVWQUYTLlIAD4/S5+hTBttNqYcwqH5acVhIzhAFfkywDOYH50p8Y0zx R//h7v4Pm+fNQ6ugtXRXrXQGeK7zWRYXyy9pyHS8yw/W4KxBigioRGOheS1MZrHIyNAw Eqaf0DbPPq4TJuv20OSr9jjQL9PmR1nxMslSjb/BtFb+wRSCLTt0hAw2t6t9m6gvn3AK 82Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741416237; x=1742021037; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L7XYd6bILvV5S9oc7kfROdvIGE+piMUFy2TT1wDFAAs=; b=sqGfgyfQq4XvqtYQwItz7xCz0x632OqViHCva0QLzmiQBopRmOBzQ4awzrnt7eNGxi EfB0f3DmaGcjYyiVsFUOkmM/r6GYHawiFz+6Xb5ztLD/iMyAPplpr2YIxVTNx2b4iT7z tt0OTAUPHykfgguNqH6MgDJIaAnrv9UcNLqlHUf6H5LxA6ZkrjcIi0375tJ+sOquFTYz OS/nyUb8isaAtM7zmMhjE//WF7WwGql2E21ekEo8+BV3UoIudoqu/zkltHAJqx8/VQKs 4iNKnSCjziULukjKeMD/XvEx9VGbJ66Gpeix++J9KSGMLc6wulMeusYX8fTd1RliIxFj JdAg== X-Forwarded-Encrypted: i=1; AJvYcCXnps/SYA4ftRqXvIcbKC/XWm+wymrHrpQMw7QohdkWbub2FT8d939wnWuZVvuk/+v1JZtu/oJqEw==@kvack.org X-Gm-Message-State: AOJu0Yz5XWP8w/XS0430vS57x07TdfD43oGDrR/JDigfsEsDgR/sDjfR tnDBCXwHfDdS0sNalTFvhoEzvlOyXXWhe+dfVqo6TRh67UJD5v5VSk+N7ddgBe0= X-Gm-Gg: ASbGncvNHUhkfhcpYieSq6fRpUWtPPD7G39WVthOyUhnXIWqbApcdMwZvEIoEosv/nl S9By/dVxlDTy0uWpCJXY1hIy595MoVBghuc5vNd5PvfU5I+eZlW/YkG2PYkpgIxb05GLG4BSEjX p+2jePffGH8ryfykUpILfW5x1ir/MSOaO6kHgoU4j88Ap03LovjQaQ3ctVs9nJpdRpNKrLRRdIc 1+eQ+V4onkMvADvQf5LPVV5q9l4v5GRLHh7+/6ggy6dphAj5bg1QEM9U2nlGjD/7YqknsgQnoSK 1h0Ghkq5T3qRWe0QPRxyy5OOliPVoVAQHVcnt8WMfFMPqWB9AELthHz38mXTvVUwTpqHS33W47a li9CkFn/gZiQVWEm/ODJN X-Google-Smtp-Source: AGHT+IF/hoytkHf/78nzK/gEIzqXnGG5MP6Y8FgGhVp8Zx6LE+l7N0K13IdyKh5Omm9Q6AhxhqYyLg== X-Received: by 2002:a17:903:98b:b0:223:397f:46be with SMTP id d9443c01a7336-22428ad4a09mr106979815ad.47.1741416237682; Fri, 07 Mar 2025 22:43:57 -0800 (PST) Received: from dread.disaster.area (pa49-186-89-135.pa.vic.optusnet.com.au. [49.186.89.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-224109e816csm40661065ad.54.2025.03.07.22.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 22:43:57 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1tqnuc-0000000ALct-08Dn; Sat, 08 Mar 2025 17:43:54 +1100 Date: Sat, 8 Mar 2025 17:43:53 +1100 From: Dave Chinner To: Yunsheng Lin Cc: Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Carlos Maiolino , "Darrick J. Wong" , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Luiz Capitulino , Mel Gorman , kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements Message-ID: References: <20250228094424.757465-1-linyunsheng@huawei.com> <91fcdfca-3e7b-417c-ab26-7d5e37853431@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91fcdfca-3e7b-417c-ab26-7d5e37853431@huawei.com> X-Rspamd-Queue-Id: D545840004 X-Rspamd-Server: rspam11 X-Stat-Signature: a64e5rmuhwh8mee7bb1ewea8szg4jyot X-Rspam-User: X-HE-Tag: 1741416238-898587 X-HE-Meta: U2FsdGVkX1/I76gtkBlosYV80mIoH1Wv5K7/OoCx3emro3lxIdmljbrKnoIGmbUjFRazkz6X+wLA76TnEQv2Fe4lUYzUyWXaTXng8+poGKoDFYqayKR59AfyB28nqqT593JDiY3syo1pV1BZwlclsAl7VLeeXhaIO9SfhgMYlTAN3/Y9A0reKv0eBDbPrCTDd9Hc4dOWlazcNxPmld+ruynumpERDtPEI8bAH3YPDCOyh5mboKy6Sr6emp290Er8UPANsPhkmZdHMxJpW41+sEd6iOjka58F6CxFY71cJE/TRcuJr4PASU7+7cKKs+Af1aCBAsWl4lhbtsGhDG1+3iai6gDPaXQlLSdv7CsA75AXxyhFULRBSfEijkORKQU3EotelXSaJEsCb8uQSJZ4G04uq/TY1shRQiJTOYHjA8Vg66gH8uuDTKfDhSsoLkuuKdcFX6DcHxvN4vxRP9RNjkGSMZ/fhc+rX3+r6ulfyhlmVr1+UgKX9HMiyjftloZHhaV9AhLtN/J67L0GjY84XltfUFiaPtXiZJbdIy8qoQV4a2YPVKZYvj8pGkSTK/p5OfkzCd8BCiO9PUeE8KVPqj4rt6uti0idw0vtDjyVkb+ax+gFJssDiSWyvmSRIXE8hxO92Jm77/JuigpIMECLVzCpZsShHl+FaMcP7khM1KJ+kEkRSYNEYuHiedB0gZzvQXi4ZHBv3Kb4E/uAAPV3VZdZ+MZ7pXCy4GNGzphbAAY0GnhsvXoA6vxLLAZJwG2TdNh2c0jSfbS2sVsAPR/lQZ80PqDrIjnuj405wTRwGnxmaRseoM3A1MkVqeLamarp+tSySHB6ifJmUH3jO4jz6176fT58nOuRmK2n+E/N0s1MFUuD9AcwW+HSdsR4sw9GuUt473B3ponAIrVTjwVJryQpuXJ1nZ4+bGcOc6jRZ+Fwfe+amxIhLMRtsyI+E0LWcoyz5enUBZhSzxwhBaq kqdrqpZw nRHw+oQEVziaRruqrg5/RvoD43fbllJmCKCW9eJ42PV8j4MWDlodqAkVq2Hewo81vH6FOsB/M0ZIJS6DvJkBAooVh5FtviJvi0s63NgdKDTSOfyGvC66irptitazRb3fKIXcH0yM2FbvLWpNX5NmpyO5divAFCCRB1t98Ci2Kc+BV75zBvAhx3j6FMB6E0NFhh90ihYvwJJl7jczPuWVhm7hjjb4c0sOaM0TuQZDHOhLInHGTBj4V9driToBCQqqhinR5AVuXv4bjUd5nAO3oRGT0q8fH3FC1c2xJcL1UZn67EZ1p0mkE8HC42EQGwVQLjXOGteLT3Uz/RsGKT7GfPW60BhDA4XB7dlhPizc8yMlpOQEmQpg35xZTrEOyLLaErykXxi8A3e5GgMBWABLp3WVwYMaZqtZgQBOmOj4UQ/9SB5m0W2nRjMonYfwOHnQjzJ0BTnGntRbqkb4PQmF7tzE+BWhvUWT3YJJzNdsjt11eTw0cwTc5heAKkv0F9JBHljve/K9yUvC1+EUI1it3agrQDdJa7JU9cWWF7i0H9RD1iCkH4gGcjSfnXAhzRQej2AL7XpdRh3wSFumoWIKUp5XabStoG5QsDDMU2XstYAnUJxQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 08:09:35PM +0800, Yunsheng Lin wrote: > On 2025/3/4 16:18, Dave Chinner wrote: > > ... > > > > >> > >> 1. https://lore.kernel.org/all/bd8c2f5c-464d-44ab-b607-390a87ea4cd5@huawei.com/ > >> 2. https://lore.kernel.org/all/20250212092552.1779679-1-linyunsheng@huawei.com/ > >> CC: Jesper Dangaard Brouer > >> CC: Luiz Capitulino > >> CC: Mel Gorman > >> CC: Dave Chinner > >> CC: Chuck Lever > >> Signed-off-by: Yunsheng Lin > >> Acked-by: Jeff Layton > >> --- > >> V2: > >> 1. Drop RFC tag and rebased on latest linux-next. > >> 2. Fix a compile error for xfs. > > > > And you still haven't tested the code changes to XFS, because > > this patch is also broken. > > I tested XFS using the below cmd and testcase, testing seems > to be working fine, or am I missing something obvious here > as I am not realy familiar with fs subsystem yet: That's hardly what I'd call a test. It barely touches the filesystem at all, and it is not exercising memory allocation failure paths at all. Go look up fstests and use that to test the filesystem changes you are making. You can use that to test btrfs and NFS, too. -Dave. -- Dave Chinner david@fromorbit.com