From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95920C282DE for ; Sat, 8 Mar 2025 02:35:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D95E6B0085; Fri, 7 Mar 2025 21:35:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 989F16B0088; Fri, 7 Mar 2025 21:35:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 851CC6B0089; Fri, 7 Mar 2025 21:35:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 681236B0085 for ; Fri, 7 Mar 2025 21:35:52 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8D9CA121313 for ; Sat, 8 Mar 2025 02:35:52 +0000 (UTC) X-FDA: 83196818544.03.A7DA7A0 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf20.hostedemail.com (Postfix) with ESMTP id 7DF621C0009 for ; Sat, 8 Mar 2025 02:35:49 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aBi4Ney6; spf=pass (imf20.hostedemail.com: domain of alison.schofield@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=alison.schofield@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741401350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=79GNqSWOUI0U4kcyT7k6sMp10O5q5QpQwfI0jPGdDjY=; b=qQxztlzvGZ9p22BEJ8/hQcFU+CwIld0hCIBzEFxGQoV4f65n4qtYiMUpi/FKL6huxo4Yxk ffDJS9MbAO9Yzow5nSsC1NZEem08SZ8+2geNLK41RShePK+sN6dl2AwyDBewHSOmFPjDcP BnJVMYRPeyfSe7NoKkFu9vCp+ErJzLI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aBi4Ney6; spf=pass (imf20.hostedemail.com: domain of alison.schofield@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=alison.schofield@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741401350; a=rsa-sha256; cv=none; b=zs0hRZYQAjd8WerkHssiAS3R5i97cuCh0husZDViKo7T2h+IxkL1Sot7pbzp2wN7kyb7BH QEDH87+Oqo8PFvojklETUi49sFZo2YRTwwT/395rSnxibj9gHItpc5vyDscq037u/8u5il V1DIKQuv7JeYgWXl/IWkOv5y4KUHHNE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741401349; x=1772937349; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MhauIabnB7If6c1T4+kj4R3KybC9TZDd7Mdqu6pz4jE=; b=aBi4Ney60sebP2wr7BZxWvjlinHEkY9LUYtif4HOG9rrMVHf13upNDr4 +HTLbf3y0IoAldzpLOw0gstNsRd2bu4xD59k+2Q2lS4oatApRBnImyJbL mBzHc+1CZXmyOvVgzzm1n48VpCrrIJrbG0Tv37kYAtFaOGr+fwYkaS6YP 3iBUkRUeeoY9KVw+fBCAvidohgfMLDdmICbVhS5saCJgLOjofAuWGVT7K /uD87E9AEWVUsO2gx0Fdd3OG6C05sKbzlRmvv9ZUDxruK0qKCnCn5B//3 L/rqZMJTVcfqjeGlJXpydkTWBfNvyNV+4FScQvKzfvIbBq3eNvCB4fkjE Q==; X-CSE-ConnectionGUID: c8lZJkU3Qja5kDM5RymIEw== X-CSE-MsgGUID: Z0VrzIfXS3ePMTnYZyqOZw== X-IronPort-AV: E=McAfee;i="6700,10204,11366"; a="42377813" X-IronPort-AV: E=Sophos;i="6.14,231,1736841600"; d="scan'208";a="42377813" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2025 18:35:47 -0800 X-CSE-ConnectionGUID: mUfabHK+Ti+imaNYgWhdlA== X-CSE-MsgGUID: W3A3JNBlRQOWWIHN5QUNzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,231,1736841600"; d="scan'208";a="119475451" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2.lan) ([10.125.110.159]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2025 18:35:45 -0800 Date: Fri, 7 Mar 2025 18:35:43 -0800 From: Alison Schofield To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH 8/8] cxl/memfeature: Add CXL memory device memory sparing control feature Message-ID: References: <20250227223816.2036-1-shiju.jose@huawei.com> <20250227223816.2036-9-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250227223816.2036-9-shiju.jose@huawei.com> X-Rspam-User: X-Rspamd-Queue-Id: 7DF621C0009 X-Rspamd-Server: rspam03 X-Stat-Signature: t6yg4zrtjhux7a16q5qdfbmz7bswyhsk X-HE-Tag: 1741401349-22158 X-HE-Meta: U2FsdGVkX1+Nqe6PCU+IaDwwuXJkzeLCtX7SmYejxl0FgiiTFFVJwLmgaEShMgdluYAqMDsYVegHfAbauwk5tROIEkm2Aod+WHgThvizZGPzgytaxtyfaQ4ehjYuHrwceh/sE73FBmbVLZ0LTthRz7FGYYVdk60DcOuxV6sPoT/P+29nX6k6feQWYot0v86wUbzsvB+OXFEkHo/G9ImFltEXDI0SR5Oso92BQDBGbv1c9dRP6yWrPE0KxRiGXPIp8T2GQOz3tltMwDfYrLc5/3htIeMcQCeLxpQ4C+HKtYW2v9TSN2NcM0kLeb3uJN+grjpNX5u/h//YY+rQNGzejJtYXkGhHn2gXgeZnrJ0UiY5aaMeNcqzqPxuqbXVC+BfFqYWGTJFsB6J2wG+eYHFvbPnwaG5zMesvAMByfSwvp2pFDYmohrd+FdqGiuU5RUm4XUhnwf/u4RbFrMNyoK9rHU8/QzXtBkXgQYeJ2DQj9fNasL4Jrqc0STFucdrk4M0ldjDPKIT3Liam6qe3+JZ9noZvaL74gCdpqEt+mLyB7UcrM+u0a7J2p9VFY6jshBBN3lCR3Gk88HP+K4Vbx78vfDjZzN3joaOb6uSaPKplEUMiMvCA5T1t1vehFOPSFcT0uIQVN3mXV1xii6HC578ONyJ7mLXKJY6c3MxSccPAhNWSyLMHOYfl5MX8NrQ+ilHxCm2TJ9CnLFZkWVC0lMmCqeAkZtnFONyA1askDzn546y/X3H+j3kXtem+ffmmwQdACWMZHwYvLIFgyzng1zpWdGCuSGM7sDRGb36htOfWpS7tJIVIEXep6ze4BWac4P5+Pe1dSE2bzNJnWa75FpIb1RCAVPnNOT/D0PuXVLzzLGyADPsNFHJOGqVp8ZaK3mhEbpWZsD+lbxrkZRUHF0wWwJpITEkpiX+SUsfebBs1P6D5J62dOC7DwMJbiSpcQ/9wcXjPbccm61dktYor6H kY0k2IP7 Z670z+ojlZ8CqFd0+jVGTU8M/KJDoBeMKy5SqHeLSmf48V8+uS1T/fXg+eM8FTbh8uP0sbxP/mJanHF3bkE1gAQCeSDgolXOEVMxbGxFifIckvnYlauKhgswAQziuorrBLRXUOP+cDP7RfAbm2F2PrmcNoRSWWCm92N3l/hGsyg3UT8lSWq/uyp/8y6S9ap8ffKKM0fX4oC+iwnuse4nP+0E5VBQIj1xHOC/MU+37PVhvYJMJLcXhU2gT4t2x3ePwS3OH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 10:38:15PM +0000, shiju.jose@huawei.com wrote: > From: Shiju Jose snip > > diff --git a/drivers/cxl/core/memfeatures.c b/drivers/cxl/core/memfeatures.c > index 8d5a57a0c154..14d3960504a2 100644 > --- a/drivers/cxl/core/memfeatures.c > +++ b/drivers/cxl/core/memfeatures.c Hi Shiju, This new file memfeatures.c would benefit from clang-format-ing, starting in the earlier patch that introduced it, and repeating through this last patch. (I got a lot of diffs when I ran clang-format.) -- Alison snip >