From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77555C282DE for ; Sat, 8 Mar 2025 01:48:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B172F6B0082; Fri, 7 Mar 2025 20:48:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA0646B0083; Fri, 7 Mar 2025 20:48:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 941B16B0085; Fri, 7 Mar 2025 20:48:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 760396B0082 for ; Fri, 7 Mar 2025 20:48:20 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AF84D161139 for ; Sat, 8 Mar 2025 01:48:21 +0000 (UTC) X-FDA: 83196698802.08.F5EC39E Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf21.hostedemail.com (Postfix) with ESMTP id 0F7801C0008 for ; Sat, 8 Mar 2025 01:48:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kgpIpd7e; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of alison.schofield@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=alison.schofield@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741398499; a=rsa-sha256; cv=none; b=LdiI1xEHH/qF9CUOWVSEzC9twZOisAxV3je7NRchPB9LQia2WZ6RtcubxF6vBTTuH3drsy N50DNBmBurNtQpIVvAD2upZH42EDitJtwesIb5pGg6Wn5hf+UtXjR6E8VOFIq6RIabHqP/ zGniz5BI9bd1F2tC9RsbCVnv+p5Q7nI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kgpIpd7e; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of alison.schofield@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=alison.schofield@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741398499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+b6JrEOOG3592Z4vGnzldlvh54HdZyQdAj/USnPENOY=; b=J82XuDnUEWikplwqFHLHbBgQYNeeOV2uGZhbmDOXfd5pFgl6aNA9bXTSIzqnC5BrhWxoWW H583lBNNpqwO/E3x8LrKU/6/WKmmWngNDzQaDYxbzjRHnh3iCPhr2cSLVT7LFr+PgyZwLD +vcfVCP9P9Unizi5/TQOie/DMRNWvBE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741398499; x=1772934499; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=33/GF+zRlq2xnIN/f2zSmMFCuYusedV0G5v+qkiM8iY=; b=kgpIpd7er7USc6IwaEeoyanWroQkmOD2V/suyq23rqvpP6S0EqTfRrz7 HLnr7GI24srMH8wX+d5ZU282k6zcxE6ou/tjyqsvpL/Z2dth0Bp+nVhyq C5G6GZ1VvsBSsKIpP88+kE6WuAJ9XKxi7acDUFw2qBNk6DEIgdKPBaLA0 tQaLuNMGmOs4SEn/82tVMGtk9418VxmQJ0uwrxPWrmI1j4sSwEuzbbcXS gP1eswsD3b0/BAXl4IEyBvuE7Klc0ooeODtn8EXtUeVY36QzP2OY66yWp urzVY/Lp2dxrbeXMBQMjhqLwq9E28yyEeIOdl9OKWbE9eyEoLRN+MIYH9 g==; X-CSE-ConnectionGUID: yOydQVuoQtC0NspcMIv4LA== X-CSE-MsgGUID: QL1rqmCzQ2as9vDM+Wi6LQ== X-IronPort-AV: E=McAfee;i="6700,10204,11366"; a="30037722" X-IronPort-AV: E=Sophos;i="6.14,230,1736841600"; d="scan'208";a="30037722" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2025 17:48:17 -0800 X-CSE-ConnectionGUID: o+MtEFLDSxy5hVpewTMf6w== X-CSE-MsgGUID: 1Zigs2F7RKmK0p2WooquOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,230,1736841600"; d="scan'208";a="119966640" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2.lan) ([10.125.110.159]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2025 17:48:15 -0800 Date: Fri, 7 Mar 2025 17:48:13 -0800 From: Alison Schofield To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH 3/8] cxl/memfeature: Add CXL memory device ECS control feature Message-ID: References: <20250227223816.2036-1-shiju.jose@huawei.com> <20250227223816.2036-4-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250227223816.2036-4-shiju.jose@huawei.com> X-Rspamd-Queue-Id: 0F7801C0008 X-Rspamd-Server: rspam11 X-Stat-Signature: btr6pmzemccwbdusrzphsprjp64w6ri6 X-Rspam-User: X-HE-Tag: 1741398498-990379 X-HE-Meta: U2FsdGVkX1+brPJrEHwpLgBtZP/0ug88uEUG4rDo1B7c94B8nZiWBRsqVRuBUmQm+jDXDuMqVJQkPvrWGIKYcBBgBRfabCVqMzm02/TVSTfKXQMMeReS6wZI+rrQDaZ7xy/VCKCLXXJpG04OaypFcQKuR4NLjcheCsgmMaBwMnIY8xYLLskSyppWE2huCFWT6jzrPKxhfrJc0qmGA8YmxU1Mj1bD5da3sNmNOnMnAF7xI0GYTbQ7BrbmQ5t0ksQqIKMfuwh+oGR8e6VdAGaYyHtgaWRmxDHeK5jjw4O482exuhbApYSNXvc7i8+pIBqIB3l5xLYhXQkWoigSiMsZA9xijckXVWwn2FG27Z+8EhkeO4juRoZbsIoYDFnHLVWLqDPEtNuQzdVY6nJLQHgftmUPeIT3VicLdbSvp/5mUhVKjINFCcUleGdWrbXYF23MeSaVQBbdRl0EMc6+0gZKyRs3FCRaKSrPe9Evv2xh2HsdbQ+Gj8tRtYxLPzrpyEMtaKwe+g91sOFYm3fHbb5Tqs3pRKvDAT3mmmurhsrP0hOdWdIgvkRE9IDV/1HUbzY3eaL2sjUNeC4ilMFaRfye8O/CSA8rmyZz2sKZntk3FfnUQMTiM4JeElcvZVXf48g5yig8ptWhbmfoNEw37v5mZ4MKpetZJoecMsUYrDne3+lC+5P+0VQTLJy3SUCqbxyHL7Y5y89NNYmvAZdlkyp2iDLUAjK4sCFzWB2ypL8euUcX0dqKApaIrP69xafxmChp96K/A4w3qtMORnbghb9VciuSi7lpBd+69Wjf9O1hgnIV2zveJde3Ab8gAH21ZcAwuWKD/EGhcEUcw76GnMwhG1iX33BLQxAHCvsLqMRmN9EBEXenIWhcmgmW2/S0wggvMpeOhLgmSK3TQYlOo2ULNqEDS0RgMddtHkI4Mv+zxg61d0ZamTYSTwKP0uPNOltgFr7uSbCFzm+GCfmB3sJ cKkorNQs 0m1ORMZ2on7rtyFtCPtQAtjxK5Ak9ld0IP2Fc514cWVX3VLe9FnF46opdu8MpNhy8UYfujwrr7qb4Jr1iquKdlSxJTkAlyBK1tYBVNnGcE6uG2QZuZbKPSklUU2A1vHdr5Xj3IMxQ87ia6SEuATjX3FWGhSu4nSfwefciToARRG7x8GoDUYE2SWCxwPJzfhwd88HzA+g/YIp3gAV7Hth+oZnn2XsUkX1JEEXpDlTXiSrLMjvp6ZyVoc7nTVqAoCxUFHNK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 10:38:10PM +0000, shiju.jose@huawei.com wrote: > From: Shiju Jose snip Next 2 macros have line continuation chars at 81 and 89. Please pull into column 80 or less. > > +#define CXL_ECS_GET_ATTR(attrib) \ > +static int cxl_ecs_get_##attrib(struct device *dev, void *drv_data, \ > + int fru_id, u32 *val) \ > +{ \ > + struct cxl_ecs_context *ctx = drv_data; \ > + struct cxl_ecs_params params; \ > + int ret; \ > + \ > + ret = cxl_mem_ecs_get_attrs(dev, ctx, fru_id, ¶ms); \ > + if (ret) \ > + return ret; \ > + \ > + *val = params.attrib; \ > + \ > + return 0; \ > +} > + > +CXL_ECS_GET_ATTR(log_entry_type) > +CXL_ECS_GET_ATTR(count_mode) > +CXL_ECS_GET_ATTR(threshold) > + > +#define CXL_ECS_SET_ATTR(attrib, param_type) \ > +static int cxl_ecs_set_##attrib(struct device *dev, void *drv_data, \ > + int fru_id, u32 val) \ > +{ \ > + struct cxl_ecs_context *ctx = drv_data; \ > + struct cxl_ecs_params params = { \ > + .attrib = val, \ > + }; \ > + \ > + return cxl_mem_ecs_set_attrs(dev, ctx, fru_id, ¶ms, (param_type)); \ > +} snip