From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E20C28B2F for ; Fri, 7 Mar 2025 22:01:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28FE66B007B; Fri, 7 Mar 2025 17:01:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 23E306B0083; Fri, 7 Mar 2025 17:01:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1079D6B0085; Fri, 7 Mar 2025 17:01:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E34C56B007B for ; Fri, 7 Mar 2025 17:01:17 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0EC371CA640 for ; Fri, 7 Mar 2025 22:01:20 +0000 (UTC) X-FDA: 83196126720.13.7A3CEDB Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf16.hostedemail.com (Postfix) with ESMTP id B2BB918000C for ; Fri, 7 Mar 2025 22:01:13 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=U1+0lpAH; spf=pass (imf16.hostedemail.com: domain of alison.schofield@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=alison.schofield@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741384874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kfCNAxeYcKjk8W9za4tnHi7gnXMY4e8S7dejpdSdXqs=; b=HtppHsZuRUkk4ou98DBehJdxftFtPLfKhdbfx7/AQospawbibMTXGIbAFBX1DLOs8LGfP9 +b9fK9hVB9Ms4syJZsJZzz60tGKqzBBNGB+R3Ixq4sJHCGswjTgX7MHvin45lOc+50glf7 ij0bDFwjpF9idL9wPmjUPh0ZozQUEhQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=U1+0lpAH; spf=pass (imf16.hostedemail.com: domain of alison.schofield@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=alison.schofield@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741384874; a=rsa-sha256; cv=none; b=zrqR4VbnAPigi42R9BGZqze51OLjWNzyoqV+l/8dkHligBcXcUO/LIFG6IEldO1oCSUMAL U993AoXiBM8xlmjiT1ko2NLZHfcAwX/pKKXMZHmlFeIB6M7Km6MCozHly10rsldT6Z8JPS i8sEFuUTZvWgKgfWYqJXjWZv9po2sFs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741384875; x=1772920875; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8wclTX/Gee3E13d5b9MYB3LesJcY5QD7R9wGeN/+huQ=; b=U1+0lpAHMFxqd5qbRYRT4QO/R90c6VHpvPF8wTazpA1Cnimb9btXZPoM 8LTFo4Ev+n1hU7ZlRL3K+w6HZJtNSCC03R0T/IskLjsuQDcw8xVxdCGHN doqsSYE9vOW9DsyMmsW67CpXUoxAwdrjTDeligCCwAaegv91NKZlJdJrW BmbbYrYePtEzVI+IATjtfO1UDj1ij3qUe0jfBYQEWfFeDfxRVwggnlks2 SZLt0oob3iwk/cT8lby2CGF5rRlRk3XzqD1F1yjJDBj97wcju4Z2+vxUG +fCW7soVYzQ7Zp0roJ65PaOJoYmUCiBWTUF2EcP/822kfAuhhoPUw0pAn w==; X-CSE-ConnectionGUID: t2MM38SVRfCC99uZgcPdiw== X-CSE-MsgGUID: 1LlgPkHOQYWsOaXl2NS4bQ== X-IronPort-AV: E=McAfee;i="6700,10204,11366"; a="52655625" X-IronPort-AV: E=Sophos;i="6.14,230,1736841600"; d="scan'208";a="52655625" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2025 14:01:13 -0800 X-CSE-ConnectionGUID: ZRS4FBdCTWWIJu+RcFO3fg== X-CSE-MsgGUID: f8UFgJ7fQtqNmQicF/Hn2A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="119959202" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2.lan) ([10.125.110.159]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2025 14:01:10 -0800 Date: Fri, 7 Mar 2025 14:01:08 -0800 From: Alison Schofield To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH 5/8] cxl/region: Add helper function to determine memory is online Message-ID: References: <20250227223816.2036-1-shiju.jose@huawei.com> <20250227223816.2036-6-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250227223816.2036-6-shiju.jose@huawei.com> X-Stat-Signature: 1wa3ndtgtisnokpzwbk57e77b6otmdgk X-Rspam-User: X-Rspamd-Queue-Id: B2BB918000C X-Rspamd-Server: rspam01 X-HE-Tag: 1741384873-45116 X-HE-Meta: U2FsdGVkX1+AV8PJTR/i4xw7jmusVyQYCaahSWpoaaFr0B/1QGGZ96EUkzwXQddwboXD+LNJ0Rs1Z7JhUFEhTw2TxibrN8gfxSjYJzD0DBmSgNGzOqPIWj7/KmMsJwrbH1buNPdm2NUKmVoS0zfAVvEP8YMTKI6NxNDLU6Sa7ExPPwGuLzEU4mTzDxV+GzApQLPu7W7HHz+adoHMTClt7MECSkv2L52BcFZ1kQw2OXYAtpMY8GgUyYEEzpg+6cwpMKiqAjIed+02HPJc1zXkuqQkb2GEFktYKSP3L81+w2q4BuXwZmE6hsvUuYkydBUEACMYSALcJA9QCoQ5JTQfvAaYyDpb3/X+ysuvdfTBBjI9vCLvQVjxYGPYmYOsKfQuBAidusUu/kxk4bCi12uWnpEkmHowa4ILPqcZkRf1zTwc4vPtw0nsPwZypD3ZTpZNvGhaSHkYiJw7AKvvKn1//SlvI/LzjxwWDxrTAm1W2xAK/NLLtZKRQOoph4rSsdGI0RebDxtmwrcB1C3orltzHagZ7J/4S5uTYUkgn8ocV5q8j7cMUjYoBN8CvvJLpy2GUphyx27Ha2+m8syqFMsJaVniSDLeNlyH9M0Jiew506y18vy6gyE/LYanj4X4VrT1TMt1fvr5Qtz1sesxZ45q041R4Xc4o+OoIly/ZiL/5EIKLK+asqgNEjtfk52lc4KSefkYRsA6yOrg+j/PyXqLLQYcggUfPahWcTnzfQqPNmp8RHWMSrrpkS9G4Vlis9Foav+aBAyjdEvxXx4trwJtSjCYDxML9wW+a0YMRFUdqfoB9a5+P5Aid5XjMFLrPLwNY4LeR2n0llqn975/vq9kmNl+dBEHG8Lvs8T8fFz4BUjRDa3doNjyHHW4qbrtE/E21b5N0xkmHngtFwSIDu7owws5rJl6ph8I/PohHIXLLRbdHMtUkA7nw8sdCMN7mnvw0Z0xfkpM8fDLklj+yGp pG1WNdVs +nVg1sGMyQs9dWez+Pk6nF1GBCz/PwwxahGZnJWZnkOeOEJ5MEsn05/O3jx4WPI2FSz6v0yvvJ7Sfq0D4dX8nF186pEGkS+EoiayiL8PEuSEk9QombbMlowyeA59pg9RH6QP91RZnA96d/xf6tER+fEUtlJQcGTyj/NETUPktWurXfs7W+3Hzawqi/L4nCqxkg59L4AAn4LJ9Q9CIvfqMZVWjVAEmR7BYjx8BfvzqnBkAKG9M+WyOxT+8y3FdfPVv1rDR+hvSspWn+QXuUfU6dAMcTx82LW8+WRdz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 10:38:12PM +0000, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add helper function to determine a CXL memory is online. > > Use case: certain memory operations are permitted when the memory > is offline only, for eg. some memory repair operations. > Hi Shiju, This helper is basically wrapping the existing helper cxl_num_decoders_committed(port) so that you can start from a cxlmd. Other callers of cxl_num_decoders_committed() do similar work, ie find the port, confirm an endpoint, then call it. I don't think it's done enough to warrant a helper for all callers. (but others may disagree and ask for that) This patchset does this work a few times, so a helper makes sense here. The part I don't get is why it is placed in the region driver, requiring it to be stubbed out when region driver is not present. cxl_num_decoders_committed() is part of the cxl/core and is defined in port.c. Long way of asking, would it work to just add a helper to core/memfeatures.c and use it within? The name could use an update. cxl_are_decoders_committed(cxlmd) is a stretch because a cxlmd does not have decoders. That naming made sense for 'cxl_num_decoders_committed(port) because a port has decoders, a memdev does not. -- Alison > Co-developed-by: Jonathan Cameron > Signed-off-by: Jonathan Cameron > Signed-off-by: Shiju Jose > --- > drivers/cxl/core/core.h | 9 +++++++++ > drivers/cxl/core/region.c | 10 ++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h > index 6c83f6f18122..386e36b18c19 100644 > --- a/drivers/cxl/core/core.h > +++ b/drivers/cxl/core/core.h > @@ -32,8 +32,17 @@ int cxl_get_poison_by_endpoint(struct cxl_port *port); > struct cxl_region *cxl_dpa_to_region(const struct cxl_memdev *cxlmd, u64 dpa); > u64 cxl_dpa_to_hpa(struct cxl_region *cxlr, const struct cxl_memdev *cxlmd, > u64 dpa); > +bool cxl_are_decoders_committed(const struct cxl_memdev *cxlmd); > > #else > +static inline bool cxl_are_decoders_committed(const struct cxl_memdev *cxlmd) > +{ > + /* > + * If no driver, in absence of a way to check, assume decoders are committed. > + */ > + return true; > +} > + > static inline u64 cxl_dpa_to_hpa(struct cxl_region *cxlr, > const struct cxl_memdev *cxlmd, u64 dpa) > { > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index 9e7b716296d7..3fd14cb0c470 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -2864,6 +2864,16 @@ struct cxl_region *cxl_dpa_to_region(const struct cxl_memdev *cxlmd, u64 dpa) > return ctx.cxlr; > } > > +bool cxl_are_decoders_committed(const struct cxl_memdev *cxlmd) > +{ > + struct cxl_port *port = cxlmd->endpoint; > + > + if (port && is_cxl_endpoint(port) && cxl_num_decoders_committed(port)) > + return true; > + > + return false; > +} > + > static bool cxl_is_hpa_in_chunk(u64 hpa, struct cxl_region *cxlr, int pos) > { > struct cxl_region_params *p = &cxlr->params; > -- > 2.43.0 > >