From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 940C7C28B23 for ; Fri, 7 Mar 2025 19:19:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86D2F6B007B; Fri, 7 Mar 2025 14:19:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81B0A6B0082; Fri, 7 Mar 2025 14:19:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E2CD6B0083; Fri, 7 Mar 2025 14:19:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 502026B007B for ; Fri, 7 Mar 2025 14:19:49 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 40E6DC0F06 for ; Fri, 7 Mar 2025 19:19:51 +0000 (UTC) X-FDA: 83195719782.18.09499E7 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf03.hostedemail.com (Postfix) with ESMTP id 1A64F20013 for ; Fri, 7 Mar 2025 19:19:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=c1og5nYd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf03.hostedemail.com: domain of alison.schofield@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=alison.schofield@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741375189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O04GsXH+GBcQGVj5TTxTejRV22raMy3fLY2h5j6q894=; b=7lP5L7WXrRerS67QZsuGAUI/vXIEoiR5W73/CWH7VbxKQfaIIt1ATfgpeJMxJUyVcF9H83 s8tZSGmDTmbgZjq5plP7wUeatrVRSFvjMdgGFLZyJjco2aDi4HgjbCCSmKovmZvasQpCIo fNVNxVVW7S1ygvtFUS6D81jdE84hMgo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741375189; a=rsa-sha256; cv=none; b=5JFiBhb4ac/1QizpvJVS+t8vyo9MIevF5HDjJ4cQXQul9Fb3TUSQGeVxQAQfoR0LcFsqLr KUSZ7AxNV/z15FXd70HGbeAnrHTl10fFahDIV8U2hmgWvUmm4KQ5sLKQwzqTjCaGOQO4OD +NxQKjuysndo/JzHqs3EdjmlpH/crvc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=c1og5nYd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf03.hostedemail.com: domain of alison.schofield@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=alison.schofield@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741375188; x=1772911188; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lWohW1lK5/1oJ/E8ckkRCgfaedm9zAHAHPnzlFJse9c=; b=c1og5nYdFSEwkVJg5AdElIH08htf6RXQnt25AIYSIOXT2ci8OAiSYlMe KXF8IdeIO1kIb+xz8aQ79YKZmN6EXZRyBG9Hfh2bEM5lzbO1Sndz4von1 +/8M4a+dyr8hc/VDRzvy03in+VrR3STaMjoksb3dNOwyGoccJuBtgXmuW BcYzV+hSwsX+2BW3OLS8NEnMhztNAj5zHvFNRBMS1SwmP/Y4DklgNnq32 Qutbb87xsr42vt0Ocm4jEUgaf+116LSLs5ksIZ0qCsKKQGvJnkxZg2++L HJfKUKeXc3VLQz7VrCyur7kv4hVmJEplZKe0uhFeZ6E7Ty24w/dBbeNgt w==; X-CSE-ConnectionGUID: WE69DI+ASJGRYuRFztZZaQ== X-CSE-MsgGUID: qKhz5IviSFmQVrJz2g65wg== X-IronPort-AV: E=McAfee;i="6700,10204,11365"; a="42315422" X-IronPort-AV: E=Sophos;i="6.14,230,1736841600"; d="scan'208";a="42315422" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2025 11:19:46 -0800 X-CSE-ConnectionGUID: CfyhsuotQIeGhCi5YnLAaA== X-CSE-MsgGUID: ze8qhkRFRD+Y3Nyxiz0cpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="156621322" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2.lan) ([10.125.110.159]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2025 11:19:44 -0800 Date: Fri, 7 Mar 2025 11:19:43 -0800 From: Alison Schofield To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH 1/8] cxl: Add helper function to retrieve a feature entry Message-ID: References: <20250227223816.2036-1-shiju.jose@huawei.com> <20250227223816.2036-2-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250227223816.2036-2-shiju.jose@huawei.com> X-Stat-Signature: bfm4can74uu55tdt357t7qx8iycfbsbk X-Rspamd-Server: rspam05 X-Rspam-User: X-Rspamd-Queue-Id: 1A64F20013 X-HE-Tag: 1741375187-382281 X-HE-Meta: U2FsdGVkX1+WpkG8643Pl6pyl2UgclFeD411YYn+diAzTG3jkef5yjJTChz691O1b4BnJyvTw8ntLdjEEppnbFFZeSzQf2u2J9ZT2uinxmQybZ/06HGg1Xtvcec4skxbdEL2tclfMRWnCtvKhallf8rHWWrbuR6+Sdg1E2k3da7V1qjgSKL87a1kEfcPFedqz0Wov4HfUV5GhAMPnu5A2i8Zv8K9H2WHq/HA9kGrNBZQraLC5glHW1d9PrRpU0rUuPraPHYjFjNKq77B60aj8z83aaY4p78fzOJq8HoIjisvSFmfnxKwc9P2ZZusOzvEdaDmYHRBjhuOV+6nKQOApDxZd7x6e7ky7CucI4jNKPynRBgVkXA8J55yIYfjGQNFn/QK1i+IuEWsYmFFLCdXT5xtFP4q81WMSMWuXBt3d/MFr0Y6InDlVZ6VNcXK31Fbxi9CroMELT3XUarR2YbUHDAKjIBbe/VidNMpQffwQAaIi5SXnkQ4LibBobvZzvMQPYHPJRKNjcfIPlcnTC7AscI/biySa6jkZFGfb4cE8inljC/6eurgb97O3PpIdGKQKmuUVhI4mvVA98X5Drj9xVAM8UINN0rmdV3R1plmzW4jcMSJi2HyPI9SOw/Lt7HXiiwSK3IGwE+Fki2R9VD2Ta3nuX1SiqR63c84PjVofO3LcDTQoMTLo9I3Id7li+Pyll8r1fCulr/a/3/TxNuSpRNDc2yazVVK6NEWJZDuzVvU9AlyNilxJyKizW1yna2t7sac5vhZje7/K4TuA1TlL4LVCoh9H89mFSeKeXdbltDk1VwmKzZxJazmTYcNNyZ8E/k9hyo8zegXeAprYJ89S5dQ3VhvSKN1bdny0SczAlrp6T6WuTg6ZWAviMylmDf9jWAQYCCqBLQfrKcFvcNunGcMI3+J62FUUOUC7exjltwTSpsMv1heAOxYtB1BKmZ+CfZ+KxhS+l4PG+mMvst SmcBAXN+ JTKQjClEp6cNKGpyvd29pPt5hcnbM87OMvnq0VXB504yS555jn4T4MmDtLFKiDep9Talzam8EU4ybtOQM2tzsE4CLRW39vClgcrARtrfy/MTu5e7q/ItZgeBPN/0Adn/ndPKT2RPrdUbbLm7fICL8tqR686iuzUKGotrf/zz/6AnOwYduarQ0PvYABoKg7gT1rT9ncz2lQHLW8XyQml1Iz3KrjLiA8J+8/kC5vByOH08cbzvmGxT+wEY2/ECyvTWABkDY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 10:38:08PM +0000, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add helper function to retrieve a feature entry from the supported > features list, if supported. > > Signed-off-by: Shiju Jose > --- > drivers/cxl/core/core.h | 2 ++ > drivers/cxl/core/features.c | 20 ++++++++++++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h > index 3d3b00835446..6c83f6f18122 100644 > --- a/drivers/cxl/core/core.h > +++ b/drivers/cxl/core/core.h > @@ -120,6 +120,8 @@ int cxl_port_get_switch_dport_bandwidth(struct cxl_port *port, > int cxl_gpf_port_setup(struct device *dport_dev, struct cxl_port *port); > > #ifdef CONFIG_CXL_FEATURES > +struct cxl_feat_entry *cxl_get_feature_entry(struct cxl_dev_state *cxlds, > + const uuid_t *feat_uuid); > size_t cxl_get_feature(struct cxl_mailbox *cxl_mbox, const uuid_t *feat_uuid, > enum cxl_get_feat_selection selection, > void *feat_out, size_t feat_out_size, u16 offset, > diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c > index 048ba4fc3538..c822fb4a8c33 100644 > --- a/drivers/cxl/core/features.c > +++ b/drivers/cxl/core/features.c > @@ -203,6 +203,26 @@ int devm_cxl_setup_features(struct cxl_dev_state *cxlds) > } > EXPORT_SYMBOL_NS_GPL(devm_cxl_setup_features, "CXL"); > > +struct cxl_feat_entry *cxl_get_feature_entry(struct cxl_dev_state *cxlds, > + const uuid_t *feat_uuid) > +{ > + struct cxl_features_state *cxlfs = to_cxlfs(cxlds); > + struct cxl_feat_entry *feat_entry; > + int count; > + > + /* > + * Retrieve the feature entry from the supported features list, > + * if the feature is supported. > + */ > + feat_entry = cxlfs->entries->ent; Do we need some NULL checking here on cxlfs, entries > + for (count = 0; count < cxlfs->entries->num_features; count++, feat_entry++) { Was num_features previously validated? > + if (uuid_equal(&feat_entry->uuid, feat_uuid)) > + return feat_entry; > + } > + > + return ERR_PTR(-ENOENT); Why not just return NULL? > +} > + > size_t cxl_get_feature(struct cxl_mailbox *cxl_mbox, const uuid_t *feat_uuid, > enum cxl_get_feat_selection selection, > void *feat_out, size_t feat_out_size, u16 offset, > -- > 2.43.0 >