From: Herbert Xu <herbert@gondor.apana.org.au>
To: Yosry Ahmed <yosry.ahmed@linux.dev>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
Minchan Kim <minchan@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH mm-unstable 3/5] mm: zpool: Remove object mapping APIs
Date: Fri, 7 Mar 2025 10:38:57 +0800 [thread overview]
Message-ID: <Z8pcQdB4HA9ulyE9@gondor.apana.org.au> (raw)
In-Reply-To: <Z8nTa1yut6I0RS0a@google.com>
On Thu, Mar 06, 2025 at 04:55:07PM +0000, Yosry Ahmed wrote:
>
> The zswap and zsmalloc look good and the code is simpler. I am fine with
> this approach if Sergey is fine with it, although I wonder if we should
> update Sergey's patches in mm-unstable do this directly. Currently we
> are switching from mapping APIs to read/write APIs, and then quickly to
> the pinning APIs. The history will be confusing.
>
> Sergey, do you prefer if we keep things as-is, or if you update your
> series to incorporate Herbert's changes for zsmalloc/zram, then I can
> update my series to incorporate the changes in zswap?
>
> We can also combine the series into a single updated one with
> zsmalloc/zram/zswap changes.
>
> Let me know what you prefer.
This patch is only illustrating what zswap would look like once we
move to an SG-based interface. So I'm not actually submitting it
for inclusion at this time.
Sergey has volunteed to add parameter support to acomp. Let's
wait for that before making these changes to zsmalloc/zswap.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-03-07 2:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250305061134.4105762-1-yosry.ahmed@linux.dev>
[not found] ` <20250305061134.4105762-6-yosry.ahmed@linux.dev>
2025-03-05 8:14 ` [PATCH mm-unstable 5/5] mm: zpool: Remove zpool_malloc_support_movable() Sergey Senozhatsky
2025-03-05 14:53 ` Johannes Weiner
2025-03-05 17:05 ` Nhat Pham
2025-03-05 8:18 ` [PATCH mm-unstable 0/5] Switch zswap to object read/write APIs Sergey Senozhatsky
[not found] ` <20250305061134.4105762-2-yosry.ahmed@linux.dev>
2025-03-05 8:18 ` [PATCH mm-unstable 1/5] mm: zpool: Add interfaces for " Sergey Senozhatsky
2025-03-05 14:43 ` Johannes Weiner
2025-03-05 17:32 ` Nhat Pham
[not found] ` <20250305061134.4105762-3-yosry.ahmed@linux.dev>
2025-03-05 14:48 ` [PATCH mm-unstable 2/5] mm: zswap: Use object read/write APIs instead of object mapping APIs Johannes Weiner
2025-03-05 17:35 ` Nhat Pham
[not found] ` <20250305061134.4105762-5-yosry.ahmed@linux.dev>
2025-03-05 8:16 ` [PATCH mm-unstable 4/5] mm: zsmalloc: Remove object mapping APIs and per-CPU map areas Sergey Senozhatsky
2025-03-05 14:51 ` Johannes Weiner
2025-03-05 17:39 ` Nhat Pham
2025-03-05 18:57 ` Yosry Ahmed
[not found] ` <20250305061134.4105762-4-yosry.ahmed@linux.dev>
2025-03-05 8:17 ` [PATCH mm-unstable 3/5] mm: zpool: Remove object mapping APIs Sergey Senozhatsky
2025-03-05 14:49 ` Johannes Weiner
2025-03-05 17:37 ` Nhat Pham
2025-03-06 1:48 ` Herbert Xu
2025-03-06 4:19 ` Herbert Xu
2025-03-06 16:55 ` Yosry Ahmed
2025-03-07 2:38 ` Herbert Xu [this message]
2025-03-07 5:19 ` Sergey Senozhatsky
2025-03-06 14:15 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8pcQdB4HA9ulyE9@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=peterz@infradead.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox