From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF30C282DE for ; Thu, 6 Mar 2025 16:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36A80280004; Thu, 6 Mar 2025 11:58:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F353280001; Thu, 6 Mar 2025 11:58:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19598280004; Thu, 6 Mar 2025 11:58:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E7016280001 for ; Thu, 6 Mar 2025 11:58:23 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A09A5C1B84 for ; Thu, 6 Mar 2025 16:58:24 +0000 (UTC) X-FDA: 83191734528.11.7771AAC Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) by imf11.hostedemail.com (Postfix) with ESMTP id C72094001A for ; Thu, 6 Mar 2025 16:58:22 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Gm2vaxi5; spf=pass (imf11.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741280303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bxRazIvJEGNH5PVFbt7GI6DugbAZvTodK1oAlzbYoWo=; b=xoy8heVE6J6OzxagLuHfUbn1W9EGVhzFMTq8qUlMibslVe2UyW79cYN242RadGmQcP/UL2 Mbvl46SSz0bIn2ZZX6x68wCTrGgGIP8G9TEo/urONNSQLehh4aKUsWPZW7iXoMoOamXL+4 buQEVB9if/n+LdTBziZC4Kk5M02tp2E= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Gm2vaxi5; spf=pass (imf11.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741280303; a=rsa-sha256; cv=none; b=PS4xIgJxrp71WfF7t/Yw1cWFpYI4qmXwz98BdOorqP8Mwvl2Fyug4tVM2L1NwC1eGulByk 86n+PHfwbgCvM1/38MLDcJGKEmBZPNkbyUvWCOB48qQPfKzuix8wOEMilJZeP9zpMytbwt WsbI9f+WaghkPenrO5QHOGvXXQed9FA= Date: Thu, 6 Mar 2025 16:58:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741280299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bxRazIvJEGNH5PVFbt7GI6DugbAZvTodK1oAlzbYoWo=; b=Gm2vaxi5nFtGcLmN1dR1DKbNBVnzkVUAwVh4n09///Xbch+KqF2Bh5qcFOvQtgcnghcB9j 1Jtj/Sbwd0YAJse+6Et9XaO20QlLiDVOZ4+SYDeTKQUpFWIWS5ZKxaQEegYsiNlSCb5XT2 GArUNBIyXntq8wE2X8xnf2hrd1Bjc4k= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Herbert Xu Cc: Sergey Senozhatsky , Eric Biggers , Linux Crypto Mailing List , linux-mm@kvack.org Subject: Re: [RFC PATCH 7/7] mm: zswap: Use acomp virtual address interface Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: jcodx6pg13z3ruiwqsz3ho7d7atj35es X-Rspamd-Queue-Id: C72094001A X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741280302-719221 X-HE-Meta: U2FsdGVkX196FVhOhaQ32gDwr3RLxPjelHqCWigL6nZ7uEwk6UWP4jHuFZVpZPdIGfItFSiR/n7E5NXuhZAXSBMGP78B4G9o2Uyyk3CF4CLqvbbEfOgF0UH/36Bwk7hY3IyEKL7cnxYJNFFTEhq8Yr4qXfuefDtMTaTwqFcin1fJAglBHCM100XIWD3UlOhKPQpuo9Sl5fkjWJJmNDjsYf708OUJyTThaPBgaMrHMP0Qzag7dI0TTCR2D0vzipeYQBxdYbkR9y9V4m6U4cj+IKhlt+OttpLrMQgz+XbqyfgqLFKQObu7NVoH8oe6kKiDE7ubUIcV8pUDtqDJ5/UUnSASlY7q+l8mx3rVtgnz6UR35q1UZjcKawEnJshqTOrF07MzKi/vTg1YbvCRTjUjD3nrlIZdmILUdac9j3bROR1i1nsdLAwCq1/Nicnyte+25IQGtkR1pk7KMZpKkgbZDYqQ2mqb9gYw20Kq46/9DYAwMsaLBm990vsz02/1G4GD7hshwxN/ayH2IgnPz/aIIve2aKnxIpWZP4ZvGgXTapRNfnxchjV0j0oMd2BJvzq97PY6XFZIN+d8cWS/tVEYaxUz1YMFted290jmlLCiGHwLiZHQeUWDavIGaSIbEzUT64ZUDwuv7SSjYb9/bdmMzlX9DcbNhUBkGSgH2bjEVcd9Waaemyo54M3pLuyQ6Sh00/j6ODX8LupSrkDCLqB7ZWrJCNyEfZ+DNLz1fYDrW5/IaUzHGoeBUMuNdn47puJk5pA39l/LJt1h+b+5oOhOJVCQ3fHs4gaKM17lBbV5xt06ofbDHkVUUUOP2G/drHMLrk6B+/9MV2fzZVJ8Fc/+VBiDzXPYguq2Lo61y/rIcDydeYizYgFFfVtoc+zjVfNih8Uubouyb2SYNWrT/Pto/R0I3582budr0HQE6ECzqlyWC5tp35y3rS6ChtDmXhd5AuGCoES5qk79KoW14kd epiAJBYL CcwJhkGQtCPH3oqECmaoVPMVPuImUaTaJaAq8SkyKpXjFCkbuhDqBzevQT59yv1IMJDT/fue+jn5Jsld+BcUzjMo1z0E/rIeIGDG6UTkJnlCHGnsk9ldJNom2EsMsp6L4hAUz4ocrwwnceO5OZg4gIlQynWnFuIjOJcnV/8C2ip1t7I/FP+p7kPSYvVlSJts6c5PJpPOJH4xamcBdlnLnQ+4XfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 06, 2025 at 08:40:27AM +0800, Herbert Xu wrote: > On Wed, Mar 05, 2025 at 04:25:44PM +0000, Yosry Ahmed wrote: > > > > Zswap is already using an SG list when calling into the crypto API. The > > problem is that SGs (i.e. sg_init_one()) does not support kmap highmem > > addresses. Is there a fundamental reason this can't happen, or is it > > just sg_set_bug() using virt_to_page(). > > The whole point of SG lists is so that you don't need to kmap it > until the data is actually accessed. Putting kmapped memory into > the SG lists defeats the purpose. I saw your patch in the other thread and I like just passing a SG list from zsmalloc to zswap, and passing it as-is to the crypto API. The problem of virt vs highmem addresses organically goes away with that. Thanks.