From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F2FC282D1 for ; Thu, 6 Mar 2025 16:55:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01CC4280002; Thu, 6 Mar 2025 11:55:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0E2C280001; Thu, 6 Mar 2025 11:55:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFE4E280002; Thu, 6 Mar 2025 11:55:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C3789280001 for ; Thu, 6 Mar 2025 11:55:17 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7D1121C9FB0 for ; Thu, 6 Mar 2025 16:55:17 +0000 (UTC) X-FDA: 83191726674.18.036E128 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf14.hostedemail.com (Postfix) with ESMTP id 8F9F210000C for ; Thu, 6 Mar 2025 16:55:15 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vQsIxCqt; spf=pass (imf14.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741280115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kwhx/mtOi1GHi7BWSEe20K0H0IJsKkOByjdFjZj3bKc=; b=jsjwpqvVBzLUKxFaxgRI75wT5X2rO8uLNAecBE/GrGBaeTSJ606GF/+uyIEh09rbg0gunw OY1NvWlEiPDYHPcF9wEpDCp1uIjKuwt6zgoVgEo4b0hoVtXqsMv6gqtGLNPs8O9oamvLNw oA4g9ZR4RXXlJny5I/BJeefS+qmHyXI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741280115; a=rsa-sha256; cv=none; b=c4i7RNhe1CkwaEBMtbdXsCjHJCcOlCSpDz+gIJaRAUw/YnAEsnAGYM1vcaMeWCdiJ1bTnQ j88bXZIhcKRLNqEgs/t7SRw/MfrBMtwgIWo5gLR8ORpRnifk8jhScwPMFL1iKTJA3EiJEB IFF4fDcSyHRhB6BPo1KmzvqzekXwhRs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vQsIxCqt; spf=pass (imf14.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 6 Mar 2025 16:55:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741280112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kwhx/mtOi1GHi7BWSEe20K0H0IJsKkOByjdFjZj3bKc=; b=vQsIxCqtKLzZDN2FoDbwBZ2U/BVPqjwidfkrceSl4A798NuUB19lgu1wZEi7kwHPakRhDP ssQA/ydZeQ3uErvGo9p7CSJ4b0V9D+rGJbDkfxpWmJpixhunt341epOTV0C+2JPSqobLkz EL6msC+6vtKG1sarEevBM/MFeofyaPM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Herbert Xu , Sergey Senozhatsky Cc: Andrew Morton , Johannes Weiner , Nhat Pham , Chengming Zhou , Minchan Kim , Sergey Senozhatsky , Thomas Gleixner , Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable 3/5] mm: zpool: Remove object mapping APIs Message-ID: References: <20250305061134.4105762-1-yosry.ahmed@linux.dev> <20250305061134.4105762-4-yosry.ahmed@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam02 X-Stat-Signature: xysqfyfgw3n1m55b7bpqhqgzh98mtkit X-Rspamd-Queue-Id: 8F9F210000C X-Rspam-User: X-HE-Tag: 1741280115-607443 X-HE-Meta: U2FsdGVkX19w9Q1qSWqkvDZlFUyZq/Z8FhBOn1gL+QvFeL2iqrDt8Dh2PupvN+7oJ+WPqcI7fDjBMKmKOQrnqSckpevMQL9FkrXAE0CcPYNCVHi8GbQzmXXAd/9El72RrTqWHlUTdZQ4cHszQRsd5ubNwJrHTSolMlWVr8PY9h1v/uxmbZDYpg0vAGPQV9kFW6Sy1A1N1l/oiS5rGfG8moySxl1jRHHgK2Kqxvi76QpmuNqL44+eqlB9ViRGJ6LdxRu0cVx2BxeU2r6vDaikprzCDtMUjOAhzZSfGbCCu5QWH7HGDVd9nuy/PiMLzBWQcE8amO7N2gRVGvpKDEVPOXzak/eXDUyBXqUUp69rKx9ntWnp0mreeXDV3jrDr3Gu6TBIIU+TSEq0GRiHcxAmRJIlOQitDJzozdqThpDjg01MhntQlYde/snU+xi+AwohAsbFY/GuxYsYjxH+bNwc6SgF1bulP22WJjhHw++TX65v3OXbvfds6T4dFgJPxDBLo95lE+pwOYHLfeT+Nqkjsi7KNUIA67YCr1CiUv0hO3atQymrxIXS1BZ27z4HUV/j9+mhTrgF0oAbs+cHq3EUhT2tPZe+1YYYrICMnGcWW6vizXBmXBKl20IdLazQgXSYOX5FTb6pkK0ncXP4rdx2OUReBB492kqUZFj/xjpX2tDLRPaoWwd/E7sLIobNonMpaziz1R7lviEbi1e8bHws2qFqsBP9JuO95SvgtJW8D7JNhtFrhfd3aP4Pe2n2ruud94MNz9OvZvuYOTu0n8L6BmQ93KF0mnBMUHvKBvocm6n407oJfVvKwV8+enUIc4crJTRhRJOC5vwP2yyhBtYHJlsXTfW/OH2nUECjSHPPgmPD4Y4+H61/1OCJaszxcXsCX5TaNpnjiY82fTsKlpkQU6HHFfuLbOyJnvoa7VgwqCIGKdyOLPYCUgQyrv6OugC4x80nu5SDZuUG9Jxxwjw wcFf415L d6NR8P3YMKCElsxjblBv/I6BE46+c/q7Ceim8nsTjnCIWSFcTnNOq9rRvs9JEbV8+sHfypFGqfN8jYitvbehcP6FpyXgadqPiBPsyQ0GMiVQ/Bu01vwLOBEwsMIhjOpw98Cmlsid5ajpXum8GInmgoJMCz8zqpDhtW94McraisK77kJKX+HkJLF4yflV8MqUw++zfpuHOoZ0OdoTJLUH8Z+tP8qwq2/HYq2xqwYOi4TmsIWlgDhbjHO0kmV6NbGvceNcj0SlUInCVmYvErg4j9lvt+uE63CupJ8yqegiX2WrP4LE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 06, 2025 at 12:19:19PM +0800, Herbert Xu wrote: > On Thu, Mar 06, 2025 at 09:48:58AM +0800, Herbert Xu wrote: > > > > This patch breaks zbud and z3fold because they haven't been converted > > to the new interface. > > I've rebased my zswap SG patch on top of your series. I've removed > all the mapping code from zpool/zsmalloc and pushed it out to zram > instead. > > This patch depends on a new memcpy_sglist function which I've just > posted a patch for: > > https://patchwork.kernel.org/project/linux-crypto/patch/Z8kXhLb681E_FLzs@gondor.apana.org.au/ > > From a77ee529b831e7e606ed2a5b723b74ce234a3915 Mon Sep 17 00:00:00 2001 > From: Herbert Xu > Date: Thu, 6 Mar 2025 12:13:58 +0800 > Subject: [PATCH] mm: zswap: Give non-linear objects to Crypto API > > Instead of copying non-linear objects into a buffer, use the > scatterlist to give them directly to the Crypto API. > > Signed-off-by: Herbert Xu The zswap and zsmalloc look good and the code is simpler. I am fine with this approach if Sergey is fine with it, although I wonder if we should update Sergey's patches in mm-unstable do this directly. Currently we are switching from mapping APIs to read/write APIs, and then quickly to the pinning APIs. The history will be confusing. Sergey, do you prefer if we keep things as-is, or if you update your series to incorporate Herbert's changes for zsmalloc/zram, then I can update my series to incorporate the changes in zswap? We can also combine the series into a single updated one with zsmalloc/zram/zswap changes. Let me know what you prefer.