From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19801C282EC for ; Thu, 6 Mar 2025 14:04:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77DD0280002; Thu, 6 Mar 2025 09:04:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72DDB280001; Thu, 6 Mar 2025 09:04:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F56A280002; Thu, 6 Mar 2025 09:04:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4250F280001 for ; Thu, 6 Mar 2025 09:04:39 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A69411A161B for ; Thu, 6 Mar 2025 14:04:39 +0000 (UTC) X-FDA: 83191296678.30.EF38148 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 900BA180016 for ; Thu, 6 Mar 2025 14:04:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KvxNqbwy; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741269877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9w1loW1D93ByGjxUH+v0w87cRUrgY5imRrAfL3a+uhQ=; b=RwYTYKYOXG/DDebKM2x9q7OKdyGipJxoVee94c9XT5Hom7UyAGWEkI4niroVOgJTyaY1HV kiAm01HrAHEjRYy8kewzYFHd57Y453mNHkNnMsRs5DpJwdI5mNh330756Tyq1JzDISSs9A vsH5tVAB99IZXjsy+uUijw/IiI9zNDo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KvxNqbwy; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741269877; a=rsa-sha256; cv=none; b=XyDjKDSJMJfc9CUSr8oXcLbu31tCyhpBJU8YT1AcSeSzMIJRgDXSGr5QCdebU/yTOZie3p +hHQqDDfm62pErCtPofCa1rMv5nUSF/PqKmUf7tL1dVe+3iBrwBn77p0V92CYuzVcipO18 ZbN1WFVA73UfIk5g/ERUUQTuu0E6D1s= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5497590ffbbso885886e87.1 for ; Thu, 06 Mar 2025 06:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741269875; x=1741874675; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=9w1loW1D93ByGjxUH+v0w87cRUrgY5imRrAfL3a+uhQ=; b=KvxNqbwy1SbM0e6RI6O2cuZ6xKoAORPKYEcbIaBU7uL1h9Jxq7DQ/q7cOJu7t0Sgho DXJXhGx1u58UtCTulMKfLsE/i3mplYE7b4U5PNo53qmzXDrcqIFrcnSEVjsT6O16wQkj kd17OLIXh609Lv6yBFNazUl7+e1RIle0gJzAd0fw4u/xbZSPu+Plq84GQggQHki/EsUj 0LaXyKkpkmWJA4d2KxTThkStn9GEu5tEUVM9m+O6SCG520AprloTz86KbrbKNyKWjAKp eLaZEVTCJ0xqc8/Sl6MUdZ/gKEvtgwg9kJ4BGS4rahfQ90GwFkUJAEeXqB1b3e/YeKVb vD5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741269875; x=1741874675; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9w1loW1D93ByGjxUH+v0w87cRUrgY5imRrAfL3a+uhQ=; b=t7HB2cnk2mD8ykqmsSwpx6GgK9+DGxOpf0o8HAzwHQKN3Ac21hNRDP8uSv5RyLz8VO AyRoWUJD6bYOFv/dUEGqB3XH97d/Va5iNEAM5LCXp2qgHD/wVGboLj71hlRgmwvI2TNd tgmozheNaNt8hCjvhRfuNZZlwVsRdE1I/9XrXmjfSw4wz/PCuIL4NQDuhulNvbkok5pi h6S0uJZRnEge6+Zua+T4VsVQjReeQv5eYA6oPuB4rjbpStgbP5Uea10b0/EtxezhQ8Br Db9oTkBKwfKas9o37ZWYLgflFW/vhGFFJEaCIkgWEeC1kRGrXzu5IQlpuy/ttgEuPyc6 TT8g== X-Forwarded-Encrypted: i=1; AJvYcCUlgsEJpIIyjEgXquYcbVOVSwAYST9C0dqzPTFZVYKdlXeo1v9j5kRfUFmiQn7sQAGsqMPoeYifFg==@kvack.org X-Gm-Message-State: AOJu0YyWRoTJSQ2ROMMg7Pg3llYAiEPk0hYGKIQupE7ENL93fiCP1wX+ CNOCK6GF2ASp1hzZDdvpb66FUYLWIsRpcG9pIDaliqVCo/qbFcfy X-Gm-Gg: ASbGncvd4nw7cK2YPbOy5ecSBic2DSVtIjzlmHKmf4lNawQeKmQ79GEWnzP1XB+mmU5 ALsbtjVDW5z6l2Sc6rnFrP5kXEPxdqTl/1iyLGPWA+vpdiKZvHBsN6gDA8q9Iw/wgkoouPJ6u/I z72LKAeEYNGNcClImJ5tDLApt8S63HBl63Im8v4m7zNmvxegHDEl1QVHr2SVNtzJRfJroLmXX4q Xcpav0oxaQRaMjsSgCfsdlXPINjZ1yF4G3uXQTmhy0R9AfDOY87Kwhldu+O924PfD4YLUF6fm+/ 8f6Sbj+Is93VX/Cp+C+IZf7rwTsVoB15tzmcssxNJZpzQe8S7U0IY3gGE8dVYofBtJs= X-Google-Smtp-Source: AGHT+IGonnW2BIlqC2FdXER3bXAFv4ISuWErmmFhIv+nnElrcZtI1jJxe9rCZw7FGgE21qslHhMlvg== X-Received: by 2002:a05:6512:281d:b0:549:5b54:2c66 with SMTP id 2adb3069b0e04-5497d345ea7mr2751359e87.23.1741269875014; Thu, 06 Mar 2025 06:04:35 -0800 (PST) Received: from pc636 (host-95-203-6-24.mobileonline.telia.com. [95.203.6.24]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5498b0bcf82sm185064e87.154.2025.03.06.06.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 06:04:34 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 6 Mar 2025 15:04:31 +0100 To: Jocelyn Falempe , Matthew Wilcox Cc: Matthew Wilcox , Ryosuke Yasuoka , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, kraxel@redhat.com, gurchetansingh@chromium.org, olvaffe@gmail.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, dmitry.osipenko@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH drm-next 1/2] vmalloc: Add atomic_vmap Message-ID: References: <20250305152555.318159-1-ryasuoka@redhat.com> <20250305152555.318159-2-ryasuoka@redhat.com> <3bfd4238-6954-41a3-a5a3-8515a3ac9dce@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bfd4238-6954-41a3-a5a3-8515a3ac9dce@redhat.com> X-Stat-Signature: 8inraf8jeimrtddkrbcimhwt91j7b1cx X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 900BA180016 X-Rspam-User: X-HE-Tag: 1741269877-449905 X-HE-Meta: U2FsdGVkX19LCAhxyT+Xu/wPFKPrw9sfF9J6KrKKkiaetKuBgoPaYZhdgAag6DaqwBxNvvwH1ceFHX5FkCVhnGUU9PotLuJ/WIVzo9o5/89PZDvUA7X5q0+JcaKEKf6k0Xc6UhCl7MJrR7PJYmpG/LpPTSjiKqs3esXpl6l+0nvbyHktOiQf3t8IwNcRQoemwusf5UUoTakjlk4ZGz1Qjeaxcvc1+W7IkTHZeKAiwUCo9eM2LQUbyZ9sU95tMEYT68+jHNWxSp5K+zBsSBzDp0wlZ6Oa05AI136gcZlNKILNR2G1gLO6MwR7AAy9moYnTEjbCwXBN3ozdK2jM5PG1yHZfv3W0rULRZA64CsI1THWJyS4eZh9RDbpzf6aqJUT2FnJYH4dM2hYKr/+t6V2dwzJhrgcwYX9wHoLtFgwNzq8Yitvig+jO4eqFg0uBwMXw9i7ZHmqQG0lBuinvF7SaGm4gYoeNcEBSuLaRfYtAMEm0sTcXqr+NcSKJ/VGUMM21heee+HuP69mTSjMNUvta9MA9HD2BXf9GN6eVq4uOkdwSTDefg8YEX5yyUGJ0LiaZLz0h3k1pbYLOclsNuIdTFPLGhZV5F5yGU6hguRGfluHMa5mhqqR4VwAa/COzrqZ15yqZ7YxzR7Xb8OCb27iRboxVUn8aQz5WY3VazJorT+FyOaq1XRrnsndH1rQO+p57FD8kxb6IiACjWXllNaAghPMZoQT1CphO2JjhQMxwmfGl6qrbjlzgdJEvbiw6gMp3AAxWNjhHATwjyK+O0dQVAX9H2fVUEBTgf7z8/TbTjHOf8eKpiOgcLmhBDyPOdZ/oN6ZdzNKk/MCUQZcV0emRwevGfSfeM1FNj/vSnaYAqOIuEblZp/de0PWSmoCxGdeklMwHDapU+8P/ButlQ1MdugzUXRlCMC3o7VD+TnYKrOaj1XGeIh0TvUGpzWeUbjU7PRXl+6wbrJAfMsjp2R KaI/D91M m/NCfAUKPFTs9tOrguFnMleP+DvMbv0ZaoUJMnen+aaelyHts73ppyRKJIQqsTW+dWvVx+k2DbwSRmqjeS7wHQPyIonSRqUgW86XY/1MOORzP6Z53W/R7KHdzjFn/UuZggILldQjetVgUNAOZVSQUTf5yiUvno4nJSbA6RegNtZKGg6NYBbLhO3vlBOtv+pooqTtcoPOvJASaEblW+m4sEfbVuh16yfbuOAq+Z8FrpRGd/UdLT/yTSbmPoFue7ya65E9G2qrlNxHf5pFCduRwczshB5RSHCQGwRb69KVHXcWzd1n9sL5HnI50R0gB2p8QQkzPcpHVm73m3CipQQy9XfoeFq6HWK2mv1cpIXKO10c3zy2v7u1o3CTZQ+7bP+03vVq508ssXY9gVo2DgAnoDFcM/xISOtmQq2u6AMXPO+8mRfUElW5cSHLLYT5f4c88oaOJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 06, 2025 at 02:24:51PM +0100, Jocelyn Falempe wrote: > On 06/03/2025 05:52, Matthew Wilcox wrote: > > On Thu, Mar 06, 2025 at 12:25:53AM +0900, Ryosuke Yasuoka wrote: > > > Some drivers can use vmap in drm_panic, however, vmap is sleepable and > > > takes locks. Since drm_panic will vmap in panic handler, atomic_vmap > > > requests pages with GFP_ATOMIC and maps KVA without locks and sleep. > > > > In addition to the implicit GFP_KERNEL allocations Vlad mentioned, how > > is this supposed to work? > > > > > + vn = addr_to_node(va->va_start); > > > + > > > + insert_vmap_area(va, &vn->busy.root, &vn->busy.head); > > > > If someone else is holding the vn->busy.lock because they're modifying the > > busy tree, you'll corrupt the tree. You can't just say "I can't take a > > lock here, so I won't bother". You need to figure out how to do something > > safe without taking the lock. For example, you could preallocate the > > page tables and reserve a vmap area when the driver loads that would > > then be usable for the panic situation. I don't know that we have APIs > > to let you do that today, but it's something that could be added. > > > Regarding the lock, it should be possible to use the trylock() variant, and > fail if the lock is already taken. (In the panic handler, only 1 CPU remain > active, so it's unlikely the lock would be released anyway). > > If we need to pre-allocate the page table and reserve the vmap area, maybe > it would be easier to just always vmap() the primary framebuffer, so it can > be used in the panic handler? > We can reserve a vmap space for ATOMIC or NOWAIT allocations. As for PTE part, we can also populate reserved space, because after that operation those are never get released. The question is how many users need this. As for this particular case i am in line with Jocelyn Falempe. Allocate for DRM and write on panic. -- Uladzislau Rezki