From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1AF3C19F32 for ; Wed, 5 Mar 2025 19:31:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E70CA28000F; Wed, 5 Mar 2025 14:31:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFA7828000B; Wed, 5 Mar 2025 14:31:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9BDB28000F; Wed, 5 Mar 2025 14:31:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A86AA28000B for ; Wed, 5 Mar 2025 14:31:07 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A64B3120A9C for ; Wed, 5 Mar 2025 19:31:07 +0000 (UTC) X-FDA: 83188490574.29.9F61E19 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 12F65100014 for ; Wed, 5 Mar 2025 19:31:03 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="MiHR/u0l"; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741203064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=17Q1ePKPZtBEcl+vkrap0wJMpbpHnmXjVqjNWIZ6vhg=; b=AJ9mR/aGmbs2HMbRsMa7oy5+B6dm/+N/3H8fixuJ56NeyUi//8iYfagFmnHn1Y00kIVuad S6Rban0rOAtZ+DBOdUHkYqUsSxOfVBxHy8FSCEIUQI9UCst9Qx5FhLN/SNKVboOonEOdtC C7cAfKiKe/MFJyBG46SgL+tu78rTF/g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="MiHR/u0l"; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741203064; a=rsa-sha256; cv=none; b=zZSnCH+CY7uHTfnDJUBwpSaYGkVuoEtzFlL223ZvmRd3/tIjigfeIwD4cHghzKTILFnPT8 a+vUVREKwsl1bPIKhP09suqCDYF+SNdds5c0a/5nQnqaAqp/3Nf74M7mg+6Mvi3cCs3wwJ dKHgnypEmeuGgbbyZDnQwUTdnJzYFVk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=17Q1ePKPZtBEcl+vkrap0wJMpbpHnmXjVqjNWIZ6vhg=; b=MiHR/u0l5WWzte3RVYSWhrNqLK dETVteqyqPEHquevzsPbV3NjjXC5nAHASQz6P29yuenxd7ElZ+nx9y2PnLkdeAMjFGmJceiioJC+3 c3eB6ndsGoSV4lSfAhfsofngXQepmkT4ediyjgHz3wraqJP+ATjAs5MdePDRk9doca9d9m8vwwOM/ x0UoZ59vYD49pxTySy0SVGlIG/4F1vZIK/qVQzE+Bg7SdcuJDxU8wEhpPMFbvSv08mXDAR4LRksFj oHhrFbuyNkRHYEtPloIpnwDNdTxAP6cwO9rJMPYzoPQBGWs2rfh7jQpjJ/ETV4WLqlV0ay89kHQVo QK7Dai/g==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tpuSH-0000000661R-1wXY; Wed, 05 Mar 2025 19:30:57 +0000 Date: Wed, 5 Mar 2025 19:30:57 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Morton , Russell King , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Tong Tiangen Subject: Re: [PATCH -next v1 3/3] kernel/events/uprobes: uprobe_write_opcode() rewrite Message-ID: References: <20250304154846.1937958-1-david@redhat.com> <20250304154846.1937958-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304154846.1937958-4-david@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: 12F65100014 X-Rspamd-Server: rspam09 X-Stat-Signature: wfppaps5jz43rntaoh6oyac6j5zaa7nd X-HE-Tag: 1741203063-895450 X-HE-Meta: U2FsdGVkX1+Rh82HZ8Dy/sUo0+b/WRXH+JeILkfsLCA4//aoG2ChCBGpNDx/+FIEQxrNfLP7uLrjS8T/nJqQ9eMAtROO0kHRHCBlz0mC5nBoNfrPexKATLj09uokAnyz//wn8sSsb07oyhsQQ8ByL93xN4mB6cydw0dsXJLIWv/iUvxUkZzmf725ibNhThklEGydyCBx8ff5af0mLJfJkrKMed2k7XySKoThAwuPRptlKHCpzkPMh1dFq2jGg9yvLaU0zBa0ovWuJ0YMCXr851twbT/E1/qVMOO/cnRh9HtKG1aUYtI5nd8mrvGGocgO3H1+eZorNH5uVLUXPlMbGkJ7ob1hffD0cUpDuUXFtR7Z8Yd7sytxCNI1Tw8ENpy9dTtZJzihpn4ClRZZrh/CwIdOhSUx74QbiwgRJbPa181VqihB3PoQ4/BFfZpR8LiTHaaJ5lH9w2d9LJPL/n9qRcsrgkI33JtCUMoqFvoeaf6dwgSV2s528kdgVNMKE6Cp+5G+GWH3Z4jYdoyVY8d3mqkBYGKxz1cW7h2qyYWCYnbBdqvD/750tmLBJwYw4UlRmR86jgaCTd5iF/J2X0vom4ERcCO8TLzUEOfmC2XaoK1r0KLekt4wDM+F+xVzAWrN6O/Tea3ZOkl+HtwMLT3nbq7pp+6BWVxTj5AAOFkfmwDIIwDHhM7I3zK8wIQeCFgv7yC+BmpHpB5b8bNr58nv9ouUQ2hTQYZSAj43jvxWGKr8dtLMkSRg5ADNr8mODBYdFTbLozFwZjI6KuYVz4GQfY76crUt4Rm5Kn3lmQN7PYwy9J52cwTXyQdjggZ37dQJ5FI1OObMqiQHJrjtkRDqimcgeFtfBj7oH5/OcPeEi652eB7c5LkuwhBn9ONkKfg4RqcdmXaZKFm5Xnnvd0GUuDFTdx82k2ChyF5fN8Ek4RIv0yUJBwLUloLnIdR2p3MxhpvDMmK7RXmYtC9gyK2 d5wuHnHM S+dGCwgWWiN3bVouWQnH9FbiOifyyOic1oAolHtQHrHLJTqxIiZPed9iTldt8Kl2Phfk/JI7fpGiaH94clwz92g/WzI7YA+NiOs+BB0F9UFYcC3s3dgqduQ+4trJjKXlCNa58BLXAYS6OJI9HP9Fje/phgzc2dgNWTlDQ1pcdSGs5lxDs6jXGZopBzMsGgzv1QNNP7DMh8XZns9qfzvxB9du7lDcCf36BLIQhG6RFszxJEg52Si59MHagMKtvoU75HY6pae/mLD+kVF0jlxaMkbXBQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 04:48:46PM +0100, David Hildenbrand wrote: > +static bool orig_page_is_identical(struct vm_area_struct *vma, > + unsigned long vaddr, struct page *page, bool *pmd_mappable) > +{ > + const pgoff_t index = vaddr_to_offset(vma, vaddr) >> PAGE_SHIFT; > + struct page *orig_page = find_get_page(vma->vm_file->f_inode->i_mapping, > + index); > + struct folio *orig_folio; > + bool identical; > + > + if (!orig_page) > + return false; > + orig_folio = page_folio(orig_page); I'd rather write this as: struct folio *orig_folio = filemap_get_folio(vma->vm_file->f_mapping, index); struct page *orig_page; if (IS_ERR(orig_folio)) return false; orig_page = folio_file_page(folio, index);