From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70492C19F32 for ; Wed, 5 Mar 2025 19:19:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2D1728000B; Wed, 5 Mar 2025 14:19:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB552280004; Wed, 5 Mar 2025 14:19:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97C5028000B; Wed, 5 Mar 2025 14:19:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 732E3280004 for ; Wed, 5 Mar 2025 14:19:57 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 69916120A5B for ; Wed, 5 Mar 2025 19:19:58 +0000 (UTC) X-FDA: 83188462476.28.4B08FE6 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf04.hostedemail.com (Postfix) with ESMTP id 7304440009 for ; Wed, 5 Mar 2025 19:19:56 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="w4Wt/sTU"; spf=pass (imf04.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741202396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Dbkia67ueSV6cjdkjckzotwlbJdsnWCbOKHIw0ZXs8=; b=2WIL5kseCBzK+Be3s9eJrtTgRIepgVM6d0lMVAxrNFWrCVVbBOPpooaRjJFAI2BxLpxknj p+wOfgbkBNit3OxTE9qwnYG68tlHPEiJv8f3OIkS+eB5Tt95Y0ditkK9YxEA77i9RWs6Fb ngrIX+Li0dgKO07A/GZKDO29qM/gBX4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741202396; a=rsa-sha256; cv=none; b=VtcMjDwe226lta2yVImo2F0Yn810j16cmIoeD95GboINK5GWlv0/5W8ZbJJFkqNEPFo5oN Ox4WvElxrss0NmW1kgLzzNCeZGWH5Ut+gK4GGBr+R3pzZa9R6gYzVzlJifSIkKczFuIwCP 3uX8DKwyZrqVnXRC94N4URqtY5MY0i4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="w4Wt/sTU"; spf=pass (imf04.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 5 Mar 2025 19:19:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741202393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Dbkia67ueSV6cjdkjckzotwlbJdsnWCbOKHIw0ZXs8=; b=w4Wt/sTU9lP0yZfFS/CRFyS9hI9UZqgN4ieXlcdCIIHRCqLP8rzawdXhNxV9hNQmEEdERH SEGB5Y2nJ5fQZRSP4/2d4M0FLBMHARwY+q240VtohaGi+XvRrfx18YBI7iYPesz2sPgbhP G0M1N1Im8U7BpHChr5BxbLP9f8q36Ao= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Liu Ye Cc: akpm@linux-foundation.org, david@fromorbit.com, zhengqi.arch@bytedance.com, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/shrinker: fix name consistency issue in shrinker_debugfs_rename() Message-ID: References: <20250305071759.661055-1-liuye@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250305071759.661055-1-liuye@kylinos.cn> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam02 X-Stat-Signature: bsxgkp4nj5wbkz6c8be646aozs61gg1g X-Rspamd-Queue-Id: 7304440009 X-Rspam-User: X-HE-Tag: 1741202396-419077 X-HE-Meta: U2FsdGVkX18JnWahNZmtC3tT1uQQSvOMeuD8Hy9g+q0MgrsFxcJUChh/ETMA24MC1h5VMlF+h8r57P2JDdWrgg7JDSIPG07T6D5Jbz2EST88x6CNJinijbAAiHr1164dtS0SuJPb2jDU5+CQi7wu4uoy4w7Fqie5e8ChJ/qNF1RAqIiU5ShaBQryh/QTJGsQSpgjSQ5o5tso/qJwb2rXvLYOKPzI/FJpbvxVecYq4s0pgQ28sB7cBTuMtIR3FnEMk0hxqxUcX9HqRWmVmMSTiBco4acEq9ZyUq5XtdgjCIzhlDy5J1DuoHl+o4sStwVUSyo0aUywpVe8Fdi67LQsxVnWX5pMFplfDe1zYlUaX6/5/HUjhwwpdFf85coLbUxQNU6MiBT/RY8Dh0+/N/ueMGitPXtf2tXUO+vVP+OY1v1BmEj+hDvZw82+eqibhUSWsvsy5rlQmXD4hvMBBdnLQ50xsDzVywd4YY6PUn7D39q3mwxIfkJcrOVxf0qz0Ksja3nWM3Cqp1amUpERNnf1c8dPEP2fShKloA2AS9xD7D5XNliZJk3BVQJLxv/LsDr1yzqONpAcUOU813GsfBufcbo0LxjhKmDQpYn9nRHxTjqlXfAvgPu4snbr0AGYGHi4q8XX2C9mKdbjQkbWhe+nm5Z9grysm2OOSkTGER8gwMpdVwBIVHiTlHIY6Ri3+TMAVgJIvZtPNNK7DQ50f77qgFM8BtJSVzHPJeoEcz6TtYM7EcNOoXgInsJPs2fER4NiRY89f8rW7tFZTE4TBQWUEix4lOhfcvYLIBBXp9FvGxvRv32Ok+hZxQthNQyIbbSQPXlDleKo/dYhkv4BvPU39WMvd1Pq9st5xbtPA2QyMroLNU3q9NqTdk1p3gibaN0rIDBKNfc3fm3z7kWVe/AWYUY2xLr24GttmlfqoD+q77AEmWFGYc9ESJLK7rCl8S3ow44jjmVY+gDRRKOghx/ 9HQT7P+T e/9mZWIrflrzwsr9S3BSoZ13iWb9wXsn3eo9rq+dXqg+UoNybGEk15Au1KhqZa5ExL8GRvwIH+Liuy78kqhO47Pj9y2dihE3V9R2Mvg7mKoiqe6K3AwROglFC1jUPgj++K4I+WnZiXO5/l4BqkrfjTH+b9S9bF0tDs095LzVPRoI+M6izTD/RI3nytZFSfNZEqdK1m+vRMVH4UEf1F1nRuUWLZwWxYgw2V9tlZxLR7l0cdVm/z964aOe01XmrIBXPRVX/elSEih5M5BmVgaf6qN4nSvgxUgHfceG2ehjdNnxnnqyzq1B5qjecn784EneZLXuicz60C9//XXuVPUIw+83Zxh6FjRuw23U8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 05, 2025 at 03:17:59PM +0800, Liu Ye wrote: > After calling debugfs_change_name function, the return value should be > checked and the old name restored. If debugfs_change_name fails, the new > name memory should be freed. The effect is that the shrinker->name is not > consistent with the name displayed in debugfs. > > Signed-off-by: Liu Ye > Reviewed-by: Muchun Song > Reviewed-by：Qi Zheng Reviewed-by: Roman Gushchin Thanks!