linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yosry Ahmed <yosry.ahmed@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Nhat Pham <nphamcs@gmail.com>,
	Chengming Zhou <chengming.zhou@linux.dev>,
	Minchan Kim <minchan@kernel.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH mm-unstable 4/5] mm: zsmalloc: Remove object mapping APIs and per-CPU map areas
Date: Wed, 5 Mar 2025 18:57:51 +0000	[thread overview]
Message-ID: <Z8ier-ZZp8T6MOTH@google.com> (raw)
In-Reply-To: <20250305061134.4105762-5-yosry.ahmed@linux.dev>

On Wed, Mar 05, 2025 at 06:11:32AM +0000, Yosry Ahmed wrote:
> zs_map_object() and zs_unmap_object() are no longer used, remove them.
> Since these are the only users of per-CPU mapping_areas, remove them and
> the associated CPU hotplug callbacks too.
> 
> Signed-off-by: Yosry Ahmed <yosry.ahmed@linux.dev>
> ---
>  include/linux/cpuhotplug.h |   1 -
>  include/linux/zsmalloc.h   |  21 ----
>  mm/zsmalloc.c              | 226 +------------------------------------
>  3 files changed, 1 insertion(+), 247 deletions(-)

I missed updating the docs. Andrew, could you please squash the
following diff in? I intentionally did not state the name of the new
APIs to avoid needing to update the docs with similar changes in the
future:

diff --git a/Documentation/mm/zsmalloc.rst b/Documentation/mm/zsmalloc.rst
index 76902835e68e9..d2bbecd78e146 100644
--- a/Documentation/mm/zsmalloc.rst
+++ b/Documentation/mm/zsmalloc.rst
@@ -27,9 +27,8 @@ Instead, it returns an opaque handle (unsigned long) which encodes actual
 location of the allocated object. The reason for this indirection is that
 zsmalloc does not keep zspages permanently mapped since that would cause
 issues on 32-bit systems where the VA region for kernel space mappings
-is very small. So, before using the allocating memory, the object has to
-be mapped using zs_map_object() to get a usable pointer and subsequently
-unmapped using zs_unmap_object().
+is very small. So, using the allocated memory should be done through the
+proper handle-based APIs.

 stat
 ====


  parent reply	other threads:[~2025-03-05 18:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250305061134.4105762-1-yosry.ahmed@linux.dev>
2025-03-05  8:18 ` [PATCH mm-unstable 0/5] Switch zswap to object read/write APIs Sergey Senozhatsky
     [not found] ` <20250305061134.4105762-6-yosry.ahmed@linux.dev>
2025-03-05  8:14   ` [PATCH mm-unstable 5/5] mm: zpool: Remove zpool_malloc_support_movable() Sergey Senozhatsky
2025-03-05 14:53   ` Johannes Weiner
2025-03-05 17:05   ` Nhat Pham
     [not found] ` <20250305061134.4105762-2-yosry.ahmed@linux.dev>
2025-03-05  8:18   ` [PATCH mm-unstable 1/5] mm: zpool: Add interfaces for object read/write APIs Sergey Senozhatsky
2025-03-05 14:43   ` Johannes Weiner
2025-03-05 17:32   ` Nhat Pham
     [not found] ` <20250305061134.4105762-3-yosry.ahmed@linux.dev>
2025-03-05 14:48   ` [PATCH mm-unstable 2/5] mm: zswap: Use object read/write APIs instead of object mapping APIs Johannes Weiner
2025-03-05 17:35   ` Nhat Pham
     [not found] ` <20250305061134.4105762-5-yosry.ahmed@linux.dev>
2025-03-05  8:16   ` [PATCH mm-unstable 4/5] mm: zsmalloc: Remove object mapping APIs and per-CPU map areas Sergey Senozhatsky
2025-03-05 14:51   ` Johannes Weiner
2025-03-05 17:39   ` Nhat Pham
2025-03-05 18:57   ` Yosry Ahmed [this message]
     [not found] ` <20250305061134.4105762-4-yosry.ahmed@linux.dev>
2025-03-05  8:17   ` [PATCH mm-unstable 3/5] mm: zpool: Remove object mapping APIs Sergey Senozhatsky
2025-03-05 14:49   ` Johannes Weiner
2025-03-05 17:37   ` Nhat Pham
2025-03-06  1:48   ` Herbert Xu
2025-03-06  4:19     ` Herbert Xu
2025-03-06 16:55       ` Yosry Ahmed
2025-03-07  2:38         ` Herbert Xu
2025-03-07  5:19           ` Sergey Senozhatsky
2025-03-06 14:15     ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8ier-ZZp8T6MOTH@google.com \
    --to=yosry.ahmed@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=chengming.zhou@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=nphamcs@gmail.com \
    --cc=peterz@infradead.org \
    --cc=senozhatsky@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox