From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45725C19F32 for ; Wed, 5 Mar 2025 18:46:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D900280016; Wed, 5 Mar 2025 13:46:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 088AB280006; Wed, 5 Mar 2025 13:46:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6C45280016; Wed, 5 Mar 2025 13:46:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C3D46280006 for ; Wed, 5 Mar 2025 13:46:30 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 39A891C8C40 for ; Wed, 5 Mar 2025 18:46:32 +0000 (UTC) X-FDA: 83188378224.30.4204F80 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf23.hostedemail.com (Postfix) with ESMTP id EE6A0140007 for ; Wed, 5 Mar 2025 18:46:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CgSQZKTY; spf=pass (imf23.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741200389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ucfgsix0oowqP24fIT+M10+ojZiyuKkeB730wJpBX2Y=; b=OzDeY/w7vP/0rLS54CDs3jzA0GrB4VEA0ZnyQPlhyTVtcHpQwc24z0YX2Gepzzc044dS03 Xx2x5gVi3H3GIoDgYL8OlKbmXZW8b05wlKmSkaOjO1DxGByZ84NX6xef8M3AJClwMXEAwN Yho6Hr2PJIgo95WbNo3zvE/suciyXlY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CgSQZKTY; spf=pass (imf23.hostedemail.com: domain of yosry.ahmed@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741200389; a=rsa-sha256; cv=none; b=iv4KEIkg7yAviomVKPcimJQJlaqqf2KdejCXgPuWUJ99rNhEe2D1HsFZ+u2NLULfhYO2Ts XpuIC7B27XhkIv43k0+GIBkkRdiwcv4Q4WPs9vhxna4z+IC1u4Py384ytcTOI9FoTs41S5 aONJqF4LIbQPRfTJ5Y4WcA5s0gxRauw= Date: Wed, 5 Mar 2025 18:46:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741200384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ucfgsix0oowqP24fIT+M10+ojZiyuKkeB730wJpBX2Y=; b=CgSQZKTYf3TtLNgJK3W72xUGYPzZ7wlIVY/rEvUnO/Rm5xxaFryuAt1j5h0wcnmVOUVezh 9Q90TZY7PAn8rJ31PeCw8OuSrXCsMxLDYy25NeWgpff8/IrUYxOdqBnS7nXNP1D+banfdy OdOAFukMdf8QEJ+96dLXYOzQzF5W6NQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Arnd Bergmann Cc: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Arnd Bergmann , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Kefeng Wang , Jeff Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mremap: fix uninitialized return code Message-ID: References: <20250305172800.3465120-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250305172800.3465120-1-arnd@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: 3ny5cw5tszhoz58smh69kxe6r81zbghi X-Rspamd-Queue-Id: EE6A0140007 X-Rspamd-Server: rspam07 X-HE-Tag: 1741200388-224167 X-HE-Meta: U2FsdGVkX18DYKZ5F8gIauVTkaQGlQBlYNM+xUWIisOuNFX0eDWyAmLZEX/1mTiLrCioRPwtmhDfyisYc9T7nshkKVZqDX7AMKxNrO0N1EB5Naag4++gqQXffYZ/yJ5v/jif/q6FAp6SM25aN3q5jUmZlj1mycFXGroJCtma0S9a3i+sC0l8WnEEIHEFDB9n0gZSPogpSOL9kS8klZ2iaNg3xthhQHmOQxHpiPIVFNNJGyzAu2tWYdDMfQjXj0W4aJec6BrqLsHXBS7RWL8RaXigxVejbmqfmRJwATW0yBcC+h19TxK7JvsYg9RRqM/1vBSjvzcu5ojs5+0D4FyLL+9p8K7z4vrXiVFKTcc6ZRkvKKQws1OrEx1/VoU3wVDhN1aLM0JmF6dk0U0aAWuC94ZXVixk4P8+96OXZNPMYoUGrPhcJbgNDyhYMik+8bOxfUtYAdmDPw2x+gw9+VQCnKLABc3uyRINbB6sEnGp4FUkwL27RcmH4CoI6pghROvvs2ctLJOv4tCsUobK9OQbZKywz2VSUCvMoDxrGSJ3ewX5Eh14DT/d64rOHw1Udw4kizhIpYS04f5BRLjV5zIE2i/o1be+M9e5KI5JUKjDjVJ9YdoSSG2EAPQVIV8FtTSFTbrqN8dxnIsRBb+JIdS30oDVvHsAHURBU/k5tUvs2irBShszJr1Gbbqjy35WmfGRer6AiGzdecCSJ5AicC4Q0D7OsxjdEN5XbSt/uc6DPr3+rLln8RBUsCh8pZ2zmfCK5zgMZ1hYAcUXx5ShXUV6QZZcJqfFdgT3B8D3p9GU5NG6Speu1su5O5AHIO+qQpTB/8ivILCflehKFExM6nO//kNevaZ9C7yZ0+ZlNLUhUkd6kWvmQ3nC42MyIWNRWgeWh0KmUn2mg5yWC//RSh3Rix1Lhq7GYuwKmQSHRz12a2XDirpZurlQ+4bNRpthsyJmbJ1Z9EKdRRv20/Zya1H wWf8hTsy FSyD+ED70gic6Z1Q3hOgjEd0rr2aB3FYg9oOkx9T/ttiDbc8QuWjkWHHWMSPLD5LNFsz9J36aNY+bf+k1lV2Xt7Qc5ii4MYLmWW2gp11G3z2ndEvwiOcpzKJJrEs+nATtwauatrAqX+o8sqrxP6gXYOV7ms7/+Yzg+zAp83hCW/LiC1XwR7qjBo0yRwdDZ6wh5txvP3fkWA3dSIBfvdRKGdjEu7mqIZpPiGKOf44VBhmq49d9N7LI8JbT+tRDn75GELwAILkKZbixb0XTtsoBuPuLjtMlRN2QOxEVrHvCyYXpZMeKudXu+g6V9ZXKZQ8kxShveh0z2Ur2HcuWRN3L4a8/ka5wAwLuSv2nweJzfaF6SkLk2ogMugfGrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 05, 2025 at 06:27:56PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The 'err' variable is set in a conditinal branch and is not > set otherwise: > > mm/mremap.c:1017:7: error: variable 'err' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > 1017 | if (vma->vm_start != old_addr) > > Set it to zero before the initial value is set. > > Fixes: 3129f7896afb ("mm/mremap: initial refactor of move_vma()") I think Andrew already fixed this: https://lore.kernel.org/lkml/20250304151556.635d9041a7ca36f1960fe664@linux-foundation.org/ > Signed-off-by: Arnd Bergmann > --- > mm/mremap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/mremap.c b/mm/mremap.c > index 456849b9e7bd..9c51a2360d84 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -1014,6 +1014,7 @@ static unsigned long prep_move_vma(struct vma_remap_struct *vrm) > return -ENOMEM; > > if (vma->vm_ops && vma->vm_ops->may_split) { > + err = 0; > if (vma->vm_start != old_addr) > err = vma->vm_ops->may_split(vma, old_addr); > if (!err && vma->vm_end != old_addr + old_len) > -- > 2.39.5 > >