From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F434C19F32 for ; Wed, 5 Mar 2025 18:59:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC8A528001D; Wed, 5 Mar 2025 13:59:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7A1F280008; Wed, 5 Mar 2025 13:59:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C426428001D; Wed, 5 Mar 2025 13:59:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A58C4280008 for ; Wed, 5 Mar 2025 13:59:30 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5E8B51606EB for ; Wed, 5 Mar 2025 14:11:14 +0000 (UTC) X-FDA: 83187684468.20.5155516 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf18.hostedemail.com (Postfix) with ESMTP id ACFBD1C0021 for ; Wed, 5 Mar 2025 14:11:10 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=aCExl2NM; spf=pass (imf18.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741183872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AToyKnOnD1v+SUQPd1Fd3I6aomA1OJw/wBfqmGsPzWw=; b=QGf0Y3O45OSTanhjM4O0dHlNh/NRYJA7tpYjwbyxsLieVO/E5PXa0WaAsPCuhYPxrJFo77 RUR4srWNEQEI+MSs+nET3sCjG9WJ6f9OZ7y7kEsBvjp/sVBeIQKFSOCF/cP0iKoaBC4n81 eXC6lvcH+9xwFLNdlEzeS6EksolGD0M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=aCExl2NM; spf=pass (imf18.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741183872; a=rsa-sha256; cv=none; b=Op7oYUnZILOIS4yfkLIl4qXZ2kLmPbNTSafNK0Z1pNS+pOlmzit/mlNV9mPAFXYUF3fKEw H00tFEPLWvBlNyNv5WX9BP2Hk0jshoU8RYHx2WUVLlpMpcMAX/A3q9L6EaQBbf56+DPIm7 RnNGpBwyrtyZqrCF4z3rhEl2PZOs93Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AToyKnOnD1v+SUQPd1Fd3I6aomA1OJw/wBfqmGsPzWw=; b=aCExl2NMBzWUF69P81jOvU4kZr nLZGYt305ctQgnTzaKWUsBISvq9QAmNMl2hV3t/wyfj9enEDfbCHz3yKQeAXLMoLSdcVukekJJyLh AwgbhsKTa1GzAJ8Mncha0FrU8JSSkjQp3pPKdu9anORPCS0oOZ7CTmGu1EjLU5LLSJlA/44I2Rf+o pHk76oxVgfe3SOJRwzucCF/Ji9kkn4g0QdL9kHinszpW0XFVQI6c9EWKhYTpI50COVtc+vykRIhlH jizw3rYvkY9WFCGEaJcit2xbHJudw+madT1ho5GMzw/8pXScAGAQQovaCNFYQ8EGCedvlQ+CdJSRr ZVvP1HQQ==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tppSQ-003zix-26; Wed, 05 Mar 2025 22:10:47 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Wed, 05 Mar 2025 22:10:46 +0800 Date: Wed, 5 Mar 2025 22:10:46 +0800 From: Herbert Xu To: Yosry Ahmed Cc: Sergey Senozhatsky , Eric Biggers , Linux Crypto Mailing List , linux-mm@kvack.org Subject: Re: [RFC PATCH 7/7] mm: zswap: Use acomp virtual address interface Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: ACFBD1C0021 X-Stat-Signature: nikshp4j6hq5juoz5q3f7ymbji4h6h6c X-HE-Tag: 1741183870-186849 X-HE-Meta: U2FsdGVkX1/rdrYcxxZvB/X8TSxp69IrW/vP+OiN/Rcm8Wsf/oTNrI7ljNmb/NszqdZT8tPU2inBSg7zXnG36bPoKWbM+guh+Qyn+pFUjHxPZOnHROuN8MNORmVadHjOf7HyGab9OLmeH9gsz3yTOSYc5bG7e0tC4j8UhXDkRqFx0zPjpSnfj2dBOEyQaki8U1L5SmQMANbyGiu0Fve4whUsNex6xiRazZzb448y+h26rO0sSxBoW95wa8RYBI02dSjx9JGJzdc8dInxoxDMxVTLIaVAEDXG0E1poRvimjfr63k98o7nw6pacHta3QWJw+e/Q04RrCzyAozDuWDhc8QOqHW763q7FVd24nGK8Rkczbp5fjUNx5lZrTGHwyCvDFAXSprcYD3cNogJJuCDCnNYukYLyPoPp9c8ZZO1NanYRHnDyKiO2/eO1vAPLFsbLPaGZdfCcJA3C3thi/sIW2dRirvnUqQD7YkhjKcY2agK2yaLLuvCrPrSSATOAAolwkUQwaynIiJW0q26JP/SqHZa7acauWlZhtgb1QnHt4ADCq7knijSbXbDtL99/2Rxr5RqxN+fzWieJWcBL5UnQGCBdiJwiyKxMUm/30P7c6lyKz2Lh8pd6/nWZSUC/RAigQyS8ueeAKJJ73sEUic2XPQqukbjngOonJ7kKalUch30Xlq/RR3HCMqrJB1YMPISLhzDWl60KrsrwM3cs34O3aTHC3WFgzDHnT4UaYfLP4SXa9Uy45WEJdkUUNyfcgJM9TE2L0lXAuTDeboHKz8BtDpc0WVFwWLgv4edGXHneTnhPkdMRkXDG+fEC8TYEIOkrpIiouN608fOel7a4dQXFzIyYrA/9NoXYdqVFgPNCWJ+bvpdyWuniGCzKabZg8vOXF0Bj0hqOrp1uOpY2bfRZxnSbOLSN881ymTBnW+EovpmfAaFlzsE1ivqz2pD5NRQza667NQjsguQHshHWh/ rRuaVWw4 gmEsaPZ5eOc5zDD5zKMYv1uaLMq2ppoO4vMpXtLoMItCMOmnz73gZpWrZGbQJd8YucgJohCKOOkmgLPdy4n43zWPmMo7Z5m7f1OU9oKEDyy6bKsrov89r6UFSsDoNSPOjOPeWuImwujQyyN24V1kFpeIJUGHdzD93eF2ZD1guJEh/wdhkRqnv+l+yDowgwvcR1joWpHWiBVht3E0z7VSIbftC4Ij9BPyoy1plHlzjTB3Hu1vS2jlJ+boEUn1LN4MiZoxN83rGAdOamDE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 05, 2025 at 03:46:18PM +0800, Herbert Xu wrote: > > > Also, please take a look at patch 2 in this series for another reason, I > > want to make sure if your virtual address series can be used to remove > > the !virt_addr_valid() memcpy() case completely. > > Yes it should work provided that you specify the memory as nondma. Actually you can do better than that, specify the memory as nondma if IS_ENABLED(CONFIG_HIGHMEM), and otherwise as virt. The idea is that we only have two hardware offload drivers, both from Intel and they're probably not going to be used on platforms with HIGHMEM. So something like: if (IS_ENABLED(CONFIG_HIGHMEM)) acomp_request_set_nondma(acomp_ctx->req, src, dst, entry->length, PAGE_SIZE); else acomp_request_set_virt(acomp_ctx->req, src, dst, entry->length, PAGE_SIZE); Of course all this would disappear if we used SG lists properly. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt