From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A58C19F32 for ; Wed, 5 Mar 2025 19:34:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13BDE280022; Wed, 5 Mar 2025 14:34:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EC8528001D; Wed, 5 Mar 2025 14:34:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECF91280022; Wed, 5 Mar 2025 14:34:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C869828001D for ; Wed, 5 Mar 2025 14:34:39 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7DDDF1C721C for ; Wed, 5 Mar 2025 10:06:54 +0000 (UTC) X-FDA: 83187068748.21.1399585 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf11.hostedemail.com (Postfix) with ESMTP id 63F9340003 for ; Wed, 5 Mar 2025 10:06:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gMiU1piC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741169212; a=rsa-sha256; cv=none; b=dkEOai+3LYCAKsj9LnAcyM7wJ5wxZBl+RUsUuPnC7GupJSZhiTFKo8K2oh8itVC1K7VWmH X53qocjcNimFvcboUjgwMiVtAREQeMxXiMyjyQnkN6VJ46EqcTNoX64JIV0gEz5KqfBoYe LKFzDWOyyq4N9A3MrLbDIXVXzFhIMlI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gMiU1piC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741169212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nz0m9XjljqPblAse0sZQMRClnBy6VQjPdVLGpt3wUIM=; b=H9Eifz778Ybk+2iHcVV4DbzPb39jEMUGIbPBAZw+68KjWWP9/M9qlWU+lUBvjLAqYq15pR WSSWJPMI0t9bl48PgBkqlvIuFlKy2mvb2OhAfrxd/X8ghGPvavgZhHVmHGfIQZXt5wOD4Y Hy9tBbKOE4QEQ+CJOKhPCu6PlIandxI= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-30b9f7c4165so39688111fa.3 for ; Wed, 05 Mar 2025 02:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741169210; x=1741774010; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=Nz0m9XjljqPblAse0sZQMRClnBy6VQjPdVLGpt3wUIM=; b=gMiU1piCcKG9S1KJ1C28fSPoreSaW8HUecTAVq1lZOtH5QumHQ7B8ESJGrgPP0hvCj i3C5hSOWmPFODeL5hUEUsQ1XKh2HveOyAByb3zLJd35wMMuWty+4BCK/8wPlzv4TJXVb VioXVQmwtHjvdZf81VCMv1BV5efrbFPwGj5zZduyA4nnq9TdWFzfvLg/vpAOja2UPS0w D8mnTzyqawRqTpqnv41sTdu2yU8u0RFiE5nQik9xqg7TjjBQIfmraehN/ebpR1mEa5aI NOcOfg0yK8o6WwB1o2t/tN9mwXyxHlxX8DThNdWFYHs1bTHaLG8dJryExLufqiI6xPKp ZbpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741169210; x=1741774010; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nz0m9XjljqPblAse0sZQMRClnBy6VQjPdVLGpt3wUIM=; b=W8Ay0fZ8Es8dma/Xl9HBTWlEX8KIXgAfhU+D85+gW8ig1oE36V3Ozvttw9kmjh++CE Cl4n4XbVDdSCO8pekQdy4je0L6gfTgwwdZJDcQ361jRu/a7JWGu9gcPNd6jeISnHjBgf BStzxBvhUtVVxL2dKF4FrkRA1uiIcOKht13xYmpolKI117o27e+p2DzLhHeWz0ZhlvZy WXKwP+b57mX1EvXLk5zCHP7uU0FXiQYrt3ZYBUvUfvBT60c1Svz74u7LbqlbHYB8af43 U7tsy/Z5YIXnF5Q97olLYXMnuiWvTQXh36P2flP8oJpT2DnMurQBvKdU1czdDrPhuA6f UKnQ== X-Forwarded-Encrypted: i=1; AJvYcCUJfDB1noynYooj0R3uId9IH84CSpbNOqxMHFjrj0v9IfP9UMacg+jwgo3tZQOVsFubBr6lSuDXig==@kvack.org X-Gm-Message-State: AOJu0YyrZLmwcdAwwELFiHKFRNybdszsh+ewE2P2iVDXPOK4MiHhpZBn q7dNND4lLara4Qkrz7q3AAOCHJOVq0+R/C/UX6K3nTpFYqud1P1m X-Gm-Gg: ASbGncvTXt9hmOzg+XNvxeiwqpFaUlvsxSIW2QkQE1lWPlmVKRdRKbLt0iePHd/0ieT 8+joX4aqyiHp0VcXNSO1Vlgpln2LCpytt9Lnuf96HQxhCCNcnO7165b1LWrdAEB+e8dKvjQ36CR G6Fmo/zzUBAfqa/i0uHzceIEyl9lfEgArOs1ePD+6SI3N4Xa1ZnijB568I7NFHRMGiNbHcExw1q o02F6zgGFHaaqjNDnlxOucMvTTlBM6YeqpBxVoQoY1Bbfm9CuHGdd3+YeRONsSmXsFKxyB29yew KlVPEB+DFcHEiT1HgbccpfqF52BYkYCvLxYEKp/EKNQW+BEp0XvuXnug2qILTvyqGaw= X-Google-Smtp-Source: AGHT+IG9+VyiFJ8Bg58dftnhDOV3AWLXhGy/UlIQSuO5xKlJiv2sStd/Ls9bdEQrSRkUxRJdhxXgzA== X-Received: by 2002:a05:651c:9:b0:300:3307:389d with SMTP id 38308e7fff4ca-30bd7a583ebmr8662591fa.19.1741169209563; Wed, 05 Mar 2025 02:06:49 -0800 (PST) Received: from pc636 (host-95-203-6-24.mobileonline.telia.com. [95.203.6.24]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30bb1098ef6sm10975301fa.42.2025.03.05.02.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 02:06:49 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 5 Mar 2025 11:06:46 +0100 To: Baoquan He , liuye Cc: liuye , Uladzislau Rezki , akpm@linux-foundation.org, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm/vmalloc: Remove unnecessary size ALIGN in __vmalloc_node_range_noprof Message-ID: References: <20250303094410.437985-1-liuye@kylinos.cn> <20250303094410.437985-2-liuye@kylinos.cn> <6701d375-8d7c-4e13-b0db-486a48088446@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 63F9340003 X-Stat-Signature: 6ybi5i64jjqcwj6e68arhksjh6hyu4wb X-HE-Tag: 1741169212-108436 X-HE-Meta: U2FsdGVkX18EtMs2DL+JK3mD3g6ZOSdPGLiKJOIa2uWykBtx9mGAQp0JOIUpmN1Ok/x0/23vgNG1U6BfGE+DBCX074MjSd7enLgIJRt0GFM0Q+wlvCIhpfHVg+6Ocz6FQ3s5cNjL4oK5hq7SojSotNKGYZHusM8VQGqrW50rimYb0jV5i8jgwWPUEqdCZEyr2s+FgidX/PtknhBc2RbdZj7oC3pLv/ZCnkyGu4RkchLekNpKALlAx7gn9qGJfgHk+oN1Yfo43HwuW7kef1W86dmY5QrFz21T9/pJThKPxxfO0oerZpbhGf0FuThE3eivZ9qsohAzgIZkr52Hl+o9Nf0T5LzyQZyQNIw0hRePUXcL+gbFXTZnW3tJ6Sub+xpkIFqOYSTTWBC6SSW5DGdxLN/6aC2WgSPwTou1Y8VnKSdXGtm4ztaW0qxFt/fv1oENfOyQQrKEm9swLvQxJkVfZA8XDFRkoOzsyra2BODLsOwVgO0OtBgSUqg/OfNpUuZLUlCKuEUkZzFEG3y1wXNy8WhHCY37ar8vNSqoax4pWU1Cd5jCtqs51P8qHZhxR/+Lyyb342S3WEiWKOFhwbAnZO38OGoOENvHh1zTxl9ppdUR+7OkP3agnAVvioWV82T8Y8qAgDquXTyDQh2DUHrZlAQRHgiPXveyQZk5zE+m7zl952FIeEWwlRWrA8aJfVUB4E8JV7FPUk3q/64nqKRf1L3Y9wOXEn9zGmYK2hS+cEOP2KjLk/iemV7yU0M21lyhbIlCsHgPpESmomj3yFWHRpdiGIrMvmWFMPz2UMn92oR882LCnboDp41e3uZ6TZ5YILnWPUNOb3o4sJiQ8poWSjDfn8f0cMmXwZC+w5OFHFyDfIYQKAWPElmOerwfGf9PhJyvjJPzXcsn+fmWDZdYdr2Yg4eKEEZLc38zTQGCWrH+Tbpe2is2b7rqaBm+kQHRWk/zddCn1aRfipCfQSL PbX6ZNP9 7qeIW2jIAa5AzFa69nTvf0majODFCeiq5VzMy2c+psBppMZq0HGGYcGvkSGnfPn9xEkCDOkKpW4AvvIr3uzBic5BNTI5EspEdgd3a1QcUDLJIb1FCZGwY5iyWPs3sB09Eqc7Hf6eNK6tL3lpuXmjeadlxq0XeCvNqY6ApJSxwLt9WhKUHFWbGRa/e2+Ps09gh/fi0j07WsktJubB1kU4J8cAxCUH3vuzsErE4aRy9DBfAo+xczpsugJgFmQmxN9ZeI6QwP9R95ZN3bkk69Hri0k0gzDkQ2fbJfq7DmgEtiLpKd9xHDjuijqkMD9Iya8zIdKHPixO7E0L6XQJurarCIT2LJPUlO5BIbFDTL3bMehH1nFxE7HiPS7dane22nui4oR1H7PXUunwNzvfJ4Dd69pD1ntK5KZf2hGmY0F0bZ36PzeXLoZqFBgLuIWRntGIGL2c5ctdqZYCQe4DBbjW+OMTM7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000097, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 05, 2025 at 06:02:19PM +0800, Baoquan He wrote: > On 03/05/25 at 09:46am, liuye wrote: > > > > 在 2025/3/4 02:30, Uladzislau Rezki 写道: > > > On Mon, Mar 03, 2025 at 05:44:07PM +0800, Liu Ye wrote: > > >> The same operation already exists in the function __get_vm_area_node, > > >> so delete the duplicate operation to simplify the code. > > >> > > >> Signed-off-by: Liu Ye > > >> --- > > >> mm/vmalloc.c | 1 - > > >> 1 file changed, 1 deletion(-) > > >> > > >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > >> index dc658d4af181..20d9b9de84b1 100644 > > >> --- a/mm/vmalloc.c > > >> +++ b/mm/vmalloc.c > > >> @@ -3798,7 +3798,6 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, > > >> shift = arch_vmap_pte_supported_shift(size); > > >> > > >> align = max(real_align, 1UL << shift); > > >> - size = ALIGN(real_size, 1UL << shift); > > >> } > > >> > > >> again: > > >> -- > > >> 2.25.1 > > >> > > > There is a mess with: > > > > > > unsigned long real_size = size; > > > unsigned long real_align = align; > > > > > > "real_size" and "real_align". Those are useless. What is about: > > > > Sorry, the order of the patches may be misleading. > > > > The correct order is as follows： > > > > PATCH1.  mm/vmalloc: Size should be used instead of real_size " > > PATCH2.  mm/vmalloc: Remove unnecessary size ALIGN in __vmalloc_node_range_noprof                  > > PATCH3.  mm/vmalloc: Remove the real_size variable to simplify the code " > > PATCH4.  mm/vmalloc: Rename the variable real_align to original_align to prevent misunderstanding > > > > If PATCH1 is the correct fix, then consider PATCH2, PATCH3, and PATCH4. > > Well, seems the patch split is done too subtly. It's only about the > size/align inside one function, maybe one patch is enough in this case. > My personal opinion. > I agree. One patch would be enough. -- Uladzislau Rezki