From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9400C282DE for ; Wed, 5 Mar 2025 19:33:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4265A6B0089; Wed, 5 Mar 2025 14:33:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D5496B008C; Wed, 5 Mar 2025 14:33:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 277096B0095; Wed, 5 Mar 2025 14:33:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 057126B0089 for ; Wed, 5 Mar 2025 14:33:46 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50C80A1A21 for ; Wed, 5 Mar 2025 07:46:33 +0000 (UTC) X-FDA: 83186715066.15.DF6ECB3 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf30.hostedemail.com (Postfix) with ESMTP id 6918D80004 for ; Wed, 5 Mar 2025 07:46:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=qe+eWC4f; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf30.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741160791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7lxQGJWnptYN6UJuItgLOi8alFXoRtXtR7MzeGJQRmg=; b=VEqCuWDwiPOK2+zn/dHsNFQPPQnw3IJX4VrFm9jrishZwD1cZi/Sh5/O14VkIKndEmfPtV 28ujFAWsrQ8WQQFoaqc6U82LGCZPB2NFQT+a2H5DNMiKvPeJ7+8Tb5Qeh7hrnNQpdEooCW YXGPCGUW5wL9heM+xjWZMFJmQvJms94= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741160791; a=rsa-sha256; cv=none; b=UCMYFA73uVS6BToWmXIVBB1O5bmP9BgwAtVrVtiKGuZ4OzPuID3Srl1L/0IhWX8jl0ciW9 81Jz7/iwXjQtKVSUYXDtY82jxnlZrf7qjRB8hUPjaeFmsK/5v8WgZ1fUws2HQTsdSmPisJ pR6FCrfEvBcd/8pwdZcTFJAjpFEKPv0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=qe+eWC4f; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf30.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7lxQGJWnptYN6UJuItgLOi8alFXoRtXtR7MzeGJQRmg=; b=qe+eWC4f6x2IYkKkc+nU+IYq/k pzd31Tex4VcnHP0W5MTbJxjFiALMM9PlcJPtU5bu1iBRjKfHFpePibNeNKDMLbWTKqjhcKeY4Cwa/ L6ILmIRrjd5gB9Go1bL3qJH+QcKdw7yGPByPA5wi5VUnJSU2ybc0VDxfZ2fbDI/nk2WewAv9Q4klx h32bSitkn1/otCUcy0PvC8RStgIrABoupRZkl94hXpI7AoahRMGdLM2Uvj9I7Fjc5c3zRPN5OvqKU oPGTuCB4KW+G8C8h4vD10HXBu323DYLYH2P/8HH1iYcasd0EZ2pn11dxbHz8QTYKpt2Zyo94qlvkB S45N+g7g==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tpjSM-003tvh-0I; Wed, 05 Mar 2025 15:46:19 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Wed, 05 Mar 2025 15:46:18 +0800 Date: Wed, 5 Mar 2025 15:46:18 +0800 From: Herbert Xu To: Yosry Ahmed Cc: Sergey Senozhatsky , Eric Biggers , Linux Crypto Mailing List , linux-mm@kvack.org Subject: Re: [RFC PATCH 7/7] mm: zswap: Use acomp virtual address interface Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6918D80004 X-Stat-Signature: h7gqt5w8idf8zmbu8x61cddwr68bdoc8 X-HE-Tag: 1741160790-602272 X-HE-Meta: U2FsdGVkX1/zobrsilwHEWMbhINJRiX9Vnj+zThLrUJrkP/vRcc/guP0/oMqygv3qEtNB20aprZAjUkQ3RxoVcvoBD4EZf9abPhUsgfwDyZvwhMLgJv9LJ5ybBZmP6eQQWM4HAYpVOtrFoj0ntIPF8lcDNm8qwRhKlf6jyqcQrmdqYtxzNxYRTOyynTv4M4zDYjbHS8/E3OF5p7XJPiVvQ8MWFGBV1Wq3kN0up04pVBCdANH17VhYIF7XfAt0+aYXXncoijTC29bu9sruN1XJzLaUm1h/wC+auvlSNf8u1grvwYo/dcJPLmEsBw0JVjGt1w7nvjVZn900ITqc4p8ZT6kE2Gs1M2cAUbVJNHwX977DHeCw+XHxiMhgC68pC2mjwBqfLiQwAsYGbJoFepOrpgMQIWJVxeO/Xwb0LUiG5OCaotLjhpetAbzn/rhOYjuUM7IyRi7jeYHtbxR/OCKivAJ/Fzv94cJf4Wi1t7LnsqogQ12N4TzLPt9+MvriCF6HKeCcjiKhL887bw1wVxuzo1HZ07eWNBdBzn6bGkJCGBPmDVWEEj2heFTQw/EquRM8PYxcBd0Y2ovcIL5LpIWaSUp0u+BW9heRGjrdGFYawSCcjpPgs4fZO/xA0MdGGrSJpqDZasjC8pcUUd7klD4of/SScPzAuCEXsBGTr+usumK2pR4FtK+ZjowFlzmPyvpns5DKdTyJCh0nnRV2DQtRdYHyKDqsMYLl3AEUlYZqTzpUoske+AV3hId0AXLVc4AY/Wvv2SC0fy4+OIuZEmqSiXTmIfAO5I5HW+8KREnjc4zqSiDV7NhJQNPtStPppLHbcHmpOnfZzDw1zZ5qC2Abe5FvTD51dwqUfbUixuUQjAFsWf+F3K5Wvs03IImoWssxC2+bp3WYrVQm80WoLPUVbUgSOY+3/JF8uYdrHF14XkFPTR9ou4dyFxbblvvWbBktjFOVvvEoAnjWLF3VMX 3AtxzoJa E0wDdp1yRivFPgFVkE2TNHrZYmc22aes6FL0JzNH3Byx3H63/BsYaLRXGce1WE9YyxwgnMHKIgpe5P6Ix1I6fynNm1wr7FBEDS8vfEMzJB2AYy4sb7uAoj6/l6a6mi8ij0qO9Ky9KVkYYOaESIV7Jtm5ARiXD0cmRaQUSbu0GCmEQBTD5nYYRkvplMFYzxiNYC5/oKUIURcjOsREuX4ZMy/uiq2ICBnAjg2Jq/uw6qacoXuNqd/gU91baGS7YLNkJtn4SLvp0/xZaEkB7ROx3a3nqB5wkkUxs+l22 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 05, 2025 at 06:17:01AM +0000, Yosry Ahmed wrote: > > Actually I just sent out a series that I had sitting in my local tree > for a bit to complete Sergey's work and completely remove the map/unmap > APIs: > https://lore.kernel.org/lkml/20250305061134.4105762-1-yosry.ahmed@linux.dev/. Looks good to me! > I am not objecting to switch the API to use SG lists if we intend to > switch multiple compression algorithms to use them and will completely > switch to using SG-based APIs in both zswap and zram. But I don't want > us to have two separate interfaces please. Fair enough. I will wait until crypto_acomp can replace zcomp before posting more SG list changes to zswap. > Also, please take a look at patch 2 in this series for another reason, I > want to make sure if your virtual address series can be used to remove > the !virt_addr_valid() memcpy() case completely. Yes it should work provided that you specify the memory as nondma. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt