From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097D6C282D0 for ; Tue, 4 Mar 2025 23:32:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77CCF6B0082; Tue, 4 Mar 2025 18:32:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72AA96B0083; Tue, 4 Mar 2025 18:32:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 555B26B0085; Tue, 4 Mar 2025 18:32:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 372016B0082 for ; Tue, 4 Mar 2025 18:32:57 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E0EF7120714 for ; Tue, 4 Mar 2025 23:32:56 +0000 (UTC) X-FDA: 83185471152.03.F0DE5F4 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf11.hostedemail.com (Postfix) with ESMTP id 7B35340003 for ; Tue, 4 Mar 2025 23:32:53 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="aIc1m/pw"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=tsi603w2; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf11.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741131173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qm12ZzaYckjjlc6sS6Ju/cTbV3TlnumQ0Sq9bOwT9v8=; b=UlEc7rFCaw4RMC9qmI7CMchQR9Rxv1dPkE+w9GwNTy6BFv1eN4wY01ezqM7N/iuRyIkoZ3 QutcIKUOqa/rt3EM77L4EmbEr3keqSPxvE5uT5XXgYTz9VRF+4TS/pkAplcyUaiX6M3owj ZTQFuc9+5Sp3pQNm16KtHOP2VpgEhPE= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741131173; a=rsa-sha256; cv=pass; b=ESDEH1SDh0krGmWibY51dejcO1ADfHzgGBUIk8xnCu9oIP50yOvCEdGjfxSxWOyzPyzw1T EbzDNbhkzf800QYjI+PCJNM5BJQZmy6hn/rHOlFOyQvQiSuU5SuiVvJz7ejsS4jpE7JzrE 5R1SZoFFKA10qxKlJHZ8wXAFho0C278= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="aIc1m/pw"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=tsi603w2; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf11.hostedemail.com: domain of harry.yoo@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=harry.yoo@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 524Kfhe8024281; Tue, 4 Mar 2025 23:32:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=Qm12ZzaYckjjlc6sS6 Ju/cTbV3TlnumQ0Sq9bOwT9v8=; b=aIc1m/pw8XvCAwhEeHb6SGyBt9kdMgiQXu y0AwgNicb0BhPUCi/U2uZfU1TgqDFew6b4nNkjLziawTdz8POC3+fJZMIKak04Ce IsvKinheU8QIiCDLeQZcCyCof6MOIXJCa3JAi4Csr7HJIRDNuJUsRqqCnVDAVyGM 2nOpqjdmM8EVwUXIfbI9wQXzYB0LrtslSb39Z+0leJcgJ4YTK4+vZbKniz9wLYgM KxbYROFTumVi6tcEK1VFDKvPLQYT3IEMtAVoeBzKE0AUoKlqL/z0m3ecQHe8Pkgn FocloojV8gkF0Qbr11Y4krJ/lvCh+Bg4XbBpurlWXx12pYinA4rw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 453u9qedmc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Mar 2025 23:32:36 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 524LKPGk040417; Tue, 4 Mar 2025 23:32:34 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2048.outbound.protection.outlook.com [104.47.70.48]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 453rpfwrs1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Mar 2025 23:32:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z7NWlYhSZvVW8ByGO5YZDLT8J5V5bBSmcHMWq0LqAhxvflv+F9/x66nDkiXFWrjWD9yBJfIdUi5PcAbOju+3Gnl34SALVtBykopx1CHFV8Ew6TTu2D1+USj+pny0/cZhZgXjDbq6ApmlvdIaDScAg2jV+N+hYwcsNgDoebTqGB4AALR7kxS8Bf6c+naqhB870U7jglyUjtjJc3nev8Vfp4Aj2BX9i/Xm/0lt4AI09r9pWGzAqOcixWBWktORgSlH9Mn0ZLto8HVFoQs/uWiKmo4zJ0IVS/+9bs1JJ362BiRFFKxBkytLRa3okgQeaxmUBCRRrE+Hg4GZFnuPLgZb0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qm12ZzaYckjjlc6sS6Ju/cTbV3TlnumQ0Sq9bOwT9v8=; b=WzIRRy9ibey1BBrfPOW4kEgq4GyUeAPg5G+8N39T/oJKImLML9yLmB9w/88d6KNWTdMnavEUCdsJf5yWKFljySovRKPcTXct+fkcbNj7swSs0hbn8s6scVmpMyDHBedUwBMxmXsJnqD2xT4QB0utHnYC6TTWEIbYD6v8KmXWH3yijZhsPK7yPSOGYRSbze9VI6chULpBnOhsxcpgadrCSF1XGTCQQCcQwVsLrQJa8Q8di5ubYTOrS0wumnGQkH82jKCgQSwKExz8xZgVV1dir3+iDoiM5MO45riTA81xdzHBpYWOWXqJmL1Ca59Xyg7dDmbYq3YOn/NOnvaHm9sDfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qm12ZzaYckjjlc6sS6Ju/cTbV3TlnumQ0Sq9bOwT9v8=; b=tsi603w2cG3YgRcpm1m1IqsQW5/gGOwAFrtN9vGWVJCCpTVlmpT+rHDpywrrLCQJ2I/leG1FWTdj++EfbiFdpDxq3aSuqxGu9bDuEVqEEgW538h7JGkx2ePLDyAatteeIqXoqj2itncXvxp6xeO3zFfN7ljlBFjeERx5ixUTYxI= Received: from CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) by DS7PR10MB5199.namprd10.prod.outlook.com (2603:10b6:5:3aa::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Tue, 4 Mar 2025 23:32:33 +0000 Received: from CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23]) by CH3PR10MB7329.namprd10.prod.outlook.com ([fe80::f238:6143:104c:da23%6]) with mapi id 15.20.8489.025; Tue, 4 Mar 2025 23:32:32 +0000 Date: Wed, 5 Mar 2025 08:32:25 +0900 From: Harry Yoo To: Vlastimil Babka Cc: Ye Bin , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, linux-mm@kvack.org, yebin10@huawei.com Subject: Re: [PATCH] mm/slab: call __kmalloc_noprof() when size isn't builtin constant in kmalloc_array_noprof() Message-ID: References: <20250301083720.380063-1-yebin@huaweicloud.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SL2PR01CA0005.apcprd01.prod.exchangelabs.com (2603:1096:100:41::17) To CH3PR10MB7329.namprd10.prod.outlook.com (2603:10b6:610:12c::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR10MB7329:EE_|DS7PR10MB5199:EE_ X-MS-Office365-Filtering-Correlation-Id: f1c12389-932b-415c-0a8c-08dd5b74d617 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?MVoQf+e3U+DwRGIaErutydcVGJ/1vqBpeTM4nrNlZUipIdkoZPXGoGuP5y4T?= =?us-ascii?Q?sD2qmrBiPjtJ9tzhJf2pAhwMPb+jRSCYy8eGBOb+g2PpR5JUd2VuIuJ+Za6O?= =?us-ascii?Q?m7sq78IrP+3e1TaxVndBWdQmbooYRxvzTzofnQ+BffXYBhi1TSF2CR0CxK/2?= =?us-ascii?Q?fjD+iFxbfY+nta3rGMXnV8UHeqsbKBMIbQgiaNUbf2ki04CkbZMKdhEEd6DY?= =?us-ascii?Q?GlEHGIELZFLXPY0/t7ZERNrEcnD8xe2SBNY70aB8bMNRFANTsCsbLA0gmbh5?= =?us-ascii?Q?sDN767AaKJbTk5cj8xABnFvyVoumrHrnWLARvuI0qx//E9la1gh/0Hbwk82x?= =?us-ascii?Q?PIB1oLEk8JZ+W3oRbHFCNzbHx40DFkWDq0/4omK9ZlCeZJHLi1k7x5/mwgkK?= =?us-ascii?Q?TghBL1O+dqI3NdPk5GLVh7xeyAwueppMLJiQaMZuBDAzoYYLAaxatGhENgEY?= =?us-ascii?Q?MNo49EbQd8InIpf91cxMEctPZ7PhQIVlWdXy4XF61Ig+ErV2ux8illLeFWKq?= =?us-ascii?Q?spwQvWY3L1jscmYy/AFLVCUOAWipL5ZWAxveCTOb8L74fu36YYqD6/O51PD6?= =?us-ascii?Q?7LV+Jn7RHOyKQfxNw5RSKIMytVEPMlF2g8Fm8YVRgwUbS+NbeSmSHYz3ZhIp?= =?us-ascii?Q?jTDpGDH1F2VC96mMsTfOPiHpREgASS8TvT5U+kmr8//j4TzB999Xb3KFOSSZ?= =?us-ascii?Q?SyXnINh+b3soq53wA1+aYKtYONWRa7qi+YBfbp0kAszwo2LwZaVKX0GBVmga?= =?us-ascii?Q?WdYQ7y+lYtNU/euA96l/cUSCwaO+5ZRXqnJ++7fzD/ULjQFnu+o5kujD4aOR?= =?us-ascii?Q?rnBBVqNecimEPWj32nAUU/OPldFdbCOu0RIg+5q9zu5lZpVg4IcGg/0TQMG9?= =?us-ascii?Q?4s9vbBEEmaZi0xZe7UXa12LoNilpacSdKRZJJNaP4358Jt6tYgNZbOwpYa8v?= =?us-ascii?Q?vtTVx7gVapUZyZmi8boi66tIccscgs+MX/kdvpVExlzZQx4znpfy5EAIziq6?= =?us-ascii?Q?7Yye4ELq1e91Hci4yTO6K5gwOcA9zXCz8egOQNz/N3EvnZCKaRfbCoRW6Lsw?= =?us-ascii?Q?PxK6CzLxmmMdbyAMMNv/kRtaUzGhJuP25RqBELHEQJpc4H7S7padkdpnrNKZ?= =?us-ascii?Q?EpRwFTBSXHJag/A9f9gaVEqhKIUjeqcj81Y1A8B03DaWWjvGkL4fYDV5YigE?= =?us-ascii?Q?nsy//d3LEy/4ufALIP1lwd6AtIJe52IWFEfk3zaoRlwgVKxtSNgdr/tsAtPP?= =?us-ascii?Q?+A1nzHsVqsfUy7AS7XOKv0eHuGu6Av4nX9W5sGH1weKgMN/bie5FZSkYmCCS?= =?us-ascii?Q?0b1v/ejBm2ujza+cOpNetFJhXyRjU3UfNvQTRUQBZc54DwQe9UYN0BejraQf?= =?us-ascii?Q?VCXWAfCd/stzfwDgTDnGwEQQjT2U?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR10MB7329.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W/sVTQz2wOifxBqsrkJvaXqBo5UxlGyDBEzhBb9gUBeFK6U2K2YAseM/Vr7/?= =?us-ascii?Q?Uk2tyqPxbkO48Q816X+PDTAomWVjPIxFEfMVnsYebgP8DYAHxblPSMcgAQCM?= =?us-ascii?Q?zBy76AdMSXGzMztGRnPmTb1N3Hw5w/UvfSenAuEeIkQTwAsdtW2CSfYCSxXf?= =?us-ascii?Q?8RSkmJGck9nGej7kllrU9SLqqogwMhXtN+6pXyYXNyN1PKuVcdtf8RuQoVXH?= =?us-ascii?Q?V/24jZShpRkV2V4/NjHf+v7oOkkmeZHRQwNsFpfznwULQg3Qmd8Qr4QgFf9Y?= =?us-ascii?Q?pOuUUGmrUiqirN3a64g+0XmlFc3wJ/hLZnaEjU83cRLVPCMmSoiTG7VzG2ue?= =?us-ascii?Q?BcfLIOAPADF1OfTDR35MjIWXE83t4ubqQcwW5nHiV49ViasKT2CZZWFKnaEB?= =?us-ascii?Q?Xbc5VuNgLcXVBTjBV4JmbMjDm6gkmn4YvalGqj4mow2o7aalQWwoq+03l8ad?= =?us-ascii?Q?Q87p0kHBtmDfj6aDQIt4J56teSAEwWhj/aYc+6fvCvRocoTg9wQTOzS8EDav?= =?us-ascii?Q?pz2vsGJyXoN9qFOKqU9RcI5KUfkzeCunsc1uej1MBpotv5K5y+iOkgf1vRp1?= =?us-ascii?Q?i5nukj8dyU9/NrTBBnM3vWbqwCXMbqm9G5g4fVzxXo+IR1c80Vh0zE6Kgpyp?= =?us-ascii?Q?t5W8lIWzmLOHAgFV7qxm77yA5tdY88YEm/96knYkJUtmCtoGb2b/El9tM4rT?= =?us-ascii?Q?jwmQwfKZEBmB0r3TUjdfxYb8xaCs2bOzWwhYLuxHaodL+qeXfLXWkjQD/s8Q?= =?us-ascii?Q?/eJwCetTKMHP3uWr3AycplOR/HzmleuktBTJifWZm8JzWhARwUYoM4FECtH0?= =?us-ascii?Q?PLnxKl8zUTpGapwtoNteKYG6PDiFkhBUQmErzb/WhofgN2LXd+JxSwiHlD14?= =?us-ascii?Q?vL6VZvTmZ0nh43FFFHtRo/w4Osu0nC/t7L5Ml74iJyxz7yTRLFTU7IQZMWPv?= =?us-ascii?Q?C0gYDtButmlxJ48c7id7NDdcgkmoY23/njKVNzoUikoPepIcUsC3cI4mB2jT?= =?us-ascii?Q?f+IQ51vkTOSOB1bdMMjzv3bHU7o0AvvQHYzXFTyR50ooavk65LIwdn1DNkVn?= =?us-ascii?Q?IuphOV/Ef1ol+GqAwCXcND8XWHzoVHdhtTPFkkQ13jPFC645FLoiWeljx57V?= =?us-ascii?Q?F1q+R+Y35SFzCYSgViurCN2dKDOWJXsa7amUcYwnmIgT294Nr/XP7/cDBDFo?= =?us-ascii?Q?Mn3WpfF+9sw8U89GW6vEyT/vQo8Kt2C+5TXUO2WSNffgkEncVAYnGjJo6peO?= =?us-ascii?Q?21tddcQksrti5enCJ6aieMyfj05rLx6am7roDEDOA4j/LjKhOK2BarO6mpEe?= =?us-ascii?Q?FH5VNgBdEY1jQLe1stMrFRdnjnq0DzFVa3i2AgvLn/Kdjf5IC84K4buGD1OO?= =?us-ascii?Q?aaxnp2EWXW7HGAj34f4N+/onUH2qnVM1FGYwK83hGOVCOYib2shBhPQCeFNi?= =?us-ascii?Q?l2BOzTGWBdHLBr7JpSziIJW81t8YUGqNWHHk+khPRwoXIrqIxgyVBsw0LAPC?= =?us-ascii?Q?6ZknKprHwLBDZ4FsBDF3tofHuF2+khnZ0jhr83Y2sbX4VE4SWs8oFafNKAt+?= =?us-ascii?Q?wctSqtT5dMAUWQMgpSOwJ01kS7lb2ev8GDqsm49D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zcBkIvKFR39G8T6N6hwVssFqS/0cl4ARwszfOoHC4segASRwjlzdCnjhkPVbgdvrANIx9RNUioHF1bYriibtUx2fgLISyoI0BCAQq9RzbCjAE6B7kKKADKWZqOYzdDwk98g+yHvBRIC5Hjl2ob7qNldzXLhmRRjUWtywCMfvtAcBvKDP2xB0i+GJZmWpyvN27+Gw7OyWX7m6FouAZlDW6soaF40gOmbRohkkFHnHh25HN/ykQbSLocOZO9FYdm5XnhqHyE8WxaUE6VxUsTej+PTcw6D1MdZFq2AxdImIYwDMc3omNpqGjYExjtBNvgx+CJ5Kw+7LhkAcE5fvw4n3Z6wCLsO2uY2a8u7iwdHCZw+mRVjbJcEc2LqJbfD7BaHIJFoyRkkJHCkHzvFn6bttBBWmrNffYZF+mLMUu0+PhUARNbM3W1B0HuyuQ011M86wMxdYOCXQO/VD6qJu2gQT0J/j/+Mv0t8dSF1QFE1aAn+jT0TW41rqD9Zq6trMphTJazJt/BenMJmlaDYMGS/T9mxeHrS5NZ9JEC5/GKriuv9i5gz8CIbtabJYtaEukPEllvnDTn6Ir8aB6T78DQfNPu5U9cDRLhSgknfnJigwXI8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1c12389-932b-415c-0a8c-08dd5b74d617 X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7329.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2025 23:32:32.6389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ACbfbKu+eHYNB8wdwr2yFd0JfK+vOrpRpElMcOAXX+RrffWKSsZlDhzRDVOWuw/MhhcL2qwotHLe5H88RN+/dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5199 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-04_09,2025-03-04_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=881 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502100000 definitions=main-2503040188 X-Proofpoint-ORIG-GUID: EVkhE2tJ2uE9nIsjbpcU_HLQ0QuyLGlW X-Proofpoint-GUID: EVkhE2tJ2uE9nIsjbpcU_HLQ0QuyLGlW X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7B35340003 X-Stat-Signature: xs7ppyo6o7i7bwe746fchrboe4qx7aho X-HE-Tag: 1741131173-854037 X-HE-Meta: U2FsdGVkX1//4GN5atkY36GVpRqPOScB1OdcxLocMYnYfY0fHsgSalNhD6nqODN80YEpYsUofPMlQ4PZYZMBgUGaEG8aOCI1xlAnlVE3omB1KFsc/bDYEnMORG4zM7znGmkIZy/j3ERvgbC7Zejui5/CB1EHY8JlWkFanc60T4NiZqLP++0wmxzx1/TYjtxad0njWr8lvqq9hdv/fwZU9sQAUOLQEN84NR4Yrr8KssUo7+ryHKAwKMeAeCVA3hJAGnqWTfuLWZg30wLOP1rqWna8qHe38DmeIIOWDFP61tcSOmGPs61RpGSgEEU52RjTM2F4yWrC0LZz5UYl8cG3BQYinQQzZiZ+UegCMimZ9D/wDDLVZgaGb++LaMSQufoY0fFJBEB0B3qsT8ToMD4j8g8kzPS5JvsM4abMQryR8DT/cjKZA8EKOQzFNlhhBAN9VD30BzHNLoMX32cC18v23wxKzDY2AdDKvelEOsFbgxEpwI9o08pzSGDHTFLt4SAKXS/iSDYcyW16TWjU2LbAyKu7l/4UPagPz0ugtO1f3ITvcu/LLn8DInnLfOgvxEsxIwH2gQmcaHqvls13rM7k+rlrBTAh5J3aqnN9XiOHH0ZrICaHhehIGwygWSNnt3VmiNCUfcw4xbRWalEXda4C2/vkqxmUg4YU6NMEW5lX/hjmMwjiq+OFaH4I7QDMsd1PdVq2tacWkvUI1r6zB93OTWZuXcfRcvQEmYeHkX3TNF3xwwkhIIv1F0FE+C2q3ns2EH0be9q9nTFgODwLUPaBRkfOsfR0j9gCJ+4cWyRWPN58hpFQ9068colJe3bZubfRSe7IiBFmoLkDJhmKowasnYK3/sFiW+z4dIcgRLJfIypfKj1BgHCbLo4A56J8BwyJZHGH/wB20Bi09g1rUutB6tViit/xRpzz3lmi5kjP15AIDxgdK8J9IHrIhsvajkHXOzd7WSIpH7i2wQJtkkU OQwd7RV6 HgDLurEeTnq7oGpapZTCuxXZyzyr7SbVniN2QWs1YxKcDpJR/sqlSYDyXXKLFsFOeN1GiY0JsS96gY+Q4O/kgQ45jhNjmQCCEOlYwx1x3Pfoj74C0O6lE3gw0kzFJ0W5NMRx90Myg1I9lyg6OF7fD8YSxCj+DoPXckH/p6dDY7xW5aOQVey6+XbNV/xn+mo5eYCIGg+XM1EHC7HszXYAbkvJKznIehoPGZ3iH7IPY9zlQlTSPth7d6/t3MfvylPtgBM8bLUqCDFfaRLEBEtbmzBgKLMlcLQgydpZq72ZzaK0jn0q6qQzOvZNz25NLKg/95uC8cLmOW1kQ/uPSpFVELsXRc8B59NYovt9FxoCTCQSSTW4sH6eptUoqYY/q2hiW1bci0nx9SqrSoecpEDfnRwzjKnQROEZNyTYOMXx2I9bOAPEllj9qJIlXtn/hcXE0nvaP0jKXhDcs63Zy94SiD20UOerRn2cVxGPGjJZKz5ruQ3mj9kwpXQKy7p4nfnd8tsnJygRgK1HzRsHfhKJHKXd+qfOooE/htVWUkoJPOT5qjEt9wUv9BApVXFnlUZ2zZFC2BmhcD1tgGlphRRFR1Tf7UlvxeMtR7P99zLd4E2s19P10vphQtlfVfXj0EYUqxndlrcD7DTJiPGVIahsdrXZPqVa3y1nZcTOISWOHP0SC/1/IGTY0dTJTDWwUdaJEJ2WlJyYat9FIaU5GER6iic+VHYJXlBqOxQtH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 11:03:54AM +0100, Vlastimil Babka wrote: > On 3/2/25 14:30, Harry Yoo wrote: > > On Sat, Mar 01, 2025 at 04:37:20PM +0800, Ye Bin wrote: > >> From: Ye Bin > >> > >> If 'n' or 'size' isn't builtin constant just call __kmalloc_noprof() > >> in kmalloc_array_noprof(). > >> > >> Fixes: 7bd230a26648 ("mm/slab: enable slab allocation tagging for kmalloc and friends") > >> Signed-off-by: Ye Bin > >> --- > >> include/linux/slab.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/include/linux/slab.h b/include/linux/slab.h > >> index 3b03b31831a9..0edb8363fc4f 100644 > >> --- a/include/linux/slab.h > >> +++ b/include/linux/slab.h > >> @@ -947,7 +947,7 @@ static inline __alloc_size(1, 2) void *kmalloc_array_noprof(size_t n, size_t siz > >> return NULL; > >> if (__builtin_constant_p(n) && __builtin_constant_p(size)) > >> return kmalloc_noprof(bytes, flags); > >> - return kmalloc_noprof(bytes, flags); > >> + return __kmalloc_noprof(bytes, flags); > > > > Can we simply call kmalloc_noprof(bytes, flags) once instead? > > > > The compiler should know 'bytes' is a constant if both 'n' and 'size' are > > constants. > > Right, applied like this, hope it's ok? > > > commit a6553ee4b00ba4b1466a81fb00fa4679b7ce5339 (HEAD -> slab/for-6.15/fixes-cleanups) > Author: Ye Bin > Date: Sat Mar 1 16:37:20 2025 +0800 > > mm/slab: call kmalloc_noprof() unconditionally in kmalloc_array_noprof() > > If 'n' or 'size' isn't builtin constant, we used to call __kmalloc() > before commit 7bd230a26648 ("mm/slab: enable slab allocation tagging for > kmalloc and friends"), which inadvertedly changed both paths to > kmalloc_noprof(). > > As Harry Yoo points out we can just call kmalloc_noprof() > unconditionally. If the compiler knows n and size are constants it > doesn't guarantee that bytes will be also seen as constant, and that is > the important test in kmalloc_noprof() here, so we can just defer to it > always. > > [ vbabka@suse.cz: change as Harry suggested and adjust commit log ] > > Fixes: 7bd230a26648 ("mm/slab: enable slab allocation tagging for kmalloc and friends") > Signed-off-by: Ye Bin > Signed-off-by: Vlastimil Babka Looks good to me, thanks! FWIW, Reviewed-by: Harry Yoo -- Cheers, Harry > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 09eedaecf120..ab05a143d09a 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -941,8 +941,6 @@ static inline __alloc_size(1, 2) void *kmalloc_array_noprof(size_t n, size_t siz > > if (unlikely(check_mul_overflow(n, size, &bytes))) > return NULL; > - if (__builtin_constant_p(n) && __builtin_constant_p(size)) > - return kmalloc_noprof(bytes, flags); > return kmalloc_noprof(bytes, flags); > } > #define kmalloc_array(...) alloc_hooks(kmalloc_array_noprof(__VA_ARGS__)) >