From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4135FC021B8 for ; Tue, 4 Mar 2025 16:16:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B135E6B0088; Tue, 4 Mar 2025 11:16:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC2F06B0089; Tue, 4 Mar 2025 11:16:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93D2E6B008A; Tue, 4 Mar 2025 11:16:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 73E236B0088 for ; Tue, 4 Mar 2025 11:16:24 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CD360C0332 for ; Tue, 4 Mar 2025 16:16:23 +0000 (UTC) X-FDA: 83184371046.22.F4AA1EC Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf16.hostedemail.com (Postfix) with ESMTP id 33A7518001C for ; Tue, 4 Mar 2025 16:16:20 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="mVkk52/u"; spf=pass (imf16.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741104981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IdH3AKQlJjVPXu/3oVyqdmU7Zg+wJAihXQK8/YRYybU=; b=oRrf8GQUoB4OtOL7kzooIjnpCeBZ7u31Vk8CIa86a82MgSqTvGSOi3HXlPogpkR011heiQ fFVSNy8gUhv0LvMk0jlmfy45zjGXcO1USUoIgTt5JgbRMsxP7LrN3rRv0gutboQWUtRgMi 24w+PIXiDF3hGvtFEeMPhK9gDpU50w0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="mVkk52/u"; spf=pass (imf16.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741104981; a=rsa-sha256; cv=none; b=gq37s5Nc2UWrJ3LebGks6eE8dvrVjg1anzk2Zc4ZMMKSKdT+UzjYqRP6fKIFHJ365vhjhh OPi9Td0B4i+B5F5T7eIzmJOWrQ7ybOI2HSrtkRFXC+pKjHMwyYeIS2HmnS/VLim7JXfHG5 rRWrdujBkFTlnpxGHAsn8CMknayty4I= Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7c04df48a5bso588012785a.2 for ; Tue, 04 Mar 2025 08:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1741104979; x=1741709779; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IdH3AKQlJjVPXu/3oVyqdmU7Zg+wJAihXQK8/YRYybU=; b=mVkk52/uNv4DSYVmHtyL+cbmMM2Ttboxlqq1vrqC4UBz/kaxXK2drI8kVbZUu03YLW J86gqxRmORhvu86n4Dq61peYAVE54aFEBh2QRA9/Lc7QQGSMwoJ7dls5KVnSxo+XhEqI BtF1oxVjN9FmSrLp1qjFh4YCnBDXslWXG+c0qp3yy3xzG/NjE1OGOifJq5LMzVmBDAWz 6k5XjF2sKwi3J993JUDvkBrY53uXR2PKrb/e2VaKT9u1CiLofAYYiCOIZrWtd1DbDVKS KlX8MXc+GCN30LiPFY77dqFir/tzmVjLDlpatlUbjM4CyQPYeDiQta0BQIYhY7cpAyoa Yt4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741104979; x=1741709779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IdH3AKQlJjVPXu/3oVyqdmU7Zg+wJAihXQK8/YRYybU=; b=rf6/1yxtOyLlEuVt/qDw1xnn7mW5o9465EhAtDGATftAKd+W2sdX6MEIOOX3rkrnHZ OIoUxDqEethRjpLR5qzGfl+z7mX8L+ejqJxSZ+np5Foy/BO/PqFhqVwo3caIFWvMLFqm MW94RGVPQ+ISq9mqnwpzAhWoa0sTeVi0oBny+PEdLrUS4FKfxjSzJoizYT0AyJE03Y5K pm6MxgZ7nIUUVtTM0Vm+SlyyB2TZxW/f50m2nL+FWIrE30f9KSAPWztMtk7FJwznniDF JMSkH6XGIUdYK355mIbyf29fEOGlUqEHBzlQgM+yQCrH9AM8INLR4OxrQfq1ylwZ7L4U vOkw== X-Forwarded-Encrypted: i=1; AJvYcCVjxRoZSukgDmhIV0e+I9k75tZVT8Ta2n/MAYWxfj6GqHxuY45LiEDd9KvxkXoobE/YNbGyq0n6HA==@kvack.org X-Gm-Message-State: AOJu0YyFzNE6IgX6qzyBQw3RfXA71CifL0Af3QlyfEokjXGL7w93gTAi nWSxidn/jU2VIl0Y7kG/7YDUvJfh4Bn0D8rGhktm4GFxRhc2SEGubbIsk/OrTAI= X-Gm-Gg: ASbGncuaxE5gjmvS1/ERrUQWBGsi4Su40osaMFyyi0TYxr3/owC0/XHx+fHbEu3uNJM crFDUqEBUgTWdxFkSuQ4QHZtg8CN8IGuBig64JiR2uce7sgWV2Y8PEuzocqdHXH31+Mqn1i3QKK 9WQBwWtX88+vFQLBslZ5FRy1mHPX9JP4EDPbtI4Qvv8srvIGYrphKuW+N7Vl+/+quHfwA2UWwvg EcPFkCKyyCMWS3VZTUaZ97K56pQVfG80dFYMhf6tFCyOAsOSUcnsUjbmeB2FLwtp8EXmIFM9GCG MZ29+p0pzr7yKsY8O7aiVT5uAJzSSZOsgNPXhsr2ZLqj3alF9HHzhAFnIXq3f4RVInAnG2DMyiz Yf8QwbMamNhCt+q7ngsWMUWEf0Es= X-Google-Smtp-Source: AGHT+IG+8gkxb5a4FLU8HNw0RgCDeDarhruq85hL2w5mldbW/rpOd9s+9LQfuwgtmnJwF45uXgCLwA== X-Received: by 2002:a05:620a:26a8:b0:7c3:d3bf:d1c0 with SMTP id af79cd13be357-7c3d3bfd3d7mr258875085a.43.1741104979239; Tue, 04 Mar 2025 08:16:19 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c3be1f0c05sm279200385a.102.2025.03.04.08.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 08:16:18 -0800 (PST) Date: Tue, 4 Mar 2025 11:16:16 -0500 From: Gregory Price To: Honggyu Kim Cc: kernel_team@skhynix.com, Joshua Hahn , harry.yoo@oracle.com, ying.huang@linux.alibaba.com, gregkh@linuxfoundation.org, rakie.kim@sk.com, akpm@linux-foundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com, yunjeong.mun@sk.com Subject: Re: [PATCH 2/2 v6] mm/mempolicy: Don't create weight sysfs for memoryless nodes Message-ID: References: <20250226213518.767670-1-joshua.hahnjy@gmail.com> <20250226213518.767670-2-joshua.hahnjy@gmail.com> <95541985-8d40-4ded-a83e-46203c441640@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95541985-8d40-4ded-a83e-46203c441640@sk.com> X-Stat-Signature: zyx9ai87i7r8jgb8rhffpt733k71zfcp X-Rspamd-Queue-Id: 33A7518001C X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741104980-197104 X-HE-Meta: U2FsdGVkX1+WBOoMDiAu40nRGsBk3Ah5NE1P/JwZPEu0OARv0JGQeMaeBJ/qvSh1m8smM4PZOwWthk106a30smkLK/nWhjMd3RU8pU6wCLafus1yyTEFKbDpsOZcUtECVlU4Do2AkLuyW1S5ox3c3AFho86IzsnEjux/x9T4tlyX0XrlInqajqSU0fjgBRAgGiRRWSLo9dRefLhNjBZL9Gx1StBokGC4i5cHJ9RF7zn4aNDvE4i2+wuwUNxYHnXOocToLAe+dpq6PRJWHTWUHkNpA+z2u0XFDm+mp0J1BQAo3NfepCwh1XTD4qheSzzI1IVFUflszTr4xpjrzQRV41j5iUF8vedj8eUskJhSO+6YSYWjalG47WzVmEjsUYm2/OlzYzGPtlEdXF38iVSJfUBeTQwMAijt/2azAq7ZnLuyMO9B8NK1Kb+/MIqcDnwUfkqg6zt1rerEly+/3Sv+nVKMHJcQKNoJioqoQSl4bp6/hS/OgXpT7xM/3eMCPInoxk8zBcpNcl9SDPfhXUAbUFBeLRtQjG4jvJ9G5WrB6K3WQ7RBsqOTf95++gwQdgcp20Uon6yjzMlf0NGgNhdaQu1cqbSSKMDLPTCLJgTmcP+9/SXzhCTxA/d9tIV1NE1vQkxneeTi2DhD453EGMrs7wQ+v9vURDrpqOJtzUCu6kVXd4WdNX+UStCMi87t8yxXX2jS2Jg5NkOnLbGaV/LVvUB6EluxAvqYSMKOG43vGJy/zDgFa5OcHQxp3UHmnQ+ZhZfyivtzANiop8Y2uiNDJMgEgzLsWFRuvco0uniKybzbrF/2SDnAntOmQaeLq8Q+FNmXJFhUGv5WnOpclLs7ECRhQmmhZfqJ1BuCtLBMs4UW37rfS5NhugIh07TYXVNfAZ85+qXBCg6Tq/Bv12xqP8Tf5T94YhKOg/MdSWlTSyFmMZiSqJU/dflJ5badSrrhLsJr1PcJW0BIsVNNNQ2 vKz2RMWY WkmXsUYsxDJ5U3GL6bTg3+jS/Wc7Hbs166hzKNLAqqzz08UvGBPpS/PJpP/AGfnV3jEXpPY4VERoIojFaMyS0ADOjt6EemESIrOc7nk5WaEQ6LVx2JgyG+FZDrmCS47R8+8vLTiwCrUmdTyeaG2fIJmA8t2fccvqnraXr6kyH2dfYCio5WQl95uQvkoFJhs6L7+QoVcP2rwKN+UIkxRuaBBaI5Ajaccjlg/YdV5YFX/qGNYgcyFAM1ucJmYjo2rxhw8clXOShiwqaulWjkL7c6um00XahSY5KxcP6StOgkZ8VIkpbjtsTaEPg77/iPmrjWEVItnIn1rLqWc2fZIAphKFwsi2YBPGO/Ort3ntoYdEQ9aQwySrYFSjWyVKYPPfz2njqTZH00IgR1W2jGHyM8RPClw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 10:03:22PM +0900, Honggyu Kim wrote: > Hi Gregory, > > > This patch may have been a bit overzealous of us, I forgot to ask > > whether N_MEMORY is set for nodes created but not onlined at boot. So > > this is a good observation. > > I didn't want to make more noise but we found many issues again after > getting a new machine and started using it with multiple CXL memory. > I spent yesterday looking into how nodes are created and marked N_MEMORY and I think now that this patch is just not correct. N_MEMORY for a given nid is toggled: 1) during mm_init if any page is associated with that node (DRAM) 2) memory_hotplug when a memory block is onlined/offlined (CXL) This means a CXL node which is deferred to the driver will come up as memoryless at boot (mm_init) but has N_MEMORY toggled on when the first hotplug memory block is onlined. However, its access_coordinate data is reported during cxl driver probe - well prior to memory hotplug. This means we must expose a node entry for every possible node, always, because we can't predict what nodes will have hotplug memory. We COULD try to react to hotplug memory blocks, but this increase in complexity just doesn't seem worth the hassle - the hotplug callback has timing restrictions (callback must occur AFTER N_MEMORY is toggled). It seems better to include all nodes with reported data in the reduction. This has two downsides: 1) stale data may be used if hotplug occurs and the new device does not have CDAT/HMAT/access_coordinate data. 2) any device without CDAT/HMAT/access_coordinate data will not be included in the reduction by default. I think we can work around #2 by detecting this (on reduction, if data is missing but N_MEMORY is set, fire a warning). We can't do much about #1 unless we field physical device hot-un-plug callbacks - and that seems like a bit much. ~Gregory