From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DECA8C021B8 for ; Tue, 4 Mar 2025 10:18:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41D726B008A; Tue, 4 Mar 2025 05:18:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CE0B6B008C; Tue, 4 Mar 2025 05:18:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2951B6B0092; Tue, 4 Mar 2025 05:18:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0BE916B008A for ; Tue, 4 Mar 2025 05:18:22 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B3353552A0 for ; Tue, 4 Mar 2025 10:18:21 +0000 (UTC) X-FDA: 83183468802.17.DC975FF Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf11.hostedemail.com (Postfix) with ESMTP id AF0E240012 for ; Tue, 4 Mar 2025 10:18:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=t3xrvCYX; spf=pass (imf11.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741083499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cHHGVIwYUugRFpPbUWW4QxwSvbgE0LZxVDWqc5K4qXA=; b=lBPn0ph9zJnGqpMh5J7/WwJtZJBnZ/DE1TMQXulC8eS+PWnCufM2AQHNQPsC7BzuIKTiRP n7yqdj4NkARUzENEl7HUCSJY21QuZLe3YrusOpmIGk+aB2PXjR2QI7LX23tPB9GnETNGl1 Ip7IeptCzl6rHhk65JqQghu2XVO0oOM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=t3xrvCYX; spf=pass (imf11.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741083499; a=rsa-sha256; cv=none; b=7mYLg8jrgf+T42UHpKN6cNbUtEz7rMs9u3QN13BPbkvLMHC3AF/Owpn6IUZyUVM3917euP Lqw1O6X68+otWNs/hKanzKMPqmN5mJTX1O9vyDCBkONS6RxHM6G0O6yD1ndErrSKSqs8p8 vmx+oJHfjBP7W6NnOT8+IUfy/TtoVc8= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-438d9c391fcso47145e9.0 for ; Tue, 04 Mar 2025 02:18:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741083498; x=1741688298; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cHHGVIwYUugRFpPbUWW4QxwSvbgE0LZxVDWqc5K4qXA=; b=t3xrvCYXbgrNMXJrl8prDUjLPez4hDaHjCA9D58c+VDtPnpwmvgDpgJjbfiR3PVgfE VvCjde6mrGyXth6Qo/cK2azKeAHFN7XgpeifoHqAOwTcHfXZ3Bc+6gGL+1XdtS/5jzQo Fn2wxXDFYd5wXkS5btZFwa0vyuLEcjX2trJD+TsyaJ/boCzhhUCQGOZ158Ls0eaS6PCx AWc2SUJ+3NZigwMMaw8OSwfBOsrWBRD8dX68t4ZCckCoIiSzlfgV3xLSaT/vcoHFbcjj AVsk/E8G93O1BbRXacBT6qyXvKOWk/qbGg6XA+iyV75GigYbMwNEQK2VLAOZj/HEoCXx Nt3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741083498; x=1741688298; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cHHGVIwYUugRFpPbUWW4QxwSvbgE0LZxVDWqc5K4qXA=; b=HsLn16+bciRt/TIEFXROh7pmDf5/kwb90GgMDy5JThzerfTuXysSH6rjN3pGvARdc3 OXBUp9xBVoPvzpOYQDSdkjOzwi+/byKQsoSeH3r4/vYGfwMYihjzFpuV2cnap+Gy9cbS 5/70lrMrnr7MmrMjl7sRAxyD51TxJYbQsyJ6bErzm6VHadM9CVOQPPL3hGRuH2bf/jdZ hhpuLfJz/4d4tvxV57B7iN2Hh1bOeU8TkV+ctJ4QrS04RQPFxN7nFk4T5WXwr5YbV6eQ YNanR6jtpVWjsDoJw697cOv+VQktUGRya81J1vgvHqcFLeMid8+MWdwfeOblCPvD+f25 0zVQ== X-Forwarded-Encrypted: i=1; AJvYcCXCYgXOiKQjJWNp3hp6delJ294xPN+DsMp6vMEiGLzkUG6YQ+4uLSZtLZHtRYIvCiu0olg9/qGmlA==@kvack.org X-Gm-Message-State: AOJu0Yy2AreU1Hz8uy8COBYsuT5QGZFCl56Cb1CVHO+7kpvlS1jxUvWm srNf+SyAmik1YjjONMP2xLQQD5toFWDSqif8v5N96IWW4TkRD2m64lTysG9PJg== X-Gm-Gg: ASbGncvjQaZ1DHZWY6af0F7vo4PUIXFwYaeLgnTWGa2c23QvxqJVKBtGZ2/jSxLEK1v koelrMoKDVu2Yf3SEGOEdgKq0dCU8S94eRIe4mE1IbJwqNtXXTj01SIpspy6Poquk1OUQ/F0PsB 1qWtanjTxY8Wy8Qi2NizR17EtHFF+MSVphrv5DAIUy5IfdgXwbIpz2AixHcT+ajn1Ek7/PohBy9 2vULUr/Tp2nWabkYXEwylWKmytJyd04yU2f/mIi94ogCo9ZGfaIHdFLVL9BgO6j7wvuocJsQqeG OJ8DunaG6OqRym3fuMr3plT5OIcoWMKJGLLxmXxWyn+4gURkQ0hPkAjRt4ZrGl5HHFOYwYlg+o9 KbMQL X-Google-Smtp-Source: AGHT+IF1PXtKs5JYeKClxwK1lAzDe1Sy+Hic0+WUm5WKWP2ZPJezaTOmzVJ6ghefB6dnk3leGQIlaw== X-Received: by 2002:a05:600c:43d4:b0:439:9434:1b66 with SMTP id 5b1f17b1804b1-43bcbe262d7mr789425e9.1.1741083497923; Tue, 04 Mar 2025 02:18:17 -0800 (PST) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47b7dcfsm17460567f8f.55.2025.03.04.02.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 02:18:17 -0800 (PST) Date: Tue, 4 Mar 2025 10:18:13 +0000 From: Brendan Jackman To: Stephen Rothwell Cc: Andy Shevchenko , Johannes Weiner , kernel test robot , Andrew Morton , David Hildenbrand , Oscar Salvador , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Vlastimil Babka , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: Add lockdep assertion for pageblock type change Message-ID: References: <20250227-pageblock-lockdep-v1-1-3701efb331bb@google.com> <202503010129.rJvGqZN1-lkp@intel.com> <20250228182804.GB120597@cmpxchg.org> <20250304101357.66067dd3@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304101357.66067dd3@canb.auug.org.au> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AF0E240012 X-Stat-Signature: 91x4dz3bn85sr4mi93un8tt8fc395dj5 X-HE-Tag: 1741083499-66731 X-HE-Meta: U2FsdGVkX18HOdyBVs5C/XAV8SrP5I9I/qZqBH6NoaP71KxXkwh9bewA53L9QTV9wNH9YkKkQK2mggnWH0T/02iUZpM420lTbSnK/YBin0nEGuN12y1VfCJ3/HlNrIqMR4qTs/FxPI63N6GXS9wB4k5ILpFNjDZ31t2k9clm0xkiEeexR86JCz6jbp2BsRxrn9bQ4m9+fCHyAKzth1abUzmZS4nj8vpN6Y1lpPPYDGKq/nlimK5JHK2zaFIrheG3qifd63ke246dM+4H+NhJnEC4QcK4Kw7w4A23SZ8jJQ+8S5YmO597nbEgTL6+076csnoqNS+BeKkGQ/oQ22klbwonxOLs4P0mp69E9lFsMJKjyy0BpxHlm9dpiUqQj1Q3ejWb4wzKDBEe/0gRIf1pB8cjBuGrZG0DrQVhYM4H3ITkShlf0vNPyVZKSUssYxVA3MPYkjv69LUsEhoJ1bkARAu0H10P9oBOKQVn8YQq011T2waBFnRduDYFnjdxwvipPeIj4PShSjNwo1+YFBaOEJX/3XMtxVBls1UFCwVebPwhBG1rbrsJC3GPzX4cZg7+aUFk3UYaMA5174dc0XNUaCFqFV5MXbmCSw68xWcnMWsQpsk5ehBKVS7v4n317A2ZFS7kVpn91e4isnqwrXij/g/1n47tw+rPVBf0A2UHxcdxptOz+GWQXil9y4tXO1EpiKUJIjPfBYP7HgGDD2Z8RQOWAKZNTIC9NXUHCGgVivVQMTWQ6FBAuFEM5A+WRTOBo8Bx4H2rFS8hj20qgX5rQKaU7T3IgnJcYdux4nU7/p5RWIO7YWTCwE8E9wV1EBU6QF8jdjNu2oPEhKk1qUR6cBjaqTMvMtxcStSZ6BwsBklz69orDSAhOIwskY9uBJpPh1mQInvGDGX4Bxtk/nuOgF33VFGaSx5pPEICcednkQl6vI+RYajhhwq7fySN59tRM/SZU2hIoBJz3Z7lqiQ U/9bjfnB KCeFjsKhJHmnDhaZJVDO0gzt79T9CNiFyKta+6onNMl/fYmztIrIbX0C1WVQM9jn+FLhqm5kngLU0WF11D+LgzHvIgfo80oO7YwwWd2aOCeAUlakgcBLRLVcviirsACm0N7/Zzrdm4B+rLRmS8/n7njetYOco+HDOTDeS1n+X5ZQnXta7WzmJITmUTgDHgBqcnGUMc6CYkUEmuTht7WXt69UHHbvS0fmS8PZSHDPQrLs/0wUfcOgTszYxkptuusbm70wzdXvtYKjnLWRESp8biCaeZA1OrYs5JvtgLY0N8YkO6CNY364AeNVPEPr2ddOKmOAOfpQQvisOq+cPsTO62m6y+3MstE1IyhJJXee2mG++7yjY2peFRkgcnmEF+TI2+GxHiAi/42cSlfMzg3bYDbtI76jVyFwOIgNOdTG7dxMRRwsqUI56sMySh9KsZSTJYvsg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 10:13:57AM +1100, Stephen Rothwell wrote: > Hi Andy, > > On Mon, 3 Mar 2025 13:18:42 +0200 Andy Shevchenko wrote: > > > > On Fri, Feb 28, 2025 at 01:28:04PM -0500, Johannes Weiner wrote: > > > On Sat, Mar 01, 2025 at 01:31:30AM +0800, kernel test robot wrote: > > > > > The patch is missing a dummy in_mem_hotplug() in the > > > !CONFIG_MEMORY_HOTPLUG section of . > > > > +1, I just stumbled over and this is not fixed in today's Linux Next. I'm > > wondering how this was missed during merge into Linux Next. Stephen? > > I just get what people put in their trees. There are no conflicts > around this and none of my builds failed, so I didn't see the problem. > Has someone sent a fix patch to Andrew? If so, if you forward it to > me, I will add it to linux-next today. Andrew has backed it out of mm-unstable now. There's a v2 [0] which still has runtime issues but AFAIK it's not in any tree yet. [0] https://lore.kernel.org/linux-mm/20250303-pageblock-lockdep-v2-1-3fc0c37e9532@google.com/ In case it helps calibrate expectations: I think this particular patch had been reviewed but in general some patches get into mm-unstable without any review being recorded at all. My understanding is that Andrew squints at it and goes "that looks like it will probably eventually get merged" and puts it in so that people get a view of likely upcoming changes. So if an issue like this reaching linux-next is a big problem then I think the solution is not to merge mm-unstable. I'm not sure how high the bar is supposed to be for feeding into linux-next.