From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2D5C021B8 for ; Tue, 4 Mar 2025 09:47:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42F3C6B008A; Tue, 4 Mar 2025 04:47:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DF826B008C; Tue, 4 Mar 2025 04:47:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A68E6B0092; Tue, 4 Mar 2025 04:47:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0D65D6B008A for ; Tue, 4 Mar 2025 04:47:02 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 89E2BA8281 for ; Tue, 4 Mar 2025 09:47:01 +0000 (UTC) X-FDA: 83183389842.07.2BDCEE1 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf12.hostedemail.com (Postfix) with ESMTP id 8ECFD40005 for ; Tue, 4 Mar 2025 09:46:59 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QvVxIMkD; spf=pass (imf12.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741081619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fDostDuCz+69r2wOSDeI1fXNvVPWdirSCV/X9dfMlRE=; b=yU+5zAW4klumZtVDURtZKMkPty0ZqUseCd6mQTJ3g0d2OVyqYRJksgAdQPVDpUyJouZD/v nlkQtKQeM0f0qERAYmofro12iFPno/IMtHegVOUEI/40lCbFSMTUaR/ftpInuCkFB/JMKE wkHLhxkhdYlYCBUioaRWpaQWcJSXV9s= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QvVxIMkD; spf=pass (imf12.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741081619; a=rsa-sha256; cv=none; b=PeOwipy6uWodhh2I8+WpkhfOgvfD2YXJyGFgF0gBYXsyuIBDXZTALiSbUSFfYKF/8RKcUf hzrHI7JWCUojEB8elm1MNYIxt79iENdVX5kkSZeGzNnra+VO3As2Kyly+HjBdb1DPmKbu5 g2fomjo5XC344yuOwcE/7Qb+Oixzof0= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-54963160818so2874276e87.2 for ; Tue, 04 Mar 2025 01:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741081618; x=1741686418; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=fDostDuCz+69r2wOSDeI1fXNvVPWdirSCV/X9dfMlRE=; b=QvVxIMkDX9kmgUI8+qHuWialdSoqQl6zrLnP0xHkSGNa86MELmoPjVNGPM4xYHYE2E rImtSHLHQXCKnuXrWSeMBJvGU5awxYLkmwda1S1PcMDQ0fetwyruAou2PaGUhqnJ9f+k xCbDS3T4tlG2XEa04AMyQhUOrMxLh19WiRjuGAPN4Uzfnzkjg0AWP/bKL2Dui/90RL2r KSwpvx3A/ItQ1My4FPaiHcP4eTX+BA4hZbShOaJZXb1b5pORWKbbD+nZX/vZvcfI8yAX jvP4c9XPYeLRA4hywG4Kz7+0PIDaUFavA93QfGQruHRy75kbBV3XzjjXSEdlV7z1tJIh XpEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741081618; x=1741686418; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fDostDuCz+69r2wOSDeI1fXNvVPWdirSCV/X9dfMlRE=; b=k/NqfRr2eE/D2qkZu96qpXXGjAsf/NRM0Ge5dJmfenvYcNAwwC2OPb4MPFlDUFvtEt 3bA9kromr7zjnp02xBX/5nE2km3xdrVMNerFHXrcLRsUa3QL8u17vnRZ1w5KTCQig3nw 07A8cTtqP4SuRZ4k3SFTQqKRydAmJkoiX9IdffWgn7z25qLdyemA0OlD04RNWF+kVDXy bdXg85bFPj/JC1FenvyUGTAKmgL0csx/YYIxWk9Z8CB3E/FmoYpN/WwUaQaY7pTp75FF FvgOGux7y/RXZcr3Xa9Gxlhci2591s5EyG/BrE98zXH+5UNF+snnMnGFxNQMIKkYx/oX hX3A== X-Forwarded-Encrypted: i=1; AJvYcCWJWSrHa5sQJst/6IU7lW6cKrJXMEWzXE1SipgnNQz7VQxpU4u9mHUFCsi9bLWnsvYa4Ppyj+WEIw==@kvack.org X-Gm-Message-State: AOJu0YwOrAti8IZNy/Eq5nsupZDceqh+kMEPA8XFNcmKEHrtlXzixpxA 88HPxVdQGgENegYprJDZyR7en9drCpKwlK9GDqYaRfOS4xyMyNOrh7F0Wg== X-Gm-Gg: ASbGncvjZAWul7vA0TVEvvlyMFdfqANgtzCW5fFuoY+RmHluFIVC5Ag9zT/cRAx0swM aIqSMFMLx/4t7QSLxdObL4BhjHTUTKG7T22PaedtD08s+ybVrfYuxDbjoFHyt1fKanDn+YMHVi7 s2GGtb9pd8e9iuwBZKya9oaTm2u+jiyczUZEC/TuRPLXj+XkWEZkZUdwctM+59JS194ORyEqX96 3bXqjsIZHdhRr1FiooPBwT1PCoxln3tUJkR7fXB+2IgAceb0eJjGUJwz641rEI+yW9DAvxFEIJK Ez+hmOzKi9M= X-Google-Smtp-Source: AGHT+IGfzQnZ26ydI/Hp3PtQZN4UXtI5pke9feZjOxzsb0bBFWh1zSD7cQWbLYhGYm4LdjPoaqrnvg== X-Received: by 2002:a05:6512:6c9:b0:545:ee3:f3c5 with SMTP id 2adb3069b0e04-5494c32008amr6366824e87.17.1741081617269; Tue, 04 Mar 2025 01:46:57 -0800 (PST) Received: from pc636 ([2001:9b1:d5a0:a500::800]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549570fc8fbsm1129701e87.80.2025.03.04.01.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 01:46:56 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 4 Mar 2025 10:46:54 +0100 To: Liu Ye Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: Move free_vm_area(area) from the __vmalloc_area_node function to the __vmalloc_node_range_noprof function Message-ID: References: <20250303015702.319416-1-liuye@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250303015702.319416-1-liuye@kylinos.cn> X-Stat-Signature: qstxck1nxhf41fok1xmwx6gu9mnc9mii X-Rspamd-Queue-Id: 8ECFD40005 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741081619-213026 X-HE-Meta: U2FsdGVkX1+DoeNeXoBDkZBihMR1zscJao4igT5hfBzx+J2WO6il3947uFXVlTNN2y5SKtZXyOkmnaaFN4tbDAp8+0Wf6vwH22uDiABKk790lnfirWE3TFKgbhZU52Bvs6NbBccqTKxq0BxupYYSvWqWne6WPVnBp/AGDeXYkw2l7ZDusFwxGcJYn/8TqumrOSK1a54pDPLS+MYMaiH5qNf+1Mle8RHRrHGIRCaDh030lJ40L53S6SK9+JXnB3asRw//szTIG0hfPk7mztyYRup8r8P5quPYP8NfIxZbGNMi4Ioy9nRXklAlYDXzQ0zxYLP409hKSwi8qmnF9xK00HoPbzce59MytfxNk9B8Q4mKSC7bg3aLrRpeX+q4kzCJR6OLfVz0/8xdjfVLqHU/N8DNHqbn70xol09CSlzPJW1m6ZWVa/h3p22DFNwitX2oDXFh4iys0019MaiODIHbLAh3FUeW13MGDCDNdb2fuLTGjQGOIgM+1UzubDPFG1HwYg5SYP/EzUwr9K+0j1+YnH4Wk/0+azUV4wVPJ8FER0gRhJ/9kGzVo5YAl/sfgZPJJ+uuSMLhO1b7H8mvzDZLBWQnTr6ugxES/TD9iBPv4MUy8PFRNLlD3myxrAtNoi0h7IDOpmhjxtdoSUftJW2lJBkn2I2K7272CpnVhuwb05s6+uEKdLd+gQrJw3vjqOFPk58LyDQUALqV0WK/NltBJreoNix9AivMvepxEAyBEQhc2UBW40RwgFK7oWI2NKbe02kKuP7KHVxpJ5Jw0PZrCx2Ej1lnCBT5Ip7H5eyZT2TDRGeh5JsLgYdMIK8h0388ZsDJgeGUJcUEJM+h6TjPEdVQGhzn41VTHIBiSODbWTAgOx0vMKZCGehdBeYsF7hvXq9z+zqNvzOyCHLHqzDkcnONZ7B3FH4zAiGSL43WZuemEkNxFjOe5b2sVAj3Cli37NOed026xVCp6VPrwZF Ndovxsuu pCD/2nJh9c/NTJmY/2YNJMswHNaQ4VMI+rvd1djKpyHMujMpMUI2+PZWtnFChtmVY1kMC3ryUkBsNa8mfvg3AmG1+0rTuYOif+9e7vm81vSFTGEUtiK+9Ibr4xTccDFJg8wpm9hlizWDFHklwX0qh3VdzaRhCv4ls8LlrSacq374M9p+N6kAh6R95H41zcnx1sUh5pphRv6hdAiRaDLAJu4yQPxwNqoJYhIGboaZ3MmZBBKDyLneHi26c1F5cl8z3kScDABq2vP6+Ci90BHz2eoq1U86AqftV8zsLTQ/Gm5KlL6QgrJ03c8wssFhutiD6hL2Y1TsNwd81gK2B9vfQaoBVoUELVdHLcw8baa6BXwhuowQmPCDlhVJGw9NQoCjBvBLiqswZcDmky+Xbxi1RwaHFO7rIcv0SZFm8DTrC31nOk4RfZKuftcXlr1Frz4TpbukKG/6Ug3x/uzI6oMi4FNzWSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 09:57:02AM +0800, Liu Ye wrote: > Moved free_vm_area from the __vmalloc_area_node function to the > __vmalloc_node_range_noprof function so that allocation and freeing > of the area can be paired in one function for better readability. > > Signed-off-by: Liu Ye > --- > mm/vmalloc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index a6e7acebe9ad..dc658d4af181 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3651,7 +3651,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > warn_alloc(gfp_mask, NULL, > "vmalloc error: size %lu, failed to allocated page array size %lu", > nr_small_pages * PAGE_SIZE, array_size); > - free_vm_area(area); > return NULL; > } > > @@ -3844,8 +3843,10 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, > > /* Allocate physical pages and map them into vmalloc space. */ > ret = __vmalloc_area_node(area, gfp_mask, prot, shift, node); > - if (!ret) > + if (!ret) { > + free_vm_area(area); > goto fail; > + } > > /* > * Mark the pages as accessible, now that they are mapped. > -- > 2.25.1 > This one looks good to me: Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki