From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCD3C021B8 for ; Tue, 4 Mar 2025 05:19:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C65D06B0082; Tue, 4 Mar 2025 00:19:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BEDC76B0083; Tue, 4 Mar 2025 00:19:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8E6D6B0085; Tue, 4 Mar 2025 00:19:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8BB686B0082 for ; Tue, 4 Mar 2025 00:19:43 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EE2DA1C852B for ; Tue, 4 Mar 2025 05:19:42 +0000 (UTC) X-FDA: 83182716204.19.80584B6 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf01.hostedemail.com (Postfix) with ESMTP id B508440005 for ; Tue, 4 Mar 2025 05:19:40 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=Z9TSs+Oh; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf01.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741065581; a=rsa-sha256; cv=none; b=6q/eTKfZCK1JwbE/FbqZn+UANV54Th7INjZEgoq2zQyY4LGO4CUByIFC3qwh0mxQFnLetg jDHdDUTNVnaXBNkvYYopncf3GY/HKCNv2+OFb6FAEa7viSezVcURA8QoENoQBimCyZ9I/h ovH7OFNlaD1mnOZQ4MHZ56vb7764Gmw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=Z9TSs+Oh; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf01.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741065581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sTB7OSG/jPKCsZcpm18gwfMQ6rv4CO/v9UhqKKSFcP4=; b=T8vaGfEPmeeHqa2yKD/n7QhgiH6RwXfEZ586KCRrrFE0KXH8GVnNHYr2OW0PpHIKdMcqqd hAG7OLG6SOeauuRUV131diwp8KvoD5vHglqijsfuAR7mo0FO9G/JFRkbaKCrxCL+1Uj2oZ UMvwgAi4fK9Cnzl92DvSq175VRkmzWI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sTB7OSG/jPKCsZcpm18gwfMQ6rv4CO/v9UhqKKSFcP4=; b=Z9TSs+Oha0afGDaZXLt5NJNPpi K6nfiV4QEDPMp8IBscvfsrZEPZzf/poZz8rY3Ba2gxv0NkTYlqujzUTcH1kIERwlksmB+LjAtQnes IIg0v0ER05zyDYBEfYoqrfeTA1jhuD7C/xKcgEqJ45XANnUUksiUBCDSdpvbVRuVa74dxzWBqYOX0 TF6KWRH9WwgI0oKPy1ys+KCtlaRDxOiODr2yeb/++ZojxDTQnvTXgsjQvHxhgG65Z/RFrcIjPWyma ylLuSvH35X6nSgX0+Cb4VhD1sDzrFjlnrbzeNqzLaAH1M8Oomm52ZMaGh8TCsPKm8lDLkkl7W+5i6 nHjweGFg==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tpKgl-003VMD-1r; Tue, 04 Mar 2025 13:19:32 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 04 Mar 2025 13:19:31 +0800 Date: Tue, 4 Mar 2025 13:19:31 +0800 From: Herbert Xu To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v7 01/15] crypto: acomp - Add synchronous/asynchronous acomp request chaining. Message-ID: References: <20250228100024.332528-1-kanchana.p.sridhar@intel.com> <20250228100024.332528-2-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250228100024.332528-2-kanchana.p.sridhar@intel.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B508440005 X-Stat-Signature: pa6w6g8cpw3pir96t73taj94jaskzu4b X-HE-Tag: 1741065580-459096 X-HE-Meta: U2FsdGVkX18Gqaae5G7erTotVhbiAdGeru6UBW3VMKsyT9Y4MpAQOWRDX9EIYJtamwbYVL6OtlAnQeaAihzBhqGnKi4b/5pG6h9fM2267PVrcbSzhppSoxdhnl0uwZ67OSHLQh3iG8khX0o+r80kuu0WxJRnHJGe72/K8JzQ0EzO8lBbg616mkP/yHAM5BdB8fybcvE5N64dRGdnOnNPJO6V3cUFdDaKIlIBTGwDxYw3EtEEwmXao4jzCPHrmbIwIZnKneGxgTcXfCj6/frvggN3YUmvvKa4i4ObEVYO5rtGYVUZvDoZJJ2PphB7uC+Vy2ImcLJy5b2If2FAQGU/3FpoVCN0zIlPihb/vEzhvOPmchotoMkEBzM2BRDPo365ns1hA8ZXA33mtoOx/o8ogU3ksNfguV1RGBtEBsUdNq6v43c39uVGq71I12vGk5/aIfOT9cTlv3SXAdyTReJkJ2pUfX1jkjJWxf9boI2itf8gQobohu4GTE2tVd41WLXlS2YsdD7tT+H62yKVz3Ze7Dp7lVZZjKsQp5ktiMolDwfggLyOA7meZ7CrXLg8eA32P0FSceZYRV32+J8J84CXd2F+uE25ReKV1wBcT3twPXW/1Rzb8487wqtrxCpn0nNB63w/NWRbS69hK7dbQSP6alPEjgwONCKZ4IZqOiu4RM8nKKOkRkTFIL5uSUAkR0QpzPT+u5LKnwEsNWRcGuOCrP+m6tzFL6F3wN76Osc1L080d2e2CiXAO1NHdvZWLcKdROjPG62RMn76vHdvr0q5bCMB2vJJ/7KMxqqHiwE0nO1nNfZ2KTce3dfcd9P5wUclKbIn5g7q/e49Wr/fDRSDN3illnBVkhCxzaqDDSQU/rFW91iGZZOy+UlUqxjrnRUdXsdKl81kXf8CoNJFXUaI2TxgTraG4KQIB9I/z6rmFyx7/213/nRfniKW7dUGZG6G7lT6u5y45n/LK80nG+y 5LWA/6oH quYWV6Q+dSHV86HXg2Dq8aDH5Kuq2D0+fRIgyk1SKbbVdNN6Uezey1QxQdhcteqgIl4Gtj2n174rFWCuNxx9XY58/dVPWFGjYCK0FXfVU6K5AgnVsWSgdruZ2eHCoEyknrEUYmshxifr5+1e8oGbedb/UT4nA4RoilAHdl4+gms6vpjF6olkRj+uxZmNnoPbQ+x4hPhYuU6jZVWcwtoTSTxa5fElWRfE2djGUSIrpYAWzxsB2QSZTbEnL0BjSjZKvof9ts3RVr/2rXFQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 28, 2025 at 02:00:10AM -0800, Kanchana P Sridhar wrote: > > Step 2: Process the request chain using the specified compress/decompress > "op": > > 2.a) Synchronous: the chain of requests is processed in series: > > int acomp_do_req_chain(struct acomp_req *req, > int (*op)(struct acomp_req *req)); > > 2.b) Asynchronous: the chain of requests is processed in parallel using a > submit-poll paradigm: > > int acomp_do_async_req_chain(struct acomp_req *req, > int (*op_submit)(struct acomp_req *req), > int (*op_poll)(struct acomp_req *req)); > > Request chaining will be used in subsequent patches to implement > compress/decompress batching in the iaa_crypto driver for the two supported > IAA driver sync_modes: > > sync_mode = 'sync' will use (2.a), > sync_mode = 'async' will use (2.b). There shouldn't be any sync/async toggle. The whole zswap code is synchronous only and it makes zero sense to expose this to the user. Just do whatever is the fastest from the driver's point of view. I've actually implemented acomp chaining in my tree and I will be reposting soon. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt