From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA85C28B2E for ; Tue, 11 Mar 2025 05:57:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6087280003; Tue, 11 Mar 2025 01:57:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE8A3280001; Tue, 11 Mar 2025 01:57:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B65B8280003; Tue, 11 Mar 2025 01:57:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 96101280001 for ; Tue, 11 Mar 2025 01:57:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C8998121962 for ; Tue, 11 Mar 2025 05:57:48 +0000 (UTC) X-FDA: 83208213816.02.9AB0C8B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id 343811A0005 for ; Tue, 11 Mar 2025 05:57:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dmTErZmr; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741672667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4roWiPw03UI2aivRO5WHWmI1ZzqHNPPBcsULnHPQ8VA=; b=MVp/wWwBJACuLH5CAfl9Gh3sN3WxU510C0tSIna8kgdl+PycTCogLpCBA39DlmU/J68E7l qB0juMNJvn5KtmjH4wjkWGo0an0SGtnK8siBDLI12FS7qQvEL8FcUCimwIXSu07bV8Fi6L IanH2OWgD8hKnJ4DnQ8Q1MG4c+MyhXY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dmTErZmr; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741672667; a=rsa-sha256; cv=none; b=z70s7vjC2m4x5Kq0C2aeO14vQkqubNWK+v0jfC8ZXaufTKXe0iFwPHg3ZJ3fF82HfAZaTq XgRLqZhNazPDIg1UnePKUM2CxZTfFL7U6ZnHMy2f5WFxG3f92epNfCKawSfcQMP7M4z53Y qTFfHior3pgBr6SyahbjH8O8HcZEf5E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5E7E7A45DE8; Tue, 11 Mar 2025 05:52:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B78FCC4CEE9; Tue, 11 Mar 2025 05:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741672666; bh=BYwU/E93/QHnTs75zXL/K5KaaL59dt5dqcEKsspSbzo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dmTErZmrStaJuWPq1Y2KiGUlkJyWnCTthhB4B91JAVbdcH9I2nMKyf/7Fd4sug/pB N7nEu2kNBk1O0Ul+w/IBo19oXH5glyY2bbtD6tCtn0BJHbkHTd1iWoNnx2w3T9m+7H IxxQVA4Y4Lv0jGi6PXT0q9QqF5s7ZqRI2g89QBdwAFMPmOQwhOa9TxU3xtlxsqpRqF lYy7nKRBTlEc1vamVRBquPAmfL9PiTgEWIBb6xcf97y28M06V5hY0PpqPM3HaTZw4K HfU+XsvU0VemNSiwuoybyIXmF+A+kWMDABoLN29HvFjqUrPbxMBmNFc1zs7FVelcPG fJ1v7DiVKuKeg== Date: Tue, 11 Mar 2025 07:57:23 +0200 From: Mike Rapoport To: Andrew Morton Cc: Alexander Gordeev , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Dave Hansen , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Gerald Schaefer , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Jiaxun Yang , Johannes Berg , John Paul Adrian Glaubitz , Madhavan Srinivasan , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Will Deacon , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH 05/13] MIPS: make setup_zero_pages() use memblock Message-ID: References: <20250306185124.3147510-1-rppt@kernel.org> <20250306185124.3147510-6-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250306185124.3147510-6-rppt@kernel.org> X-Stat-Signature: 4b4f5jt7c6ibkscpr1u17dx36cmoc3xo X-Rspam-User: X-Rspamd-Queue-Id: 343811A0005 X-Rspamd-Server: rspam01 X-HE-Tag: 1741672667-535492 X-HE-Meta: U2FsdGVkX18zSmbagtsWUL4GagkPR6mSBFYkoYalDtzjQ3nxG5DFinVGZ0rsvvskRiw6x6gWayZmxbNPPyA/eD/G93xrMWBkMWCMQcHV3LnStOm2skN8LDz6MOfgwBfRRLhs1OAdYp68QQ90epxjsY2fDupIqscAbUgpj2cqXzyh+RkGc1CT49bkVILRnLrTTRIIO0n7KPDnpBKjt3gjIB8pReZpgYl9UgIOgWgh9PjD7Z2TteP6WS8OeHj+yQ8jaUxXh/D/eEEqf7jBP3GOvz4/2iknpgA4dImD0zAukfg4hDXovvtmMDSqRYf8gLm34EX7AvtPzrW32F5UAvarCWI3cE3eD1n4ACJX2qI9stpQ6PXJDW6TRE00J7BW3fHH9/tOTtENzsWl1M8zTfC+T4NTM66LtGex3K7pb97mN9+q0/F6kE94OqUsiMwih5gEmI8arLiq4d31hXPBW1EXDK6xg+/gWTRdEGlvmwBFL+Ow07RNalVlGbyYT/h++jn6GcZndDippEprzhAWTAYoKyw3mj3LGL+DFMb2C2Lw/zW1BBa1TIjB0jE6c4UYxhgvis02U839s/5gYWK8SO39bAGnw7yZasbX9MteKXqniAFJ5LkOnDcGQM8sTolEw2bJWnr3/46SbyBRWjE3aQ1BfWTi/Cd0rwx94Dfikkcm1oahRBv3kwT/gIPVulRBl3IUUsxtGoqA4LBGPXHzTP9dLJwKS2fhoUfDpK3jj21ipoTgCaDlAfqJ/lVXi9Be6lJHK6vi/mjO66v5QjFZhwIQPqWeJ+s5gmVKERWq6SRGIf7z0A7LGZLaGSrlFVayb1jS11ONbVfr3/bDbwMvTOoTw6IZbLOUyBSva1Yn64/LwuZ/4r9BeYi1KffYSSuJ6HdOWUC4vYl+aDmpI2h5I+eJSoIsI7Bki35YXD1OxY3WdB8C9nnrFPHuxpH4gi0JrcStKZeiKywj+ONjlNXezw0 UuNiTu+N tWpTAJRSd6f1a8lzCLDQYbu0+LGAbQ4PAWLYFhw5qCdScgKjFndXNEKxTSKoKXmB4VRhnHUTDUy7h7DpnKbxZNakA/3X5W11ZRhRhqmn88NpD++FNV+gMznP33DFb9TKzQp39hCjpRmnj/+6GLK8SMvbrsEs5HqcBtLUXAhxNQtxjlA6vBmuOz2VlfYcDdpNyhMZ8pOYWhtyQZc06/QGaN9rsXQSIQFclO2GkelhgU/6uDv9Mq+gi/6rVoIkXSLV4kS26jD5/lFCeWYtJNoxAr23CNKQU/MbdRIuR+mqIrV60hlEVFc0iEFdJUcE1KX3LzsuG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 06, 2025 at 08:51:15PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Allocating the zero pages from memblock is simpler because the memory is > already reserved. > > This will also help with pulling out memblock_free_all() to the generic > code and reducing code duplication in arch::mem_init(). > > Signed-off-by: Mike Rapoport (Microsoft) > --- > arch/mips/include/asm/mmzone.h | 2 -- > arch/mips/mm/init.c | 16 +++++----------- > 2 files changed, 5 insertions(+), 13 deletions(-) Andrew can you please pick this as a fixup? >From 148713d17cbdf7a3ad08f18ba203185b70c0e7c2 Mon Sep 17 00:00:00 2001 From: "Mike Rapoport (Microsoft)" Date: Tue, 11 Mar 2025 07:51:27 +0200 Subject: [PATCH] MIPS: use memblock_alloc_or_panic() in setup_zero_page() Signed-off-by: Mike Rapoport (Microsoft) --- arch/mips/mm/init.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/mips/mm/init.c b/arch/mips/mm/init.c index 6ea27bbd387e..a673d3d68254 100644 --- a/arch/mips/mm/init.c +++ b/arch/mips/mm/init.c @@ -68,9 +68,7 @@ static void __init setup_zero_pages(void) else order = 0; - empty_zero_page = (unsigned long)memblock_alloc(PAGE_SIZE << order, PAGE_SIZE); - if (!empty_zero_page) - panic("Oh boy, that early out of memory?"); + empty_zero_page = (unsigned long)memblock_alloc_or_panic(PAGE_SIZE << order, PAGE_SIZE); zero_page_mask = ((PAGE_SIZE << order) - 1) & PAGE_MASK; } -- 2.47.2 -- Sincerely yours, Mike.