From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20FD1C282D1 for ; Mon, 3 Mar 2025 16:09:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A7016B0083; Mon, 3 Mar 2025 11:09:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 856F96B0085; Mon, 3 Mar 2025 11:09:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 746536B0088; Mon, 3 Mar 2025 11:09:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 50C596B0083 for ; Mon, 3 Mar 2025 11:09:42 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F13EF80BC0 for ; Mon, 3 Mar 2025 16:09:41 +0000 (UTC) X-FDA: 83180725362.02.8E01202 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf03.hostedemail.com (Postfix) with ESMTP id F130A20018 for ; Mon, 3 Mar 2025 16:09:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Odbw4cwU; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741018180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6IjgIQMjyLmH0kadGKdaiTf4ALagXCihpSuhgGvaARY=; b=Qht0kDQqKDLLOVRQMQI4reHtM4X5oJzI6fXEs1Ghf4+FrvAt8paDoLqJ3NtTkIvf5RfyjE OtkPs7bGxfbamxEc75QXuZLzHxhus4K3h6wXP7x/HD4K3pmDqljMutcEf6rx2rGzS14piS HQnufBi3ySqP1vpRbd0vV9+nOheVgGA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Odbw4cwU; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741018180; a=rsa-sha256; cv=none; b=n2LBwjZt9K8o2kjcQwMWQS3Gw+En1z/FhOREfZNAUJglnORoL2Xqg3S/vZqOZSaCR2XWVE /yRCc6a5YLRtmyoiR8xyoein8+UByZI3TuG3xWaE4G9kKpetHXUbioFXRhs3T3YVMvGQPW YDHvbYFKMoU3eSd+6dl6NVLeBilipw0= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-307bc125e2eso50714601fa.3 for ; Mon, 03 Mar 2025 08:09:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741018178; x=1741622978; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=6IjgIQMjyLmH0kadGKdaiTf4ALagXCihpSuhgGvaARY=; b=Odbw4cwUfpqTFKk0rN3agi7DT1fRmbKty3z7HuJhTPF68Jo0E+6ZKzBxA+d8nb3GJg LfSutAg+S4aXp1QNSwylMYEXkD4PB3MTNoZlxU84z5YRwH8YxuuTOkUKNtbMaIaul9jt qOfPkhpZIjf782Qlc2DmA8gsQ0KavvQOzLBG78PL8THX0AJfWfgULAPrJEMecanGgToz SVUtEfxctGKt7v9zPydcqj0WZAeRzwQo9WqkOan8d/QFCFpCCHfbRo0/Fx+o65yNyD4+ H6o39qbjnE3pD5/r954VgAmByZUlNVJIous4Yzr+esmcIQI/G4dG5b1NpZ19YpMIYFla //wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741018178; x=1741622978; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6IjgIQMjyLmH0kadGKdaiTf4ALagXCihpSuhgGvaARY=; b=Vu4molI/NOImq2ZidhjaEmkqcEBKEcsq1x89b4P62hBJVUF8hILCjx8PHrxrK974nY 5z/v/NRNNk/mhMKXiKd+Fj5MqfZ5DVmtTfjcuyKmn1DY/r7Qi05M9K1MYQnlMkupMoR8 yIRkxbW0vyyOqqY4E6eEqHanMkavWj9tcJZpGF2VTWRF5hq7pmQIt5gHrm86wreaxnvH qUcPLLktfF2e/HxG9sQ4D+7h/uWEN30kIkP+IECPahGkae5h3Bg91ML9L1C30BzNoMSl axbifF5aKsl5myg+KrQXKSVEMYiGXYV+Man57F1HhKekFdOAKYeIa66Q2FpUFH7zzGIM xkMg== X-Forwarded-Encrypted: i=1; AJvYcCVDoMDnpHgJK0J9qrfy6hIGeSAGhtAvoyJ9XPkmot/9rdYUL0m1bOr8X9myNlKVlsN/ddG1KEVJeQ==@kvack.org X-Gm-Message-State: AOJu0YypI0mE62AEvGs26L0hyO9IiDn+/DyOHOPVTusxKiH6qQMw1BH0 XBsKGyIR+Eu91DL/0adBJ18TjzdCfbbnbjN5R8odlYjIit5uvY9f X-Gm-Gg: ASbGncsSMbLN3YQgtky6NShlK9TH/qPEgIZ0y0kyNzoumR+ogJvTBUE9PGp8s+vuhb/ yqtaoU7BkIQoteHn3akkUv6eevBRcahOsXfhF2KqK3oc7690J6aGjHHIxCwwhhGreCJTBqdBfu6 u9HKFmK8dmsSlKRT+an2l7dn/llBlrqBda7mULVlDqsopNxCM9U0jCwmv3hIapBPIWmOeRLDcvb VX2AsknBLdGHGncbpBiBLkjFLGw9PVoPeXtvzT0s9Rv+IkYcntkkwkfgsIB7QzV8HJOc2ZcojZO Aq/XGODCKTQ= X-Google-Smtp-Source: AGHT+IHgc7Gl60rYTzinEYN7iW5O6cXP91XdcTk8Vu4+nkAW/mFzB+LhMve9YpX4q53LKkINULovYA== X-Received: by 2002:a05:651c:4cb:b0:309:1ee1:3512 with SMTP id 38308e7fff4ca-30b932f6e61mr57750541fa.26.1741018177893; Mon, 03 Mar 2025 08:09:37 -0800 (PST) Received: from pc636 ([2001:9b1:d5a0:a500::800]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30b9db4e567sm9919121fa.38.2025.03.03.08.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 08:09:37 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 3 Mar 2025 17:09:35 +0100 To: Liu Ye Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] Optimize __vmalloc_node_range_noprof function. Message-ID: References: <20250303094410.437985-1-liuye@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250303094410.437985-1-liuye@kylinos.cn> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F130A20018 X-Stat-Signature: un86cynqst15c5q59bgg59ha63dmtb4q X-HE-Tag: 1741018179-957928 X-HE-Meta: U2FsdGVkX18MY/JkTo1UJRLs6AUeCCejWUUGb5PikfMu9iVyP8Y0UjvD/G2+Xv/wV8pKqLsziMhxLycqHBhe/CtolsiwNhLjZau+ou9rx9gUdKkcDowK2p1RYzGQaPIShK7gQAeXR2hMDpPoNTSAlrbtwRqRUVl2Q6lle5tyJK86YY+dvZAZADJqN5glVA6PRGdb6tIEPfjTUFS727c/fL81If17d7vNOPZ+cIb40GzkJ+FmGKv0Iv/oozaICLFitcrCNcr9NUiLsHz+BSy4BwiYeVMkmR+cajr3YiujO784Q3a6AeunVT1R4GcUNAv56xLZ7fNZQ2G9S+LzzU+W8f7JJydc9uWR1A5j0f/+KGXH7g3wMSV++fqHhwCin4+GTtFF5i9ZKmQc6bd6jk4jIFUJMW64UY+gXa2qg+DckIHwk05x/OfgMOVbUkB3jDavAlrW+eg00PiLlqQ2WdtOkvzDrogdgDU79qCwJCqn+rRg8AtPGz0CcJOK2xDOyjkTQTgHGqDk6bjmGVMiwrmginfLVFOHFLYI+mCyC3WIsYKIXiIeIeDWorgmfjsmP7x/IcvYJBmEM7mFITvANodHtlww7TsV/dhuDK6vX3venC7e5/sOQM7Own2pl6/KU7g/3wpwatAskHRDZit6wVQrJd6ebKEa+4Eh/PBE/uomiTuJFjDdH0Ts5r/RaqTUGmbQyduWwSsRJSXWQT76+hRGgdwuOFJCmi2PeCw62/oUCJaaLgTuCjNca9KSLqBfBEMmS/d0KxZsN3jU1dgxN5fYtXeQvxBcHUcNR4ERQYDNFzxtnjim9bzbW8aT6T2yZ1WbyJjX4kxl406G7gDIrFDQAV/xoBYQWFQhoyYHk4oI+53wvd+wM41OvrhG/HREgawK6x3RgrEcKUtzZLQrJoakSBXG4mUQsTN8k5msXhqZg18kZ3pO1CE8YSdzAXbxoBnqoIPxH7aUNIz3r+lpUEU yhrw1aCG DvM+AVV3ie+xvdvWyqdpfXNxNWcvlO680XQR/O8TgWSduO85LPfOlH9vz8yibgWf28hT84hrxzNiK8zrevpT96qqSRIZE2LJ1Z8N3JksU1JK2l2VrbCkzoPpOPfVOMfz8/i/UR51WGENYXGQ7XK9WENYAGRmOebHoRlTeHJExMpBRzo/nsqALw1nYTKhcgryPx2XLBS+3komHIgZuw5IvSp8sIyc4P1DnaCmIAuXQ8CkOCPzUGbwVVwmpivBSqrweysLKblhs3Q7oSJ+MihJBEPf9KjEwdKO9mZhy1XHGyC5mMvSp7QzhV/7Kx58ZdgIpFHJq7vGL/dyKZCIHLMcvEnS1Rjg8nNNg3JO3jd0jkzCIKIY9DAImMTRglPfPMhxxDu9TzTKC8fhBjWiKYgB5ocfHYo9CJUrPKGOcOZ3d6P3QAUjOtiuXz+2yfqrKFmKrsKJey97dBSN6AqUOXqotzNBObkqLA35AG1M2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 05:44:06PM +0800, Liu Ye wrote: > The use of variables real_size and real_align in function > __vmalloc_node_range_noprof is unreadable. Optimize it in four patches. > > Liu Ye (4): > mm/vmalloc: Remove unnecessary size ALIGN in > __vmalloc_node_range_noprof > mm/vmalloc: Size should be used instead of real_size in > __vmalloc_node_range_noprof > mm/vmalloc: Remove the real_size variable to simplify the code in > __vmalloc_node_range_noprof > mm/vmalloc: Rename the variable real_align to original_align to > prevent misunderstanding > > mm/vmalloc.c | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > > -- Let me double check it. Quick question, this series does not introduce any functional change? -- Uladzislau Rezki