From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8CA2C282C6 for ; Mon, 3 Mar 2025 18:30:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F70C280005; Mon, 3 Mar 2025 13:30:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A6A4280004; Mon, 3 Mar 2025 13:30:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56E9F280005; Mon, 3 Mar 2025 13:30:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 38E99280004 for ; Mon, 3 Mar 2025 13:30:51 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8A3EFA4ADF for ; Mon, 3 Mar 2025 18:30:50 +0000 (UTC) X-FDA: 83181081060.04.DB755E3 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf19.hostedemail.com (Postfix) with ESMTP id 77CA01A001F for ; Mon, 3 Mar 2025 18:30:48 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JtdGwxt4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741026648; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NDT/FI9HyG67R1pizfIc2St2pqXpHBG0RFQRvwWXMEE=; b=ohP1IBRD1UeBEzTlct6ZuMNTQAGcPWCL1OUFTKuy6Jrg4q2IqlH+F/P2toIQ+fZOcKwyqg wkf2QnwnyaAQLb2zdNYcoxErk3fQelKrPWXFFwtA0JtLGbXV+oLO7nYXOxrDWFspV2pciE QuQ55AvMIvBwxEex/LR4j8tScOC4+b0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JtdGwxt4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741026648; a=rsa-sha256; cv=none; b=r2mXGzay4BKmX72R2dg9h78Dqbpe47ha+enyuPO+/x6nqjM8Q5orfxKcxLHJel/bY5rXKI zk64y1yVtBOHY0OKc/ZophXIryB9FqM/Nre9aplZXP0Ekl4ytl14cozihwHUZVVjFUUkFP ACHjYFl94hCwyt5ReRgFHwVTPL8/d8Q= Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-30613802a59so54597981fa.0 for ; Mon, 03 Mar 2025 10:30:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741026646; x=1741631446; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=NDT/FI9HyG67R1pizfIc2St2pqXpHBG0RFQRvwWXMEE=; b=JtdGwxt4sncUh7i0o7mWjXkWxFN7PGIh6VlDN3BrjBATa0RuOKFtcI9TagSK6ozO/9 1Pu7rdHTjQkAfxptNCZ+vOAlS/8zCRP0dSd5WAi1HWrwqa0ND++nxSM24M9smAa4LyFn lVys+0BzFQqCI1eS+foKYapuOfEbl8RMAjkLeGD5EF7hX/pvK8qPBcaKzS7fDgEeFZkV BdeOW2IDr8Ts2CDViXvMv9JJzAzBtYCAwpOfCJP6nhCf3sjpV6dHFvG+tOOFu5RU87xl AL09ADzKX+LBhM7GPoFHFbKjZUT9OXx2qtVpetpbiNMEidMBH6JlRhZXmTOhSQPrXL8B aj9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741026646; x=1741631446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NDT/FI9HyG67R1pizfIc2St2pqXpHBG0RFQRvwWXMEE=; b=py25WNYLtFI0J9Qq0nlZa9XMdixLUHkOQsgyCvd0NHh0g0ro096AQ5eanDgOp9ROWT IhuAxNvkAnkyywWsehfuja4FsZZtFES/rjraBhNbFV6y1+nV4UIbQ25sGHKjAP/5YUOT 1ANvyKG35HAgNwJBOGWR4/D1IvTWKMueokX9dHgMayFiWzolK0zdmlF0oDR4f9OCjVy4 JDDlhp6ajGIv4j5VDCyvIaWIaiwOlNjYedqIoSX5Fyd6cp5xuHlYOan2au89AqaSNGTT KihfxRL8Uo3e7W4EZ4zRSZ0wHOeP7a3Dlmikz6BPKUOv6wKwlmlh1KmasAo1cBCv5Kq+ 7kmg== X-Forwarded-Encrypted: i=1; AJvYcCW9kCaxuQhP+kwWqn/0Mqm2EHrF5FDvh+2Qnb5ju7uMMtgquJ0Old8Mrwbf4ka4r+GnXOXL8TGBhw==@kvack.org X-Gm-Message-State: AOJu0Yy1FWgJ5pR8rwsB1SSeUJgphCOVeoA3bzInZ+1nj4jmjK9vzBqw oCp3lvEOwPrwL1WabhuMv4H9WtBqtrfz9t8fobEPre9KbpwfK153 X-Gm-Gg: ASbGncsBI1+wST4OVrKNlHONvQVd2yiQEz7Ht5cF/ezRLaOYp2l800B+5651bMNbhBx Aqh9NDpfenRu19t1K+9JiQZxFhv/Spp04hF2jLrvs6mfA0KZEN0Ip0gODSkj/VbXEZ2AEaaoEYX jAlSECqHgiDqZhp6zrLFgh9S6kZNFEjKiyZhU0xeUMtVU25X0TTy5C3bqlJzDT5dIbqzS3CayYH MPtpZHQ8rJzqaZBXPcmm64bcJ9d4EBZ5QD77BmBnxlii0vh1QQZYf3vBuVUCZp6D0ZEHirL+ZSQ IlwhGGUnzFs= X-Google-Smtp-Source: AGHT+IHNJ6M+a6taADL1+o1egBEFbGVb+GeAIKsRYROrzEot5rwJRNJap7Ha4uaDJSAQ0yBH3zWdbA== X-Received: by 2002:a05:6512:3d0e:b0:545:8a1:536e with SMTP id 2adb3069b0e04-5494c129f17mr4958302e87.6.1741026646003; Mon, 03 Mar 2025 10:30:46 -0800 (PST) Received: from pc636 ([2001:9b1:d5a0:a500::800]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54963962fe4sm507952e87.240.2025.03.03.10.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 10:30:45 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 3 Mar 2025 19:30:43 +0100 To: Liu Ye Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm/vmalloc: Remove unnecessary size ALIGN in __vmalloc_node_range_noprof Message-ID: References: <20250303094410.437985-1-liuye@kylinos.cn> <20250303094410.437985-2-liuye@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250303094410.437985-2-liuye@kylinos.cn> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 77CA01A001F X-Rspam-User: X-Stat-Signature: xdqmy7tibfxaxt6nho87rtkbciom7i46 X-HE-Tag: 1741026648-635177 X-HE-Meta: U2FsdGVkX1/XcJDwX1bEOzY4o4gzY1XHyE6zn8uX44sEqEvbuq1SY8utXdRpGz9htK9W9B1A7ot6vNeSsJv7DQDmUXuwEbKVieS6ntBpT71ym0eP44Kud3436i3fnKlQWf0kjsv3QhS43pnSEWs+tNh15XFo17iGBaZaf1y5Mq/nza4OIk4vQEGqWBZqajC7gGuYuVHAKqtbhmVr8m384z/T/AbuXcnYq9AnbNasIhomh/vwtjPbFR1vkGpw6MpmqiKMldsEqj9YFAdz4LU1RIKdrG9NbOYbW5GZpfJOFrCzClhuYiIsi8hWkBNzlhyCm0lyfL8ZEQB7iayiGOMag6msKdfbt5ubla+Xs9f86rsH9DXOgIlIL5g293GhMsIlSgVqjHd2s0YTtFMW4vDxJ+qk9QSl4PCatbqgkJ0f/6Y/vLehGKfV4W+QIzANZbFfv1lCcbVV7ZkLSzFHWdkEIPkAogQUNcPU++tVRXlT89FvYiXgZg1vsLn9UGrr82Rf4w+90QGd2fPEtTNT32C4zpXioRcyxAB/2CrO2ZSTYrinFVeqw+e51vIfuYss4aj7qSWc3lO7HGpn+7+ngq/GNzVTFEXNXTZxDAhDV3WtjFhMnQFe8WUvasWH4DaSp/j9DwQOPuZNV6xQQa+2RniY469otkoNwcmJk3FO68XWmknB/FX2tpF8r29w1t7+ia18SnWpm/6EwrMPuDCMKMV5FFlpA53d2lYvmvyYGBXVFtGaCh3FwE9lgYxj365yq2gJ6biv+iqAgTfRLMln1wmUwBgqEFvyIQKxp1QzAWt+zdP7jWQL0qioj+qbWD7AqhL5a8k+B4wzfb6wUZ0eKXuh6S3br3CZQCtaFm6Lo562ROxhG2t6iKzJ0UrGPSlzdQYFXVbmUTDJ0UK63xl/cmZYJUait0dGFEhHGtbFvDtiw9YUthViur5D9/VSc5Va9AONptd51tCxuK+ACVA1+Ww fLdAQazb TZNBSyaM0JnHTLFzk9BL7RFYTuSef2pU8JboI4tNfUxeWt6GMb2QiWSDCMKUbDjp8aM0zxiQb30ZBK9YGXwO1r6S07wiVLR8RQYbvsHvEurgdb0qAS1YQNm/p4amf2qTagfIaxW/y7ZM3FlKMMS7UuMWRc0uCrnFTYlb4rR2n/j3ABqyI2Lc5vA7SVl4rlG2bh4UCIw4jGQqD1L8lLsNosx1OifC2M4A4oJ8HC3q2dj1lU71u0KDIJcsNQm2W8LzLDF79UBsOsNEujfOC1FDngrjTMVPHJvzS6fxhDaVnjozv2MihrJMPyzuWXnO8cTj9yGQOL+T7FFhuFC6s2+Dd56UIrs3KYrbazlEvuTKZxdAhjTVHM73eYcMAq1ACEvcNrYPSp9S37XF4QnJDzm0Sp5QEMXpA/L9AnF0VhpL7k/EexzBRXlo98KcR1aiuda7NNIAOcSNcEcdJI9AKHnHHVh7wDrXtoigGIiZIncyFe83q5J0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 05:44:07PM +0800, Liu Ye wrote: > The same operation already exists in the function __get_vm_area_node, > so delete the duplicate operation to simplify the code. > > Signed-off-by: Liu Ye > --- > mm/vmalloc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index dc658d4af181..20d9b9de84b1 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3798,7 +3798,6 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, > shift = arch_vmap_pte_supported_shift(size); > > align = max(real_align, 1UL << shift); > - size = ALIGN(real_size, 1UL << shift); > } > > again: > -- > 2.25.1 > There is a mess with: unsigned long real_size = size; unsigned long real_align = align; "real_size" and "real_align". Those are useless. What is about: diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 5c88d0e90c20..a381ffee1595 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3771,8 +3771,6 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, struct vm_struct *area; void *ret; kasan_vmalloc_flags_t kasan_flags = KASAN_VMALLOC_NONE; - unsigned long real_size = size; - unsigned long real_align = align; unsigned int shift = PAGE_SHIFT; if (WARN_ON_ONCE(!size)) @@ -3781,7 +3779,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, if ((size >> PAGE_SHIFT) > totalram_pages()) { warn_alloc(gfp_mask, NULL, "vmalloc error: size %lu, exceeds total pages", - real_size); + size); return NULL; } @@ -3798,19 +3796,18 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, else shift = arch_vmap_pte_supported_shift(size); - align = max(real_align, 1UL << shift); - size = ALIGN(real_size, 1UL << shift); + align = max(align, 1UL << shift); } again: - area = __get_vm_area_node(real_size, align, shift, VM_ALLOC | + area = __get_vm_area_node(size, align, shift, VM_ALLOC | VM_UNINITIALIZED | vm_flags, start, end, node, gfp_mask, caller); if (!area) { bool nofail = gfp_mask & __GFP_NOFAIL; warn_alloc(gfp_mask, NULL, "vmalloc error: size %lu, vm_struct allocation failed%s", - real_size, (nofail) ? ". Retrying." : ""); + size, (nofail) ? ". Retrying." : ""); if (nofail) { schedule_timeout_uninterruptible(1); goto again; @@ -3860,7 +3857,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, (gfp_mask & __GFP_SKIP_ZERO)) kasan_flags |= KASAN_VMALLOC_INIT; /* KASAN_VMALLOC_PROT_NORMAL already set if required. */ - area->addr = kasan_unpoison_vmalloc(area->addr, real_size, kasan_flags); + area->addr = kasan_unpoison_vmalloc(area->addr, size, kasan_flags); /* * In this function, newly allocated vm_struct has VM_UNINITIALIZED @@ -3878,8 +3875,6 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, fail: if (shift > PAGE_SHIFT) { shift = PAGE_SHIFT; - align = real_align; - size = real_size; goto again; } ? -- Uladzislau Rezki