From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA398C282C6 for ; Mon, 3 Mar 2025 10:35:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B91B280004; Mon, 3 Mar 2025 05:35:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 56903280003; Mon, 3 Mar 2025 05:35:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4305C280004; Mon, 3 Mar 2025 05:35:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 22F5E280003 for ; Mon, 3 Mar 2025 05:35:01 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B34EF140659 for ; Mon, 3 Mar 2025 10:35:00 +0000 (UTC) X-FDA: 83179881960.14.6BDBD99 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf12.hostedemail.com (Postfix) with ESMTP id 814F540012 for ; Mon, 3 Mar 2025 10:34:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QCbw+8SM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jackmanb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740998098; a=rsa-sha256; cv=none; b=zC+k6zHNz5gUzzNG/Q6c+VgkIqBLzvvfM+qeGjckYrZQ42G82WIDsVA/zSLXrmpeQZoTD7 hTZz5K4WTlFWhvg7KONAVZTQF79robpyRcXduv/7SNMLNCB6ZDfRiG31+W8ZfkeBSgtKI5 iHhp+VRj8mjFg5O+sCVsC9eQgvXf2cc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QCbw+8SM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jackmanb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740998098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+bSaBNG5Yoq7k/pu/7absa0rkEVoeKeNE/Soa/XJKAg=; b=wVIkIawSMwgO9xWUJ8Cmbh4g28hI6+Nyoalr+iTeEt9R2o9V+ptbmXgFrZ9zvdeINJOij7 Idh3tzFuW2XxSf6mI8cXRy8J3NQ8Q2dfF97Pf6Po9YIkCS3XKBKYbnWLkDJ0wdSvEmIuW5 JNdmkTDKFs0gwh9MKJTjadj14WiokaM= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4393ee912e1so67825e9.1 for ; Mon, 03 Mar 2025 02:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740998097; x=1741602897; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+bSaBNG5Yoq7k/pu/7absa0rkEVoeKeNE/Soa/XJKAg=; b=QCbw+8SMqKd+beCrrB1C4aQcnF2bYMBGNXZyzqpBSc9a2jvYUwLimhGE+ZIGZ103+L I4bNAx7WnVe/uKSCMNjMpnjJOEi1C5bQH5G+ajtGXvUowc7n84895T5Lhe8ziT6tCt4h uzhHMyRnuvI/fkXWAszFBFwkBFLLX9PxUO8l2RbiIfVl2wUuKX2lvxPXdd8U++P35rMI FlmD0/UgyURqMaOYRPHGr0m5a96jB1jBXl/QYEfDjOOW9KahZTbYmRTBc3VyNO/6oICe 7dQLJ6wpJJUM+2fiPt3TNFIZQxYn7qilh6PxVOnVYtw3K3SW5/3r4CldzjolJJkFBZC9 Xm5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740998097; x=1741602897; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+bSaBNG5Yoq7k/pu/7absa0rkEVoeKeNE/Soa/XJKAg=; b=bq0bx91j8VrBrgxt3akMfb081OYFgnFeNPRAoJAXAUdnsbF8ayQPo5Vis4T5gAy/zp mVMBlETXMQ6N53eVO/8uu1huIMWCJnLz1NEqPxOM8dr/AVTh8QdRiNoQmcu70DEoo/7L SqGpPrkhzJmEBAanXzMJs4OMPHnbZKGRB1tXalJXn7Di8Fsd5CtgUp2a8I699/pSKLhB f4/gpcgf7Rr9Fg+wGxy81r7bwy4RcM8yJHJ4DwrpCEGr59Rf69D5vn2CYumOgc+eFagA qiBlQNwGk1ywxg6+vZupTlWib2TUvN2vGC1JcFXjWH6kTfQhP9Xp3qApwhXLCSvz/idO U6GA== X-Forwarded-Encrypted: i=1; AJvYcCU32r1nybohrdUQqt7SpELus7X7u+FpupWWrdMCGbQGMsLIn7PmXtX7YQF/wnJbF8IraJj8YFMVaA==@kvack.org X-Gm-Message-State: AOJu0YyaqeGEJjnIVxTvIv9H8WcEJ91eAVHHuc9Osm7a6kA827SMb8jz 3VmIhmszR8D9Ot0chdPhtzwsxnlBCFLGEcQVGkk4FuD5SvmLxmZlAqMZ8MjczA== X-Gm-Gg: ASbGnctxifK0stsgOwe1mLFGILApWUPx/hIi3H9Kp17DsG99tAiaQ6yeEMAYjFjygOx YEhw6JpquPLHJddtneaHRU3PmoE+GXsHci6ItvJ33SmkyHgQaYkqqxvbKXdynIonVMxnuKfnq8y HG6gkvCdcB9whXbMdPnKLMclPv4OcNkRuwhQ0WNJi0gUbFjrwO/wEVXPpRxZn1VQh/2WKulsOsU HhXE/3yPAVSUBW7VW0k6V49tlUZsYR203aOVxONMhozNcldI0SpQU1IDDv7OBl2GmAtyriS3vYg Z1rFAJwM0/s8UcLgCbQigjR4V8ZlWhwv28TxVIq+tyxLmeCNVAP3UOkUmzEEFE2kR5aBVf/Ez8t wndZY X-Google-Smtp-Source: AGHT+IH5+lAh4aDnKOfBgCart5GsF44/Ttw0+2rACrYtMiBk/Nmmsik0qBemWNe1gfOZHSa/eQkRBw== X-Received: by 2002:a05:600c:47d1:b0:43b:bf3f:9664 with SMTP id 5b1f17b1804b1-43bbf3f96f9mr1090565e9.5.1740998096859; Mon, 03 Mar 2025 02:34:56 -0800 (PST) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bbf2ed24asm41351505e9.23.2025.03.03.02.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 02:34:56 -0800 (PST) Date: Mon, 3 Mar 2025 10:34:52 +0000 From: Brendan Jackman To: Dev Jain Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/10] selftests/mm/uffd: Rename nr_cpus -> nr_threads Message-ID: References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-4-958e3b6f0203@google.com> <18ea9794-3901-4802-875c-b0327984a9d6@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18ea9794-3901-4802-875c-b0327984a9d6@arm.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 814F540012 X-Stat-Signature: o5hkwrsqp33k3o9fkxxdcg1nsme3prc1 X-Rspam-User: X-HE-Tag: 1740998098-665746 X-HE-Meta: U2FsdGVkX1/zbcyihSyPTOp0iZDkcklUirNR4FEANlrG8ajbiIDYQmY0oaaR37gMA7cRj5b+FDDFwi6gFggs0VGn4y0v6pctZJ3FdMyyPVJPPLSlO7mte/DTNy85vEGWxuz3E9kxCcqpWPEZbtMvAZcmhQZGETlSVIOztbQERBU/hCTb18KjMAhCUV3g47WRxEcdc9qqyHL73CdOXcjrhx4IWFwQNOPQpZv7qDFqNLDjVJtut8UIOTrM2c9EgtqF0z6qRa3hedw2VXjHOOCBbGwAxm+3+6m0UpJ5hDPsJ0yfPjocuLaMjHdv0NliiHDR+qSIgLt9e43b1hPa+IbXC08i5JWD5iyNlMT9JgYd7DXwYGLP14hDY/85BQrAJw08NH8zzs3wdgPM7DDcwtnG2Nn0nPJ4NE/t/DDpT9isP3zgSUdavRBb2eWOBkP/V8bAsJGs9kXWDi4VgJjGe+pbxI5GdmEiqy91rrl+O9Vrd5zV0XHJohZFcwkFGK90OK8xtyU+V5jYhNdXHb2F7aXLS04LK0KimoqduYL4yfzJ0mJC5oncbJw/CxtSJQcQxv4j93FntZY2xQJQlt9ikU7+N7/xDBMVIjsSGDEsgwj9/7rSrrac6Bj9Ja2n8yMfXmsIlUHaq0Qua1teTONfh+V1gE0qEKtZ3AB0NWr7/2tPswPGlNt1h8ASSBxR15+LSEZ1giq/rlM1+4nTJk8s+yElnZAeCXRMjXgG6eYvlXruFah5mdHBCLVauGoVeCzT06zCMLmNKHFwVm2KiKz/RUwBE6fY1AoE665iFS4Q5lWMCsb+to9zOlXTY0zqAg5L3zQVOD+Xn1UCA/GvGuXdwIKfRMXKTusXZwJbF2z2nhpUeIi83gQK1w4n25PmW3zG3Nbzzmeor0LT8EcYEcNUy2iv4Q2hCShRCq8zyEDeyGM8opQ9WtSA1l0S4ALFyU/JU5Kfv8XYL3yAn2NQtb4Ze9m RAUSykWA 0554c4Q2/gQ+HkGfEuRpajt0fCf30Mk+R7F4+HbkBLFPsFV+P0xYMlLiUlGxhfA7MLpo862mfuQLqOEk02fsjPMtzJ5E3f8ZIEnb2rLw9XdSxlWONx4p01oHUYdX5ap85ObK5m/CmnikJda3Jggc0Ds7eDD6YvYbO9D/ZLh+yUIKe5Bth2WL6Fb0EGACEHpY+c8oEpdKvx/Get503xRZaessuyLDcjtn/VcYTqrAfAsgbSX982JPXKCeDrNBvijlevlX/xbrKqoaAuqHV8qJBP1JnRF93+FWvlKB+jrjBuQzAb7DAdZpAqNrrL1REE+Oq9pok9iri1uG2Svz4Y8g+cNaAYB7SDoCnIA9UTXYWc7m/bG2ebn/2hocBUCbuvPqln1HdJP7CovBcqW8ydqx0CiZBbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.362642, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 03:48:38PM +0530, Dev Jain wrote: > > > On 03/03/25 3:17 pm, Brendan Jackman wrote: > > On Fri, Feb 28, 2025 at 11:06:35PM +0530, Dev Jain wrote: > > > Taking a cursory look at the test, it creates three threads for each cpu. > > > The bounding of the variable is fine but that being the reason to rename the > > > variable is not making sense to me. > > > > Hmm yeah the name needs to be more abstract. Do you think nr_workers > > would be confusing? Or even just "parallelism" or nr_parallel? Or any > > other ideas? > > > > FWIW I briefly looked at just cleaning this up to remove the global > > variable but that's a bigger time investment than I can afford here I > > think. (The local variable in stress() would still need a better name > > anyway). > > > > Thanks for the review BTW! > > Your welcome. > > I personally prefer leaving it as is; unless someone comes up and completely > cleans up the structure, let us save our collective brain cycles for more > meaningful battles than renaming variables :) Hmm, I think that's a false economy on brain cycles. A variable called nr_cpus that isn't a number of CPUs is bound to waste a bunch of mental energy at some point in the future. Unless you strongly object I'll go for nr_parallel. It's not a great name but, well... I think that probably just suggests it's not a great variable, and I don't have time to fix that.