From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B5CC282C5 for ; Mon, 3 Mar 2025 10:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AF4E6B0093; Mon, 3 Mar 2025 05:11:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65EAE6B0095; Mon, 3 Mar 2025 05:11:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5266A6B0096; Mon, 3 Mar 2025 05:11:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 33F1F6B0093 for ; Mon, 3 Mar 2025 05:11:32 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E670FA328A for ; Mon, 3 Mar 2025 10:11:31 +0000 (UTC) X-FDA: 83179822782.19.D93712D Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf23.hostedemail.com (Postfix) with ESMTP id 9489714000C for ; Mon, 3 Mar 2025 10:11:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eWHO8yCS; spf=pass (imf23.hostedemail.com: domain of liumartin@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=liumartin@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740996689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/tzoycHWkVx3E4Y+DlVXuOWbHG1IOfM7US2g+Qu04VQ=; b=dkbDdWlHVe8qxzXCbAFZqPnymZ87o5/Cm8iPw5nDwmWaYZIx2IWK0oDiDRB+9DWgxnw3iZ T1pn8O6TiP3NRqDkt7ZFqroTaAiEh+F9ajZaQDGF5AejTdf+DPgQM/Cq8l0mzJfMX29+cD qSHTqUvPF6LMmz+nQjk3nEJX6tWpvJY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eWHO8yCS; spf=pass (imf23.hostedemail.com: domain of liumartin@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=liumartin@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740996689; a=rsa-sha256; cv=none; b=sq/Txmc4363bJ02STik4gK3/xvvuTusFKZlDpsUJdwJRmnL1zNCU1K80R8mOcfJ66RqChq kTpFH7U84Pya3B08HO39kUwim092Fcez09rlVVsgv4LqXHhZTClnjngnTMcyxO9Ub5WNxO 93J+jRy2hxGqp7V/mdgZonpZyOd5nBg= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2237cf6a45dso30144695ad.2 for ; Mon, 03 Mar 2025 02:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740996688; x=1741601488; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=/tzoycHWkVx3E4Y+DlVXuOWbHG1IOfM7US2g+Qu04VQ=; b=eWHO8yCS3c1kiENeamsqu2qtyxvQiwOl3q6mE6WPzqwSjf+HrxpbFhlVccjpCPEQlg wmC7ScLxExHl9Q2KZIfFwTo001M4iKFFKi39mZMHQ2VObgTrM+oyUK3KwOWwaS2jVq6O 5u5BUmK54gsQdcH5zXo/vNRZWWGSsKj4i1fjnyHuspuGyrZw9Crbxn4hAeITRgTYoGXo qIm2Gs37nWtDUMpmEvoEyi/klMvNXAMP5sjeiYzHUlEz02I0kn0B+r0XuC72yKTFwZ3m uTiah9Cc0A82H9089nncuSs6P10t9oPCP7T8xwnu1AlY/dKzfOfn/M9rytFc4ZF/0K0g ic5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740996688; x=1741601488; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/tzoycHWkVx3E4Y+DlVXuOWbHG1IOfM7US2g+Qu04VQ=; b=bT+yI/1wzMUXPZq2G1WC2bvL9I8dzv5suv192EnNVj7CE82W6VmguS6FeDqiSxGCRy 2Xjv3+KOtN9eNNxSAKYbor1zJakQJMkmXEV6DmTREaXOZoCLhESPv0h31tp74FAXpu2w BR6vrcLsVFBNbGu2N7ga35vkuIp8XuoAqqMNl/je9gjby3KigeE+AkDR0Wbkay3cRfep N2zvqrpS+Lfl7WjKx3bz+60gVz/46Ns5PsC1nITnEk4Tyhq39NZZGz9mv11ai3g/5zwv F+Kc7Krbatd34RTenXwB9Xb2Du+jnbusXTCpYhBc53tCibyjSSsTCQ1LYWPZMO2da1o1 XwoA== X-Forwarded-Encrypted: i=1; AJvYcCUZIg9Y7MQetp42Px2LYdXfvhii5tdeYrJIbNBp2ty9nJT6KaiunbwwwSem8payuoGuofx32E+6Hw==@kvack.org X-Gm-Message-State: AOJu0YxR0oTK61MEc2iE/HYRhIPri5YOjd1u86ZLD7PegvOepyHlFwmX LetMp19c0aeFDe4WB/0Bzyd9xxSFmMEXG38+hjeeTq4aNiwk7c3SDPeB+P9hTlSujXl5tjDzKwk O3A== X-Gm-Gg: ASbGncsHIgRMYNKzQv5uP3AZskmpX7JLPt2ghJqJMXjagiCpLT3ZLMBAEJhrzSEzjrf cFVjheIh9stmXFblVZ5ZRfsUap6Ypz5xPq1qSpqz8gxe2fGRj4PoGXlZVtbAUSaHQZ0R2AV/XXt eouZhvIrvPdcsbu8KGGjkkZMACie46ZYoXtqCWAtw7eTnVSki1zPuK428TsI9n6eHKMteqTu5KV MXXz66WdCSRkg/R4PdINSdcSi0IDd49TikBa+EFsd24kMlefGMrpsYZ8dupZ24AoDX2nP+9zrxe jBUEoaD5cvHcz3db30Fjrm4neYlJBIV/yli6NBZMZi+8loNEXAR1rPo1gMzSnYxXjnrnNsb6zKB M1rM= X-Google-Smtp-Source: AGHT+IGOnjQ4iy0xEgElefK2WFurRrhNuqVnFRqvFF1Omaxa7ZtpMpeU2iSOp15l8p8qOWVEEogXBA== X-Received: by 2002:a05:6a00:b96:b0:736:4644:86e6 with SMTP id d2e1a72fcca58-7364644887dmr7962984b3a.12.1740996687963; Mon, 03 Mar 2025 02:11:27 -0800 (PST) Received: from google.com (0.223.81.34.bc.googleusercontent.com. [34.81.223.0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-734a003dcafsm8712797b3a.132.2025.03.03.02.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 02:11:27 -0800 (PST) Date: Mon, 3 Mar 2025 10:11:20 +0000 From: Martin Liu To: Kalesh Singh Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, surenb@google.com, minchan@kernel.org Subject: Re: [PATCH 2/3] mm/page_alloc: Add trace event for per-zone lowmem reserve setup Message-ID: References: <20250303073537.2264323-1-liumartin@google.com> <20250303073537.2264323-3-liumartin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: 6kzxscdk1bautd7rpmh157b4n7wiq1ed X-Rspamd-Queue-Id: 9489714000C X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740996689-313521 X-HE-Meta: U2FsdGVkX187Xp/8qnF0hpqefeGGo2WwFWNmxwyyX9+nJ6ZzVDtEkNhg3shnvnh9LOCqliyy5AVsATjkN+oSykDeh2QVYGLylMUCYGrL9PuXS/grdbedRHKSb0+Le2A7Wprz6te8JkIDOBKUBiD/1XxB4CMQ4p+uSYzpVe97N6+ttPBMP7Gbr8WI3c+we5SN+swx/db3ZhZxzZkQ3JPOJnYzC742x2CdI0mGnfQD6cYHQt4kLrcCeEZV6BSCzD+vKMVgaEIobYnKgV5CEuyZXqiINjgavgBCZbRtHGWBpLhO55ODwI6ydrq6LCu64iyi3cc0oZHs4ys3FNpKIlm7Dye5D43b4bi0WnW/hg7ZVRoKtQPWXiBdwc9EQBmg0OTwU2Rgx3qI9XTkIHVZ6hV8CTXeVnMDgpAqpE7gxLOfQ+BfNHLycXHw40V40UxTnGr9nmW4IBdQf8mjb82znjej1Mb2dQa51403FAWkRKjPcQ85DLDCEhU1ZHe+tjbobOTmFUIjCLmMd7W8dcUHodjSTjW0nyDVuqw/QGDRId7tVlgQKv4RpZLrCZ5KA1Z1telEbR7WL3MZezljL7kPWxvNZcw8gThZ+dHYVr0czrclFXOuJuf4z35CZXvAkwFxJUOpUSpjqiSocv5lqldH7NQHIDLNLj8WxNpKPoIT0pWJm83mDp83zB0Pa0sdgcbbW/bD7GSudzWfsiLPgLcwxSKlg1j89AhO6s1Kha//Dxv2DwbWkZJnVGJIzJOn9WdWtk0390NcxMPtiT3Vw0AouiI52On7kNedmDS3WTSBWRHEzBRYmPZqT+4usn7j5kX208pSGIScGb+4YD/aTpAJUCjktzVaELV9LFurOf3tNURgwVyKjllITlSFpYLxHJYIkdD38jNE0EWncVTJrkM1HOZhMUDgiyG6sOaM5naaFDYoXp92d0oUK3rDrLWNTYhvsfkslyG4tzkDzCHrGOE0j39 dCUgNn9K ffa/zqsoMtyt+XS/LJULMdFOpp3vh386+d1DTMX9tOpoJjQD9VXs5ubm5NZalp9KVQJHT6HDnoju6KqRybQpHwFaztk27LJ6G/MZ6+7MF4YrAnoJSC78C4R7CoBBG2vqo0R6uyyW7HDt1qN4oxikSjEFIqK85UTum+s5lM62KyNvxliFrl2VJmTTKVtPf4ux94PjgHu5BG5FK1NuEkwv5npfaVrjSAOboR+FgnduS99pWAdVn8O7irHaByYtPqLCUZ2zhIjyLP0nIzTafcKBGVC9mw62/V1mGjb4KU3lWoHF2SalD1COE/urZJAXkNKO1E/k+aIoGGy2YxIHhaThxq7HYuWGF0q0IEA55g+z8h1Xvh8VKaBlJwRJjpjWA4X+DV7BR8tiUVqJL7T9w3JZrsYQuUlEoxEqt7Ff3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 03, 2025 at 12:18:46AM -0800, Kalesh Singh wrote: > On Sun, Mar 2, 2025 at 11:36 PM Martin Liu wrote: > > > > This commit introduces the `mm_setup_per_zone_lowmem_reserve` trace > > event,which provides detailed insights into the kernel's per-zone lowmem > > reserve configuration. > > > > The trace event provides precise timestamps, allowing developers to > > > > 1. Correlate lowmem reserve changes with specific kernel events and > > able to diagnose unexpected kswapd or direct reclaim behavior > > triggered by dynamic changes in lowmem reserve. > > > > 2. know memory allocation failures that occur due to insufficient lowmem > > reserve, by precisely correlating allocation attempts with reserve > > adjustments. > > > > Signed-off-by: Martin Liu > > --- > > include/trace/events/kmem.h | 27 +++++++++++++++++++++++++++ > > mm/page_alloc.c | 2 ++ > > 2 files changed, 29 insertions(+) > > > > diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h > > index 5fd392dae503..9623e68d4d26 100644 > > --- a/include/trace/events/kmem.h > > +++ b/include/trace/events/kmem.h > > @@ -375,6 +375,33 @@ TRACE_EVENT(mm_setup_per_zone_wmarks, > > __entry->watermark_promo) > > ); > > > > +TRACE_EVENT(mm_setup_per_zone_lowmem_reserve, > > + > > + TP_PROTO(struct zone *zone, struct zone *upper_zone, long lowmem_reserve), > > + > > + TP_ARGS(zone, upper_zone, lowmem_reserve), > > + > > + TP_STRUCT__entry( > > + __field(int, node_id) > > + __string(name, zone->name) > > + __string(upper_name, upper_zone->name) > > + __field(long, lowmem_reserve) > > + ), > > + > > + TP_fast_assign( > > + __entry->node_id = zone->zone_pgdat->node_id; > > + __assign_str(name); > > + __assign_str(upper_name); > > + __entry->lowmem_reserve = lowmem_reserve; > > + ), > > + > > + TP_printk("node_id=%d zone name=%s upper_zone name=%s lowmem_reserve_pages=%ld", > > + __entry->node_id, > > + __get_str(name), > > + __get_str(upper_name), > > + __entry->lowmem_reserve) > > +); > > + > > /* > > * Required for uniquely and securely identifying mm in rss_stat tracepoint. > > */ > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 50893061db66..48623a2bf1ac 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -5857,6 +5857,8 @@ static void setup_per_zone_lowmem_reserve(void) > > zone->lowmem_reserve[j] = 0; > > else > > zone->lowmem_reserve[j] = managed_pages / ratio; > > + trace_mm_setup_per_zone_lowmem_reserve(zone, upper_zone, > > + zone->lowmem_reserve[j]); > > Hi Martin, > > Please use 8-character width tabs for indentation. Hi Kalesh, Yes, thank you for the reminders. I will address these once receiving feedback :) > > -- Kalesh > > } > > } > > } > > -- > > 2.48.1.711.g2feabab25a-goog > > > >