From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776BCC282C5 for ; Mon, 3 Mar 2025 09:48:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF452280006; Mon, 3 Mar 2025 04:47:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA49E280004; Mon, 3 Mar 2025 04:47:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6C4B280006; Mon, 3 Mar 2025 04:47:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 89FD5280004 for ; Mon, 3 Mar 2025 04:47:59 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 44582505B2 for ; Mon, 3 Mar 2025 09:47:59 +0000 (UTC) X-FDA: 83179763478.20.9A1088C Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf06.hostedemail.com (Postfix) with ESMTP id 2F8BC180009 for ; Mon, 3 Mar 2025 09:47:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tH9alu5X; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jackmanb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740995277; a=rsa-sha256; cv=none; b=EUUciIyhF3xgo49xTwXYpN4LstOxBc6HqYyRvdm+aSTBy0ZejFzw4Bhfs9+SZJfWzM7InM 5gE7pdU0ZWVdNKagAJfcWkU8H/HZTP8MPJlulfA7dAiXawyT2vSbMaqDHZVUw6acYTWpLx oYZmws45CcMdJM51of9cxj4tK3tRzh8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tH9alu5X; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jackmanb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740995277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oGUOj05rbDaMdTXzu4kbEqsK4Jpmf3wR1xuqACOFY5A=; b=zv41dXg6WDy/SMhevXohjzcNY3mk6ZF2akSrXDlkxCk9IytQYJO7Dc7XEJHxXOOyEwTRFc e9gra/mMZYgvfi0/eFgpDGHuBRO/mh7hzX6W8nwOMoxtCHJOv/nxpQoieln+5KUw0/Huyp Q6w+90gGYpZiMkwdpnhiSM2az7Qo/hg= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-438d9c391fcso77435e9.0 for ; Mon, 03 Mar 2025 01:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740995275; x=1741600075; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oGUOj05rbDaMdTXzu4kbEqsK4Jpmf3wR1xuqACOFY5A=; b=tH9alu5XgOpDCtoG5z3KzKxTmpQr5dR4A+wr/3E+Ygsw4tfE3tC6So4zKSQAzsIKXs fEF7d9YHr0o5rS5Flt6kpiGTELj45j4+Yloz+pRqfH2nq/zK0SdFH2ACnAt28bifvaBl OgGd4W8XXLVSbbPzHlkBzDx/s0+/x99ZV8gqgCnzY4greXDM3RB438yan0EvNNw6UQdY mpLWmXRwJRBRUrrbNyCOqxWqUjjOEss6wVA4DOBPK5uk/g/krLgPN+hbH17b5t4MXbjT DBD3Opsc4jo1G8qdNAYPRinr2Ppk7blp4HdQGCKMtTUj9fcww+14xbwGNWyqDYKKMKZK kmew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740995275; x=1741600075; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oGUOj05rbDaMdTXzu4kbEqsK4Jpmf3wR1xuqACOFY5A=; b=XFgU0B9Pl3CV57KJuYPI7vMaXkmZ4+WFWkpDoF/QYD1k0gn/ICu4cTjnXeIpnBeH+h MMkqHxG50c/43B09ldtBjCyDa5I5NNzoIMVqiz5m7WZVOAIfh0+2txWrBfcsFEBp33a+ rtjx2uhf1FCslGa29fCT9ETAONxZRtsgVG1kqY4BJkGxLJPItQI2BBEodRYXozSyxa/7 9eu1WmkrWk950LX37FZJcGhEQ0P1vH8EGTbsOkgNwGD/17x5R737QP9JwKXE0RrT2kdS hidyHiWu1Hb0xfgBrMHC5sXkeIv2zA5YvMFItj3/aejn4C84S4Al+j0DFI31K5/6zS1l FyCQ== X-Forwarded-Encrypted: i=1; AJvYcCWjpudEiVT6SNqPBA4/f2LroOphQnNBqGWz1VJrFSHVXvJBPbjs2DqSDPESolWC6+50w60cHeYIcA==@kvack.org X-Gm-Message-State: AOJu0Yxc8tW8ugL/gs+tulq8g4IjgdOD+FrBoTJAdFdLH0wUQjPUkDIQ nAKQ0k4JHV2IFluZv3q+U0vn3NM7QwOSe9gz1isjmcqJ5DFjiD0q0kQJDrbyVTeI6ne1tLR6xcT blg== X-Gm-Gg: ASbGnctjuES69fnaxohvkQwcIeFUrl2EnSkUBgagCyykcMhEd07ZaDSYunNwwu+1yWN xNxSjUZjQtAmabgQb2vhsgL29BxgWWFsjNug6HPs3km7DlqcKGnwzrlXYPqM5p3NfxZZY+ayfSf ScXHnGQhPWjFab0hLGSUNpVSMgSF0PC1uyzl4yNSAiawJ5/K4YSkUIQ5nvltspV17yXBeUmaVNG dz5PVExjWvF7hadVDW58PNM8uIk2Hj8dz0g0d1tRQBjN6EUHNXLEvquL7okwukKk+K8soKavWT9 yRRwLABwXe8SGjaEgl7C41NdkcuxX7RRTo3dHzZd2XmqnAif1gXQxN8S1VjochlJx6TpIdwDylh oVr6i X-Google-Smtp-Source: AGHT+IGuRRTpZx51thwL2b5hSvmhDVaJN8ebU23ciUC+XksIIzRnxpwUI7JqUrlrpyq52tUWkeY7xg== X-Received: by 2002:a05:600c:3c90:b0:439:9434:1b66 with SMTP id 5b1f17b1804b1-43baff09304mr2232035e9.1.1740995275531; Mon, 03 Mar 2025 01:47:55 -0800 (PST) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e4844a16sm13935378f8f.79.2025.03.03.01.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 01:47:54 -0800 (PST) Date: Mon, 3 Mar 2025 09:47:49 +0000 From: Brendan Jackman To: Dev Jain Cc: Lorenzo Stoakes , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/10] selftests/mm/uffd: Rename nr_cpus -> nr_threads Message-ID: References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-4-958e3b6f0203@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2F8BC180009 X-Stat-Signature: hpae7z8zmfb43e6q1idb6w5knzdzqhdq X-HE-Tag: 1740995276-687204 X-HE-Meta: U2FsdGVkX19FrpWGT/Wf4BfppO3dN4JSUydg8trVGLldyVlBz+kYjFxmLd6k6a/+DsXdY6HODsCDEjLgc853o9IArLR6lHVNYjvAonGXveWY/uFRP9G2Qo/jOt3mDE+Kyv8Mevv5SROeNN5nOUzqREBr8QzBLGwLO6vmzC8BpA7WQgc19iedqmyrTiqErq3qCplX5yKmuNj/ysJFFbQBrLQ+zYog+lefgEyzun0XbwSif50LQAqeTJFzJZNRA4pmJPoLpbCcWC3UtO92HCswdbg8+6H+km3JXziHQD2wgEmVIP8J5VoG+4Li+qZp2r93ehlTPryaq1/4vwuXl2GW6doM95EfLgnK/iAtlY5n29B7rrKSMICkgt07toS2L4UJ2sCcxQ0t53hqAhhT7PNvLYCd67Vmv1HfHezJ27Ljuqb2sfSzRwFAkaXc2SZ+nOg6d6FVrJQ0qPwnxzl7r7hvztLeJxfTKccIxmgb1XQyOjFCf9HrTudW4AiAQA4+9T70T2Kjrax/YBzmSKqCtZyK3sfavL5OkjiIybcIonmrhg7SD8VLjbBKVuMRgK1Kds7F22Gb+7JSzxLCM/Ds8o9eEGcZY8t521eTFZbmIOZ0px/um0ZlOplTHjr0cTSST9HtoROiExS55+Gtcmqm0b8wvyjVAFwj53UqmOWwDNGNnpE6JBHzJxzsw5CyzezHyb0Eut+uzDyIyHNFCAyVsHqMVC9TP/ocwICbxDZiebxUZxA/jLmCGW89DO43RUK2q/M0rgbnExmMr6gy4jX2EuRD9zw7oZQQVr8AeYrEysmS3BbZJDzeuhqAodXipfk5muUJDNEwPW4SAVOjIAysuhnOJm+k55Fb9B/98FpLgc87vUlYJTejD76VCCBpx1HroIENa3UMzOQY9OVbiWLZlG9Jj+3F//75Mx7rKmO1vbIup8vxRFRjPsAlWo1j6kBnDN+fF+mRMLGcqWRord3zB8a xT3XDRFE yqZ+GTHTH9AZb++fwqs8sjK7v1wp4q5ogFIRbczBQVZZI3YBsZsNHbnnml6cdCCkDrCryQfCpMRO0m75Y05xEW68XjRhL+h7JuaaoNjtP+clphcd1aerzXEdhy/cp1JHpREzqgwWW95mgUYw3bCk5cM+whcz30WbTqkqa3ksssoHBeYUkPc0v6ZU+DS4wa64PXTDKW/O0ohj/mwr4Sc2x/ZCq27XcItvpLAb2QxjGyOvlUwx2HfCkWF5AQ+f1vZs3HqkF8g5Q4BG5m6S70K5dfsyETlPKalGvDHqJoIl8OdirU7AD+5k1Dsix5m9gIercvUgShzN8F7XQ2m6b3dR5NRJWLE9GEKkckNk0sz3Z5VVA6Mk6bU6PE70ysnRfAtvaMO395xJ8GOE0EVJgVK6JKJ4q+A== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.496309, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 28, 2025 at 11:06:35PM +0530, Dev Jain wrote: > Taking a cursory look at the test, it creates three threads for each cpu. > The bounding of the variable is fine but that being the reason to rename the > variable is not making sense to me. Hmm yeah the name needs to be more abstract. Do you think nr_workers would be confusing? Or even just "parallelism" or nr_parallel? Or any other ideas? FWIW I briefly looked at just cleaning this up to remove the global variable but that's a bigger time investment than I can afford here I think. (The local variable in stress() would still need a better name anyway). Thanks for the review BTW!