From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44A21C021B8 for ; Sat, 1 Mar 2025 07:34:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE1BC6B007B; Sat, 1 Mar 2025 02:34:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8FB2280001; Sat, 1 Mar 2025 02:34:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A58A36B0083; Sat, 1 Mar 2025 02:34:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8658A6B007B for ; Sat, 1 Mar 2025 02:34:46 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 321E91A1BB9 for ; Sat, 1 Mar 2025 07:34:46 +0000 (UTC) X-FDA: 83172170172.27.F65BAE7 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf24.hostedemail.com (Postfix) with ESMTP id 19026180007 for ; Sat, 1 Mar 2025 07:34:43 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=EDAnrl7+; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf24.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740814484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PODAUuveZdAsaMrFa/5PaE8AwJBQJeaYR927PYVrJjU=; b=QjX6FBw50VhfuFxvVn4eQtSKF6pcVEC5vfdPUSI6ljoNy11G2U50IMSRB/7peGRb1V8/2L oWN4+hloD7bWRfl89OyDWTXhItVylbHyH+MwW593WMAcVX56zE200nC2la/VSI8gCLW4zr qAjjvfeNZdGsnjuMsz8Jy5H+VDGQqAo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=EDAnrl7+; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf24.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740814484; a=rsa-sha256; cv=none; b=2SMA/lwhV4fpYr/gZsY75fKgLwRqEfvktid50IwyXVpzT1NzFvp78JAwD9S6xJhd+Q/b2H hIB294k9bBM6V68gvv1olc97cl03QKyM1jL7Mfvd9c6Jg6HYszUqCAoP5745GIJpjR9j8/ Ovyd9Z1b0WSkqy2oJINHwUoUOuwZQko= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PODAUuveZdAsaMrFa/5PaE8AwJBQJeaYR927PYVrJjU=; b=EDAnrl7+/6K3zZtzCcrwnXcxc4 HygiRMzzr9+RmclT1XYYGgihvfwJNCAmKbhE8XR/ugXbETyYKtRU8FosLrcIdFrZTBwz8nPkdHXq4 SG7sqHTfNDvDQLENNdO6upw4ItVmyZ0q17CS8NLecYRedJF/VSkXhbo5YgogprWQsSACGdxsr3pxO l/C4T+1TmWC/E3tC9V/cnNk6oAgzKmuL+GlxegPiksanN5w3MXtK+jhsiFRsP2NCoGgJd5bIyHEIx UJ9RMjrfNzZe7xaMykYJ2WZe9pvBtu5eiFH92Ml1M2l4T/19UX6Nw7Oy3bh0mtDbRaVgDzWkYt/WB fHEqxnEg==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1toHMn-002mbh-2t; Sat, 01 Mar 2025 15:34:34 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 01 Mar 2025 15:34:33 +0800 Date: Sat, 1 Mar 2025 15:34:33 +0800 From: Herbert Xu To: Eric Biggers Cc: Yosry Ahmed , Linux Crypto Mailing List , linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [RFC PATCH 7/7] mm: zswap: Use acomp virtual address interface Message-ID: References: <153c340a52090f2ff82f8f066203186a932d3f99.1740651138.git.herbert@gondor.apana.org.au> <20250227183847.GB1613@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250227183847.GB1613@sol.localdomain> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 19026180007 X-Rspam-User: X-Stat-Signature: xw34sxdxaiotgzbqqp685zkdzt8m5fq3 X-HE-Tag: 1740814483-593296 X-HE-Meta: U2FsdGVkX18sAE7ex5kAZr4UphF3tp2g3PJTKF1LA1loknUzJhGUcTBF6iqBSfdI5YAI8BYBmQ9mZnqDufMh8V9HVqcE7BAznn4uXSNCPZ4WvY23B+2pF2+jP/gtOg0pHuEi4prwzDbugMJU+JK4ycn2xEM0VFdnTBaGOcDe8LcxhB14zhLmISMjdWCwDMUXCIyoNXblGc5bF9rddhei8deplvxOP9qPbDaq8hJoUsepa/2gPYuIC8gBfvoYaVBP3N9iYP/DebqS/zL6JwSAlu8+qkTPEDTBopIjwaYDs7sYLC/a4/eIJ18ouGBDAw9UioGGhJi/MLhXDRec3aeGJUBKbuUtHuXRYYE3iD3T5nVL+sciC1+0h5i3zRPQcJmEXMSs1eVmT2TmBfaeEslGn6DzICXWreQi+CSl7WD3Vf3F8+8L9bXFo5gv58dczxocnFQ1enKs6/+47Qeag815kodKaZLSdF5vowoKf029XUDnvwKZoMxD4NWGnpc+MZZzebKbtv9/80aJ7tSrYmkeF8/n8wqzoUgK1oZf04P1GMjAVodkemmWyKD1jZ6WL21YIhtkbNzUynwbuLm6xaAICmtF2XLKwQiRQuX2kqKAgHPKkaK66texr9ITCJUZT8Z0A8K3sRofXIaBomB/J2N7ESr8CBP/+WOsb7hpygA3DRgjDM/q3N6Z4AZreG3bKH8TXHRK4T4IZ8ytljgMoc/bgSyyHVHt4//26W8U9la+ezPngqlCWpcRy0GZc7v80SpuFZ7UETkQ57iSf60PPoG2BvPLUViQPsX2rH8DjCIoRoWfMzCn66T1L8jEPltah3AzYRuJVDjN8a6dVkQhTVvggiOHQq9lCMsY84bM3gtuDAYbwg8EIXjh7qBg+8bA3MGqDB+/BLzk8fpAZ/WZliOaw9LNNQOEhgMt+vEiAaMxL4Il096yPLAEXJiIhVuD+Ht+34VzVUdVSdikcgiAECF bWULhZFU 9OgYEwRekJXHgQM/maiK/I1Sn1lGC6KQ4iF5sRrFGXzHi5mR2NLOUuX8xP5AuuTdXBACnX9IRZUoDQfdP+xGpSHN4hdxT0dzaT9sCeE/I/srmWaSPSP+YeG6c6UsWgIKIIn8/ivQsBtrKyVGMrl+FdDQQpgNACBCTKc3MZ02ELFjms22wxZQkSQ1CjNNyGhro+EzJVZRLf5gGLB0qLTlwk4mtEnkkSjqEtfBFZzXksezTXGvErbN09uwzlQb/AJr8cW8YaAUehRVpZYM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 10:38:47AM -0800, Eric Biggers wrote: > > Well, unfortunately this patchset still uses sg_init_one() on the virtual > address, so AFAICS it doesn't work with arbitrary virtual addresses. Right, you can't do sg_init_one on highmem memory. But the problem here is that this pointer (the source for decompression) should never have been linear to start with. Had it been an SG list, things would have just worked. In fact, digging deeper reveals even more reasons why it should be non-linear. The object that we're decompressing is often split over two physical pages. In order to produce a linear pointer, the zsmalloc code is actually forcing a copy (incidentally, that's why an extra copy is being added in zswap because the zsmalloc copy is done with a per-CPU buffer that cannot be used with async). Had this be done with SG lists none of these issues would've existed and things would just work whether you're doing software compression or hardware offload. So I'm withdrawing my acomp patch-set because the premise was wrong. The only user for acomp actually wants SG lists. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt