From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E22C282C1 for ; Fri, 28 Feb 2025 14:59:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 068406B0082; Fri, 28 Feb 2025 09:59:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01823280002; Fri, 28 Feb 2025 09:59:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2366280001; Fri, 28 Feb 2025 09:59:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B81B06B0085 for ; Fri, 28 Feb 2025 09:59:07 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6F6BDA2AF6 for ; Fri, 28 Feb 2025 14:59:07 +0000 (UTC) X-FDA: 83169661134.19.0FA52CC Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf14.hostedemail.com (Postfix) with ESMTP id A821F100018 for ; Fri, 28 Feb 2025 14:59:05 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=38ATlo4B; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3OM_BZwYKCCMRD9MIBFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3OM_BZwYKCCMRD9MIBFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740754745; a=rsa-sha256; cv=none; b=cUOYUJTa52UnPH2cjNFnYAZoa88zyNiltAEvccw+P65VFjeiRYtsGWSxMzEyY2TLSAuaPh 8TUPXqiLJdxLybdIfntQvCC7/nguB8/nru7Evc/XJe8p/b8v2hWaDZ/75MdO/UepjacvSQ Z6gOGyjdps/xLK0a2M952Nvxp5TpvNo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=38ATlo4B; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of 3OM_BZwYKCCMRD9MIBFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3OM_BZwYKCCMRD9MIBFNNFKD.BNLKHMTW-LLJU9BJ.NQF@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740754745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w9dyGsvh9T/ZSon/b0EZ7+hNIbWTXl5YSkkCNWhacUA=; b=WvZrLEA5H25MQeilqfmmXmD3O7PauZTqI2tZ7Atbzn3eTZ2qcKDWWhXhFHzkyOM8Gyw1Yu n+44uwj8kJOX3s9Ys5JhnBxKwLKz0vfUThh0JxLt8k7JByodlyoN4yWjPHFnY96/kjSYkl U0JSGwj55fz0s5+IoM6PGHXaV6z0zj4= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2feb47c6757so2880443a91.3 for ; Fri, 28 Feb 2025 06:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740754744; x=1741359544; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=w9dyGsvh9T/ZSon/b0EZ7+hNIbWTXl5YSkkCNWhacUA=; b=38ATlo4Bc/8I5qTnhN56H212uLF8rVuaZaeq3n4T7OpzJOsl2sDypSP0qVprujbjKe 1Vdi8POVdp3Bb4PWurfr74BNCXJMD+rJYp0uQnkuX77brSR3k0mcMXfLRtvCQj8q1Cxk tNu7ExCDx1dCB8I/fyMENgX4KIeIqMtuY5G+mNYJZmrajEwm5/9yuv4fdDx20lVtLnxA EYh1DN7mbO4XkVJpqBVoXpEWXB8R2OzEwPv3VQkyh98VojAHNik0N8xncRh+lqEzqTz3 QG8ors0eW6X6K+hRqfKAWTT2brjnOQk5pJSPqpTmJDOGl6SOXZ8rcNY9Pc31F0wiwcE4 3wAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740754744; x=1741359544; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w9dyGsvh9T/ZSon/b0EZ7+hNIbWTXl5YSkkCNWhacUA=; b=jlWgw5V5Yn9kTJTbe88IRx+p6GF0zxqMYHA8glmaW0offhYOQMbacHDXmqKuhokdCh clF2JMZxXxM6X++RojY/xHH7mBz2JY5wY0DAVeF3mlkD9CJ/jK6qAFXOsBAj0L28T7+d B1svOMX/LqVClofonYikyU9vLbvhUvwRsEbMrq5Fo0EoKDm0eaiKgfnNR3VDEeY9tJSN AT/4j9t9n2cVEecggaMAnOm4pCtNeczjnur22WqWpuVs6zVK3qgal41xEUWj4aSZfYiS VEbyOphdt9IgmZj6K2w0RSOAzmJqDvE9yDQRZxLIseqQItwEBo+3Zs0jgKaobD2o0SKB llAw== X-Forwarded-Encrypted: i=1; AJvYcCV3EPOS2WHxPUbIys9rltf53WBSJgX2RZ37V1PIxeAlI9OoYsdbtexsokqjSG6jts2AQRgYV7q8pQ==@kvack.org X-Gm-Message-State: AOJu0Yzp0MfKO42ibx3i/dcNHCv8FT4vvDv5+W/H0AicrVvRuXtf2zKp b/90r4VXJvb1htIcJLOS5d0v8nLls8doNcs1nvP5YOV4RbXX7VEOBX8wlXBAbMsAUzqyB1y7dr5 I+Q== X-Google-Smtp-Source: AGHT+IF2C9SjHgY5w3jl+VecgX3ASvzixsucJeI44sz6MgxAbRGH5Zck3g3VWWsuFnNL5P8Hm5Vb9Y9DaLY= X-Received: from pfaz5.prod.google.com ([2002:aa7:91c5:0:b0:730:94db:d304]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:1590:b0:1ee:ba5d:3d55 with SMTP id adf61e73a8af0-1f2f4e01cf8mr6714343637.38.1740754744565; Fri, 28 Feb 2025 06:59:04 -0800 (PST) Date: Fri, 28 Feb 2025 06:59:03 -0800 In-Reply-To: <029759d4-f7b2-4ec6-b5d0-7c8a1c0fbd80@redhat.com> Mime-Version: 1.0 References: <20250228023043.83726-1-mathieu.desnoyers@efficios.com> <8524caa9-e1f6-4411-b86b-d9457ddb8007@efficios.com> <029759d4-f7b2-4ec6-b5d0-7c8a1c0fbd80@redhat.com> Message-ID: Subject: Re: [RFC PATCH 0/2] SKSM: Synchronous Kernel Samepage Merging From: Sean Christopherson To: David Hildenbrand Cc: Linus Torvalds , Mathieu Desnoyers , Andrew Morton , linux-kernel@vger.kernel.org, Matthew Wilcox , Olivier Dion , linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A821F100018 X-Stat-Signature: nga58mnoehuydw4tpixwzremne1gmrne X-HE-Tag: 1740754745-638875 X-HE-Meta: U2FsdGVkX18jk4IfwtgHAdlSsvoNu+WgEUmD0rgcgXuIJd+MbUo3RfgaE+VW4hnvXpyxdo1bcLvtnQ1RacdXAxMQxTtPzX0M/yDglGaX1QbuauWBhtf45mmdVS1SRl3VqeaO32wsZng4Bc0hiGGIRj3fpcEZ4Pll3VxciJ2AGqztXdRjT1L9IGotdoecQMrTfghJ2gjuLrzwPCRdARhn77iwbcPKLW00drxCYyeBtjw54jyt+ViujpQTBfIgLx7pbr1gjFtqLEuXJk3qI8BELpQopn/2SOPaX5WvC1rtvl9EWMZF5Ssxy9JscJGp5RbopQVE4I8M0m6p23iD0TqlKxR2WL+ApiDR8qPlF75WngFgSkI+2ErOM3bcLfVVfUvhjiUrEhZ5jKHbp5NznrteaQWT+bJmqHmcFTrJlTZ/6q6BijNqk2NAEFACo/CCW+E4n0P825DQvlNKhH8WUSVbGf73GQWoed8w2BxLbyEJJ9mFITfu6q/Ns+2DJbuVdrIH2GrwkmiFWVwuKtWMxwFVYjViSMdivQdcIOQTG5TtT0tQmluIUX5DXrululb42BFQCQPMokpc0Ewx4dZRyKafN9JgYoO3rMVepQcLm+BzEsJPwnyu4RsySLcDw/3t8+h2hVomYibv/+xw3wUyfiBP5BN798F02/X2XiDy96CD5zgT7FTqDR+hVamIfg6Xeo58jcu5QmwhsQRVQrECf47xvRCrHkXLbVp71XGVVxKQZH8E2Vm46o4UjRQSD5JnBfFWeWaYHb1xD8th+nzm2tR7xGKxzF3rbiUFZE/Mi9bsxsP88saDPkmDRyIqToWl6x7k60uDi8yyxsDCoxVcF1mBeIzqm1b8n+ExjhvySnR/5GZ32eMoJ1gq1GWeaBCRAw3dZOJrc1jHB0EIluZJ0z6AhRZxC28qi7Px3sI1fEmMp6pjBTre4mBCFVuj2VNKBmYnmHSAD5d5AQhl1cbbt2Q U/dQKzTp o78iaOknU9/6KN3OaSlwdqYJ1GmPrOyPw92hYhQDRHUjjo3ek3TJEEjXQXZPKmhmUFMo49u0jC8VYRN3Ag3argwqQ7xWRDpOwhfiGxzv5EFMUfIOT1VUp26VU0+w9FJZfD+sRcGcKRbizbrBXCe594WvE+XDEgGmeS4bpFOPB7QOb+rG/AdOaXOqKv9Hh2IQH1VRdP4ZqIpQfahAoaqSzLrxeKa6SglUKeNV1eLujZUdmv7hfNzjtU8wKW+WyE5Bxpgef+pzhCsYODht4M5Q8sSeKJqwotIPvuJjO6SQu0EgnIAZYVGCiTIv1IiOMc4KpUdqjOrnKcAQ8VNsNCZ1uocGiKCODFuLAE6Q/q4wvz0dew9PGRssFiFqc1hqAuGMaEUblhWpC/zTu7KyJKH8s//RiMCC8yByb1FEoQGC6SiOw/WEd75KfTHbo87dxMYUzxmSxgj/x7fFif1ukpQClrr/REwPRijN4sM2XvkiHHOODXYs54EIrp8RMyjCzijaz/0csGXKkjP0w4JqaTuA4nPKvseHP34mybTXL6jLDOjoLNUZJ2w6fFLFVfoQHjNakO7AdYc/zRkuZ15fZ508Q/PaRcoGOtI+Sj7HAtF9EfJqP0nFd+sC4ARWzNs3tlrMRg7mkhk30oAtI2svd5gw5bBHGGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 28, 2025, David Hildenbrand wrote: > On 28.02.25 06:17, Linus Torvalds wrote: > > On Thu, 27 Feb 2025 at 19:03, Mathieu Desnoyers > > wrote: > > > > > > I'd be fine with SKSM replacing KSM entirely. However, I don't > > > think we should try to re-implement the existing KSM userspace ABIs > > > over SKSM. > > > > No, absolutely. The only point (for me) for your new synchronous one > > would be if it replaced the kernel thread async scanning, which would > > make the old user space interface basically pointless. > > > > But I don't actually know who uses KSM right now. My reaction really > > comes from a "it's not nice code in the kernel", not from any actual > > knowledge of the users. > > > > Maybe it works really well in some cloud VM environment, and we're > > stuck with it forever. > > Exactly that; and besides the VM use-case, lately people stated using it in > the context of interpreters (IIRC inside Meta) quite successfully as well. Does Red Hat (or any other KVM supporters) actually recommend using KSM for VMs in cloud environments? The security implications of scanning guest memory and having co-tenant VMs share mappings (should) make it a complete non-starter for any scenario where VMs and/or their workloads are owned by third parties. I can imagine there might be first-party use cases, but I would expect many/most of those to be able to explicitly share mappings, which would provide far, far better power and performance characteristics.