From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF2CC19776 for ; Fri, 28 Feb 2025 11:29:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17552280004; Fri, 28 Feb 2025 06:29:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12557280001; Fri, 28 Feb 2025 06:29:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 013A4280004; Fri, 28 Feb 2025 06:29:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D7116280001 for ; Fri, 28 Feb 2025 06:29:21 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 251164CAD7 for ; Fri, 28 Feb 2025 11:29:21 +0000 (UTC) X-FDA: 83169132522.08.123CD84 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 5C8384000D for ; Fri, 28 Feb 2025 11:29:19 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf17.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740742159; a=rsa-sha256; cv=none; b=20HhpXxasBxmvAO27UbvDyvuIIeeAA5pYScN2BHjShz6d6PZHdA+wMVvBDF8v27JtXT9V4 JxjcXTkLI6V+Ddqq3U9ODIJT2Dkl/gKTYXSFfGlZtOpzh+3+54m2g55SF4/HSG/LP8otw+ e3Sd0K9tOHqkkzemHzrHUmpTiJOBCpg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf17.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740742159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rbh5IPhsiu/FQ6dkIC689ZFNba03S3wozy5QcqeXKxU=; b=2Bu6/l7mPwW6DNuJB0d51+V3QJtuGvj3xdTbWU/1ipgw5Zl1K6yNyYNRGJaYXQfsHZ6IXU w+fun3tgbM81NVbo98P1WvRSMpZ+9EX1p2Km4lLUktdEl1PdbXutslc4F6OyefwFjkqSHS iYEVzkZKl+2U2eW/LezCfKQhY+J5nhI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 83CFE5C0782; Fri, 28 Feb 2025 11:27:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55B84C4CED6; Fri, 28 Feb 2025 11:29:11 +0000 (UTC) Date: Fri, 28 Feb 2025 11:29:08 +0000 From: Catalin Marinas To: Shuai Xue Cc: yazen.ghannam@amd.com, mark.rutland@arm.com, mingo@redhat.com, robin.murphy@arm.com, Jonathan.Cameron@huawei.com, bp@alien8.de, rafael@kernel.org, linux-arm-kernel@lists.infradead.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@linux.alibaba.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com, lpieralisi@kernel.org, guohanjun@huawei.com, sudeep.holla@arm.com Subject: Re: [PATCH v18 2/3] mm: memory-failure: move return value documentation to function declaration Message-ID: References: <20250107081735.16159-1-xueshuai@linux.alibaba.com> <20250107081735.16159-3-xueshuai@linux.alibaba.com> <0c93542f-4521-41bc-a030-5b2d8621aa6a@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c93542f-4521-41bc-a030-5b2d8621aa6a@linux.alibaba.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5C8384000D X-Stat-Signature: s4eji9df1okjfmkhaposgz3w38g54a7x X-HE-Tag: 1740742159-658352 X-HE-Meta: U2FsdGVkX1/YKGp+l7W/XDSHryu2oUVy98GFTjCfZs4RKGMKeeY9QVohDqSlVRKAfTXPBK951HZUkY4AMyQnsToTrD6TBq6s23nJ0Ew5/H1PYYauiARI1ctoCt39uF1up16D3dBjPYxTkByWxlm2Djgg6PaG+KNiMQBkPkKABMHY+oKOQK8X+NUoWS0+/HGrCh5kw0LsWadyme/4LDwBF4mdZDRp+a/9oqcSJWaS5NegRHGMgHAACp4LF+1+OPSOdgasCm/EVFU7LvhtXiKYssLKlQ1TtzMi1yRJ7w4axvKX2cg9okKWsQLHuF/Fto2DkIFvBF0HyBXWFFbUbN60HCkvNIN8l27apGWEupW/cR4c2CqczYyHge4ruKjh+v+HtdSQJLJaom7it2S2CK3KEgC4qDr4rCieWvQoan8HAQnwSPf6nGuobMNmWushYDGKbgop+O+St3Z3QrSkK9AH0v1fm6j2y3JXUF1s7j6lvRiDEwYNkoiLwAymlLnds8R4hz44Jc05gBPU654lcJXTKxFBYj7baH8azexlzNPBoo1hOPuTcCUDbuDt6vpAwOsx6cVk1j8ePyiDdcgOBKw9xyDpU3bKI3Vgs0oLPaPJjjIPK3Rx6stqM1jOhCukUkABZIqWRG2ZgI3M33aDJ9Asei71et4Is8wyzF8qPEp8OsXnH2zdNRoE0OGvV6hjjbtlxGZXZ+qHSseO/mfYssRpyWC3zmEu2zWEKUu4H9nyk5IVvqsIwdH+3a1Z573WCrQUONRz7K6pvXSIpEVBCdXKuFM5cFx1hjgf91t+yhwjE3eziSEcLU/ZPV+EKYZdsrCaZWhKvVuC1ucU4CP63/2ddjLkQBeNVj2iq9vXEiUmOSTeAcggWXPIa4ZpWauYQtWBBcun38Qv53t/bLbuaALqdF5gp7FuJpUPIdb8nYxetqQ2qOJARRZfyZ4YJp76t7C+EkeeYn5yKCvZxpYQevb 8QxlRCMH N9t04WYhNxnxouhk9r8KqyJeisHY10RO8OGjq9HVODGyL1CMm5U/iBiXJa9paPy/FzKP5sEDYofFRwpPUkH1h+CymRZn8V73246dgTie7R6O7wnOKdPfhF0H1uz4lkVSOKzjfeFNdnhgokqUF7OqYvIRPVDUXr0k9QLOedOlRub0KvJW7fdGw69Llu7M7nO5IQmZlMJrs28D6w56ySpfTFWnh8+/rZ6pFqxFGwEJ41DcIfvqPIybP+Hgt+Dddpx12H/T9vyp7hXzQwnThocFgaN+ycgs+X0tdBNJObhg4/v8jCqubYAhBgWvZs+SbX38Z0O2ti3FJuTzUuww85hrGie0fa1Q30E0TzJAF6FWYd+pnZrs5ndD4X0KVGdMkD2v4OUv9e3ODVtuwr4I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 28, 2025 at 09:46:30AM +0800, Shuai Xue wrote: [...] > > On Tue, Jan 07, 2025 at 04:17:34PM +0800, Shuai Xue wrote: > > > Part of return value comments for memory_failure() were originally > > > documented at the call site. Move those comments to the function > > > declaration to improve code readability and to provide developers with [...] > By the way, could arm maintainers help to ack patch 1 and 3 if there > is no objection? James Morse is listed as reviewer of the ACPI APEI code but he's busy with resctrl/MPAM. Adding Lorenzo, Sudeep and Hanjun as arm64 ACPI maintainers, hopefully they can help. Here's the full series: https://lore.kernel.org/r/20250107081735.16159-1-xueshuai@linux.alibaba.com/ -- Catalin