From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64AD7C19776 for ; Fri, 28 Feb 2025 09:20:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADD5D6B007B; Fri, 28 Feb 2025 04:20:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A8CEE6B0082; Fri, 28 Feb 2025 04:20:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95431280001; Fri, 28 Feb 2025 04:20:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6C3AB6B007B for ; Fri, 28 Feb 2025 04:20:33 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 88067805DE for ; Fri, 28 Feb 2025 09:20:32 +0000 (UTC) X-FDA: 83168807904.07.852A7AD Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf30.hostedemail.com (Postfix) with ESMTP id 8F4F88000D for ; Fri, 28 Feb 2025 09:20:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="O20z67e/"; spf=pass (imf30.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740734430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sc/rFdhCs8ryT6ky50ep7UWZ/tEv7+DxhHl4CwzDRvQ=; b=7ihQ75iLJmzqCGoj1ZxolFjciwCcy8ANVf9zFv2N1y+6aLMVPUtxNgYUXYLoLDLrjso+zB l2K5g1CA0BBYJPtXi0OJehTZPBemOazhA4OvNPTiogHnkU7suQhAQpygwVVmmJ0lZppsZN Pa6wsp9IZqfLtKRp5cmYn/AF5cR/GkM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740734430; a=rsa-sha256; cv=none; b=q7JuTqKfabhMzBt3zYQdpoCbh2Y74lN6BQ8K+5MWpVf1egTQVbK7swVW9aI1LdpD8MIl29 3BVmKGaTQGOE5PibnfAqrVLb9P2CqLuGjn+LghWv/ec6IJhGQNn9SW7kHSiqOUoOn0G0Mh U0ATNlOOARs7pHUWRQwiCcXgysy/MLY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="O20z67e/"; spf=pass (imf30.hostedemail.com: domain of jackmanb@google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-438d9c391fcso42235e9.0 for ; Fri, 28 Feb 2025 01:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740734429; x=1741339229; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sc/rFdhCs8ryT6ky50ep7UWZ/tEv7+DxhHl4CwzDRvQ=; b=O20z67e/pp7Z1mtiA43cbnemU6+g4FaeKSZMkIhabvI7CPmjrpaAxKGrb9zINR01rz /nvoMe/eASdtilqPtQDRC0Ck6SjpWRcShBgpUzxtcgaoQjN7KPoG1wcM1oYRaN0Cp7Af UmgYUjgWn3OrGtykicTBmaeo3wBStHAuUeXrM+XlUhgE+S3viOivuFa4se2iPpFkpKct 0BDsyGw1lWayCXWgsgF8hKVtI98WDMrf+wmRXiSBsOj9fbIGZt+WfTxMBvA4grGquzW2 8HjpZcb5na8VHNbIyhdK9u7Cg5lTaC7G7qIN3NQ1AMKifJ5NTds7HaVixEAkCeuM2ssE FVcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740734429; x=1741339229; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sc/rFdhCs8ryT6ky50ep7UWZ/tEv7+DxhHl4CwzDRvQ=; b=Y3pCcvv1MshS6y3e0KdU/VYvdyzz/TDHQkIdcwJ4X+nrNusSgqenHc94ZxCh1SqfNu 8hESFozclnMolSKzQRS/07JVp5rmoar0OYIk0NrHfIB/BmajcRIPbf04c8Wa90qPi5D0 MXkyA6p+u23fsFzQxwtaIkRiD1vhTNkzj8HLVX39wSzeG10ZVDARQjRSKRc5lhqis7kv duMfCzLGG7CsH94f+2nio8RYr9WM+Z/l27qFwRF1sfg8k6U2UAf1F2zBQENlEnFcwpQo 19eJlKbg/BAtkgNt9wFywc+xvtR4m3tihNIRd9te9+TUXQmz6m6OkFJC95g7dCDHv9m+ ujQA== X-Forwarded-Encrypted: i=1; AJvYcCXMod7rB3/qSgC/fe/UYQuZ8ODjeabaoHrhF1MQB08TT0YUXYKzcZ0p2KADLqF+u6xj5ekIJiQCag==@kvack.org X-Gm-Message-State: AOJu0Yy/csRU0w9OepCqRsXtylNEKWKkJPkk1qedZZ6M/rmM3bEGF/dn Q2fY7O47kO9/+uU3z2G4Sa8PlE7Jwbz9KMCU1ljTweIm0R+hBZMZc1Db6Wv1Eq/SJs8bm42YN6B Y/w== X-Gm-Gg: ASbGncuRnN2NpqEAdt5irsKHFhpUOLjHPQjDl16Hoj23H/Br4oKmGdWM9BLSrMFdxIk mwpiXRRM8qJo7jn3/QTM2jXMeWnvvPn2Ny4CyOf6ScoufRPoZBjzfEgrPSKFFBAbjEcpwwL/one A1g4t5p6RNmkZz6y03nunb1Xbzduanff2Cv7SYHJFCVQUXo9epNNmYyRKWFrYED3j6wbXHGs1GQ /gxebrnEMbAAKiSxCA99da0sBeaug9TEJbxgbe6qvDDH/Fga89QCDsIs1hWRlycD2KE2KyG/CDj YY//AL9U8sgSIiepU+adFS/wqavOIgi8ZkwhJenMt0d9KwZb7ylxImqWPFCHCQ== X-Google-Smtp-Source: AGHT+IFm+iilWyjxC1XPFcJ/1TDrVhPbDpKHPwRPFsYeQGLAJ1FnOgobaGgyAW4Mc9lQ5kLRwLuvXQ== X-Received: by 2002:a05:600c:5618:b0:439:8739:b82b with SMTP id 5b1f17b1804b1-43ba6edd7bbmr852505e9.4.1740734428932; Fri, 28 Feb 2025 01:20:28 -0800 (PST) Received: from google.com (44.232.78.34.bc.googleusercontent.com. [34.78.232.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43b73718de4sm51645805e9.23.2025.02.28.01.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 01:20:28 -0800 (PST) Date: Fri, 28 Feb 2025 09:20:23 +0000 From: Brendan Jackman To: Andrew Morton Cc: David Hildenbrand , Oscar Salvador , Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: Add lockdep assertion for pageblock type change Message-ID: References: <20250227-pageblock-lockdep-v1-1-3701efb331bb@google.com> <20250227143302.2338b1cf15919c64a6c1eb27@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250227143302.2338b1cf15919c64a6c1eb27@linux-foundation.org> X-Stat-Signature: pk9tqi8szotto5sizz5iabcowiqkb1q3 X-Rspamd-Queue-Id: 8F4F88000D X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740734430-519207 X-HE-Meta: U2FsdGVkX1/4TRx7f94rRZZdjhYhy/bcK5wfVDFhg0R4umLjJnHizR6h1ruTJFQTKmc125rSvQ/K0KkCrkgUcaJhdqwEc5m9E5Wjn/OvsICSEqiSnmMCZNgnymZhQ1A4SkXETQV/NuUMxrIEj9eqlFy6Tz3WTIRmZ5/NQQZj1CL1A1pKaJTxgtILQnPZJzKAZuUWVIlUSzuvfvZwPZOY+1tsIi8WBTuJATKm0Wlcss3bHknFTSei8eJXi2X8mu8x+QB7RXCkqtCvwzF9KwY82JUGfFUkK8TAy2C6UBW/d6bPaxiD88dVCu5doNJ/1FvRVOUx6EqSHzEBPi0V5cZEh/lzhnc+JBY2E3lxE5xiy0LgKE+uVD8VIOTzIDWlwZZQsPLHQe6AIl2yOpAIORjxCaEDHi0JAK9E6v1jspd8AG+vwMgZOOXxsAJ9xO3OPUf3QTehfb1xUlRu8SfFgRmSnwzOtnUDY/HhMzVD0gFE7s6SjybYVm2d7mX242ZWiuxgvIexoi5x4ZpRPLJo2glsh/TvdExDVoIqf/Ni4xT/sU0CH7yEFUvdEd9ZBtrUbyu8nCTjIqQd1WWXk2DvRIvuYrKtA7Tl6H6p53Hda78ybiIPXMG6J5HNvKwOsMC8YYuzzeKgKzA20FPUAbGJ8Iz0KgBnJbthxhSCVOtdXgGU3SbDPdo1k85jLYngE6Bzbmw2Zwy0q2kEVClD4Yj6V8e2qeHGRRPL2UB97Iw4zNNLad6Rozb39KhRXyELYOhTtxCnnPmrnFwvxjceLMdMqowYrz8qUdyccOrKqy7TXF4yIW2umNjmBby9ReD/0DngXGeOFr8BroRajIIy/04Lrenzo1XV1Rm7Tdq2BjII+uae94Wgx0zdCdLGKrFw+WWsP8/HT8GR5snuqQ7gj3zHQaQD3S5VHD6fLCNKovsS0i1jSW1jXscVLFVyJ7+J33B8+gOF0e2vSs5m1QNzfiBYZv/ B8y1Mk0J 4DTy9ZUjp6X9XUE/0halT+zTYessZtbIERsYcCOrZDWWsFJ29H0DbLqXxZjySSbuHbc0v9BzrD9/+Ei8LlG15edln43TXuVOi4QYSVxStpXlyqLDe5a6JNeGX+Ci1b+8x818R+Ud1M2v2re087cqwbxdeG59hwhpbxCq+rE6/V0NI6eKcHHTh1WU7nWUfcquLlEUVja8BE1M0PRn0QrcHGXXZ2E9XaVOujyXLi8wJX+Wv9OYu00l+cTo0NVVit0AXnSYYMT9JQfyu++j2jMjc5RXKDvUzsw9lDuSD/d5gCnD7+x7S09nAIZDPVSZbfVEYk8i6e2HY8nKy5W2OvKalXXKkYq2dP1+fQfrT5lMsVqyHgOHM6YwdUTamDg7BWm2Vb8Cv7J4J3JoiO4ZXDT7r497zmFfteyki/Gr1xh41cF770PrvLdWdorpzfUADbyX7ANMf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000415, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 02:33:02PM -0800, Andrew Morton wrote: > On Thu, 27 Feb 2025 16:15:47 +0000 Brendan Jackman wrote: > > > Since the migratetype hygiene patches [0], the locking here is > > a bit more formalised, so write it down with an assert. > > > > ... > > > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -417,6 +417,10 @@ void set_pfnblock_flags_mask(struct page *page, unsigned long flags, > > > > void set_pageblock_migratetype(struct page *page, int migratetype) > > { > > + lockdep_assert_once(system_state == SYSTEM_BOOTING || > > + in_mem_hotplug() || > > + lockdep_is_held(&page_zone(page)->lock)); > > + > > if (unlikely(page_group_by_mobility_disabled && > > migratetype < MIGRATE_PCPTYPES)) > > migratetype = MIGRATE_UNMOVABLE; > > > > We could add such assertions all over the place. Why this place in > particular? For the other stuff, it's pretty obvious that it would be protected by the zone lock (or, I don't know about it!). But it didn't seem totally self-evident to me that it should protect the pageblock type. So it seems particularly helpful to have it written in the code. I may be heavily biased about this though, because of the code I'm working on for [0]. I use the pageblock type to remember whether it's mapped in the ASI restricted address space. [0] https://lore.kernel.org/linux-mm/CA+i-1C1gOBLxRxE5YFGzeayYWBYyE_X6oH4D=9eVePt4=ehTig@mail.gmail.com/T/