From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACD7C197BF for ; Thu, 27 Feb 2025 21:44:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEBF16B007B; Thu, 27 Feb 2025 16:44:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9AAE6B0082; Thu, 27 Feb 2025 16:44:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D89A26B0083; Thu, 27 Feb 2025 16:44:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE1ED6B007B for ; Thu, 27 Feb 2025 16:44:03 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7074C161D6D for ; Thu, 27 Feb 2025 21:44:03 +0000 (UTC) X-FDA: 83167052766.27.F0F0F1C Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf09.hostedemail.com (Postfix) with ESMTP id 89A7414000E for ; Thu, 27 Feb 2025 21:44:01 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pF3jnskV; spf=pass (imf09.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740692641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R3J/jMHXhUSZzVKv3voPrDtYcA94hPCQdrj69IWAc58=; b=thMaspRAZyi++S4HRjsKDM7OECjsYr1maCmloLnCg6bKq4SWvLWozgr18Vh1SeaN5LQYBo VQM+NnDv3SsVpYmEnUrMOOaJLSZoLqN+b9Ppfwhl+ufekUNzdjwxD2oPnmrt2nMKLQtNne tAg+bEuEiR5GZZNyDKGcEqNGNT2paAs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740692641; a=rsa-sha256; cv=none; b=4RLxIIb4hMg+KUGeZK4z1mERMLiNuYqESj1moG+7uxM9ZQw9vSVXnT5oSXxdRoahffhM46 JA1Os1L9T6brS9/zgHNFFKRdbmVhkkPROA/d1z/aCD3WcpShJTmz1b1kLHE+PFdzGWbnGH ddx1uBjqcSVZJgnzn+QbPM/+V/B5d0c= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pF3jnskV; spf=pass (imf09.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 27 Feb 2025 21:43:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740692639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R3J/jMHXhUSZzVKv3voPrDtYcA94hPCQdrj69IWAc58=; b=pF3jnskVNlupMHwT1GaoMwwvwrdHsBCXLLiVSV7eohPN0OG6HXf07ruESq4ZkqQ3p8fhoi QQ3SLdMZRhU5RrTDEp578wvwt8XWUYSR20NqlMBRuN/3WesC1mxhHmfuZpUnxTN/2GsAR5 rz2qe4/W5LxlXq/LOaEBPZA8DrNrhqA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Eric Biggers Cc: Herbert Xu , Linux Crypto Mailing List , linux-mm@kvack.org Subject: Re: [RFC PATCH 7/7] mm: zswap: Use acomp virtual address interface Message-ID: References: <153c340a52090f2ff82f8f066203186a932d3f99.1740651138.git.herbert@gondor.apana.org.au> <20250227183847.GB1613@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250227183847.GB1613@sol.localdomain> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 4odye5xne1ti33pz7dgx9n174dikwb6y X-Rspamd-Queue-Id: 89A7414000E X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740692641-788045 X-HE-Meta: U2FsdGVkX18uPRBUIlW6mihaIWJZEOghfx7kY9BuApK6RLlpZGUvtbjrew2RDihDl9zKkDhQpGZRL65DAYHjBZjbiJtit60Ei2XyG8hH8aZ4TUCOLo0UY0QzBNgRUk2Ox6BoZk+miI2tvnTP8CO0dI9Kc4+UovFHIrjW+FCRqbBgHoSO+4VBkr5x5LCCsaY5WCvXons1XTx6+i5jlOGCcI65is//dZpOWtSq119luojDmsDGBj0vbvRZr9cGGOBpLzM7BMnL3yDJOmKe9IWNY1XEO0DTIwFAQGdhWopL0WQZb38NNJsaaB3HfvKcW0wAM9ZaX1iAsWo2GW66CKW71c7pTTqd68SWIKgui5hxRVS7o+uzeDqJDhOK2NIz4GKkvpKESf8AnyzKZQPk+1odqcWjMDRHHtBsfkBjtElrqQOlXGxaJQ3/S6pFAy3bJycM3Pzfs71V0jvjrW7khm2KEDjkyV3T3D0W7sjj008GKxBJ7JK1FKwuzMIeC0m/NK3ZNw2voIDe/OO49V1Wxwrnu1OLVxLO/5IG9cAtiBRwprLFOcnZC6NXxF13+nf6tLx7dgPbQCNi1lYcYzdyLwD3WUrV+mGff8yyDgFH+BOZpIjUIQewspTOmIn7MKyW/CU2MUkxdxZhjae5lTBufeOBku704WZ9aqnDW4Geu3+I2/KzG0xU2+Rd93LqBjUNgLh+A8v/Pe7ii1oG4n4VoAUqJROf9N/+P0PLpg7Zdd6G2E2tYFxXu2l2N2ELuiwWxIKi46992sx94zv+EWIKPAi7lBYHw7Qp4tMSdvMPLokcTuhz/8PbNXa8AwurJrQETLyaAEJg2zuv/cuWQYCZhvdaDE9V3t/vS51hMowcbcX3hmj2OMF7HMZC2F8s2HVinBaNKUEvdZCJ5PtZY8j8orqcecmdCi+KipTPMmfJVZ8QfoZpcGGLWOsw5bIkl+PC7GJYDBgVVCb0P8cuZrjyV5X LhWmGv2r gUlcwbTg03Xdiz3cC1uc6ND9T0DsPnw0++dSQjiTkilD7LizWkONQSEUSqBCyt+8mzlStYkzIkaOn5bW59FkkA4yarKvuAAPoG625QubcS/VPczF5vXOgJo5FkZYrIVoaBWO7M1XFH2McqajXMZxtdR1PvluB3wMw9UZk6dNHfMGq3vAT+ouYyCs6j2PM/OJlCCgsBaWL9Cm8Q779GTaDB/hD8WiAan7eAIz+MCVZYvTa4hIA6hDNIkIitJ3vh3glKTE7Uh+SQHfLpOY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 10:38:47AM -0800, Eric Biggers wrote: > On Thu, Feb 27, 2025 at 06:11:04PM +0000, Yosry Ahmed wrote: > > On Thu, Feb 27, 2025 at 06:15:09PM +0800, Herbert Xu wrote: > > > Use the acomp virtual address interface. > > > > > > Signed-off-by: Herbert Xu > > > > I can't speak to the rest of the series, but I like what this patch is > > doing in zswap. Together with the recent zsmalloc changes, we should be > > able to drop the alternative memcpy path completely, without needing to > > use kmap_to_page() or removing the warning the highmem code. > > > > Thanks for doing this! > > Well, unfortunately this patchset still uses sg_init_one() on the virtual > address, so AFAICS it doesn't work with arbitrary virtual addresses. If we cannot pass in highmem addresses then the problem is not solved. Thanks for pointing this out.