linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Michal Hocko <mhocko@suse.com>,
	Gabriel Krisman Bertazi <krisman@suse.de>,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	Mel Gorman <mgorman@suse.de>, Petr Tesarik <ptesarik@suse.com>
Subject: Re: [PATCH] Revert "mm/page_alloc.c: don't show protection in zone's ->lowmem_reserve[] for empty zone"
Date: Thu, 27 Feb 2025 23:53:41 +0800	[thread overview]
Message-ID: <Z8CKhRBhMpToW5nL@MiWiFi-R3L-srv> (raw)
In-Reply-To: <2ca6130a-3756-4480-8453-77c702d919da@suse.cz>

On 02/27/25 at 02:16pm, Vlastimil Babka wrote:
> On 2/27/25 11:24, Baoquan He wrote:
> >> I guess the issue doesn't happen in practice. In any case it's out of scope
> >> of the reverted commit and the revert.
> > It could happen on arm64 because arm64 only has ZONE_DMA by default and
> > its boundary is not fixed. I saw all zones are ZONE_DMA on arm64, I
> > guess it could be easier to see a arm64 system which only has ZONE_DMA
> > on node 0 and ZONE_NORMAL/MOVABLE on other nodes.
> 
> Does it mean the ZONE_DMA is rather large then on arm64 then? In that case

Hmm, means it's more likely happening on arm64 that there's only
ZONE_DMA on node0 because its node/zone layout could more flexibly
customized in firmware by ystem vendor, but not like x86_64 with
fixed range of ZONE_DMA, ZONE_DMA32 and there's always ZONE_NORMAL in
node0.

> things probably works fine even if no protection is applied to it. The x86
> ones are small and thus need(ed) it much more. So I don't think we
> proactively need to change anything unless there are known issues observed
> in practice.

I am fine if we decide to leave it since we have made clear the root
cause and all the potential issues. Once known issue reported, we can
do the change at that time.

> 
> Another reason to avoid the effort is that hopefully we'll get rid of the
> DMA zones anyway? They don't work all that well anyway in modern times.
> Ccing Petr for awareness (due to his recent LPC talk about this topic)

Thanks for telling. I noticed Petr's interesting presentation in
LPC 2024, that sounds very stunning but very attractive if it's
finally achieved. But I love it. I think that's a good one to vote
for not touching the proctection value for now. 



  reply	other threads:[~2025-02-27 15:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26  3:22 Gabriel Krisman Bertazi
2025-02-26  6:54 ` Michal Hocko
2025-02-26 10:00   ` Baoquan He
2025-02-26 10:52     ` Michal Hocko
2025-02-26 11:00       ` Michal Hocko
2025-02-26 11:51         ` Baoquan He
2025-02-26 12:01           ` Michal Hocko
2025-02-26 15:57             ` Baoquan He
2025-02-26 17:46               ` Michal Hocko
2025-02-27  9:41                 ` Baoquan He
2025-02-27  9:16               ` Vlastimil Babka
2025-02-27 10:24                 ` Baoquan He
2025-02-27 13:16                   ` Vlastimil Babka
2025-02-27 15:53                     ` Baoquan He [this message]
2025-02-26 13:07   ` Vlastimil Babka
2025-02-26 16:05   ` Gabriel Krisman Bertazi
2025-02-26 23:00     ` Andrew Morton
2025-02-26 13:00 ` Vlastimil Babka
2025-02-27 11:50 ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8CKhRBhMpToW5nL@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=krisman@suse.de \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=ptesarik@suse.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox