From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7656BC021BE for ; Thu, 27 Feb 2025 06:19:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E55F7280002; Thu, 27 Feb 2025 01:19:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDE72280001; Thu, 27 Feb 2025 01:19:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5836280002; Thu, 27 Feb 2025 01:19:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A6DFA280001 for ; Thu, 27 Feb 2025 01:19:25 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5D19FA143B for ; Thu, 27 Feb 2025 06:19:25 +0000 (UTC) X-FDA: 83164722690.22.40A84EB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id 138A41C0006 for ; Thu, 27 Feb 2025 06:19:22 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=AWmrMDT0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ku0L8xOV; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=AWmrMDT0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ku0L8xOV; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740637163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R/DyLsluIv9CvUFzurCBHfTasMsJoHvDkGoK2MEuUrs=; b=4uy5xlSn4ienD796iXsftD0qqLtmkgsg5eSclT6zp7O3Gy1GyuSLQXfM8+sADe/6zYhnjj faO3W/KDTmWn026+adDPYabOxHDdYS4tzIMDAd2SESTn5Wf8YZf7+G9LL3AnEnBxPUgg1y ohsUhfSJx77DvTML2WzRrRP4fAf06+Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740637163; a=rsa-sha256; cv=none; b=yliqNnUgmGBt8f54fgxrXv4w/lKKw0PD8Fq7RUnIiwyunmMOuddEBmPr+gxcu+OAxmgSUo kSWa0svHb8aZES7GxrwKhWjjJhLGNGSZgtSkwkbEs5rEJfHsG/vQTwF1pqT5/ybpkt7y+m lOSanALTsOFCDNrm8W37vEtgZwLlNtY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=AWmrMDT0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ku0L8xOV; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=AWmrMDT0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ku0L8xOV; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 53A0821196; Thu, 27 Feb 2025 06:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1740637161; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/DyLsluIv9CvUFzurCBHfTasMsJoHvDkGoK2MEuUrs=; b=AWmrMDT08xAmCtWWIAgDyVId3aCUIbK/LdenRvrhzmE0qUvjFsTth/R9k8oLA5HvGTx9uV jCuBqMPyPZA6UM10Rz3KH0ER7ZeoYRxNTKPDT4BPxnZFdrisandhXJHdYOTopiN4A3G5j9 obXht3UIKGBA+fhz34JkMO61J4ClgI8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1740637161; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/DyLsluIv9CvUFzurCBHfTasMsJoHvDkGoK2MEuUrs=; b=ku0L8xOVpqf2QX7yFh3vB8sG/yOjife2wneYTKv/r83tU7JHSffAmXwR3GACntK4jxB08J AE/19UxrQ4rcJBDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1740637161; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/DyLsluIv9CvUFzurCBHfTasMsJoHvDkGoK2MEuUrs=; b=AWmrMDT08xAmCtWWIAgDyVId3aCUIbK/LdenRvrhzmE0qUvjFsTth/R9k8oLA5HvGTx9uV jCuBqMPyPZA6UM10Rz3KH0ER7ZeoYRxNTKPDT4BPxnZFdrisandhXJHdYOTopiN4A3G5j9 obXht3UIKGBA+fhz34JkMO61J4ClgI8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1740637161; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R/DyLsluIv9CvUFzurCBHfTasMsJoHvDkGoK2MEuUrs=; b=ku0L8xOVpqf2QX7yFh3vB8sG/yOjife2wneYTKv/r83tU7JHSffAmXwR3GACntK4jxB08J AE/19UxrQ4rcJBDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C66FB1376A; Thu, 27 Feb 2025 06:19:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5YA/LegDwGenWAAAD6G6ig (envelope-from ); Thu, 27 Feb 2025 06:19:20 +0000 Date: Thu, 27 Feb 2025 07:19:14 +0100 From: Oscar Salvador To: Jinjiang Tu Cc: David Hildenbrand , muchun.song@linux.dev, akpm@linux-foundation.org, mel@csn.ul.ie, lee.schermerhorn@hp.com, andi@firstfloor.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/hugetlb: fix set_max_huge_pages() when there are surplus pages Message-ID: References: <20250225141933.3852667-1-tujinjiang@huawei.com> <44267aae-4209-c5d2-9d0a-b9eeb4bd4bf0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <44267aae-4209-c5d2-9d0a-b9eeb4bd4bf0@huawei.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 138A41C0006 X-Rspamd-Server: rspam07 X-Stat-Signature: zsmz7g6y6xi8b7zii8f7sg9yk66kbxm4 X-HE-Tag: 1740637162-351867 X-HE-Meta: U2FsdGVkX18UiDsqhgOggD+O+ESWFFBGaoljIMuNehonoZeTDDMh0lM+Qmc94tuc9/MH9+Tfs0Ps1Ukv+dZmd1BCVq1TZxky36jAGsJa6x5vE0/bpnPIRY/IjFhyFrjDZ2gTCU7BeYRpgCUVhbykEZDFFxgbqFbTwQdMuBlJaQACnGx3LvKJm5GaUSRl6GowTuo69+n8OKaibPMT/DlY4p5wqQhE46gD26CAzavYOYeyMNVa30967wwqU4wbRTdF2pBffNXu0AmVB8uo+FXHQD593zHEYTEgi4CBBG/M4IsbXF8sowtrGRfL9UjQxwvGqycfgYeibAWy6iEbXB7gso3O4Y8TPtOhEuoFWxgLWqRptqk+ii9RKLQcpUzrSi4ra2nNm9FQ+VbbMKyYkzIDzl5ecFgppoDoLVo8ZP9HAlCnEDcENGOCPh/ybz6sLLnALt2zR9hsWRINeVPcyxtiyl+ug1ESwQ23ewNkFxzu0CC4NSlafnjqr4z1EAMnc4PzbMAOAV52AbZQRMqmSFkC1MqxpvuHF8U+ih9srxteFEM2sJuHpE8xMV9seqdAzrmPg9ayn6UWbcnUWaD7q/srD0mW6MbY99MvS3OKAjTw4DZV1G45EztLeKUiVsofv/VY+tX5Al+d7bYaq6+bOQomEUl/+J0VKQIWzA6TqJzkHIiRhDrKArE/5ej4EkPWpe7Pn+OYDkz6qbXg8L0ULLCiNKzyuSkVudkZks2kNh31Y+V8+OG9PtGAa/It4qFmyxzllMryxVN98W17J3D8K6NoIVU3npBZ+zRx3rAU0ehSJq7FHR5uETlfrquAxmZ/FMMOTOPM0X1pfvTqmCO5KhqFl9TmrWy6DmZjHM3aLr7tFXb9qQrwrf3qyzc9nNSSqFgb6q5wwlB/7Is55XZO3R0qClxLq5+EbSUGIp7UZaPp8Dy6tLimAXwvX4j8ap0U0+TY1ZwjC3hIvIMLgGjA8Zs 8ZrOYV36 y52Xoen7go6C84AbPv6q/kEqgx2Lcsmcl7uY8lMhrRnB6qyhsts9Si6EnQb7COaGmNpRKnWaOGu4d0Nj75N3pOOoezIA0ZINBvrcku+0LxpuH7I88cmp+yB782fZGY8MXq/QozI5937KFgpc/xcTh4x+SlonVCR9jF/cndZJ7qH7r5niBnyE4tGTkbSmGMMoWK1JtyDEATTW53njXwuWA1lrJbAbc2LjDY5DxObCXc7EDl57Q45yIvmZK80g1KiaRdKhOmusnwQ/BARZ05XwEtYRvkcj1cPUspmWfPWhav2PRU+ul74FwDGt+77qnzFdfe6Zm0Z4rweHxRYc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000693, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 27, 2025 at 11:11:25AM +0800, Jinjiang Tu wrote: > The result with this patch: >          Node 0    Node 1 > Total     5             0 > Free      0             0 > Surp     5             0 Why would node0 have any surplus pages? Also, this does not reproduce in my machine. Are you overcommitting? Are you using the hvo optimization? If so, it might be that we cannot allocate vmemmap pages and those hugetlb pages stay in a surplus state? >From bulk_vmemmap_restore_error(): * If unable to restore a hugetlb page, the hugetlb * page is made a surplus page and removed from the list. -- Oscar Salvador SUSE Labs