From: Oscar Salvador <osalvador@suse.de>
To: Jinjiang Tu <tujinjiang@huawei.com>
Cc: David Hildenbrand <david@redhat.com>,
muchun.song@linux.dev, akpm@linux-foundation.org, mel@csn.ul.ie,
lee.schermerhorn@hp.com, andi@firstfloor.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/hugetlb: fix set_max_huge_pages() when there are surplus pages
Date: Thu, 27 Feb 2025 07:19:14 +0100 [thread overview]
Message-ID: <Z8AD4p4jVxbDtUbR@localhost.localdomain> (raw)
In-Reply-To: <44267aae-4209-c5d2-9d0a-b9eeb4bd4bf0@huawei.com>
On Thu, Feb 27, 2025 at 11:11:25AM +0800, Jinjiang Tu wrote:
> The result with this patch:
> Node 0 Node 1
> Total 5 0
> Free 0 0
> Surp 5 0
Why would node0 have any surplus pages?
Also, this does not reproduce in my machine.
Are you overcommitting? Are you using the hvo optimization?
If so, it might be that we cannot allocate vmemmap pages and those
hugetlb pages stay in a surplus state?
From bulk_vmemmap_restore_error():
* If unable to restore a hugetlb page, the hugetlb
* page is made a surplus page and removed from the list.
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2025-02-27 6:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 14:19 Jinjiang Tu
2025-02-26 15:57 ` David Hildenbrand
2025-02-27 3:11 ` Jinjiang Tu
2025-02-27 6:19 ` Oscar Salvador [this message]
2025-02-27 7:06 ` Jinjiang Tu
2025-03-04 13:44 ` Jinjiang Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8AD4p4jVxbDtUbR@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=david@redhat.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=muchun.song@linux.dev \
--cc=tujinjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox