From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4C2C282DE for ; Mon, 10 Mar 2025 23:37:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3419280002; Mon, 10 Mar 2025 19:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE3A7280001; Mon, 10 Mar 2025 19:37:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DABC4280002; Mon, 10 Mar 2025 19:37:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BFB5B280001 for ; Mon, 10 Mar 2025 19:37:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6F455161540 for ; Mon, 10 Mar 2025 23:37:02 +0000 (UTC) X-FDA: 83207254284.02.406A7D2 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf19.hostedemail.com (Postfix) with ESMTP id 80D5E1A000B for ; Mon, 10 Mar 2025 23:37:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="FahTOd/L"; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741649820; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8vxyaRDkfAYo8J4tkd+ufifnYsxY6w8PIGPQNKuIvjU=; b=rnsdFpRZdD8LYg6QxjyF5HgCC9RTE2HxzhWaUwZqMAOrp94T3b3jkvbt5FgLdDJ+j53PSR 5GKGFnqBi6FN1M2d5fkVMKJ+gx5e1nNZ5J3qPjXr5bjX4L9GniS9+18tKK45nDy9o423IY uj9ClThTjYgU7Mccxb0HMKpDG/TEojk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741649820; a=rsa-sha256; cv=none; b=nXJjv539HXKLYQUk1PgU/ht9ccfB7VJet1pgv3kXAvEsbYz5clAfcuiEhEeB4Js1zZiCMW QmN2PLk0SE/GShtBhx3ND2Lh3mViU4a6pSnyJUy1ybzYZ+I6dNS3D885vmjy2qsQvu+3aj IPPihYlzTZSih+ndsZPfA3X0Cr26Hi8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="FahTOd/L"; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 10 Mar 2025 23:36:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741649817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8vxyaRDkfAYo8J4tkd+ufifnYsxY6w8PIGPQNKuIvjU=; b=FahTOd/L8bls0gAf5cWXU1nIYQSOUT9FglrPQ34c1DxeOkevHgBRHZFEhS/3s+PleG79Ne rj7NGMstLTlhEMipuhpdL0k40GMHQaRDqd79Vt1IfaAaQrQxjK6REebj11vfE+ZV8IbYhV A9IsHWuKWKt0cQWgfax+G2Y21udg7+0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , SeongJae Park , "Liam R. Howlett" , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/9] mm/madvise: batch tlb flushes for MADV_DONTNEED and MADV_FREE Message-ID: References: <20250310172318.653630-1-sj@kernel.org> <20250310153921.47d390c637105e3ad6fc49c0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 80D5E1A000B X-Stat-Signature: tk75hd8hyhztsw8fob9en3w8yh6y1dab X-Rspamd-Server: rspam10 X-HE-Tag: 1741649820-630313 X-HE-Meta: U2FsdGVkX1+8Js33WaJKiKv3uqITUA1iI9ab7uKUUswEqRQcGVfGUTctpLLuc12mdRvPi+nC2zLiRPM/hcMRYLuaS4SdIx8KWQNuSPAH54moDSRHwczmWab5JGD1SbaHjcJEMFc1WumtRr15LSPfN5/uPpxFrxuEF0EdBi3cyf+X6fnSJPmuJXsMaWAmnmL4mQX37khOFPaqF5Q4ahukVjpbVzRU6m71qOPMwTzo6T3DNzRoFymRx/GLB6GPR/h9ktQJIBjZP69XH2SbvYpv6E8n3qyrQPK+4KXTxCW7NSPH5NBmGLL5vqWKlomjQgVlJjpCXzVgT5E4K+ODa1En3ynRb4cnTqC1XOD7LoxXUKWOPuJPvijKgbgS36h4JeaKBB4D/5xnnfaT1QNugZJSQPsjAsnx9eFQS+w1UH7zBE0SZFUDDkGdWMqKndiVYTiR/Z6zxWB8LThjvuT27ZUxipFlk0ETCHp/5r+RHBdmS65Y8NmLppLHrhn1CUyBcTD5m4uveWM0pxvfEld0DiOEcPbEtGMJ1xfRZjug2/wMRQqWPQAKhEggXGQ9rX5DbYrJxCn9UdK9lp9FalVHlb9p+LS2YMBSU1ZhTj7WPfN/SimOcJPSli2akIhbhTSjimqiRtb1MtfphmWNSUWH+QJWWf6nXx98ZDHQ1Ghy5Sczqzp9IGaVjFK8JiDOC5RBsv2nnjQdmf0qzPNFYQY9LLHVJI/q4grYnml/rHUqMMUuBsK7iy/9sm037KtkQywZE3QnB40OzELAkMxYDM7cx7IjNERx30vetsjNhfvCusoURbhmlW6x9Mu2sz6GdOgqk/cTYEyIwhzp+SrDY8olQdkMTXfyPOBZRzoqu3VBp8Z9QQ51h7zHN8ws9x0Lb8B+zrP8ebKtWZ70glKx2ETKFYCHKJ3Dw++eNmbv9sGfe6eU5q2NAZR8ugrVSroIKdsw+YXGBHFG5fVQtG1zUes1Y2A kih037ci F36NMr1VgG6tq110SafCrw2jAZjWRBsF/jO0TMLJ1YJWBv0OsXGbe74IjoWCLdQpyOOIqL8wjQsw7LufuuSt0nkg9JVjB5psyUf9ho02n6fLOG/RFvaF6Lw084s4KUwoRgbRMV1yeGZphA6Xf3U32WsK6Cfk6L4TFVevc/lGo+7NiuktzPQvyYgHNxBIqkThRX5uCwIecV+Ujh+P+kxA4oA7VJkl8Vt7LY7L5fpaIR4Bh3Kp4odPInLDYHfhCvjl6SgKMJmFDB0iaxlgivEScY1x8hP7IZB7XxHqW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 10, 2025 at 04:15:06PM -0700, Shakeel Butt wrote: > On Mon, Mar 10, 2025 at 03:39:21PM -0700, Andrew Morton wrote: > > On Mon, 10 Mar 2025 10:23:09 -0700 SeongJae Park wrote: > > > > > It is unclear if such use case > > > is common and the inefficiency is significant. > > > > Well, we could conduct a survey, > > > > Can you add some logging to detect when userspace performs such an > > madvise() call, then run that kernel on some "typical" machines which > > are running "typical" workloads? That should give us a feeling for how > > often userspace does this, and hence will help us understand the usefulness > > of this patchset. > > Just for the clarification, this patchset is very useful for the > process_madvise() and the experiment results show that. +1 Google carried an internal version for a vectorized madvise() which was much faster than process_madvise() last time I measured it. I hope SJ's patchset will (partially) address this difference, which will hopefully allow to drop the internal implementation for process_madvise.